Re: [PATCH RESEND v3] meson: fix Windows build

2025-06-12 Thread Oleg Tolmatcev
> -event_filename=os.path.relpath(event.filename), > > +event_filename=event.filename, > > name=event.name, > > fmt=event.fmt.rstrip("\n"), > > argnames=argnames) > > diff --git a/scripts/tracetool/backend/syslog.

Re: [PATCH RESEND v3] meson: fix Windows build

2025-06-08 Thread Oleg Tolmatcev
Am So., 8. Juni 2025 um 02:43 Uhr schrieb Pierrick Bouvier : > > On 6/7/25 2:45 AM, oltolm wrote: > > Sorry, I forgot to cc the maintainers. > > > > The build failed when run on Windows. I replaced calls to Unix programs > > like ´cat´, ´sed´ and ´true´ with calls to ´python´. I wrapped calls to >

Re: [PATCH RESEND v3] meson: fix Windows build

2025-06-08 Thread Oleg Tolmatcev
: [python, '-c', 'import fileinput, re; print("EXPORTS", > > end=""); [print(re.sub(r"[{};]", "", line), end="") for line in > > fileinput.input()]', '@INPUT@']) > > On second thought, is print("EXPORTS", end="") correct? Unlike the lines > coming from fileinput, there is no line ending. I though that .def files > look like this: > > EXPORTS > ... > ... > > So maybe end="" should be dropped for EXPORTS to correctly format the > .def file? > > (I didn't have a Windows build environment to check myself, but it > should be easy to diff the before/after files to verify whether there > are any changes.) I already did that. It produces the same output. Oleg

Re: [PATCH v2] meson: fix Windows build

2025-06-03 Thread Oleg Tolmatcev
Am Di., 3. Juni 2025 um 19:56 Uhr schrieb Stefan Hajnoczi : > > On Tue, Jun 3, 2025 at 1:00 PM Oleg Tolmatcev > wrote: > > > > Am Mo., 2. Juni 2025 um 20:45 Uhr schrieb Stefan Hajnoczi > > : > > > > > > > +try: > > > &

Re: [PATCH v2] meson: fix Windows build

2025-06-03 Thread Oleg Tolmatcev
Am Mo., 2. Juni 2025 um 20:45 Uhr schrieb Stefan Hajnoczi : > > > +try: > > +event_filename = os.path.relpath(event.filename) > > +except ValueError: > > +event_filename = event.filename > > +event_filename = PurePath(event_filename).as_posix() > > Please do this in one

Re: [PATCH] meson: fix Windows build

2025-05-24 Thread Oleg Tolmatcev
gt; +++ b/tests/functional/meson.build > > @@ -413,4 +413,4 @@ endforeach > > > > run_target('precache-functional', > > depends: precache_all, > > - command: ['true']) > > + command: [python, '-c', '']) > > I wonder if this can be replaced with alias_target() too; and also the > pre-existing code suggests that alias_target needs at least one target, > but is that really true? > > So, maybe all or most uses of 'true' can just go away. I could replace this one with `alias_target()`, but it does need at least one dependency so I could not replace the others. Best regards Oleg Tolmatcev

[PATCH v2] hw/net: prevent potential NULL dereference

2024-05-31 Thread Oleg Sviridov
Pointer, returned from function 'spapr_vio_find_by_reg', may be NULL and is dereferenced immediately after. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Oleg Sviridov --- v2: Debug message added hw/net/spapr_llan.c | 6 ++ 1 file changed, 6

[PATCH] hw/net: prevent potential NULL dereference

2024-05-29 Thread Oleg Sviridov
Pointer, returned from function 'spapr_vio_find_by_reg', may be NULL and is dereferenced immediately after. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Oleg Sviridov --- hw/net/spapr_llan.c | 4 1 file changed, 4 insertions(+) diff --gi

[PATCH] hw/s390x: prevent potential NULL dereference

2024-05-29 Thread Oleg Sviridov
Pointer, returned from function 's390_ipl_get_iplb_pv', may be NULL and is dereferenced immediately after. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Oleg Sviridov --- hw/s390x/ipl.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletio

Re: [RFC PATCH 1/2] target/arm: move regime_ttbr helper

2022-01-31 Thread Vasilev Oleg via

Re: [PATCH] contrib/plugins: add mask plugin

2022-01-31 Thread Vasilev Oleg via
On 1/24/2022 3:26 PM, Alex Bennée wrote: > Oleg Vasilev writes: > >> From: Oleg Vasilev >> >> Plugin can be used to track statistics based on virtual address mask >> matching. >> Useful for tracking kernel vs user translation blocks. > Could we have a b

[PATCH] contrib/plugins: add mask plugin

2022-01-24 Thread Oleg Vasilev
From: Oleg Vasilev Plugin can be used to track statistics based on virtual address mask matching. Useful for tracking kernel vs user translation blocks. Signed-off-by: Oleg Vasilev Signed-off-by: Oleg Vasilev --- contrib/plugins/Makefile | 1 + contrib/plugins/mask.c | 144

Re: [RFC PATCH 2/2] accel/tcg: replace phys_pc with asid in TB htable key

2021-12-24 Thread Vasilev Oleg via
On 12/23/2021 7:31 PM, Richard Henderson wrote: > On 12/22/21 8:50 AM, Oleg Vasilev wrote: >> From: Oleg Vasilev >> >> Using a physical pc requires to translate address every time next block >> needs to be found and executed. This also contaminates TLB with code-relate

[RFC PATCH 2/2] accel/tcg: replace phys_pc with asid in TB htable key

2021-12-22 Thread Oleg Vasilev
From: Oleg Vasilev Using a physical pc requires to translate address every time next block needs to be found and executed. This also contaminates TLB with code-related records. Instead, I suggest we introduce an architecture-specific address space identifier, and use it to distinguish between

[RFC PATCH 1/2] target/arm: move regime_ttbr helper

2021-12-22 Thread Oleg Vasilev
From: Oleg Vasilev Now it is available for other files to use. CC: qemu-...@nongnu.org Signed-off-by: Oleg Vasilev Signed-off-by: Oleg Vasilev --- target/arm/helper.c| 17 - target/arm/internals.h | 17 + 2 files changed, 17 insertions(+), 17 deletions

[RFC PATCH 0/2] accel/tcg: replace phys_pc with asid in TB htable key

2021-12-22 Thread Oleg Vasilev
See last patch in series. Oleg Vasilev (2): target/arm: move regime_ttbr helper accel/tcg: replace phys_pc with asid in TB htable key accel/tcg/cpu-exec.c | 38 accel/tcg/tb-hash.h | 4 ++-- accel/tcg/translate-all.c| 7

Re: Suggestions for TCG performance improvements

2021-12-06 Thread Vasilev Oleg via
On 12/3/2021 8:32 PM, Alex Bennée wrote: > Vasilev Oleg writes: > >> On 12/2/2021 7:02 PM, Alex Bennée wrote: >> >>> Vasilev Oleg writes: ...skipped... >>> I did ponder a debug mode which would keep the last N tables dropped by >>> tlb_mmu_resize_l

Re: Suggestions for TCG performance improvements

2021-12-03 Thread Vasilev Oleg via
On 12/2/2021 7:02 PM, Alex Bennée wrote: > Vasilev Oleg writes: > >> I've discovered some MMU-related suggestions in the 2018 letter[2], and >> those seem to be still not implemented (flush still uses memset[3]). >> Do you think we should go forward with implementin

qemu-nbd trouble

2020-12-20 Thread Oleg
me problem. With losetup instead of qemu-nbd there is no errors. kernel - 5.4.82(4.19.132 get the same error) qemu - 5.0.0 -- Олег Неманов (Oleg Nemanov)

[Bug 1794086] Re: readlink(2) returns incorrect size for /proc/self/exe

2020-11-12 Thread Oleg Andriyanov
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1794086 Title: readlink(2) returns incorrect size for /proc/self/exe Status in QEMU: New Bug d

[Qemu-devel] [Bug 1794086] Re: readlink(2) returns incorrect size for /proc/self/exe

2018-09-24 Thread Oleg Andriyanov
** Summary changed: - readlink(2) returns invalid size for /proc/self/exe + readlink(2) returns incorrect size for /proc/self/exe -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1794086 Title: readl

[Qemu-devel] [Bug 1794086] [NEW] readlink(2) returns invalid size for /proc/self/exe

2018-09-24 Thread Oleg Andriyanov
Public bug reported: readlink(2) seems to ignore the size of supplied buffer for the resolved name and always returns the actual size of the resolved name instead. Steps to reproduce: ```bash echo '#include #include #include int main(int argc, const char** argv) { if(argc < 2) exit(1);

[Qemu-devel] [Bug 1738434] [NEW] CALL FWORD PTR [ESP] handled incorrectly

2017-12-15 Thread Oleg Boyarchuk
Public bug reported: To keep the story short, this 32-bit code crashes on 64-bit Windows whereas it works fine on real system and VMware: push 33h push offset _far_call call fword ptr[esp] jmp _ret _far_call: retf _ret: 32-bit code running under WoW64 on 64-bit Windows has th

[Qemu-devel] [Bug 1047999] Re: error building process in sdlaudio.o

2012-09-09 Thread Oleg Bobuh
** Description changed: ./configure --enable-sdl --enable-virtfs --enable-vnc --enable-cocoa --enable-mixemu --enable-brlapi --enable-vnc-tls --enable-vnc-sasl --enable-vnc-jpeg --enable-vnc-png --enable-curses --enable-curl --enable-bluez --enable-tcg-interpreter --enable-nptl --enable-sy

[Qemu-devel] [Bug 1047999] [NEW] error building process in sdlaudio.o

2012-09-09 Thread Oleg Bobuh
Public bug reported: ./configure --enable-sdl --enable-virtfs --enable-vnc --enable-cocoa --enable-mixemu --enable-brlapi --enable-vnc-tls --enable-vnc-sasl --enable-vnc-jpeg --enable-vnc-png --enable-curses --enable-curl --enable-bluez --enable-tcg-interpreter --enable-nptl --enable-system --enab

[Qemu-devel] [PATCH 2/2] hw/exynos4210_rtc.c: remove unnecessary code

2012-07-11 Thread Oleg Ogurtsov
Signed-off-by: Oleg Ogurtsov --- hw/exynos4210_rtc.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/exynos4210_rtc.c b/hw/exynos4210_rtc.c index b42586e..42a4ddc 100644 --- a/hw/exynos4210_rtc.c +++ b/hw/exynos4210_rtc.c @@ -510,10 +510,7 @@ static void

[Qemu-devel] [PATCH 1/2] hw/exynos4210_rtc.c: Fix calculating for value of year

2012-07-11 Thread Oleg Ogurtsov
Signed-off-by: Oleg Ogurtsov --- hw/exynos4210_rtc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210_rtc.c b/hw/exynos4210_rtc.c index f781020..b42586e 100644 --- a/hw/exynos4210_rtc.c +++ b/hw/exynos4210_rtc.c @@ -142,7 +142,7 @@ static const

[Qemu-devel] [PATCH 0/2] Exynos4210 RTC

2012-07-11 Thread Oleg Ogurtsov
Patches fixed calculationg for value of year and remove unnecessary code. Oleg Ogurtsov (2): hw/exynos4210_rtc.c: Fix calculating for value of year hw/exynos4210_rtc.c: remove unnecessary code hw/exynos4210_rtc.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) -- 1.7.5.4

Re: [Qemu-devel] [PATCH V2] Exynos4: add RTC device

2012-06-26 Thread Oleg Ogurtsov
On 27.06.2012 10:06, Oleg Ogurtsov wrote: Oleg Ogurtsov (1): Exynos4: add RTC device hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 595 ++ 3 files changed, 604 insertions(+), 0 deletions(-) create

[Qemu-devel] [PATCH V2] Exynos4: add RTC device

2012-06-26 Thread Oleg Ogurtsov
Oleg Ogurtsov (1): Exynos4: add RTC device hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 595 ++ 3 files changed, 604 insertions(+), 0 deletions(-) create mode 100644 hw/exynos4210_rtc.c -- 1.7.5.4

[Qemu-devel] [PATCH V2] Exynos4: add RTC device

2012-06-26 Thread Oleg Ogurtsov
Signed-off-by: Oleg Ogurtsov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 595 ++ 3 files changed, 604 insertions(+), 0 deletions(-) create mode 100644 hw/exynos4210_rtc.c diff --git a/hw/arm

[Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Oleg Ogurtsov
Signed-off-by: Oleg Ogurtsov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 607 ++ 3 files changed, 616 insertions(+), 0 deletions(-) create mode 100644 hw/exynos4210_rtc.c diff --git a/hw/arm

[Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Oleg Ogurtsov
This patch add RTC device Oleg Ogurtsov (1): Exynos4: added RTC device hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 607 ++ 3 files changed, 616 insertions(+), 0 deletions(-) create mode 100644 hw

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-06-14 Thread Oleg
Hmm, it does not seem to work for me: [root@Plugbox cpu]# cat alignment User: 73412 System: 1 Skipped:0 Half: 5312 Word: 68091 DWord: 1 Multi: 0 User faults:2 (fixup) [root@Plugbox cpu]# cd /i386/ [root@Plugbox i386]# chroot . bas

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-05-25 Thread Oleg
>> Do you think it will ever get fixed in a reasonable amount of time (or ever) >Well, it's on my list of things to look at, but generally my focus is the current (ARMv7) architecture, and fixing ARMv5 only bugs is lower priority. But there's a pretty good chance I'll get to it somewhere in the ne

Re: Testing of russian keymap (was Re: [Qemu-devel] [PATCH] fix '/' and '|' on russian keymap)

2010-10-19 Thread Oleg Sadov
19/10/2010 10:32 +0100, Daniel P. Berrange wrote: > On Mon, Oct 18, 2010 at 01:59:15PM -0500, Anthony Liguori wrote: > > On 10/18/2010 12:30 PM, Oleg Sadov wrote: > > >I don't understand reasons for such locale-default keyboard settings for > > >qemu too, bu

Re: Testing of russian keymap (was Re: [Qemu-devel] [PATCH] fix '/' and '|' on russian keymap)

2010-10-18 Thread Oleg Sadov
ny latin char, imagine how to type, say, a > path name (even "C:" drive in windows). > > All modern OSes nowadays have a way to switch between keyboard layouts > dynamically - this is done internally in the operating system. So, > basically, I've no idea what this -k $f

[Qemu-devel] Re: [PATCH] Remove bash-ism from configure

2007-03-25 Thread Oleg Verych
Hallo. > From: Anthony Liguori <[EMAIL PROTECTED]> > Newsgroups: gmane.comp.emulators.qemu > Subject: Re: [PATCH] Remove bash-ism from configure > Date: Sun, 11 Feb 2007 11:41:32 -0600 [] > On my system, which is an executable, not a shell command so it's > outside the scope of bashism. It's als