[PATCH] Avoid unaligned fetch in ladr_match()

2024-02-01 Thread Nick Briggs
There is no guarantee that the PCNetState is allocated such that csr[8] is allocated on an 8-byte boundary. Since not all hosts are capable of unaligned fetches the 16-bit elements need to be fetched individually to avoid a potential fault. Closes issue #2143 Signed-off-by: Nick Briggs --- hw

Re: [PATCH 1/2] migration/rdma: define htonll/ntohll only if not predefined

2024-01-14 Thread Nick Briggs
Thank you. Yes, with those two patches applied I have compiled qemu on Solaris 11.4 running on a SPARC-T4-1 (sun4v) system to emulate a single target: an HP PA-RISC. > On Jan 14, 2024, at 8:35 PM, Peter Xu wrote: > > On Thu, Jan 11, 2024 at 01:20:17PM -0500, Nick Briggs wrote: >&

[PATCH 2/2] qga: Solaris has net/if_arp.h and netinet/if_ether.h but not ETHER_ADDR_LEN

2024-01-11 Thread Nick Briggs
Solaris has net/if_arp.h and netinet/if_ether.h rather than net/ethernet.h, but does not define ETHER_ADDR_LEN, instead providing ETHERADDRL. Signed-off-by: Nick Briggs --- qga/commands-posix.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga

[PATCH 1/2] migration/rdma: define htonll/ntohll only if not predefined

2024-01-11 Thread Nick Briggs
Solaris has #defines for htonll and ntohll which cause syntax errors when compiling code that attempts to (re)define these functions.. Signed-off-by: Nick Briggs --- migration/rdma.c | 4 1 file changed, 4 insertions(+) diff --git a/migration/rdma.c b/migration/rdma.c index 94c0f871f0