Re: [PATCH] hw/mips/gt64xxx_pci: Don't endian-swap GT_PCI0_CFGADDR

2023-03-20 Thread Nathan Chancellor
On Wed, Mar 08, 2023 at 12:33:38AM +0100, Philippe Mathieu-Daudé wrote: > On 23/2/23 17:19, Jiaxun Yang wrote: > > 145e2198d749 ("hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE > > MemoryRegionOps") converted CFGADDR/CFGDATA registers to use > > PCI_HOST_BRIDGE's > > accessor facility and

Re: [PATCH] hw/mips/gt64xxx_pci: Don't endian-swap GT_PCI0_CFGADDR

2023-02-24 Thread Nathan Chancellor
an-swapping. > > This should fix some recent reports about poweroff hang. > > Fixes: 145e2198d749 ("hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE > MemoryRegionOps") > Signed-off-by: Jiaxun Yang Thanks for the fix! Tested-by: Nathan Chancellor > --- >

Re: [PATCH RFC 0/7] revert RNG seed mess

2023-02-09 Thread Nathan Chancellor
m/fw_cfg.c | 21 ++- > 10 files changed, 49 insertions(+), 161 deletions(-) > > -- > MST > For the record, all three of the cases that I tested (i386 no EFI, x86_64 with and without EFI) worked fine with this series. In case it is useful: Tested-by: Nathan Chancellor Cheers, Nathan

Re: [PATCH] x86: temporarily remove all attempts to provide setup_data

2023-02-08 Thread Nathan Chancellor
On Wed, Feb 08, 2023 at 11:14:23AM -0700, Nathan Chancellor wrote: > On Wed, Feb 08, 2023 at 03:08:35PM -0300, Jason A. Donenfeld wrote: > > All attempts at providing setup_data have been made as an iteration on > > whatever was there before, stretching back to the original > >

Re: [PATCH] x86: temporarily remove all attempts to provide setup_data

2023-02-08 Thread Nathan Chancellor
setting from x86_load_linux(), > while leaving intact the infrastructure we'll need in the future to try > again. > > Cc: Michael S. Tsirkin > Cc: Dov Murik > Cc: Tom Lendacky > Cc: Gerd Hoffmann > Cc: Daniel P. Berrangé > Cc: Paolo Bonzini > Cc: Richard

Re: [PATCH qemu v3] x86: don't let decompressed kernel image clobber setup_data

2023-02-08 Thread Nathan Chancellor
Hi Jason, On Fri, Dec 30, 2022 at 11:07:25PM +0100, Jason A. Donenfeld wrote: > The setup_data links are appended to the compressed kernel image. Since > the kernel image is typically loaded at 0x10, setup_data lives at > `0x10 + compressed_size`, which does not get relocated during the >

Re: [PATCH 5/6] hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps

2023-01-23 Thread Nathan Chancellor
Hi Philippe, On Wed, Jan 04, 2023 at 02:39:34PM +0100, Philippe Mathieu-Daudé wrote: > GT64120's PCI endianness swapping works on little-endian hosts, > but doesn't on big-endian ones. Instead of complicating how > CFGADDR/CFGDATA registers deal with endianness, use the existing > MemoryRegionOps

Re: [PATCH v5 17/31] target/arm: Enforce alignment for LDM/STM

2021-08-30 Thread Nathan Chancellor
Hi Richard, On Mon, Apr 19, 2021 at 01:22:43PM -0700, Richard Henderson wrote: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/arm/translate.c b/target/arm/transla

Re: [PATCH v4 12/12] exec: Fix overlap of PAGE_ANON and PAGE_TARGET_1

2021-04-07 Thread Nathan Chancellor
Fixes: 26bab757d41b ("linux-user: Introduce PAGE_ANON") > Buglink: https://bugs.launchpad.net/bugs/1922617 > Signed-off-by: Richard Henderson Tested-by: Nathan Chancellor > --- > include/exec/cpu-all.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

[Bug 1922617] [NEW] qemu-aarch64-static "Illegal instruction" with debootstrap

2021-04-05 Thread Nathan Chancellor
Public bug reported: This is reproducible against QEMU master. I apologize for the long reproduction steps, I tried to distill it down as much as possible. System info: # qemu-aarch64-static --version qemu-aarch64 version 5.2.91 (v6.0.0-rc1-68-gee82c086ba) Copyright (c) 2003-2021 Fabrice Bellard

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-04-02 Thread Nathan Chancellor
On Fri, Apr 02, 2021 at 11:25:42AM -0700, Kees Cook wrote: > On Fri, Apr 02, 2021 at 08:42:07AM +0200, Sedat Dilek wrote: > > On Thu, Feb 25, 2021 at 10:25 PM Kees Cook wrote: > > > > > > On Thu, 11 Feb 2021 12:42:58 -0700, Nathan Chancellor wrote: > > >

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-02-22 Thread Nathan Chancellor
On Mon, Feb 22, 2021 at 11:02:34AM -0800, Nick Desaulniers wrote: > Did this happen to get picked up already? EOM I have not gotten an email saying it has been picked up nor does it appear to be in -next. Cheers, Nathan > On Thu, Feb 11, 2021 at 11:43 AM Nathan Chancellor

[PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-02-11 Thread Nathan Chancellor
ally by the incompatible pointer types compiler warning. Update fw_cfg_showrev() accordingly. Fixes: 75f3e8e47f38 ("firmware: introduce sysfs driver for QEMU's fw_cfg device") Link: https://github.com/ClangBuiltLinux/linux/issues/1299 Signed-off-by: Nathan Chancellor --- d

Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied

2021-01-25 Thread Nathan Chancellor
On Mon, Jan 25, 2021 at 11:42:43AM +0100, Paolo Bonzini wrote: > On 25/01/21 08:10, Nathan Chancellor wrote: > > > > This patch as commit 5a140b255d ("x86/cpu: Use max host physical address > > > > if -cpu max option is applied") prevents me from using

Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied

2021-01-24 Thread Nathan Chancellor
On Mon, Jan 25, 2021 at 01:41:50PM +0800, Yang Weijiang wrote: > On Sun, Jan 24, 2021 at 02:08:29PM -0700, Nathan Chancellor wrote: > > On Wed, Jan 13, 2021 at 05:04:30PM +0800, Yang Weijiang wrote: > > > QEMU option -cpu max(max_features) means "Enables all features suppor

Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied

2021-01-24 Thread Nathan Chancellor
On Wed, Jan 13, 2021 at 05:04:30PM +0800, Yang Weijiang wrote: > QEMU option -cpu max(max_features) means "Enables all features supported by > the accelerator in the current host", this looks true for all the features > except guest max physical address width, so add this patch to enable it. > > S

Re: [PATCH 4/5] hw/ppc/ppc4xx_pci: Replace pointless warning by assert()

2021-01-11 Thread Nathan Chancellor
On Mon, Jan 11, 2021 at 11:04:25AM +0100, Philippe Mathieu-Daudé wrote: > +Peter > > On 1/11/21 2:11 AM, Nathan Chancellor wrote: > > On Tue, Sep 01, 2020 at 12:40:42PM +0200, Philippe Mathieu-Daudé wrote: > >> We call pci_register_root_bus() to register 4 IRQs with the

Re: [PATCH 4/5] hw/ppc/ppc4xx_pci: Replace pointless warning by assert()

2021-01-10 Thread Nathan Chancellor
On Tue, Sep 01, 2020 at 12:40:42PM +0200, Philippe Mathieu-Daudé wrote: > We call pci_register_root_bus() to register 4 IRQs with the > ppc4xx_pci_set_irq() handler. As it can only be called with > values in the [0-4[ range, replace the pointless warning by > an assert(). > > Signed-off-by: Philip

Re: [PATCH 4/8] hw/ppc/ppc440_bamboo: Drop use of ppcuic_init()

2021-01-10 Thread Nathan Chancellor
On Sat, Dec 12, 2020 at 12:15:33AM +, Peter Maydell wrote: > Switch the bamboo board to directly creating and configuring the UIC, > rather than doing it via the old ppcuic_init() helper function. > > Signed-off-by: Peter Maydell > --- > hw/ppc/ppc440_bamboo.c | 38 ++

[PATCH] riscv: sifive_test: Allow 16-bit writes to memory region

2020-08-31 Thread Nathan Chancellor
in_access_size match reality so that the machine can shut down properly now. Cc: qemu-sta...@nongnu.org Fixes: 88a07990fa ("SiFive RISC-V Test Finisher") Fixes: 5d971f9e67 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid"") Signed-off-by:

Re: [PATCH] memory: Revert "memory: accept mismatching sizes in memory_region_access_valid"

2020-08-30 Thread Nathan Chancellor
On Sun, Aug 30, 2020 at 08:24:15AM +0100, Mark Cave-Ayland wrote: > On 30/08/2020 07:49, Nathan Chancellor wrote: > > > Unfortunately, it does not. I applied it on top of latest > > git (ac8b279f13865d1a4f1958d3bf34240c1c3af90d) and I can still > > reproduce my failure.

Re: [PATCH] memory: Revert "memory: accept mismatching sizes in memory_region_access_valid"

2020-08-29 Thread Nathan Chancellor
On Sun, Aug 30, 2020 at 02:20:38AM -0400, Michael S. Tsirkin wrote: > On Wed, Aug 26, 2020 at 10:32:16PM -0700, Nathan Chancellor wrote: > > Hi all, > > > > Sorry for the duplicate reply, my first one was rejected by a mailing > > list administrator for being too l

Re: [PATCH] memory: Revert "memory: accept mismatching sizes in memory_region_access_valid"

2020-08-27 Thread Nathan Chancellor
On Thu, Aug 27, 2020 at 08:53:30AM -0700, Alistair Francis wrote: > On Wed, Aug 26, 2020 at 11:26 PM Nathan Chancellor > wrote: > > > > Hi all, > > > > Sorry for the duplicate reply, my first one was rejected by a mailing > > list administrator for being to

Re: [PATCH] target/ppc: Fix mtmsr(d) L=1 variant that loses interrupts

2020-04-14 Thread Nathan Chancellor
elaxation of the requirement that these exceptions cause > interrupts when MSR[EE]=1 (e.g., when mtmsr executes to completion as > TCG is doing here), rather it specifies how a pipelined processor can > have multiple instructions in flight where one may influence how another >

Re: Boot flakiness with QEMU 3.1.0 and Clang built kernels

2020-04-13 Thread Nathan Chancellor
On Tue, Apr 14, 2020 at 12:05:53PM +1000, David Gibson wrote: > On Sat, Apr 11, 2020 at 11:57:23PM +1000, Nicholas Piggin wrote: > > Nicholas Piggin's on April 11, 2020 7:32 pm: > > > Nathan Chancellor's on April 11, 2020 10:53 am: > > >> The tt.config values are needed to reproduce but I did not v

Re: Boot flakiness with QEMU 3.1.0 and Clang built kernels

2020-04-11 Thread Nathan Chancellor
gt; > The patch is a bit of a hack, but if you can run it and verify it fixes > your boot hang would be good. Yes, with this patch applied on top of 5.0.0-rc2 and using the pseries-3.1 and powernv8 machines, I do not see any hangs with a clang built kernel at b032227c62939b5481bcd45442b36

Re: [PATCH] ppc/pnv: Create BMC devices only when defaults are enabled

2020-04-04 Thread Nathan Chancellor
es using '-nodefaults'. If no BMC > device are provided, output a warning but let QEMU run as this is a > supported configuration. However, when multiple BMC devices are > defined, stop QEMU with a clear error as the results are unexpected. > > Fixes: e2392d4395dd ("pp

Re: [PATCH v2] ppc/pnv: Create BMC devices at machine init

2020-04-04 Thread Nathan Chancellor
Hi Cédric, On Thu, Nov 21, 2019 at 05:23:40PM +0100, Cédric Le Goater wrote: > The BMC of the OpenPOWER systems monitors the machine state using > sensors, controls the power and controls the access to the PNOR flash > device containing the firmware image required to boot the host. > > QEMU model

[Bug 1844597] Re: fc1120a7f5f2d4b601003205c598077d3eb11ad2 causes a kernel panic in vfp_init on a clang built kernel

2019-09-20 Thread Nathan Chancellor
I pulled down the fix, built locally, and can confirm that this resolves the issue. Thank you for the quick patch! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1844597 Title: fc1120a7f5f2d4b601003

[Bug 1844597] Re: fc1120a7f5f2d4b601003205c598077d3eb11ad2 causes a kernel panic in vfp_init on a clang built kernel

2019-09-20 Thread Nathan Chancellor
** Attachment added: "aspeed-bmc-opp-romulus.dtb" https://bugs.launchpad.net/qemu/+bug/1844597/+attachment/5290033/+files/aspeed-bmc-opp-romulus.dtb -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

[Bug 1844597] Re: fc1120a7f5f2d4b601003205c598077d3eb11ad2 causes a kernel panic in vfp_init on a clang built kernel

2019-09-20 Thread Nathan Chancellor
Ugh, sorry, I forget that I can actually upload files to these platforms :( Done, let me know if you need anything else! ** Attachment added: "zImage" https://bugs.launchpad.net/qemu/+bug/1844597/+attachment/5290032/+files/zImage -- You received this bug notification because you are a membe

[Qemu-devel] [Bug 1844597] [NEW] fc1120a7f5f2d4b601003205c598077d3eb11ad2 causes a kernel panic in vfp_init on a clang built kernel

2019-09-18 Thread Nathan Chancellor
Public bug reported: Commit 4cdabee7d6d2 ("ARM: configs: aspeed_g5: Enable AST2600") [1] in the Linux kernel enabled CONFIG_VFP. When building this config with Clang, the resulting kernel does not boot after commit fc1120a7f5 ("target/arm: Implement NSACR gating of floating point") [2] (present si