[Qemu-devel] [PATCH] vl: Fix compile issue with Werror option

2013-12-19 Thread Mike Qiu
uninitialized in this function [-Werror=maybe-uninitialized] len = strlen(bootpath) + 1; ^ cc1: all warnings being treated as errors make: *** [vl.o] Error 1 This patch is to solve this issue. Signed-off-by: Mike Qiu --- vl.c | 2 +- 1 file changed, 1 insertion

[Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()

2013-10-16 Thread Mike Qiu
s patch is to solve this. Signed-off-by: Mike Qiu --- hmp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hmp.c b/hmp.c index 5891507..32ee285 100644 --- a/hmp.c +++ b/hmp.c @@ -366,8 +366,6 @@ void hmp_info_block(Monitor *mon, const QDict *qdict)

[Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-14 Thread Mike Qiu
hat each guest has one nic. In this situation, all the guest's nic has the same mac address. This patch is to solve this bug. Signed-off-by: Mike Qiu --- net/net.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/net.c b/net/net.c index c330c9a..9e72764 1006

[Qemu-devel] [PATCH] hmp: Add '\n' in monitor_printf()

2013-10-14 Thread Mike Qiu
not locked, tray closed There will be no additional lines between scsi0-hd0 scsi0-cd2, and break the info style. This patch is to solve this. Signed-off-by: Mike Qiu --- hmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp.c b/hmp.c index 5891507..2d2e5f8 100644 --- a/h

[Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-14 Thread Mike Qiu
s bug. Signed-off-by: Mike Qiu --- net/net.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/net.c b/net/net.c index c330c9a..2796d04 100644 --- a/net/net.c +++ b/net/net.c @@ -21,6 +21,8 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALIN

Re: [Qemu-devel] [PATCH] block: Bugfix 'format' and 'snapshot' used in drive option

2013-08-08 Thread Mike Qiu
essages. So give me some comments and sugguestions, pls. Thanks Mike 2013/8/8 22:45, Mike Qiu wrote: > When use -drive file='xxx',format=qcow2,snapshot=on the error > message "Can't use snapshot=on with driver-specific options" > can be show, and fail to st

[Qemu-devel] [PATCH] block: Bugfix 'format' and 'snapshot' used in drive option

2013-08-08 Thread Mike Qiu
It is because the commit 74fe54f2a1b5c4f4498a8fe521e1dfc936656cd4, it puts 'driver' option if the command line use 'format' option. This patch is to solve this bug. Signed-off-by: Mike Qiu --- blockdev.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/blockdev

Re: [Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-21 Thread Mike Qiu
于 2013/7/19 22:32, Peter Maydell 写道: On 19 July 2013 15:12, Andreas Färber wrote: No, I don't. There were other segfault avoidance patches like yours over the past months - they're all fixing individual segfault symptoms. Question for Paolo is whether we want to continue to discover them one by

Re: [Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-18 Thread Mike Qiu
于 2013/7/19 1:14, Andreas Färber 写道: Hi, Am 18.07.2013 17:27, schrieb Mike Qiu: Hi all Any comments ? You should've CCed the USB maintainer whose file you are touching for review rather than just ppc people, see ./MAINTAINERS. I have CC to the usb naintainer Gerd Hoffmann, his files a

Re: [Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-18 Thread Mike Qiu
Hi all Any comments ? Thanks Mike 2013/7/16 11:50, Mike Qiu wrote: > For usb-ehci in qemu, its caps just has read() operation, > the write() operation does not exist. > > This cause a Segmentation fault when use usb-ehci device in ppc64 > platform. > > here is gdb output:

[Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-16 Thread Mike Qiu
mr->ops has not been implement, in function memory_region_dispatch_write(), it call oldmmio write accessor, but at the same time old_mmio still not been implement by default. That is the root cause of the Segmentation fault. To solve this problem, add empty function: ehci_caps_write() Signed-o