Re: [Qemu-devel] [ANNOUNCE] QEMU 0.14.0.tar.gz is available

2011-02-18 Thread Miguel Di Ciurcio Filho
On Thu, Feb 17, 2011 at 10:06 PM, Anthony Liguori wrote: > The QEMU team is pleased to announce the availability of the 0.14.0 release. > > Download instructions are available at http://wiki.qemu.org/Download > > A detailed change log is available at http://wiki.qemu.org/Changelog/0.14 > Great, a

Re: [Qemu-devel] [ANNOUNCE] QEMU 0.14.0-rc0.tar.gz is available

2011-02-03 Thread Miguel Di Ciurcio Filho
On Wed, Feb 2, 2011 at 11:27 PM, Anthony Liguori wrote: > > An in progress detailed change log is available at > http://wiki.qemu.org/Changelog/0.14 > I still need some help to list the changes, bug fixes and improvements for i386/x86_64. - What is the status of nested SVM/VMX? - Are we using an

Re: [Qemu-devel] git rm Changelog?

2011-01-25 Thread Miguel Di Ciurcio Filho
On Tue, Jan 25, 2011 at 12:35 PM, Anthony Liguori wrote: > > A wiki page (similar to what kernel newbies does) would be nice to > supplement what's included in the release notes. > There you go: http://wiki.qemu.org/Changelog/0.14 This is a first draft and I will try to keep up, let's see what h

Re: [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers

2010-12-07 Thread Miguel Di Ciurcio Filho
On Mon, Dec 6, 2010 at 4:23 PM, Luiz Capitulino wrote: > Query handlers still carry their human monitor name. This commit > renames all of them to a more QMP-like name. > > For example, do_info_version() is renamed to qmp_query_version(). > - * do_info_balloon(): Balloon information > + * qmp_quer

Re: [Qemu-devel] Stable patch tracking

2010-09-13 Thread Miguel Di Ciurcio Filho
On Sun, Sep 12, 2010 at 11:02 AM, Avi Kivity wrote: >  On 09/12/2010 03:42 PM, Avi Kivity wrote: >> >>  On 09/12/2010 03:04 PM, Anthony Liguori wrote: Can the captcha for logged in users be removed? >>> >>> >>> Can you be more specific about what you're seeing? >>> >>> There should only

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-10 Thread Miguel Di Ciurcio Filho
On Fri, Sep 10, 2010 at 2:10 PM, Anthony Liguori wrote: >> >> Well, snapshots have an ID today (which is different from their name). >> Nobody stops you from putting a UUID there. Fully backwards compatible, >> no feature flag needed. I think Miguel was planning to actually do this. >> > > The pro

[Qemu-devel] Re: [RFC] qcow2: Add snapshot inherantance and uuid identification

2010-08-17 Thread Miguel Di Ciurcio Filho
On Tue, Aug 3, 2010 at 2:19 PM, Miguel Di Ciurcio Filho wrote: > As discussed on today's call, here is a prototype to support snapshots > inherantance in qcow2 and to use uuid as identification mechanism. > Bump. Just a friendly reminder of this RFC, now that everybody is back from

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-13 Thread Miguel Di Ciurcio Filho
On Thu, Aug 12, 2010 at 3:56 PM, malc wrote: > > While intentions of this are good, i believe this goes too far, i doubt > that the proposed additions are enforcable and have no doubts that they > will be widely ignored and at the same time provide more grounds for > whining. Furthermore the exist

[Qemu-devel] [PATCH 2/2] QMP/monitor: update do_info_version() to output broken down version string

2010-08-09 Thread Miguel Di Ciurcio Filho
This code was originally developed by Daniel P. Berrange Signed-off-by: Miguel Di Ciurcio Filho --- monitor.c | 23 +++ 1 files changed, 19 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index c313d5a..e82c48f 100644 --- a/monitor.c +++ b/monitor.c

[Qemu-devel] [PATCH 1/2] QMP: update 'query-version' documentation

2010-08-09 Thread Miguel Di Ciurcio Filho
Update the documentation of 'query-version' to output the string version broken down. Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 2af3de

[Qemu-devel] [PATCH 0/2] QMP: update 'query-version'

2010-08-09 Thread Miguel Di Ciurcio Filho
mu": {"micro": 50, "minor": 13, "major": 0}, "package": ""}, "capabilities": []}} Clients will no longer need to parse the entire string. Regards, Miguel --- Miguel Di Ciurcio Filho (2): QMP: update 'query-version

[Qemu-devel] [PATCH 2/3] savevm: Generate a name when run without one

2010-08-04 Thread Miguel Di Ciurcio Filho
to expose this kind of internals to the user. Signed-off-by: Miguel Di Ciurcio Filho --- savevm.c | 29 - 1 files changed, 20 insertions(+), 9 deletions(-) diff --git a/savevm.c b/savevm.c index 9291cfb..025bee6 100644 --- a/savevm.c +++ b/savevm.c @@ -1799,8 +

[Qemu-devel] [PATCH 0/3] snapshots: various updates

2010-08-04 Thread Miguel Di Ciurcio Filho
ing errors and do not rename the name of variables Regards, Miguel Miguel Di Ciurcio Filho (3): monitor: make 'info snapshots' show only fully available snapshots savevm: Generate a name when run without one savevm: prevent snapshot overwriting q

[Qemu-devel] [PATCH 1/3] monitor: make 'info snapshots' show only fully available snapshots

2010-08-04 Thread Miguel Di Ciurcio Filho
ATE VM CLOCK 31.5M 2010-07-26 17:26:49 00:00:13.245 41.5M 2010-07-26 19:01:00 00:00:46.763 Signed-off-by: Miguel Di Ciurcio Filho --- savevm.c | 59 +++ 1 files changed, 43 insertions(+), 16 deleti

[Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting

2010-08-04 Thread Miguel Di Ciurcio Filho
n "savevm: Generate a name when run without one" Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx |7 --- savevm.c| 19 ++- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 2af3de6..68

Re: [Qemu-devel] [RFC] qcow2: Add snapshot inherantance and uuid identification

2010-08-04 Thread Miguel Di Ciurcio Filho
On Tue, Aug 3, 2010 at 5:55 PM, Blue Swirl wrote: >> +    if (strlen(current_snapshot_id) > 0) { >> +        pstrcpy(sn->parent_id_str, sizeof(sn->parent_id_str), >> current_snapshot_id); >> +    } else { >> +        pstrcpy(sn->parent_id_str, sizeof(sn->parent_id_str), >> "---00

[Qemu-devel] [RFC] qcow2: Add snapshot inherantance and uuid identification

2010-08-03 Thread Miguel Di Ciurcio Filho
like lvscan and lvdisplay. One very simple, the other one show full information. * Better distinguish ids and names I would like to suggest split functions like bdrv_snapshot_find() to something more strict, like bdrv_snapshot_find_by_id() and bdrv_snapshot_find_by_name() Signed-off-by: Miguel D

[Qemu-devel] Re: KVM call agenda for August 3

2010-08-02 Thread Miguel Di Ciurcio Filho
On Mon, Aug 2, 2010 at 8:46 PM, Juan Quintela wrote: > > Please send in any agenda items you are interested in covering. > I would like to briefly RFC about some snapshot issues that I have being dealing, for the conversion of savevm/loadvm to QMP. They are listed here: http://wiki.qemu.org/Feat

Re: [Qemu-devel] [PATCH 2/3] cleanup: del_existing_snapshots() must return the upstream error code

2010-07-30 Thread Miguel Di Ciurcio Filho
On Fri, Jul 30, 2010 at 6:45 AM, Markus Armbruster wrote: > Why? > > I figure the next patch wants it, but if that's the reason, the commit > message should state it. > To better identify what happened and where, IMHO.

[Qemu-devel] Re: [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-07-30 Thread Miguel Di Ciurcio Filho
On Fri, Jul 30, 2010 at 10:39 AM, Luiz Capitulino wrote: >> >> TODO: I have no clue on how to create a timestamp string when using Windows. > > So, what happens on windows? > I've found some code in bdrv_snapshot_dump() that formats a timestamp when using Windows. I will use it as a basis. > Als

[Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-07-28 Thread Miguel Di Ciurcio Filho
e no clue on how to create a timestamp string when using Windows. Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx |9 --- savevm.c| 59 -- 2 files changed, 40 insertions(+), 28 deletions(-) diff --git a/qemu-monito

[Qemu-devel] [PATCH 2/3] cleanup: del_existing_snapshots() must return the upstream error code

2010-07-28 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- savevm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index 6c6adb0..fb38e8a 100644 --- a/savevm.c +++ b/savevm.c @@ -1775,7 +1775,7 @@ static int del_existing_snapshots(Monitor *mon, const char *name

[Qemu-devel] [PATCH 0/3] savem: various cleanups

2010-07-28 Thread Miguel Di Ciurcio Filho
1]. All feedback is very appreciated. Regards, Miguel [1] http://wiki.qemu.org/Features/SnapshottingImprovements Miguel Di Ciurcio Filho (3): cleanup: bdrv_snaphost_find() returns zero or -ENOENT cleanup: del_existing_snapshots() must return the upstream error code savevm: prevent snapshot o

[Qemu-devel] [PATCH 1/3] cleanup: bdrv_snaphost_find() returns zero or -ENOENT

2010-07-28 Thread Miguel Di Ciurcio Filho
The bdrv_snaphost_find() returns zero in case it finds an snapshot or -ENOENT in case it doesn't. Checking returning values as >= zero doesn't make sense. Signed-off-by: Miguel Di Ciurcio Filho --- savevm.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --g

Re: [Qemu-devel] [PATCH] monitor: make 'info snapshots' show only fully available snapshots

2010-07-28 Thread Miguel Di Ciurcio Filho
On Wed, Jul 28, 2010 at 12:38 PM, Markus Armbruster wrote: > Miguel Di Ciurcio Filho writes: > >> The output generated by 'info snapshots' shows only snapshots that exist on >> the >> block device that saves the VM state. This output can cause an user to >

[Qemu-devel] [PATCH] monitor: make 'info snapshots' show only fully available snapshots

2010-07-27 Thread Miguel Di Ciurcio Filho
ATE VM CLOCK 31.5M 2010-07-26 17:26:49 00:00:13.245 41.5M 2010-07-26 19:01:00 00:00:46.763 Signed-off-by: Miguel Di Ciurcio Filho --- savevm.c | 65 ++--- 1 files changed, 45 insertions(+), 20 dele

[Qemu-devel] [PATCH v4 2/3] QMP: Introduce query-available-devices

2010-07-23 Thread Miguel Di Ciurcio Filho
--- hw/qdev.c | 84 + hw/qdev.h |1 + monitor.c |8 ++ 3 files changed, 93 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index e99c73f..14985f5 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -29,6 +29,7 @@ #i

[Qemu-devel] [PATCH v4 3/3] monitor: Convert 'info qdm' to QMP

2010-07-23 Thread Miguel Di Ciurcio Filho
--- hw/qdev.c | 31 +++ hw/qdev.h |2 +- monitor.c |3 ++- 3 files changed, 30 insertions(+), 6 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 14985f5..ea9633c 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -780,13 +780,36 @@ void do_info_qtree(Monitor *mon

[Qemu-devel] [PATCH v4 0/3] QMP: Introduce query-available-devices (was query-qdm)

2010-07-23 Thread Miguel Di Ciurcio Filho
; Changes from the Daniel's original patch: - Split the patch in two, taking out the documentation from the code - Reworded some parts of the documentation and added data types - Small cleanups and renamed do_info_devices() to do_info_qdm() - Added do_info_qdm_print() to be used in the moni

[Qemu-devel] [PATCH v4 1/3] QMP: Introduce the documentation for query-available-devices

2010-07-23 Thread Miguel Di Ciurcio Filho
--- qemu-monitor.hx | 71 +++ 1 files changed, 71 insertions(+), 0 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 2af3de6..f6b976a 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -2490,6 +2490,77 @@ STEXI show device

[Qemu-devel] [PATCH v2] loadvm: improve tests before bdrv_snapshot_goto()

2010-07-19 Thread Miguel Di Ciurcio Filho
verification of the existance of an snapshot on the VM state device and the verification of the size of the saved VM state Signed-off-by: Miguel Di Ciurcio Filho --- monitor.c |3 +- savevm.c | 71 +--- 2 files changed, 36 insertions

[Qemu-devel] Re: [PATCH] loadvm: improve tests before bdrv_snapshot_goto()

2010-07-19 Thread Miguel Di Ciurcio Filho
On Mon, Jul 19, 2010 at 11:22 AM, Kevin Wolf wrote: >> >> -    /* Verify if there is a device that doesn't support snapshots and is >> writable */ >> +    bs_vm_state = bdrv_snapshots(); >> +    if (!bs_vm_state) { >> +        error_report("No block device supports snapshots"); >> +        return

[Qemu-devel] [PATCH v3 1/2] QMP: Introduce the documentation for query-qdm

2010-07-19 Thread Miguel Di Ciurcio Filho
--- qemu-monitor.hx | 71 +++ 1 files changed, 71 insertions(+), 0 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 2af3de6..4e6062b 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -2490,6 +2490,77 @@ STEXI show device

[Qemu-devel] [PATCH v3 2/2] monitor: Convert 'info qdm' to QMP

2010-07-19 Thread Miguel Di Ciurcio Filho
Converts the 'info qdm' command to QMP, allowing the discovery of all devices known to the QEMU binary without relying on command line paramaters like -device ? and -device devtype,? This change does not modify the output of the 'info qdm' monitor command. Signed-off-by: Mig

[Qemu-devel] [PATCH v3 0/2] QMP: Introduce query-qdm

2010-07-19 Thread Miguel Di Ciurcio Filho
Changes from the Daniel's original patch: - Split the patch in two, taking out the documentation from the code - Reworded some parts of the documentation and added data types - Small cleanups and renamed do_info_devices() to do_info_qdm() - Added do_info_qdm_print() to be use

Re: [Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices

2010-07-16 Thread Miguel Di Ciurcio Filho
On Fri, Jul 16, 2010 at 1:14 PM, Anthony Liguori wrote: > On 07/16/2010 10:41 AM, Markus Armbruster wrote: >>> A less invasive way to do this would be to chain netdev devices. >>> >>> Basically: >>> >>> -netdev tap,fd=X,id=foo >>> -netdev dump,file=foo.pcap,netdev=foo,id=bar >>> -net nic,model=vir

[Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices

2010-07-16 Thread Miguel Di Ciurcio Filho
On Fri, Jul 16, 2010 at 3:34 AM, Jan Kiszka wrote: > >> - When using virtio-net, I'm not sure how to handle iovec when vnet_hdr=on > > Let the sending peer report (offset field or callback) where to find the > payload in a frame. > Looking further, do you mean what net.c:vc_sendv_compat() does?

[Qemu-devel] [PATCH RFC 3/4] net/tap: Suggested support for NetClientDump

2010-07-15 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/tap.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index 0147dab..5bd069b 100644 --- a/net/tap.c +++ b/net/tap.c @@ -442,6 +442,9 @@ int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name

[Qemu-devel] [PATCH RFC 2/4] net: Introduce NetClientDump and auxiliary functions

2010-07-15 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net.c | 90 + net.h |8 + qemu-common.h |1 + 3 files changed, 99 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index 8ddf872..6f125f8 100644 --- a/net.c

[Qemu-devel] [PATCH RFC 0/4] Dumping traffic when using netdev devices

2010-07-15 Thread Miguel Di Ciurcio Filho
how to deal with tap+vhost, is it necessary? - When using virtio-net, I'm not sure how to handle iovec when vnet_hdr=on - Create a function to add dump to a netdev on the fly, is it necessary? - Handle cleanups Miguel Di Ciurcio Filho (4): net/dump: Make pcap structures public net: Intr

[Qemu-devel] [PATCH RFC 4/4] net/slirp: Suggested support for NetClientDump

2010-07-15 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/slirp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..5823699 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -240,6 +240,9 @@ static int net_slirp_init(VLANState *vlan, const char

[Qemu-devel] [PATCH RFC 1/4] net/dump: Make pcap structures public

2010-07-15 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/dump.c | 21 - net/dump.h | 21 + 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/net/dump.c b/net/dump.c index 6db7ecf..8eebacd 100644 --- a/net/dump.c +++ b/net/dump.c @@ -34,27 +34,6

[Qemu-devel] [PATCH] loadvm: improve tests before bdrv_snapshot_goto()

2010-07-14 Thread Miguel Di Ciurcio Filho
VM state - if fails return -error - load the VM state - if fails return -error - return zero do_loadvm must not call vm_start if any error has occurred in load_vmstate. Signed-off-by: Miguel Di Ciurcio Filho --- monitor.c |3 +- savevm.c | 71

Re: [Qemu-devel] QMP argument parser does not verify json type

2010-07-13 Thread Miguel Di Ciurcio Filho
On Tue, Jul 13, 2010 at 10:03 AM, Markus Armbruster wrote: >> >> And then this should result in an error: >> {"execute": "device_add", "arguments": {"driver": "virtio-net-pci", >> "id": "nic1", "netdev": "ndev1", "vectors": "10"}} > > Yes. > > This is where command line (QemuOpts), human monitor (

Re: [Qemu-devel] [PATCH v2] QMP: Introduce the documentation for query-qdm

2010-07-13 Thread Miguel Di Ciurcio Filho
On Tue, Jul 13, 2010 at 8:49 AM, Markus Armbruster wrote: >> +- "bus": the name of the bus type for the device (json-string) >> +    - Possible values: PCI, SCSI, I2C, ISA, SSI, USB, virtio-serial-bus, >> System > > Missing: IDE (hw/ide/qdev.c) and s390-virtio (hw/s390-virtio-bus.c). Ack. > >>

[Qemu-devel] Re: [PATCH 0/8] vlan cleanup

2010-07-13 Thread Miguel Di Ciurcio Filho
On Tue, Jul 13, 2010 at 3:16 AM, Jan Kiszka wrote: > Miguel Di Ciurcio Filho wrote: >> This series removes the vlan stuff without mercy. I've tried to make the >> steps >> as small as possible, but the last one is huge. I did some basic tests and >> networking

[Qemu-devel] [PATCH 4/8] vlan cleanup: do not build socket and dump

2010-07-12 Thread Miguel Di Ciurcio Filho
--- Makefile.objs |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 67f1b21..5442901 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -23,8 +23,6 @@ block-obj-y += $(addprefix block/, $(block-nested-y)) net-obj-y = net.o net-nested-

[Qemu-devel] [PATCH 8/8] vlan cleanup: remove usage of VLANState

2010-07-12 Thread Miguel Di Ciurcio Filho
--- hw/qdev-properties.c | 39 -- hw/qdev.c|2 - hw/qdev.h|5 - hw/xen_devconfig.c |8 +- hw/xen_nic.c |1 - net.c| 323 + net.h| 10 -- net/slirp.c |

[Qemu-devel] [PATCH 2/8] vlan cleanup: update options

2010-07-12 Thread Miguel Di Ciurcio Filho
--- qemu-options.hx | 120 --- 1 files changed, 17 insertions(+), 103 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index d1d2272..1cf2bf2 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -956,24 +956,24 @@ DEF("smb", HAS_ARG

[Qemu-devel] [PATCH 7/8] vlan cleanup: remove legacy monitor commands

2010-07-12 Thread Miguel Di Ciurcio Filho
--- net.c | 60 --- net.h |2 - qemu-monitor.hx | 28 - 3 files changed, 0 insertions(+), 90 deletions(-) diff --git a/net.c b/net.c index addd167..2c1c50f 100644 --- a/net.c +++ b/net.c @@ -10

[Qemu-devel] [PATCH 6/8] vlan cleanup: remove dump.h and dump.c

2010-07-12 Thread Miguel Di Ciurcio Filho
--- net/dump.c | 159 net/dump.h | 33 2 files changed, 0 insertions(+), 192 deletions(-) diff --git a/net/dump.c b/net/dump.c deleted file mode 100644 index 6db7ecf..000 --- a/net/dump.c +++ /dev/null @@ -1,159 +0,0

[Qemu-devel] [PATCH 3/8] vlan cleanup: do not depend on socket and dump

2010-07-12 Thread Miguel Di Ciurcio Filho
--- net.c | 42 -- 1 files changed, 0 insertions(+), 42 deletions(-) diff --git a/net.c b/net.c index 8ddf872..addd167 100644 --- a/net.c +++ b/net.c @@ -26,8 +26,6 @@ #include "config-host.h" #include "net/tap.h" -#include "net/socket.h" -#include "n

[Qemu-devel] [PATCH 5/8] vlan cleanup: remove socket.h and socket.c

2010-07-12 Thread Miguel Di Ciurcio Filho
--- net/socket.c | 573 -- net/socket.h | 33 2 files changed, 0 insertions(+), 606 deletions(-) diff --git a/net/socket.c b/net/socket.c deleted file mode 100644 index 1c4e153..000 --- a/net/socket.c +++ /dev/null @@ -1,573 +0,0

[Qemu-devel] [PATCH 1/8] vlan cleanup: update documentation

2010-07-12 Thread Miguel Di Ciurcio Filho
--- qemu-doc.texi | 24 +++- 1 files changed, 3 insertions(+), 21 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index e2c8e56..d5bf318 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -624,19 +624,7 @@ qemu linux2.img -hdb nbd:unix:/tmp/my_socket @section Network

[Qemu-devel] [PATCH 0/8] vlan cleanup

2010-07-12 Thread Miguel Di Ciurcio Filho
roper names. Regards, Miguel --- Miguel Di Ciurcio Filho (8): vlan cleanup: update documentation vlan cleanup: update options vlan cleanup: do not depend on socket and dump vlan cleanup: do not build socket and dump vlan cleanup: remove socket.h and socket.c

[Qemu-devel] QMP argument parser does not verify json type

2010-07-09 Thread Miguel Di Ciurcio Filho
Hi there, I've run QEMU like this: $ qemu -qmp tcp:localhost:3000,server,nowait -netdev type=tap,id=ndev1,vhost=on Then I run these commands over QMP: works: {"execute": "device_add", "arguments": {"driver": "virtio-net-pci", "csum": "off", "id": "nic1", "netdev": "ndev1"}} works: {"execute":

[Qemu-devel] [PATCH v2] QMP: Introduce the documentation for query-qdm

2010-07-09 Thread Miguel Di Ciurcio Filho
Changelog from v1 - - renamed "props" to "properties" - updated the examples - reworded the explanations of "name" and "description" - split "type" into a json-object, adding "qmp" and "qdev" - list all possible values for "bus" - list all possible values for "qdev" on "type" - list

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce the documentation for query-qdm

2010-07-05 Thread Miguel Di Ciurcio Filho
On Mon, Jul 5, 2010 at 12:22 PM, Luiz Capitulino wrote: >> + >> +Describe the capabilities of all devices registered with qdev. >> + >> +The returned output is a list, each element is a json-object describing a >> single >> +device type. > > s/The returned output is a list/The returned value is a

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce the documentation for query-qdm

2010-07-05 Thread Miguel Di Ciurcio Filho
On Sun, Jul 4, 2010 at 2:14 AM, Avi Kivity wrote: >>  show device tree >> �...@item info qdm >>  show qdev device model list >> +ETEXI >> +SQMP >> +query-qdm >> +- >> + >> +Describe the capabilities of all devices registered with qdev. >> > > Why the name qdm? > > 'query-available-devices'

[Qemu-devel] [PATCH 2/2] monitor: Convert 'info qdm' to QMP

2010-07-02 Thread Miguel Di Ciurcio Filho
Converts the 'info qdm' command to QMP, allowing the discovery of all devices known to the QEMU binary without relying on command line paramaters like -device ? and -device devtype,? This change does not modify the output of the 'info qdm' monitor command. Signed-off-by: Mig

[Qemu-devel] [PATCH 0/2] QMP: Introduce query-qdm

2010-07-02 Thread Miguel Di Ciurcio Filho
This series introduces the documentation for the query-qdm command and the conversion of the monitor command 'info qdm' to QMP. The documentation and code are based on a patch previously sent to qemu-devel by Daniel P. Berrange: http://lists.gnu.org/archive/html/qemu-devel/2010-06/msg00931.html

[Qemu-devel] [PATCH 1/2] QMP: Introduce the documentation for query-qdm

2010-07-02 Thread Miguel Di Ciurcio Filho
--- qemu-monitor.hx | 68 +++ 1 files changed, 68 insertions(+), 0 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 9f62b94..5348899 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -2490,6 +2490,74 @@ STEXI show device

[Qemu-devel] [PATCH v2 6/7] net: slirp: introduce info_dict

2010-06-30 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/slirp.c | 42 +++--- 1 files changed, 39 insertions(+), 3 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..9549711 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -32,6 +32,9 @@ #include

[Qemu-devel] [PATCH v2 5/7] net: vde: introduce info_dict

2010-06-30 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/vde.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/net/vde.c b/net/vde.c index 0b46fa6..a8a5b03 100644 --- a/net/vde.c +++ b/net/vde.c @@ -31,6 +31,9 @@ #include "qemu-char.h" #include &quo

[Qemu-devel] [PATCH v2 7/7] monitor/net: introduce 'info netdev' with QMP support

2010-06-30 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- monitor.c |8 +++ net.c | 71 + net.h |2 + 3 files changed, 81 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 170b269..b44768c 100644 --- a

[Qemu-devel] [PATCH v2 4/7] net: tap/tap-win32: introduce info_dict

2010-06-30 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/tap-win32.c |7 +++ net/tap.c | 22 +- 2 files changed, 28 insertions(+), 1 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 74348da..5e58702 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c

[Qemu-devel] [PATCH v2 3/7] net: Introduce VLANClientState->info_dict

2010-06-30 Thread Miguel Di Ciurcio Filho
There is no standard format when formatting VLANClientState.info_str, so it is difficult to extract information and transmit it over QMP. This patch adds info_dict, a QDict to better handle this information. Signed-off-by: Miguel Di Ciurcio Filho --- net.c |1 + net.h |1 + 2 files

[Qemu-devel] [PATCH v2 1/7] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-30 Thread Miguel Di Ciurcio Filho
These commands show the information about active backend network devices. Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx | 100 +++ 1 files changed, 100 insertions(+), 0 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx

[Qemu-devel] [PATCH v2 2/7] QObject API: introduce qdict_to_qstring() function

2010-06-30 Thread Miguel Di Ciurcio Filho
This is a helper function that converts a QDict to a QString, using the format: key1=value1 SEP key2=value2 SEP key3=value3 Handy for debugging and formating the Monitor output. Signed-off-by: Miguel Di Ciurcio Filho --- qdict.c | 60

[Qemu-devel] [PATCH v2 0/7] QMP: Introduce query-netdev

2010-06-30 Thread Miguel Di Ciurcio Filho
This series implement the previously discussed QMP command query-netdev. Regards, changelog from v1 - - Fixed wrong usage of qemu_free() with vc->info_dict, now using QDECREF() - Fixed QString leak in netdev_iter() changelog from last protocol spec ---

[Qemu-devel] [PATCH 6/7] net: slirp: introduce info_dict

2010-06-23 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/slirp.c | 42 +++--- 1 files changed, 39 insertions(+), 3 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..9549711 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -32,6 +32,9 @@ #include

[Qemu-devel] [PATCH 5/7] net: vde: introduce info_dict

2010-06-23 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/vde.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/net/vde.c b/net/vde.c index 0b46fa6..a8a5b03 100644 --- a/net/vde.c +++ b/net/vde.c @@ -31,6 +31,9 @@ #include "qemu-char.h" #include &quo

[Qemu-devel] [PATCH 4/7] net: tap/tap-win32: introduce info_dict

2010-06-23 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/tap-win32.c |7 +++ net/tap.c | 22 +- 2 files changed, 28 insertions(+), 1 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 74348da..5e58702 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c

[Qemu-devel] [PATCH 7/7] monitor/net: introduce 'info netdev' with QMP support

2010-06-23 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- monitor.c |8 +++ net.c | 70 + net.h |2 + 3 files changed, 80 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 170b269..b44768c 100644 --- a

[Qemu-devel] [PATCH 3/7] net: Introduce VLANClientState->info_dict

2010-06-23 Thread Miguel Di Ciurcio Filho
There is no standard format when formatting VLANClientState.info_str, so it is difficult to extract information and transmit it over QMP. This patch adds info_dict, a QDict to better handle this information. Signed-off-by: Miguel Di Ciurcio Filho --- net.c |1 + net.h |1 + 2 files

[Qemu-devel] [PATCH 2/7] QObject API: introduce qdict_to_qstring() function

2010-06-23 Thread Miguel Di Ciurcio Filho
This is a helper function that converts a QDict to a QString, using the format: key1=value1 SEP key2=value2 SEP key3=value3 Handy for debugging and formating the Monitor output. Signed-off-by: Miguel Di Ciurcio Filho --- qdict.c | 60

[Qemu-devel] [PATCH 1/7] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-23 Thread Miguel Di Ciurcio Filho
These commands show the information about active backend network devices. Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx | 100 +++ 1 files changed, 100 insertions(+), 0 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx

[Qemu-devel] [PATCH 0/7] QMP: Introduce query-netdev

2010-06-23 Thread Miguel Di Ciurcio Filho
This series implement the previously discussed QMP command query-netdev. There is small change in the specification from the last version: when "type" is "tap", the attribute "sndbuf" have been removed. "sndbuf" is not available on all platforms and most of the tap_set_sndbuf() implementations are

[Qemu-devel] Re: [PATCH v3] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-22 Thread Miguel Di Ciurcio Filho
On Tue, Jun 22, 2010 at 10:06 AM, Luiz Capitulino wrote: > On Mon, 21 Jun 2010 17:31:28 -0300 > Miguel Di Ciurcio Filho wrote: > >> These commands show the information about active backend network devices. >> >> Changes from v2 >> --- >> - G

[Qemu-devel] [PATCH v3] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-21 Thread Miguel Di Ciurcio Filho
fd' are now optional when type is 'tap' - Reworded the explanation of 'peer' Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx | 96 +++ 1 files changed, 96 insertions(+), 0 deletions(-) diff --git a/qemu-m

[Qemu-devel] Re: [PATCH v2] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-21 Thread Miguel Di Ciurcio Filho
On Mon, Jun 21, 2010 at 11:42 AM, Luiz Capitulino wrote: >> +- "info": json-object containing the configuration information about the >> device. >> +        - When "type" is "tap", the following values might be available: >> +            - "fd": available if connected to an already opened TAP >>

Re: [Qemu-devel] [PATCH v2] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-18 Thread Miguel Di Ciurcio Filho
On Fri, Jun 18, 2010 at 5:28 PM, Anthony Liguori wrote: > On 06/18/2010 11:26 AM, Miguel Di Ciurcio Filho wrote: >> >> These commands show the information about active backend network devices. >> >> Signed-off-by: Miguel Di Ciurcio Filho >&g

[Qemu-devel] [PATCH v2] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-18 Thread Miguel Di Ciurcio Filho
These commands show the information about active backend network devices. Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx | 105 +++ 1 files changed, 105 insertions(+), 0 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx

[Qemu-devel] [PATCH v2] monitor: Really show snapshot information about all devices

2010-06-17 Thread Miguel Di Ciurcio Filho
save the VM's state. Signed-off-by: Miguel Di Ciurcio Filho --- savevm.c | 57 - 1 files changed, 32 insertions(+), 25 deletions(-) diff --git a/savevm.c b/savevm.c index 20354a8..5bc5fcd 100644 --- a/savevm.c +++ b/savevm.c @@ -1858,3

Re: [Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Miguel Di Ciurcio Filho
On Wed, Jun 16, 2010 at 12:22 PM, Chris Lalancette wrote: >> > I didn't mention in the commit, but I've looked at libvirt's source >> > and it is not using 'info snapshots' AFAIK. >> >> Anthony, Dan, are you okay with the change then? > > Right, exactly as Miguel said, libvirt doesn't use "info sn

[Qemu-devel] Re: [PATCH 2/8] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-16 Thread Miguel Di Ciurcio Filho
On Wed, Jun 16, 2010 at 2:39 PM, Luiz Capitulino wrote: >> +SQMP >> +query-netdev >> + >> + >> +Each device is represented by a json-object. The returned value is a >> json-array >> +of all devices. >> + >> +Each json-object contain the following: >> + >> +- "id": the device's ID,

[Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Miguel Di Ciurcio Filho
On Wed, Jun 16, 2010 at 9:40 AM, Kevin Wolf wrote: > > If the human monitor was exactly what its name says, I'd happily apply > this one (though I think it should be made clear from which image the VM > state would be loaded). However, it isn't and I'm not sure if this > wouldn't break libvirt. Da

[Qemu-devel] [PATCH] monitor: Really show snapshot information about all devices

2010-06-15 Thread Miguel Di Ciurcio Filho
0:03.263 2 0 2010-05-26 21:51:09 00:00:08.844 3 0 2010-05-26 21:51:24 00:00:23.274 4 0 2010-05-26 21:53:17 00:00:03.595 Signed-off-by: Miguel Di Ciurcio Filho --- savevm.c | 46 +++

Re: [Qemu-devel] Re: [CFR 9/10] device_del command

2010-06-15 Thread Miguel Di Ciurcio Filho
On Tue, Jun 15, 2010 at 1:59 PM, Jan Kiszka wrote: > Anthony Liguori wrote: >> device_del >> -- >> >> Remove a device. >> >> Arguments: >> >> - "id": the device's ID (json-string) > > "id" should become "device" (I hope to send the corresponding patches > this night). The idea is to not on

Re: [Qemu-devel] [PATCH 2/8] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-11 Thread Miguel Di Ciurcio Filho
On Fri, Jun 11, 2010 at 8:37 AM, Markus Armbruster wrote: >> +- "id": the device's ID, must be unique (json-string) >> +- "vlan": QEMU's internal vlan identification. Only present if the device is >> +  attached to a VLAN (json-int, optional) >> +- "peer": ID of the frontend device when on a 1:1 r

[Qemu-devel] [PATCH 0/8] QMP: Introduce query-netdev

2010-06-10 Thread Miguel Di Ciurcio Filho
This series introduces the protocol specification for querying the backend network devices and a monitor command to show the same information. Patch 01 adds a new function qdict_to_qstring(). Patch 02 adds the documentation for query-netdev. Patch 03 adds a new QDict member to VLANClientState na

[Qemu-devel] [PATCH 2/8] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-10 Thread Miguel Di Ciurcio Filho
These commands show the information about active backend network devices. Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx | 53 + 1 files changed, 53 insertions(+), 0 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx

[Qemu-devel] [PATCH 3/8] net: Introduce VLANClientState->info_dict

2010-06-10 Thread Miguel Di Ciurcio Filho
There is no standard format when formatting VLANClientState.info_str, so it is difficult to extract information and transmit it over QMP. This patch adds info_dict, a QDict to better handle this information. Signed-off-by: Miguel Di Ciurcio Filho --- net.h |1 + 1 files changed, 1

[Qemu-devel] [PATCH 8/8] monitor/net: introduce 'info netdev' with QMP support

2010-06-10 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- monitor.c |8 + net.c | 96 + net.h |2 + 3 files changed, 106 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 15b53b9..0038214 100644 --- a

[Qemu-devel] [PATCH 6/8] net: socket: introduce info_dict

2010-06-10 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/socket.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/net/socket.c b/net/socket.c index 1c4e153..aad9eb8 100644 --- a/net/socket.c +++ b/net/socket.c @@ -28,6 +28,7 @@ #include "net.h"

[Qemu-devel] [PATCH 1/8] QObject API: introduce qdict_to_qstring() function

2010-06-10 Thread Miguel Di Ciurcio Filho
This is a helper function that converts a QDict to a QString, using the format: key1=value1 SEP key2=value2 SEP key3=value3 Handy for debugging and formating the Monitor output. Signed-off-by: Miguel Di Ciurcio Filho --- qdict.c | 60

[Qemu-devel] [PATCH 4/8] net: tap/tap-win32: introduce info_dict

2010-06-10 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/tap-win32.c |6 ++ net/tap.c | 20 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 74348da..3833592 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c

[Qemu-devel] [PATCH 7/8] net: slirp: introduce info_dict

2010-06-10 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/slirp.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..5735009 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -32,6 +32,10 @@ #include "monitor.h"

[Qemu-devel] [PATCH 5/8] net: vde: introduce info_dict

2010-06-10 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/vde.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/net/vde.c b/net/vde.c index 0b46fa6..0fe7c09 100644 --- a/net/vde.c +++ b/net/vde.c @@ -31,6 +31,9 @@ #include "qemu-char.h" #include "qemu-comm

[Qemu-devel] [PATCH v5] savevm: Really verify if a drive supports snapshots

2010-06-08 Thread Miguel Di Ciurcio Filho
ion was updated too to enforce that when loading a VM at least all writable devices must support snapshots too. Signed-off-by: Miguel Di Ciurcio Filho --- block.c | 17 + block.h |1 + savevm.c | 58 -- 3 files

  1   2   >