Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-19 Thread Michael Olbrich
On Tue, Sep 19, 2017 at 05:09:51PM -0700, Alistair Francis wrote: > On Tue, Sep 19, 2017 at 1:23 AM, Michael Olbrich > wrote: > > On Mon, Sep 18, 2017 at 02:28:26PM -0700, Alistair Francis wrote: > >> On Sat, Sep 16, 2017 at 3:35 AM, Michael Olbrich > >>

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-19 Thread Michael Olbrich
On Mon, Sep 18, 2017 at 02:28:26PM -0700, Alistair Francis wrote: > On Sat, Sep 16, 2017 at 3:35 AM, Michael Olbrich > wrote: > > The current code checks if the next block exceeds the size of the card. > > This generates an error while reading the last block of the card. > &

[Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-16 Thread Michael Olbrich
: Michael Olbrich --- Changes in v2: - fixed warning I'm not quite sure if 0x00 is the correct return value, but it's used elsewhere in the same function when an error occurs, so it seems reasonable. hw/sd/sd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH] hw/sd: fix out-of-bounds check for multi block reads

2017-09-16 Thread Michael Olbrich
: Michael Olbrich --- hw/sd/sd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index ba47bff4db80..94ff52512c43 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1797,8 +1797,13 @@ uint8_t sd_read_data(SDState *sd) break; case

Re: [Qemu-devel] [PATCH] hw/arm/boot: allow using a command line specified dtb without a kernel

2016-09-22 Thread Michael Olbrich
On Thu, Sep 22, 2016 at 05:23:17PM +0100, Peter Maydell wrote: > On 10 September 2016 at 16:07, Michael Olbrich > wrote: > > When kernel and device tree are specified in the QEMU commandline, then > > this device tree may be modified e.g. to add virtio_mmio devices. > > W

[Qemu-devel] [PATCH] hw/arm/boot: allow using a command line specified dtb without a kernel

2016-09-10 Thread Michael Olbrich
modified device tree made available to the bootloader with the same mechanism already supported by device trees fully generated by QEMU. Signed-off-by: Michael Olbrich --- hw/arm/boot.c | 4 ++-- vl.c | 5 - 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/arm/boot.c