Re: [Qemu-devel] [PATCH] Makefile.target: include top level build dir in vpath

2015-09-07 Thread Michael Marineau
On Mon, Sep 7, 2015 at 2:11 PM, Paolo Bonzini wrote: > > > On 07/09/2015 23:02, Michael Marineau wrote: >> ping http://patchwork.ozlabs.org/patch/510065/ > > Just back from vacation, this is queued in my next pull request > (currently at tags/for-upstream on github.com

Re: [Qemu-devel] [PATCH] Makefile.target: include top level build dir in vpath

2015-09-07 Thread Michael Marineau
On Sun, Aug 23, 2015 at 5:57 PM, Michael Marineau wrote: > Using ccache with CCACHE_BASEDIR set to $(SRC_PATH) or a parent will > rewrite all absolute paths to relative paths. This interacts poorly with > QEMU's two-level build directory scheme. For example, lets say > BUILD_DIR=

[Qemu-devel] [PATCH] Makefile.target: include top level build dir in vpath

2015-08-24 Thread Michael Marineau
n the makefile the path appeared in the relative path to ../blockdev.c is useless. This change simply adds the top level build directory to vpath so paths relative to the source directory, top build directory, and target build directory all work just fine. Signed-off-by: Michael Marineau --- This is

Re: [Qemu-devel] [PATCH] Makefile.target: include top level build dir in vpath

2015-08-12 Thread Michael Marineau
On Aug 12, 2015 6:32 AM, "Paolo Bonzini" wrote: > > > > On 09/08/2015 09:02, Michael Marineau wrote: > > Using ccache with CCACHE_BASEDIR set to $(SRC_PATH) or a parent will > > rewrite all absolute paths to relative paths. This interacts poorly with > >

[Qemu-devel] [PATCH] Makefile.target: include top level build dir in vpath

2015-08-09 Thread Michael Marineau
Using ccache with CCACHE_BASEDIR set to $(SRC_PATH) or a parent will rewrite all absolute paths to relative paths. This interacts poorly with QEMU's two-level build directory scheme. For example, lets say BUILD_DIR=$(SRC_PATH)/build so build/blockdev.d will contain: blockdev.o: ../blockdev.c ../

Re: [Qemu-devel] [PATCH] Fix usage of USB_DEV_FLAG_IS_HOST flag.

2013-05-21 Thread Michael Marineau
On Mon, May 13, 2013 at 11:51 AM, Gerd Hoffmann wrote: > On 05/13/13 01:19, Michael Marineau wrote: > > USB_DEV_FLAG_IS_HOST is the bit number, not value. Booting with a > > "Fitbit Base Station" USB dongle was triggering this assert. > > > > Signed-off-by:

[Qemu-devel] [PATCH] Fix usage of USB_DEV_FLAG_IS_HOST flag.

2013-05-12 Thread Michael Marineau
USB_DEV_FLAG_IS_HOST is the bit number, not value. Booting with a "Fitbit Base Station" USB dongle was triggering this assert. Signed-off-by: Michael Marineau --- hw/usb/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/core.c b/hw/usb/core.c ind