Re: [Qemu-devel] [RFC PATCH 03/14] KVM Test: Add a common ping module for network related tests

2010-07-28 Thread Michael Goldish
On 07/28/2010 02:50 PM, Michael Goldish wrote: > On 07/27/2010 04:01 PM, Lucas Meneghel Rodrigues wrote: >> On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: >>> The kvm_net_utils.py is a just a place that wraps common network >>> related commands which is used to d

Re: [Qemu-devel] [RFC PATCH 03/14] KVM Test: Add a common ping module for network related tests

2010-07-28 Thread Michael Goldish
On 07/27/2010 04:01 PM, Lucas Meneghel Rodrigues wrote: > On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: >> The kvm_net_utils.py is a just a place that wraps common network >> related commands which is used to do the network-related tests. >> Use -1 as the packet ratio for loss analysis. >> Us

Re: [Qemu-devel] [RFC PATCH 02/14] KVM Test: Add a function get_interface_name() to kvm_net_utils.py

2010-07-28 Thread Michael Goldish
On 07/27/2010 05:08 AM, Lucas Meneghel Rodrigues wrote: > On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: >> The function get_interface_name is used to get the interface name of linux >> guest through the macaddress of specified macaddress. > > I wonder if it wouldn't be overkill to have separ

Re: [Qemu-devel] [PATCH] Monitor: Convert do_sendkey() to QObject, QError

2010-07-21 Thread Michael Goldish
On 07/21/2010 09:44 PM, Luiz Capitulino wrote: > On Sun, 18 Jul 2010 15:43:55 +0300 > Michael Goldish wrote: > >> Signed-off-by: Michael Goldish > > Do you need this for 0.13? I think the development window is already closed. No, it's not urgent. >>

Re: [Qemu-devel] [RFC PATCH 01/14] KVM-test: Add a new macaddress pool algorithm

2010-07-20 Thread Michael Goldish
On 07/20/2010 04:44 PM, Amos Kong wrote: > On Tue, Jul 20, 2010 at 01:19:39PM +0300, Michael Goldish wrote: >> > > Michael, > > Thanks for your comments. Let's simplify this method together. > >> On 07/20/2010 04:34 AM, Amos Kong wrote: >>> Old meth

Re: [Qemu-devel] [RFC PATCH 01/14] KVM-test: Add a new macaddress pool algorithm

2010-07-20 Thread Michael Goldish
On 07/20/2010 04:34 AM, Amos Kong wrote: > Old method uses the mac address in the configuration files which could > lead serious problem when multiple tests running in different hosts. > > This patch adds a new macaddress pool algorithm, it generates the mac prefix > based on mac address of the ho

[Qemu-devel] [PATCH] Monitor: Convert do_sendkey() to QObject, QError

2010-07-18 Thread Michael Goldish
Signed-off-by: Michael Goldish --- monitor.c | 15 --- qemu-monitor.hx | 22 +- qerror.c| 12 qerror.h|9 + 4 files changed, 50 insertions(+), 8 deletions(-) diff --git a/monitor.c b/monitor.c index d5377de