Re: [Qemu-devel] [PATCH] arm: Ensure LSB of BLX is set

2015-09-01 Thread Meador Inge
On Tue, Sep 01, 2015 at 05:28:10PM +0100, Peter Maydell wrote: > On 6 July 2015 at 19:09, wrote: > > From: Meador Inge > > > > This small patch adds a sanity check when disassembling > > the BLX instruction. The use case came to light when > > doing toolchai

Re: [Qemu-devel] [PATCH 2/2] target-arm: Add "anyvfp" CPU

2015-07-13 Thread Meador Inge
On Mon, Jul 06, 2015 at 11:31:37PM +0100, Peter Maydell wrote: > I'm not convinced. System mode gives you a bare metal > system -- it's the bare metal app's job to enable > VFP if it wants to use it. If your bare metal app > doesn't do that then it is broken. Fair enough. I knew this patch would

Re: [Qemu-devel] [PATCH 0/2] target-arm: "any" CPUs for system-mode

2015-07-13 Thread Meador Inge
t; >>> On 6 July 2015 at 19:53, wrote: > >>>> From: Meador Inge > >>>> > >>>> This patch series opens up the "any" CPU for system-mode and > >>>> adds a new "any" variant named "anyvfp" that initializes

Re: [Qemu-devel] [PATCH 2/2] target-arm: Add "anyvfp" CPU

2015-07-13 Thread Meador Inge
On Mon, Jul 06, 2015 at 03:00:20PM -0700, Peter Crosthwaite wrote: > So a better way to do this is via QOM properties. You can propertyify > VFP support on the QOM type ARMCPU then users can use -global to set > in on the command line. You could do this for any number of ARM CPU > features you car

Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2015-07-13 Thread Meador Inge
On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote: > Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h On second thought, I was following an existing pattern in 'main.c'. Really fixing this would require changing around 30 other locations too. I think if we

Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2015-07-08 Thread Meador Inge
On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote: > Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h Will fix. Thanks. -- Meador

Re: [Qemu-devel] [PATCH v2] MIPS: Translate breaks and traps into the appropriate signal

2013-02-04 Thread Meador Inge
Ping: http://patchwork.ozlabs.org/patch/211162/. On 01/10/2013 04:50 PM, Meador Inge wrote: > GCC and GAS are capable of generating traps or breaks to check for > division by zero. Additionally, GAS is capable of generating traps > or breaks to check for overflow on certain div

[Qemu-devel] [PATCH v2] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Meador Inge
implements the corresponding feature in QEMU. Signed-off-by: Meador Inge --- Changes since v1: * Moved the BRK_* enumerations from target-mips/cpu.h to linux-user/main.c since they are only used in main.c * Fixed some style violations found by checkpatch.pl. * Removed a superfluous

Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Meador Inge
S CPU loop. I originally put it in target-mips/cpu.h because that is where the exception codes are defined. However, the one user argument makes sense to me. I moved the enum definition. Thanks for the review. -- Meador Inge CodeSourcery / Mentor Embedded

Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Meador Inge
On 01/10/2013 03:57 PM, Stefan Weil wrote: > please check your patch before submitting it to qemu-devel. > See also http://wiki.qemu.org/Contribute/SubmitAPatch. Ah, thanks for the pointer. I have fixed the style violations. -- Meador Inge CodeSourcery / Mentor Embedded

[Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Meador Inge
implements the corresponding feature in QEMU. Signed-off-by: Meador Inge --- linux-user/main.c | 64 - target-mips/cpu.h |6 + 2 files changed, 69 insertions(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index

Re: [Qemu-devel] [PATCH v1 4/4] hw: Add support for a dummy ARMv7-M board

2012-08-28 Thread Meador Inge
On 08/28/2012 07:48 AM, Peter Maydell wrote: > On 27 August 2012 21:37, Meador Inge wrote: >> This patch adds support for a "dummy" ARMv7-M board so that >> QEMU can be used as an ISS for ARMv7-M processors. For example, >> running an image compiled for th

[Qemu-devel] [PATCH] hw/armv7m_nvic: Correctly register GIC region when setting up NVIC

2012-08-27 Thread Meador Inge
memory access functions to be called when accessing parts of the NVIC memory. Signed-off-by: Meador Inge --- hw/armv7m_nvic.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/armv7m_nvic.c b/hw/armv7m_nvic.c index 6a0832e..5c09116 100644 --- a/hw/armv7m_nvic.c +++ b

[Qemu-devel] [PATCH v1 4/4] hw: Add support for a dummy ARMv7-M board

2012-08-27 Thread Meador Inge
This patch adds support for a "dummy" ARMv7-M board so that QEMU can be used as an ISS for ARMv7-M processors. For example, running an image compiled for the Cortex-M3 with -cpu cortex-m3 should just work. Signed-off-by: Meador Inge --- hw/arm/Makefile.objs |1 + hw/dumm

[Qemu-devel] [PATCH v1 1/4] hw: Add support for loading ARMv7-M applications via -kernel

2012-08-27 Thread Meador Inge
The minimal amount of arm_boot_info has been setup to allow for machines based off of ARMv7-M processors to be loaded via the -kernel option. Signed-off-by: Meador Inge --- hw/armv7m.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/hw/armv7m.c b/hw

[Qemu-devel] [PATCH v1 3/4] hw: Deduce the default machine from the specified CPU model

2012-08-27 Thread Meador Inge
ff-by: Meador Inge --- hw/alpha_dp264.c |2 +- hw/axis_dev88.c |2 +- hw/boards.h |4 ++-- hw/integratorcp.c |2 +- hw/lm32_boards.c |3 +-- hw/mcf5208.c |2 +- hw/milkym

[Qemu-devel] [PATCH v1 2/4] target-arm: Make SYS_HEAPINFO work for ARMv7-M

2012-08-27 Thread Meador Inge
The current implementation of the ARM semi-hosting SYS_HEAPINFO system call assumes that the base address of RAM for all ARM devices is 0x0. This isn't true for ARMv7-M devices, which uses a base of 0x2000 for SRAM. Signed-off-by: Meador Inge --- target-arm/arm-semi.c |8 ++

[Qemu-devel] [PATCH v1 0/4] Improve ARMv7-M architecture emulation

2012-08-27 Thread Meador Inge
for ARMv7-M applications. Meador Inge (4): hw: Add support for loading ARMv7-M applications via -kernel target-arm: Make SYS_HEAPINFO work for ARMv7-M hw: Deduce the default machine from the specified CPU model hw: Add support for a dummy ARMv7-M board hw/alpha_dp264.c |2

[Qemu-devel] [PATCH for-1.2 v2] target-mips: Enable access to required RDHWR hardware registers

2012-08-21 Thread Meador Inge
access to them when they are not available in hardware. * There is also the ULR register which is only recommended for full release 2 compliance. Incidentally, accessing this register in the current implementation works fine without flipping its access bit. Signed-off-by: Meador Inge

Re: [Qemu-devel] [PATCH] target-mips: Enable access to required RDHWR hardware registers

2012-08-21 Thread Meador Inge
On 08/21/2012 10:52 AM, Aurelien Jarno wrote: > Le 21/08/2012 17:41, Meador Inge a écrit : >> On 08/21/2012 05:14 AM, Andreas Färber wrote: >>> So what about the non-MIPS32r2 case? IIUC then the SYNCI_Step register >>> would no longer be accessible, which your commit m

Re: [Qemu-devel] [PATCH] target-mips: Enable access to required RDHWR hardware registers

2012-08-21 Thread Meador Inge
On 08/21/2012 05:14 AM, Andreas Färber wrote: > Am 21.08.2012 01:41, schrieb Meador Inge: >> While running in the usermode emulator all of the MIPS32r2 *required* >> RDHWR hardware registers should be accessible (the Linux kernel enables >> access to these same registers)

[Qemu-devel] [PATCH] target-mips: Enable access to required RDHWR hardware registers

2012-08-20 Thread Meador Inge
While running in the usermode emulator all of the MIPS32r2 *required* RDHWR hardware registers should be accessible (the Linux kernel enables access to these same registers). Signed-off-by: Meador Inge --- target-mips/translate.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions

Re: [Qemu-devel] [PATCH 01/10] hw/armv7m_nvic: Fix incorrect default for num-irqs property

2012-08-13 Thread Meador Inge
m_gpio_in' failed. Aborted (core dumped) I just tried out your patch and it fixes the issue I was seeing. Tested-by: Meador Inge -- Meador Inge CodeSourcery / Mentor Embedded http://www.mentor.com/embedded-software

Re: [Qemu-devel] [PATCH v2 2/2] linux-user: Use init_guest_space when -R and -B are specified

2012-08-13 Thread Meador Inge
On 08/13/2012 09:52 AM, Peter Maydell wrote: > I'm currently putting together a linux-user pullreq (with Riku's > agreement since he's currently a bit busy), so I'll just fix this > as I put this patch in, though. Thank you! -- Meador Inge CodeSourcery / Mentor E

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-10 Thread Meador Inge
#x27;s patches > with different SoB (not saying you are, same company after all). Please consider my patch retracted. Maciej's work superseded mine. -- Meador Inge CodeSourcery / Mentor Embedded http://www.mentor.com/embedded-software

Re: [Qemu-devel] [PATCH v2 0/2] Probe the guest memory space when using -R

2012-08-10 Thread Meador Inge
Ping ^ 2. On 08/01/2012 01:47 PM, Meador Inge wrote: > Ping. > > On 07/26/2012 09:50 PM, Meador Inge wrote: >> Hi, >> >> This patch series fixes an issue that was discussed here [1] where using -R >> can cause QEMU to fail to setup the guest address space because

[Qemu-devel] [Bug 1031920] [NEW] Linux user gdbserver does not respond to remote `Ctrl-C' interrupts

2012-08-01 Thread Meador Inge
Public bug reported: The bug was reproduced in a recent mainline build for ARM Linux by starting emulation with a gdbserver: $ qemu-arm -g 1234 a.out and then connecting from gdb: (gdb) target remote :1234 Remote debugging using :1234 [New Remote target] [Switching to Remote target] 0x8ba8

Re: [Qemu-devel] [PATCH v2 0/2] Probe the guest memory space when using -R

2012-08-01 Thread Meador Inge
Ping. On 07/26/2012 09:50 PM, Meador Inge wrote: > Hi, > > This patch series fixes an issue that was discussed here [1] where using -R > can cause QEMU to fail to setup the guest address space because the guest base > validation fails. I fixed this issue by (1) refactoring

[Qemu-devel] [PATCH v2 0/2] Probe the guest memory space when using -R

2012-07-26 Thread Meador Inge
pace(..., false);/ * Fixed typo in 'init_guest_space' header comment. [1] http://lists.nongnu.org/archive/html/qemu-devel/2012-06/msg04508.html Signed-off-by: Meador Inge Meador Inge (2): linux-user: Factor out guest space probing into a function linux-user: Use init_guest

[Qemu-devel] [PATCH v2 2/2] linux-user: Use init_guest_space when -R and -B are specified

2012-07-26 Thread Meador Inge
uaranteed to succeed since the host address space validation might fail. Signed-off-by: Meador Inge --- linux-user/elfload.c | 59 ++--- linux-user/main.c| 35 + linux-user/qemu.h|6 - 3 files changed,

[Qemu-devel] [PATCH v2 1/2] linux-user: Factor out guest space probing into a function

2012-07-26 Thread Meador Inge
Signed-off-by: Meador Inge --- linux-user/elfload.c | 110 +++--- linux-user/qemu.h| 13 ++ 2 files changed, 90 insertions(+), 33 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index f3b1552..7d8d866 100644 --- a

Re: [Qemu-devel] [PATCH 1/2] linux-user: Factor out guest space probing into a function

2012-07-25 Thread Meador Inge
On 07/10/2012 11:12 AM, Peter Maydell wrote: > On 10 July 2012 16:57, Meador Inge wrote: >> Signed-off-by: Meador Inge >> --- >> linux-user/elfload.c | 111 >> +++--- >> linux-user/qemu.h| 11 + >>

[Qemu-devel] [PATCH 2/2] linux-user: Use init_guest_space when -R and -B are specified

2012-07-10 Thread Meador Inge
Modify the driver to initialize the guest address space when -R or -B is specified so that the reserved memory space can be probed. Calling 'mmap' just once as is currently done is not guaranteed to succeed since the host address space validation might fail. Signed-off-by: M

[Qemu-devel] [PATCH 1/2] linux-user: Factor out guest space probing into a function

2012-07-10 Thread Meador Inge
Signed-off-by: Meador Inge --- linux-user/elfload.c | 111 +++--- linux-user/qemu.h| 11 + 2 files changed, 89 insertions(+), 33 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index f3b1552..44b4bdb 100644 --- a/linux

[Qemu-devel] [PATCH 0/2] Probe the guest memory space when using -R

2012-07-10 Thread Meador Inge
/msg04508.html Signed-off-by: Meador Inge Meador Inge (2): linux-user: Factor out guest space probing into a function linux-user: Use init_guest_space when -R and -B are specified linux-user/elfload.c | 162 ++ linux-user/main.c| 35

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Meador Inge
nd ensuring that the probing finds a single region for the request va region size and any needed extra stuff. Case (3) is mostly the same as (2) but we are probing for a guest base with a region size deduced from looking at the image we are loading. I suppose it is still OK to map two regions h

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Meador Inge
On 06/27/2012 12:32 PM, Richard Henderson wrote: > On 06/27/2012 08:51 AM, Meador Inge wrote: >> To solve this issue I experimented with performing a similar probing in >> 'main' >> as in 'probe_guest_base' so that we can find a reserved VA region tha

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Meador Inge
found that can be validated, then QEMU gives up. Does this approach seem reasonable? [1] http://git.qemu.org/?p=qemu.git;a=commit;h=97cc75606aef406e90a243cdb25347039003e7f0 -- Meador Inge CodeSourcery / Mentor Embedded http://www.mentor.com/embedded-software

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-12 Thread Meador Inge
On 06/12/2012 09:08 AM, Richard Henderson wrote: > On 2012-06-07 13:59, Meador Inge wrote: >> load_addr = loaddr; >> if (ehdr->e_type == ET_DYN) { >> +if (loaddr < mmap_min_addr) >> +probe_guest_base(image_name, loaddr, hiaddr);

Re: [Qemu-devel] [PATCH 0/4] linux-user: Option parser cleanup

2012-06-08 Thread Meador Inge
Ping ^ 3. On 05/07/2012 09:44 AM, Meador Inge wrote: > Ping ^ 2. > > On 04/04/2012 09:30 PM, Meador Inge wrote: >> Ping. Any comments on this series? >> >> On 03/27/2012 05:44 PM, Meador Inge wrote: >>> This series is focused at cleaning up a few issues in

Re: [Qemu-devel] [PATCH] MIPS/user: Fix reset CPU state initialization

2012-06-08 Thread Meador Inge
/* Enable access to the SYNCI_Step register. */ > env->CP0_HWREna |= (1 << 1); > if (env->CP0_Config1 & (1 << CP0C1_FP)) { > -env->hflags |= MIPS_HFLAG_FPU; > -} > -#ifdef TARGET_MIPS64 > -if (env->active_fpu.fcr0 & (1 << FCR0_F64)) { > -env->hflags |= MIPS_HFLAG_F64; > +env->CP0_Status |= (1 << CP0St_CU1); > } > -#endif > #else > if (env->hflags & MIPS_HFLAG_BMASK) { > /* If the exception was raised from a delay slot, > @@ -12820,7 +12815,6 @@ void cpu_state_reset(CPUMIPSState *env) > } > /* Count register increments in debug mode, EJTAG version 1 */ > env->CP0_Debug = (1 << CP0DB_CNT) | (0x1 << CP0DB_VER); > -env->hflags = MIPS_HFLAG_CP0; > > if (env->CP0_Config3 & (1 << CP0C3_MT)) { > int i; > @@ -12848,11 +12842,7 @@ void cpu_state_reset(CPUMIPSState *env) > } > } > #endif > -#if defined(TARGET_MIPS64) > -if (env->cpu_model->insn_flags & ISA_MIPS3) { > -env->hflags |= MIPS_HFLAG_64; > -} > -#endif > +compute_hflags(env); > env->exception_index = EXCP_NONE; > } > > -- Meador Inge CodeSourcery / Mentor Embedded http://www.mentor.com/embedded-software

[Qemu-devel] [RFC PATCH 0/1] linux-user: Issue running applications through ld.so

2012-06-07 Thread Meador Inge
when needed for shared objects. This worked for all the test cases I threw at it (including running the gcc and glibc test suites through QEMU). However, I am not all that familiar with the Linux usermode pieces and would like some feedback. Thoughts? Meador Inge (1): linux-user: Probe the

[Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-07 Thread Meador Inge
In some cases when running a shared library directly from QEMU (e.g. ld.so) the guest base should still be probed so that any images loaded later at fixed addresses by the target code can still be mapped. Signed-off-by: Meador Inge --- linux-user/elfload.c |3 +++ 1 files changed, 3

Re: [Qemu-devel] [PATCH 0/4] linux-user: Option parser cleanup

2012-05-07 Thread Meador Inge
Ping ^ 2. On 04/04/2012 09:30 PM, Meador Inge wrote: > Ping. Any comments on this series? > > On 03/27/2012 05:44 PM, Meador Inge wrote: >> This series is focused at cleaning up a few issues in the >> GNU/Linux usermode driver's option parsing. -h has been >&g

[Qemu-devel] [Bug 916720] Re: select fails on windows because a non-socket fd is in the rfds set

2012-04-19 Thread Meador Inge
I am still seeing the symptoms that Arie pointed out: Remote debugging using :1234 Ignoring packet error, continuing... warning: unrecognized item "timeout" in "qSupported" response Ignoring packet error, continuing... Ignoring packet error, continuing... Ignoring packet error, continuing... Ignor

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Init dcache and icache size for e500 user mode

2012-04-13 Thread Meador Inge
On 04/13/2012 06:40 AM, Andreas Färber wrote: > Am 12.04.2012 19:24, schrieb Scott Wood: >> On 04/12/2012 11:59 AM, Andreas Färber wrote: >>> Am 10.04.2012 22:04, schrieb Meador Inge: >>>> commit f7aa558396dd0f6b7a2b22c05cb503c655854102 pulled the dcache a

[Qemu-devel] [PATCH] target-ppc: Init dcache and icache size for e500 user mode

2012-04-10 Thread Meador Inge
commit f7aa558396dd0f6b7a2b22c05cb503c655854102 pulled the dcache and icache line size initialization inside of a '#if !defined(CONFIG_USER_ONLY)' block. This is not correct because instructions like 'dcbz' need the dcache size initialized even for user mode. Signed

Re: [Qemu-devel] [PATCH 0/4] linux-user: Option parser cleanup

2012-04-04 Thread Meador Inge
Ping. Any comments on this series? On 03/27/2012 05:44 PM, Meador Inge wrote: > This series is focused at cleaning up a few issues in the > GNU/Linux usermode driver's option parsing. -h has been > fixed to exit with 0, a -help option has been added, proper > error messages ha

[Qemu-devel] [PATCH 3/4] linux-user: Add proper error messages for bad options

2012-03-27 Thread Meador Inge
'--help' (it wasn't clear that --help was actually an error). Signed-off-by: Meador Inge --- linux-user/main.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 570178a..9616d8e 100644 --- a/linux-user/mai

[Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2012-03-27 Thread Meador Inge
Signed-off-by: Meador Inge --- linux-user/main.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 962677e..aabce83 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -51,7 +51,7 @@ int have_guest_base

[Qemu-devel] [PATCH 4/4] linux-user: Treat --foo options the same as -foo

2012-03-27 Thread Meador Inge
The system mode binaries provide a similiar alias and it makes common options like --version and --help work as expected. Signed-off-by: Meador Inge --- linux-user/main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index

[Qemu-devel] [PATCH 2/4] linux-user: Add -help

2012-03-27 Thread Meador Inge
This option is already available on the system mode binaries. It would be better if long options were supported (i.e. --help), but this is okay for now. Signed-off-by: Meador Inge --- linux-user/main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/linux-user/main.c

[Qemu-devel] [PATCH 0/4] linux-user: Option parser cleanup

2012-03-27 Thread Meador Inge
-foo. Meador Inge (4): linux-user: Exit 0 when -h is used linux-user: Add -help linux-user: Add proper error messages for bad options linux-user: Treat --foo options the same as -foo linux-user/main.c | 30 -- 1 files changed, 20 insertions(+), 10 dele

Re: [Qemu-devel] [PATCH v1 1/1] syscall: #ifdef newer RLIMIT_* codes

2012-03-27 Thread Meador Inge
uot;extended life cycle support"). So, I definitely need it :-) (and yes I know that this sysroot is ancient). I don't know if others are using such old development sysroots. The changes are minimal and while it would be great to have this applied upstream I do understand if you wan

Re: [Qemu-devel] [PATCH v1 1/1] syscall: #ifdef newer RLIMIT_* codes

2012-03-27 Thread Meador Inge
Ping. On 02/20/2012 01:38 PM, Andreas Färber wrote: > Am 20.02.2012 19:26, schrieb Meador Inge: >> Commit e22b7015353be824620b1f0f5e32a8575b898a8c added the translation >> from target to host RLIMIT_* codes, but some of the added codes are >> only available on newer

Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly

2012-03-27 Thread Meador Inge
Ping. On 02/24/2012 04:53 PM, Andreas Färber wrote: > Am 24.02.2012 23:18, schrieb Meador Inge: >> Fixing a simple typo, s/errno/err/, that caused >> the error status from GDB semihosted system calls >> to be returned incorrectly. >> >> Signed-off-by: Meador Ing

Re: [Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT

2012-03-05 Thread Meador Inge
On 03/05/2012 01:53 PM, Andreas Färber wrote: > Am 05.03.2012 18:06, schrieb Meador Inge: >> On 02/23/2012 07:44 AM, Meador Inge wrote: >> >>> 'POWERPC_INSNS2_DEFAULT' was defined incorrectly which was causing the >>> opcode table creation code to erro

Re: [Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT

2012-03-05 Thread Meador Inge
On 02/23/2012 07:44 AM, Meador Inge wrote: > 'POWERPC_INSNS2_DEFAULT' was defined incorrectly which was causing the > opcode table creation code to erroneously register 'eieio' and 'mbar' > for the "default" processor: > >** ERROR: opcod

Re: [Qemu-devel] [PATCH v1 1/1] mips: properly compute hflags and fcr0 on cpu reset

2012-03-03 Thread Meador Inge
On 03/03/2012 10:45 AM, Andreas Färber wrote: > Am 02.03.2012 22:03, schrieb Meador Inge: >> Currently 'cpu_reset' doesn't fully compute all of the needed >> HFLAGs and fails to setup fcr0 after clearing the CPU state. >> This can cause instruction exceptions

[Qemu-devel] [PATCH v1 1/1] mips: properly compute hflags and fcr0 on cpu reset

2012-03-02 Thread Meador Inge
model. Signed-off-by: Maciej W. Rozycki Signed-off-by: Nathan Froyd Signed-off-by: Meador Inge --- target-mips/cpu.h | 49 +++ target-mips/op_helper.c | 49 --- target-mips/translate.c | 17 +++--

[Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly

2012-02-24 Thread Meador Inge
Fixing a simple typo, s/errno/err/, that caused the error status from GDB semihosted system calls to be returned incorrectly. Signed-off-by: Meador Inge --- m68k-semi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/m68k-semi.c b/m68k-semi.c index bab01ee..6d60ced

[Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT

2012-02-23 Thread Meador Inge
to insert opcode [1f-16-1a] *** ERROR initializing PowerPC instruction 0x1f 0x16 0x1a Signed-off-by: Meador Inge --- target-ppc/translate_init.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index

[Qemu-devel] [PATCH v1 1/1] syscall: #ifdef newer RLIMIT_* codes

2012-02-20 Thread Meador Inge
Commit e22b7015353be824620b1f0f5e32a8575b898a8c added the translation from target to host RLIMIT_* codes, but some of the added codes are only available on newer version of Linux (as documented in 'getrlimit(2)'). Signed-off-by: Meador Inge --- linux-user/syscall.c | 12 +++

Re: [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the watch_mem_write

2012-02-20 Thread Meador Inge
On 02/18/2012 11:11 AM, Max Filippov wrote: > Signed-off-by: Max Filippov Reviewed-by: Meador Inge > --- > exec.c | 12 +--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/exec.c b/exec.c > index b81677a..f105b43 100644 > ---

Re: [Qemu-devel] [PATCH v2 1/1] exec: Fix watchpoint implementation

2012-02-20 Thread Meador Inge
On 02/18/2012 10:33 AM, Andreas Färber wrote: > Am 17.02.2012 18:06, schrieb Andreas Färber: >> Am 17.02.2012 18:03, schrieb Meador Inge: >>> Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f >>> where 'watch_mem_write' was modified to

[Qemu-devel] [PATCH v2 1/1] exec: Fix watchpoint implementation

2012-02-17 Thread Meador Inge
Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f where 'watch_mem_write' was modified to fall-through to 'abort' on every input. Signed-off-by: Meador Inge --- * Changes since v1: - 'break' out of switch statement instead of 'return

Re: [Qemu-devel] [PATCH v1 1/1] exec: Fix watchpoint implementation

2012-02-17 Thread Meador Inge
On 02/17/2012 10:28 AM, Jan Kiszka wrote: > On 2012-02-17 17:23, Meador Inge wrote: >> Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f >> where 'watch_mem_write' was modified to fall-through to 'abort' on >> every input. >> &

[Qemu-devel] [PATCH v1 1/1] exec: Fix watchpoint implementation

2012-02-17 Thread Meador Inge
Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f where 'watch_mem_write' was modified to fall-through to 'abort' on every input. Signed-off-by: Meador Inge --- exec.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/e

[Qemu-devel] [PATCH v2 0/1] Fix GDB semihosting

2012-02-17 Thread Meador Inge
quest until the system CPU has stopped. * Changes from v1 - At the suggestion of Peter Maydell I changed the implementation to delay sending syscall requests until the CPU has stopped instead of incorrectly attempting to just suppress the sending of 'T' status replies. Meador Ing

[Qemu-devel] [PATCH v2 1/1] gdbserver: Don't send a GDB syscall until the system CPU is stopped

2012-02-17 Thread Meador Inge
'RUN_STATE_PAUSED' state. Signed-off-by: Meador Inge --- gdbstub.c | 44 1 files changed, 28 insertions(+), 16 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 7d470b6..a08532f 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -283,8 +283,7 @@ en

Re: [Qemu-devel] [PATCH v1 0/1] Fix GDB semihosting

2012-02-16 Thread Meador Inge
On 02/16/2012 01:08 PM, Peter Maydell wrote: > On 16 February 2012 18:39, Meador Inge wrote: >> On 02/15/2012 02:14 PM, Peter Maydell wrote: >>> I think the right way to deal with both the problem you were seeing >>> and this related issue is simply not to try to s

Re: [Qemu-devel] [PATCH v1 0/1] Fix GDB semihosting

2012-02-16 Thread Meador Inge
CONFIG_USER_ONLY +s->state = RS_IDLE; +put_packet(s, gdb_syscall_buf); gdb_handlesig(s->c_cpu, 0); #else +/* In this case wait to send the syscall packet until notification that + the CPU has stopped. This must be done because if the packet is sent + now the reply from the syscall request could be received while the CPU + is still in the running state, which can cause packets to be dropped + and state transition 'T' packets to be sent while the syscall is still + being processed. */ cpu_exit(s->c_cpu); #endif } -- Meador Inge CodeSourcery / Mentor Embedded http://www.mentor.com/embedded-software

Re: [Qemu-devel] [MASCOT CONTEST] Alex Bradbury #1

2012-02-15 Thread Meador Inge
On Wed, Feb 15, 2012 at 8:31 AM, Anthony Liguori wrote: > Please respond to this note with an '+1', or an Ack, to vote for this icon. +1 -- Meador

Re: [Qemu-devel] [MASCOT CONTEST] Clare Liguori #1

2012-02-15 Thread Meador Inge
On Wed, Feb 15, 2012 at 8:46 AM, Anthony Liguori wrote: > Please respond to this note with an '+1', or an Ack, to vote for this icon. +1

Re: [Qemu-devel] [PATCH v1] ./configure: use -lole32 when building with mingw32

2012-02-15 Thread Meador Inge
On 02/15/2012 10:49 AM, Peter Maydell wrote: > On 15 February 2012 16:41, Meador Inge wrote: >> glib calls 'CoTaskMemFree' which is defined by ole32.dll. >> Therefore when building with mingw32 -lole32 should be in >> 'LIBS'. > > Not that I'

Re: [Qemu-devel] [PATCH v3 0/1] Allow the building of VirtFS to be disabled

2012-02-15 Thread Meador Inge
Ping... Any comments on the v3 patch? http://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg01236.html On Thu, Feb 9, 2012 at 8:31 PM, Meador Inge wrote: > There have been reports [1, 2] where folks have had issues building > VirtFS and the virtio backend on older systems.  I pers

Re: [Qemu-devel] [PATCH v1 1/1] gdbserver: Keep VM state status replies from happening during a syscall

2012-02-15 Thread Meador Inge
On 02/15/2012 11:54 AM, Blue Swirl wrote: > On Wed, Feb 15, 2012 at 16:55, Meador Inge wrote: >> Fix an issue where the GDB server implementation was allowing >> 'RUN_STATE_DEBUG' >> transitions to send a signal trap status back to the GDB client while a >>

[Qemu-devel] [PATCH v1 1/1] gdbserver: Keep VM state status replies from happening during a syscall

2012-02-15 Thread Meador Inge
Fix an issue where the GDB server implementation was allowing 'RUN_STATE_DEBUG' transitions to send a signal trap status back to the GDB client while a syscall is being processed. This eventually resulted in sending a SIGINT to the GDB client. Signed-off-by: Meador Inge --- gdbstu

[Qemu-devel] [PATCH v1 0/1] Fix GDB semihosting

2012-02-15 Thread Meador Inge
;' reply to be sent back to the GDB client. 8. The GDB client interrupts and breaks the semihosting flow. This patch fixes the problem be staying in the 'RS_SYSCALL' state until next packet read comes in. Therefore keeping any 'T' statuses from being sent back to the GDB client while the syscall is still being processed. Meador Inge (1): gdbserver: Keep VM state status replies from happening during a syscall gdbstub.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- 1.7.7.6

[Qemu-devel] [PATCH v1] ./configure: use -lole32 when building with mingw32

2012-02-15 Thread Meador Inge
glib calls 'CoTaskMemFree' which is defined by ole32.dll. Therefore when building with mingw32 -lole32 should be in 'LIBS'. Signed-off-by: Meador Inge --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 885

[Qemu-devel] [PATCH v3 1/1] ./configure: add option for disabling VirtFS

2012-02-09 Thread Meador Inge
Signed-off-by: Meador Inge --- Makefile |2 ++ configure | 25 +++-- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index e66e885..3dd67e2 100644 --- a/Makefile +++ b/Makefile @@ -40,7 +40,9 @@ HELPERS-$(CONFIG_LINUX) = qemu-bridge

[Qemu-devel] [PATCH v3 0/1] Allow the building of VirtFS to be disabled

2012-02-09 Thread Meador Inge
o" = "yes" -a "$bar" = "yes"'. * Changes from v1 - Simplify the configure logic and support the standard behavior of defaulting virtfs="". Changes suggested by Peter Maydell. Meador Inge (1): ./configure: add option for disabling VirtFS Mak

[Qemu-devel] [PATCH v2 1/1] ./configure: add option for disabling VirtFS

2012-02-09 Thread Meador Inge
Signed-off-by: Meador Inge --- Makefile |2 ++ configure | 25 +++-- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index e66e885..3dd67e2 100644 --- a/Makefile +++ b/Makefile @@ -40,7 +40,9 @@ HELPERS-$(CONFIG_LINUX) = qemu-bridge

[Qemu-devel] [PATCH v2 0/1] Allow the building of VirtFS to be disabled

2012-02-09 Thread Meador Inge
d by Peter Maydell. Meador Inge (1): ./configure: add option for disabling VirtFS Makefile |2 ++ configure | 25 +++-- 2 files changed, 21 insertions(+), 6 deletions(-) -- 1.7.7.6

Re: [Qemu-devel] [PATCH v1 1/1] ./configure: add option for disabling VirtFS

2012-02-09 Thread Meador Inge
On 02/09/2012 04:39 PM, Peter Maydell wrote: > On 7 February 2012 20:44, Meador Inge wrote: >> Signed-off-by: Meador Inge >> --- >> Makefile |4 >> configure | 16 +--- >> 2 files changed, 17 insertions(+), 3 deletions(-) >> >&

Re: [Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disabled

2012-02-09 Thread Meador Inge
On 02/08/2012 02:15 AM, Aneesh Kumar K.V wrote: > On Tue, 7 Feb 2012 14:44:05 -0600, Meador Inge > wrote: >> There have been reports [1, 2] where folks have had issues building >> VirtFS and the virtio backend on older systems. I personally saw >> problems due to the

[Qemu-devel] [PATCH v1 1/1] ./configure: add option for disabling VirtFS

2012-02-07 Thread Meador Inge
Signed-off-by: Meador Inge --- Makefile |4 configure | 16 +--- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 47acf3d..030619c 100644 --- a/Makefile +++ b/Makefile @@ -40,7 +40,9 @@ HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper

[Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disabled

2012-02-07 Thread Meador Inge
Fedora 16). [1] http://lists.nongnu.org/archive/html/qemu-devel/2011-12/msg00171.html [2] http://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg00404.html Meador Inge (1): ./configure: add option for disabling VirtFS Makefile |4 configure | 16 +--- 2 files changed, 17

[Qemu-devel] QEMU build errors with 'fdopendir'

2012-02-03 Thread Meador Inge
be available in some environments where QEMU is built. [1] http://lists.nongnu.org/archive/html/qemu-devel/2011-12/msg00171.html -- Meador Inge CodeSourcery / Mentor Embedded http://www.mentor.com/embedded-software