On Fri, 25 Jun 2021 at 14:58, Peter Maydell wrote:
>
> On Fri, 25 Jun 2021 at 12:18, Maxim Uvarov wrote:
> >
> > Fix irq mapping for virt machine reboot and shutdown
> > interrupts triggered from ATF code.
> >
> > Signed-off-by: Maxim Uvarov
> > -
Tested against the latest ecba223da6215d6f6ce2d343b70b2e9a19bfb90b
and ATF code. Patches fix 'reboot' and 'poweroff' commands issued
from linux.
Maxim Uvarov (2):
arm/virt: fix irq mapping for gpio_pwr
gpio_pwr: use shutdown function for reboot
hw/arm/virt.c
Fix irq mapping for virt machine reboot and shutdown
interrupts triggered from ATF code.
Signed-off-by: Maxim Uvarov
---
hw/arm/virt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 4b96f06014..d83f4ebdd3 100644
--- a/hw/arm/virt.c
qemu has 2 type of functions: shutdown and reboot. Shutdown
function has to be used for machine shutdown.
Signed-off-by: Maxim Uvarov
---
hw/gpio/gpio_pwr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/gpio/gpio_pwr.c b/hw/gpio/gpio_pwr.c
index 7714fa0dc4..dbaf1c70c8
Implement gpio-pwr driver to allow reboot and poweroff machine.
This is simple driver with just 2 gpios lines. Current use case
is to reboot and poweroff virt machine in secure mode. Secure
pl066 gpio chip is needed for that.
Signed-off-by: Maxim Uvarov
Reviewed-by: Hao Wu
Reviewed-by: Peter
Add secure pl061 for reset/power down machine from
the secure world (Arm Trusted Firmware). Connect it
with gpio-pwr driver.
Signed-off-by: Maxim Uvarov
Reviewed-by: Andrew Jones
---
hw/arm/Kconfig| 1 +
hw/arm/virt.c | 56 ++-
include
No functional change. Just refactor code to better
support secure and normal world gpios.
Signed-off-by: Maxim Uvarov
Reviewed-by: Andrew Jones
---
hw/arm/virt.c | 57 ---
1 file changed, 36 insertions(+), 21 deletions(-)
diff --git a/hw/arm
/arm-trusted-firmware/commit/886965bddb0624bdf85103efb2b39fd4eb73d89b
Maxim Uvarov (3):
hw: gpio: implement gpio-pwr driver for qemu reset/poweroff
arm-virt: refactor gpios creation
arm-virt: add secure pl061 for reset/power down
hw/arm/Kconfig| 1 +
hw/arm/virt.c | 111
Add secure pl061 for reset/power down machine from
the secure world (Arm Trusted Firmware). Connect it
with gpio-pwr driver.
Signed-off-by: Maxim Uvarov
---
hw/arm/Kconfig| 1 +
hw/arm/virt.c | 47 +++
include/hw/arm/virt.h | 2 ++
3
No functional change. Just refactor code to better
support secure and normal world gpios.
Signed-off-by: Maxim Uvarov
---
hw/arm/virt.c | 64 ++-
1 file changed, 43 insertions(+), 21 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index
Implement gpio-pwr driver to allow reboot and poweroff machine.
This is simple driver with just 2 gpios lines. Current use case
is to reboot and poweroff virt machine in secure mode. Secure
pl066 gpio chip is needed for that.
Signed-off-by: Maxim Uvarov
Reviewed-by: Hao Wu
---
hw/gpio/Kconfig
name space.
v3: added missed include qemu/log.h for qemu_log(..
v2: replace printf with qemu_log (Philippe Mathieu-Daudé)
This patch works together with ATF patch:
https://github.com/muvarov/arm-trusted-firmware/commit/886965bddb0624bdf85103efb2b39fd4eb73d89b
Maxim Uvarov (3):
hw: gpio
On Tue, 19 Jan 2021 at 16:07, Peter Maydell wrote:
>
> On Fri, 15 Jan 2021 at 10:11, Maxim Uvarov wrote:
> >
> > Add secure pl061 for reset/power down machine from
> > the secure world (Arm Trusted Firmware). Connect it
> > with gpio-pwr driver.
>
Add secure pl061 for reset/power down machine from
the secure world (Arm Trusted Firmware). Connect it
with gpio-pwr driver.
Signed-off-by: Maxim Uvarov
---
hw/arm/Kconfig| 1 +
hw/arm/virt.c | 50 +++
include/hw/arm/virt.h | 2 ++
3
Implement gpio-pwr driver to allow reboot and poweroff machine.
This is simple driver with just 2 gpios lines. Current use case
is to reboot and poweroff virt machine in secure mode. Secure
pl066 gpio chip is needed for that.
Signed-off-by: Maxim Uvarov
Reviewed-by: Hao Wu
---
hw/gpio/Kconfig
together with ATF patch:
https://github.com/muvarov/arm-trusted-firmware/commit/7556d07e87f755c602cd9d90359341bdd14d9d57
Previus discussion for reboot issue was here:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg757705.html
Maxim Uvarov (3):
hw: gpio: implement gpio-pwr driver
No functional change. Just refactor code to better
support secure and normal world gpios.
Signed-off-by: Maxim Uvarov
---
hw/arm/virt.c | 67 ---
1 file changed, 47 insertions(+), 20 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index
Combine code for secure and non secure pl061 (gpio) with
refining fdt creation.
Signed-off-by: Maxim Uvarov
---
hw/arm/virt.c | 122 ++
1 file changed, 83 insertions(+), 39 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 6f3ec15985
Add secure pl061 for reset/power down machine from
the secure world (Arm Trusted Firmware). Connect it
with gpio-pwr driver.
Signed-off-by: Maxim Uvarov
---
hw/arm/Kconfig| 1 +
hw/arm/virt.c | 34 ++
include/hw/arm/virt.h | 2 ++
3 files
Implement gpio-pwr driver to allow reboot and poweroff machine.
This is simple driver with just 2 gpios lines. Current use case
is to reboot and poweroff virt machine in secure mode. Secure
pl066 gpio chip is needed for that.
Signed-off-by: Maxim Uvarov
Reviewed-by: Hao Wu
---
hw/gpio/Kconfig
for reboot issue was here:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg757705.html
Maxim Uvarov (3):
hw: gpio: implement gpio-pwr driver for qemu reset/poweroff
arm-virt: add secure pl061 for reset/power down
arm-virt: combine code for secure and non secure pl061
hw/arm/Kconfig
On Thu, 14 Jan 2021 at 14:48, Peter Maydell wrote:
>
> On Thu, 14 Jan 2021 at 11:24, Maxim Uvarov wrote:
> >
> > On Thu, 14 Jan 2021 at 14:22, Maxim Uvarov wrote:
> > > Does that mean that in that case you need all regions to be 64k
> > > aligned? I mean secu
On Thu, 14 Jan 2021 at 14:22, Maxim Uvarov wrote:
>
> On Thu, 14 Jan 2021 at 12:50, Peter Maydell wrote:
> >
> > On Thu, 14 Jan 2021 at 00:04, Andrew Jones wrote:
> > >
> > > On Wed, Jan 13, 2021 at 10:30:47AM +0300, Maxim Uvarov wrote:
> > > >
On Thu, 14 Jan 2021 at 12:50, Peter Maydell wrote:
>
> On Thu, 14 Jan 2021 at 00:04, Andrew Jones wrote:
> >
> > On Wed, Jan 13, 2021 at 10:30:47AM +0300, Maxim Uvarov wrote:
> > > - the same size for secure and non secure gpio. Arm doc says that
> > > secure
Combine code for secure and non secure pl061 (gpio) with
refining fdt creation.
Signed-off-by: Maxim Uvarov
---
hw/arm/virt.c | 122 ++
1 file changed, 83 insertions(+), 39 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index d38a7d5d2f
Add secure pl061 for reset/power down machine from
the secure world (Arm Trusted Firmware). Connect it
with gpio-pwr driver.
Signed-off-by: Maxim Uvarov
---
hw/arm/Kconfig| 1 +
hw/arm/virt.c | 34 ++
include/hw/arm/virt.h | 2 ++
3 files
)
This patch works together with ATF patch:
https://github.com/muvarov/arm-trusted-firmware/commit/dd4401d8eb8e0f3018b335b81ce7a96d6cb16d0f
Previus discussion for reboot issue was here:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg757705.html
Maxim Uvarov (3):
hw: gpio
Implement gpio-pwr driver to allow reboot and poweroff machine.
This is simple driver with just 2 gpios lines. Current use case
is to reboot and poweroff virt machine in secure mode. Secure
pl066 gpio chip is needed for that.
Signed-off-by: Maxim Uvarov
Reviewed-by: Hao Wu
---
hw/gpio/Kconfig
at 19:28, Andrew Jones wrote:
>
> On Tue, Jan 12, 2021 at 11:25:30AM -0500, Andrew Jones wrote:
> > On Tue, Jan 12, 2021 at 04:00:23PM +, Peter Maydell wrote:
> > > On Tue, 12 Jan 2021 at 15:35, Andrew Jones wrote:
> > > >
> > > > On Tue, Jan
Add secure pl061 for reset/power down machine from
the secure world (Arm Trusted Firmware). Connect it
with gpio-pwr driver.
Signed-off-by: Maxim Uvarov
---
hw/arm/Kconfig| 1 +
hw/arm/virt.c | 40
include/hw/arm/virt.h | 3 +++
3 files
Implement gpio-pwr driver to allow reboot and poweroff machine.
This is simple driver with just 2 gpios lines. Current use case
is to reboot and poweroff virt machine in secure mode. Secure
pl066 gpio chip is needed for that.
Signed-off-by: Maxim Uvarov
---
hw/gpio/Kconfig | 3 ++
hw/gpio
:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg757705.html
Maxim Uvarov (2):
hw: gpio: implement gpio-pwr driver for qemu reset/poweroff
arm-virt: add secure pl061 for reset/power down
hw/arm/Kconfig| 1 +
hw/arm/virt.c | 40 +
hw/gpio
Please skip v2 and use v3. I had to check that one line change code
compiles. qemu_log() requires include header for that function.
Best regards,
Maxim.
On Wed, 6 Jan 2021 at 19:34, Maxim Uvarov wrote:
>
> Add secure pl061 for reset/power down machine from
> the secure world (Ar
Add secure pl061 for reset/power down machine from
the secure world (Arm Trusted Firmware).
Use the same gpio 3 and gpio 4 which were used by
non acpi variant of linux power control gpios.
Signed-off-by: Maxim Uvarov
---
v3: added missed include qemu/log.h for qemu_log(..
v2: replace printf
Add secure pl061 for reset/power down machine from
the secure world (Arm Trusted Firmware).
Use the same gpio 3 and gpio 4 which were used by
non acpi variant of linux power control gpios.
Signed-off-by: Maxim Uvarov
---
v2: replace printf with qemu_log (Philippe Mathieu-Daudé)
hw/arm/Kconfig
Add secure pl061 for reset/power down machine from
the secure world (Arm Trusted Firmware).
Use the same gpio 3 and gpio 4 which were used by
non acpi variant of linux power control gpios.
Signed-off-by: Maxim Uvarov
---
This patch works together with ATF patch:
https://github.com
Maydell wrote:
> > > On Wed, 28 Oct 2020 at 08:59, Maxim Uvarov
> > > wrote:
> > > >
> > > > If we're emulating EL3 then the EL3 guest firmware is responsible for
> > > > providing the PSCI ABI, including reboot, core power down, et
If we're emulating EL3 then the EL3 guest firmware is responsible for
providing the PSCI ABI, including reboot, core power down, etc.
sbsa-ref machine has an embedded controller to do reboot, poweroff. Machine
virt,secure=on can reuse this code to do reboot inside ATF.
Signed-off-by: Maxim U
On Thu, 15 Oct 2020 at 17:12, Graeme Gregory wrote:
>
> On Wed, Oct 14, 2020 at 01:04:43PM -0400, Shashi Mallela wrote:
> > This was added as a placeholder for the virt requirement suggested by Maxim
> > earlier.Agreed that this fdt otherwise has no significance for sbsa-ref
> > platform nor is be
> +static uint64_t sbsa_gwdt_rread(void *opaque, hwaddr addr, unsigned int size)
> +{
> +uint32_t ret;
> +
> +if (addr == SBSA_GWDT_WRR) {
> +/* watch refresh read has no effect and returns 0 */
> +ret = 0;
> +} else {
> +qemu_log_mask(LOG_GUEST_ERROR, "bad addre
On Thu, 8 Oct 2020 at 17:09, Peter Maydell wrote:
>
> On Thu, 8 Oct 2020 at 11:43, Maxim Uvarov wrote:
> >
> > On Thu, 8 Oct 2020 at 13:27, Peter Maydell wrote:
> > >
> > > On Thu, 8 Oct 2020 at 11:21, Maxim Uvarov wrote:
> > > > Interesting
STATE_END_OF_LIST()
> +}
> +};
> +
> +static uint64_t sbsa_gwdt_rread(void *opaque, hwaddr addr, unsigned int size)
> +{
> +uint32_t ret;
> +
> +if (addr == SBSA_GWDT_WRR) {
> +/* watch refresh read has no effect and returns 0 */
> +ret = 0
On Thu, 8 Oct 2020 at 13:27, Peter Maydell wrote:
>
> On Thu, 8 Oct 2020 at 11:21, Maxim Uvarov wrote:
> >
> > On Thu, 8 Oct 2020 at 05:43, Shashi Mallela
> > wrote:
> > > +static void sbsa_gwdt_update_timer(SBSA_GWDTState *s)
> > > +{
> > >
On Thu, 8 Oct 2020 at 05:43, Shashi Mallela wrote:
>
> Generic watchdog device model has been implemented as per ARM BSAv0.9
>
> Signed-off-by: Shashi Mallela
> ---
> hw/arm/Kconfig | 1 +
> hw/watchdog/Kconfig | 4 +
> hw/watchdog/meson.build
Hi.
one small note below in this email.
On Thu, 8 Oct 2020 at 05:43, Shashi Mallela wrote:
>
> Included the newly implemented SBSA generic watchdog device model into
> SBSA platform
>
> Signed-off-by: Shashi Mallela
> ---
> hw/arm/sbsa-ref.c | 44
>
On Thu, 1 Oct 2020 at 23:36, Peter Maydell wrote:
>
> On Thu, 1 Oct 2020 at 20:37, Maxim Uvarov wrote:
> >
> > Initial virtual driver matching linux kernel sbsa_gwdt
> > driver. Driver implements basic functionality and makes
> > watchdog works on virtual machine a
rver Base System Architecture (SBSA)
Signed-off-by: Maxim Uvarov
---
hw/arm/virt.c | 28
hw/watchdog/Kconfig| 5 +
hw/watchdog/meson.build| 1 +
hw/watchdog/sbsa_wdt.c | 293 +
include/hw/arm/virt.h
-rc3#n705
.compatible = "linaro,optee-tz"
Thank you,
Maxim.
On Wed, 22 Apr 2020 at 16:07, Maxim Uvarov wrote:
>
> Add optee compatible string for dtb to force linux
> to boot optee module.
>
> Signed-off-by: Maxim Uvarov
> ---
> v2: added method.
> hw/arm/virt.c
Add optee compatible string for dtb to force linux
to boot optee module.
Signed-off-by: Maxim Uvarov
---
v2: added method.
hw/arm/virt.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 656b008..c937a82 100644
--- a/hw/arm/virt.c
+++ b
Add optee compatible string for dtb to force linux
to boot optee module.
Signed-off-by: Maxim Uvarov
---
hw/arm/virt.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 656b008..7d712f3 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
Add optee compatible string for dtb to force linux
to boot optee module.
Signed-off-by: Maxim Uvarov
---
hw/arm/virt.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 656b008..7d712f3 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
51 matches
Mail list logo
