Re: Will the qemu-devel prefix in the mails come back?

2019-09-19 Thread Martin Schrodt
On 9/19/19 8:13 PM, Alexander von Gluck IV wrote: > Here's catching + sorting this ML in procmail... > > :0: > * ^(List-Id).*qemu-devel.nongnu.org.* > .Lists.Qemu/ > Here's what I did (dovecot sieve): if exists "List-Id" { if header :regex "List-id" "<([a-z_0-9-]+)[.@]" {

Re: Will the qemu-devel prefix in the mails come back?

2019-09-19 Thread Martin Schrodt
On 9/19/19 7:29 PM, Daniel P. Berrangé wrote: > On Thu, Sep 19, 2019 at 07:04:15PM +0200, Martin Schrodt wrote: >> Does anybody know? > > Unfortunately, no, it won't. > > ... Thanks a lot for the explanation, makes sense. Thank y'all for answering so quickly! Martin

Will the qemu-devel prefix in the mails come back?

2019-09-19 Thread Martin Schrodt
Does anybody know? My mail filter would appreciate :) Thank you, Martin

[Qemu-devel] [Bug 1839060] [NEW] HDA device non functional in Windows 10 1903

2019-08-06 Thread Martin Schrodt
Public bug reported: I made the update to 1903, and the HDA device stopped working. The driver says the device is working correctly, but it does not. When I try to open the Windows sound configuration, the dialog hangs and never shows it's content. Several people reported this back in May: htt

[Qemu-devel] [PATCH] fix microphone lag with PA

2019-06-15 Thread Martin Schrodt
. This fixes the problem reliably on their side, while having no adverse effects on mine. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index fa9dd9efd4..5fc886bb33 100644 --- a/audio/paaudio.c

[Qemu-devel] [PATCH V4 3/3] audio/paaudio: fix microphone input being unusable

2019-03-15 Thread Martin Schrodt
The current code does not specify the metrics of the buffers for the input device. This makes PulseAudio choose very bad defaults, which causes input to be unusable: Audio put in gets out 30 seconds later. This patch fixes that and makes the latency configurable as well. Signed-off-by: Martin

[Qemu-devel] [PATCH V4 2/3] audio/paaudio: prolong and make latency configurable

2019-03-15 Thread Martin Schrodt
smaller chunks helped. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 12 ++-- qapi/audio.json | 6 +- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index ab2a37bbdb..be27c73f09 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c

[Qemu-devel] [PATCH V4 0/3] Fixes for PulseAudio driver

2019-03-15 Thread Martin Schrodt
revealed that having a longer buffer does not hurt, so it's propably better to not make it artificially short when the user chooses shorter timer periods) Martin Schrodt (3): audio/paaudio: fix ignored buffer_length setting audio/paaudio: prolong and make latency configurable audio/pa

[Qemu-devel] [PATCH V4 1/3] audio/paaudio: fix ignored buffer_length setting

2019-03-15 Thread Martin Schrodt
Audiodev configuration allows to set the length of the buffered data. The setting was ignored and a constant value used instead. This patch makes the code apply the setting properly, and uses the previous default if nothing is supplied. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 24

Re: [Qemu-devel] [PATCH 2/3] make latency configurable

2019-03-15 Thread Martin Schrodt
Hi, On 3/15/19 8:53 AM, Gerd Hoffmann wrote: > Hi, > >> r = pa_stream_connect_playback (stream, dev, attr, >> PA_STREAM_INTERPOLATE_TIMING >> -#ifdef PA_STREAM_ADJUST_LATENCY >> |PA_STREAM_ADJUST_LATENCY

Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

2019-03-15 Thread Martin Schrodt
On 3/15/19 9:01 AM, Gerd Hoffmann wrote: > On Fri, Mar 15, 2019 at 08:49:06AM +0100, Martin Schrodt wrote: >> Hi, >> >> On 3/15/19 8:43 AM, Gerd Hoffmann wrote: >>> Hi, >>> >>>> -qapi_Audio

Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

2019-03-15 Thread Martin Schrodt
Hi, On 3/15/19 8:43 AM, Gerd Hoffmann wrote: > Hi, > >> -qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); >> +qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, >> ppdo->buffer_length); > > I'd just use > > ppdo->has_buffer_length ? ppdo->buffer_leng

Re: [Qemu-devel] [PATCH V2 1/3] audio/paaudio: fix ignored buffer_length setting

2019-03-14 Thread Martin Schrodt
On 3/14/19 10:34 PM, Philippe Mathieu-Daudé wrote: >> +static int qpa_validate_per_direction_opts (Audiodev *dev, >> AudiodevPaPerDirectionOptions *pdo) > > If this function is expected to return a boolean value, please use the > 'bool' C type and true/false. > >> +{ >> +if (!pdo->has_buffer

[Qemu-devel] [PATCH V3 1/3] audio/paaudio: fix ignored buffer_length setting

2019-03-14 Thread Martin Schrodt
Audiodev configuration allows to set the length of the buffered data. The setting was ignored and a constant value used instead. This patch makes the code apply the setting properly. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 24 +--- 1 file changed, 21 insertions

[Qemu-devel] [PATCH V3 2/3] audio/paaudio: prolong and make latency configurable

2019-03-14 Thread Martin Schrodt
configurable via the new -audiodev config. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 18 +++--- qapi/audio.json | 6 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 695b30d419..adf5fe3779 100644 --- a/audio/paaudio.c

[Qemu-devel] [PATCH V3 3/3] audio/paaudio: fix microphone input being unusable

2019-03-14 Thread Martin Schrodt
The current code does not specify the metrics of the buffers for the input device. This makes PulseAudio choose very bad defaults, which causes input to be unusable: Audio put in gets out 30 seconds later. This patch fixes that and makes the latency configurable as well. Signed-off-by: Martin

[Qemu-devel] [PATCH V3 0/3] Fixes for PulseAudio Driver

2019-03-14 Thread Martin Schrodt
Version 2 of the series added proper commit messages and fixed a typo. Version 3 fixes coding style problems Martin Schrodt (3): audio/paaudio: fix ignored buffer_length setting audio/paaudio: prolong and make latency configurable audio/paaudio: fix microphone input being unusable audio

[Qemu-devel] [PATCH V2 0/3] Fixes for PulseAudio driver

2019-03-14 Thread Martin Schrodt
Version 2 of the series, adds proper commit messages and fixes a typo. Martin Schrodt (3): audio/paaudio: fix ignored buffer_length setting audio/paaudio: prolong and make latency configurable audio/paaudio: fix microphone input being unusable audio/paaudio.c | 45

[Qemu-devel] [PATCH V2 2/3] audio/paaudio: prolong and make latency configurable

2019-03-14 Thread Martin Schrodt
configurable via the new -audiodev config. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 18 +++--- qapi/audio.json | 6 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 1a799ca3e7..c9007fdb01 100644 --- a/audio/paaudio.c

[Qemu-devel] [PATCH V2 1/3] audio/paaudio: fix ignored buffer_length setting

2019-03-14 Thread Martin Schrodt
Audiodev configuration allows to set the length of the buffered data. The setting was ignored and a constant value used instead. This patch makes the code apply the setting properly. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 21 ++--- 1 file changed, 18 insertions

[Qemu-devel] [PATCH V2 3/3] audio/paaudio: fix microphone input being unusable

2019-03-14 Thread Martin Schrodt
The current code does not specify the metrics of the buffers for the input device. This makes PulseAudio choose very bad defaults, which causes input to be unusable: Audio put in gets out 30 seconds later. This patch fixes that and makes the latency configurable as well. Signed-off-by: Martin

[Qemu-devel] [PATCH 2/3] make latency configurable

2019-03-14 Thread Martin Schrodt
Signed-off-by: Martin Schrodt --- audio/paaudio.c | 18 +++--- qapi/audio.json | 5 - 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 1a799ca3e7..c9007fdb01 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -500,16

[Qemu-devel] [PATCH 3/3] fix input lag

2019-03-14 Thread Martin Schrodt
Signed-off-by: Martin Schrodt --- audio/paaudio.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index c9007fdb01..e4370c3113 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -600,6 +600,7 @@ static int qpa_init_in(HWVoiceIn *hw

[Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

2019-03-14 Thread Martin Schrodt
Signed-off-by: Martin Schrodt --- audio/paaudio.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 5d410ed73f..1a799ca3e7 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -577,7 +577,7 @@ static int

[Qemu-devel] [PATCH 0/3] Fixes for PulseAudio driver

2019-03-14 Thread Martin Schrodt
included in 4.0? If that's the case I'd make a post on Reddit's VFIO section to find some testers, to see if the defaults work. Martin Schrodt (3): fix: buffer_length is ignored make latency configurable fix input lag audio/paaudio.c | 45 +++-

[Qemu-devel] [PATCH v4 1/2] audio/paaudio: remove separate PA feeder threads

2017-10-15 Thread Martin Schrodt
t;instruct PA to adjust latency for recording device" When this is enabled, PA will try to set the overall latency of the source to the value given by FRAGSIZE. Signed-off-by: Martin Schrodt --- audio/audio.c | 5 + audio/audio_int.h | 2 + audio/paaudio.c | 635 ++

[Qemu-devel] [PATCH v4 2/2] audio/hda: create millisecond timers that handle IO

2017-10-15 Thread Martin Schrodt
with other backends (for example Alsa). Signed-off-by: Martin Schrodt --- hw/audio/hda-codec.c | 193 --- hw/audio/intel-hda.c | 7 -- 2 files changed, 154 insertions(+), 46 deletions(-) diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c

[Qemu-devel] [PATCH v4 0/2] Improve audio output quality

2017-10-15 Thread Martin Schrodt
the style checker bots... :( Signed-off-by: Martin Schrodt Martin Schrodt (2): audio/paaudio: remove separate PA feeder threads audio/hda: create millisecond timers that handle IO audio/audio.c| 5 + audio/audio_int.h| 2 + audio/paaudio.c | 635

[Qemu-devel] [PATCH v3 2/2] audio/hda: create millisecond timers that handle IO

2017-10-15 Thread Martin Schrodt
with other backends (for example Alsa). Signed-off-by: Martin Schrodt --- hw/audio/hda-codec.c | 193 --- hw/audio/intel-hda.c | 7 -- 2 files changed, 154 insertions(+), 46 deletions(-) diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c

[Qemu-devel] [PATCH v3 0/2] Improve audio output quality

2017-10-15 Thread Martin Schrodt
assistance with. Signed-off-by: Martin Schrodt Martin Schrodt (2): audio/paaudio: remove separate PA feeder threads audio/hda: create millisecond timers that handle IO audio/audio.c| 5 + audio/audio_int.h| 2 + audio/paaudio.c | 635

[Qemu-devel] [PATCH v3 1/2] audio/paaudio: remove separate PA feeder threads

2017-10-15 Thread Martin Schrodt
t;instruct PA to adjust latency for recording device" When this is enabled, PA will try to set the overall latency of the source to the value given by FRAGSIZE. Signed-off-by: Martin Schrodt --- audio/audio.c | 5 + audio/audio_int.h | 2 + audio/paaudio.c | 635 ++

[Qemu-devel] [PATCH v2 1/2] audio/paaudio: remove separate PA feeder threads

2017-10-15 Thread Martin Schrodt
t;instruct PA to adjust latency for recording device" When this is enabled, PA will try to set the overall latency of the source to the value given by FRAGSIZE. Signed-off-by: Martin Schrodt --- audio/audio.c | 5 + audio/audio_int.h | 2 + audio/paaudio.c | 862 ++

[Qemu-devel] [PATCH v2 0/2] Improve audio output quality

2017-10-15 Thread Martin Schrodt
presented this to the list a few days ago, but it was in too rough a state, so I cleaned it up and wrote better commit messages. This is still missing proper handling for VMState-migration, which I will need a bit of assistance with. Signed-off-by: Martin Schrodt Martin Schrodt (2): audio/paaudio

[Qemu-devel] [PATCH v2 2/2] audio/hda: create millisecond timers that handle IO

2017-10-15 Thread Martin Schrodt
with other backends (for example Alsa). Signed-off-by: Martin Schrodt --- hw/audio/hda-codec.c | 193 --- hw/audio/intel-hda.c | 7 -- 2 files changed, 154 insertions(+), 46 deletions(-) diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c

Re: [Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-10 Thread Martin Schrodt
On 10/10/2017 08:18 PM, Eric Blake wrote: > That's a lot of changes to be slamming in one patch. Any chance you can > split it into a series of smaller patches that are easier to review > individually? Perhaps one patch per item in your bulleted list is a > good start for subdividing this into s

[Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-10 Thread Martin Schrodt
input delay when first using the input device. Signed-off-by: Martin Schrodt --- audio/audio.c | 4 + audio/audio_int.h | 2 + audio/paaudio.c | 640 -- hw/audio/hda-codec.c | 218 +--- hw/audio/intel

[Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-10 Thread Martin Schrodt
input delay when first using the input device. Signed-off-by: Martin Schrodt --- audio/audio.c | 4 + audio/audio_int.h | 2 + audio/paaudio.c | 640 -- hw/audio/hda-codec.c | 218 +--- hw/audio/intel