Paolo Abeni writes:
> Extend the VirtioDeviceFeatures struct with an additional u64
> to track unknown features in the 64-127 bit range and decode
> the full virtio features spaces for vhost and virtio devices.
>
> Also add entries for the soon-to-be-supported virtio net GSO over
> UDP features.
Kostiantyn Kostiuk writes:
> g_win32_error_message - translate a Win32 error code
> (as returned by GetLastError()) into the corresponding message.
>
> In the same time, we call error_setg_win32_internal with
> error codes from different Windows componets like VSS or
> Performance monitor that pr
Daniel P. Berrangé writes:
> On Fri, Jul 18, 2025 at 07:59:50AM +0200, Markus Armbruster wrote:
>> Markus Armbruster writes:
>>
>> > Adam Williamson writes:
>> >
>> >> In cfcacba an `error_report` was added to this file, but the
>> >>
Markus Armbruster writes:
> Adam Williamson writes:
>
>> In cfcacba an `error_report` was added to this file, but the
>> corresponding include of `qemu/error-report.h` was missed. This
>> only becomes apparent when building against Xen 4.20+.
>>
>> Signed-of
Adam Williamson writes:
> In cfcacba an `error_report` was added to this file, but the
> corresponding include of `qemu/error-report.h` was missed. This
> only becomes apparent when building against Xen 4.20+.
>
> Signed-off-by: Adam Williamson
> ---
> hw/xen/xen_pt.c | 1 +
> 1 file changed, 1
We recently (merge commit 504632dcc631) enclosed command and type
names in `backquotes`, so they become links in generated HTML. Take
care of a few we missed.
Signed-off-by: Markus Armbruster
---
qapi/dump.json | 2 +-
qapi/machine.json | 2 +-
qapi/migration.json | 4 ++--
qapi/misc
Enclose command and type names in `backquotes`, so they become links
in generated HTML.
We did this for qapi/ in merge commit 504632dcc631.
Signed-off-by: Markus Armbruster
---
qga/qapi-schema.json | 80 ++--
1 file changed, 40 insertions(+), 40
tion about route of network.
Return:
[GuestNetworkRoute] -- List of route info of guest.
Fixes: commit 8e326d36dd16 (qga/linux: Add new api 'guest-network-get-route')
Signed-off-by: Markus Armbruster
Reviewed-by: Daniel P. Berrangé
---
qga/qapi-schema.json | 1 +
1 file
ned-off-by: Markus Armbruster
Reviewed-by: Daniel P. Berrangé
---
qga/qapi-schema.json | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index a9cc9150dc..6c26ace3c9 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -53
This series touches only doc comments. I'd like to get it into 10.1.
v2:
* PATCH 4: More cross-references [Daniel]
Markus Armbruster (4):
qga: Fix guest-network-get-route return value documentation
qga: Remove trivial "Returns:" sections
qga: Rephrase return docs to avoid
iously
no worse. For instance, guest-info's documentation changes from
Return:
GuestAgentInfo -- GuestAgentInfo
to
Return:
GuestAgentInfo
The auto-generated returns all are in the exact same spot.
We did this for qapi/ in commit 0462da9d6b1 (qapi: remove trivial
"Ret
Daniel P. Berrangé writes:
> On Thu, Jul 17, 2025 at 10:21:17AM +0200, Markus Armbruster wrote:
>> Enclose command and type names in `backquotes`, so they become links
>> in generated HTML.
>>
>> We did this for qapi/ in merge commit 504632dcc631.
>>
&g
ned-off-by: Markus Armbruster
---
qga/qapi-schema.json | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index a9cc9150dc..6c26ace3c9 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -534,8 +534,7 @@
# discarded. T
tion about route of network.
Return:
[GuestNetworkRoute] -- List of route info of guest.
Fixes: commit 8e326d36dd16 (qga/linux: Add new api 'guest-network-get-route')
Signed-off-by: Markus Armbruster
---
qga/qapi-schema.json | 1 +
1 file changed, 1 insertion(+)
diff --git a/qg
This series touches only doc comments. I'd like to get it into 10.1.
Markus Armbruster (4):
qga: Fix guest-network-get-route return value documentation
qga: Remove trivial "Returns:" sections
qga: Rephrase return docs to avoid type name
qga: Add cross-references
qga/q
iously
no worse. For instance, guest-info's documentation changes from
Return:
GuestAgentInfo -- GuestAgentInfo
to
Return:
GuestAgentInfo
The auto-generated returns all are in the exact same spot.
We did this for qapi/ in commit 0462da9d6b1 (qapi: remove trivial
"Ret
Enclose command and type names in `backquotes`, so they become links
in generated HTML.
We did this for qapi/ in merge commit 504632dcc631.
Signed-off-by: Markus Armbruster
---
qga/qapi-schema.json | 50 ++--
1 file changed, 25 insertions(+), 25
Brian Song writes:
> This work provides an initial implementation of fuse-over-io_uring
> support for QEMU export. According to the fuse-over-io_uring protocol
> specification, the userspace side must create the same number of queues
> as the number of CPUs (nr_cpu), just like the kernel. Current
The following changes since commit f96b157ebb93f94cd56ebbc99bc20982b8fd86ef:
Merge tag 'accel-20250715' of https://github.com/philmd/qemu into staging
(2025-07-16 07:13:40 -0400)
are available in the Git repository at:
https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2025-07-16
for you to
ed if they
are present and functional. The version used for building docs on
readthedocs is pinned to the recommended version, 6.2.1.)
Signed-off-by: Akihiko Odaki
Tested-by: Markus Armbruster
Reviewed-by: John Snow
Signed-off-by: John Snow
Message-ID: <20250715212848.171879-2-js...@redhat.
From: Steve Sistare
Use qom-list-get to speed up the qom-tree command.
Signed-off-by: Steve Sistare
Acked-by: Markus Armbruster
Message-ID: <1752248703-217318-3-git-send-email-steven.sist...@oracle.com>
Tested-by: Markus Armbruster
[Lint picked off to mollify make check-minreqs]
Sign
From: Akihiko Odaki
Add docs/requirements.txt to
"Sphinx documentation configuration and build machinery".
Signed-off-by: Akihiko Odaki
Signed-off-by: John Snow
Message-ID: <20250715212848.171879-3-js...@redhat.com>
Reviewed-by: Thomas Huth
Signed-off-by: Markus Armbruster
From: Steve Sistare
Add a unit test for qom-list-get.
Signed-off-by: Steve Sistare
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Message-ID: <1752248703-217318-4-git-send-email-steven.sist...@oracle.com>
Signed-off-by: Markus Armbruster
---
tests/qtest/qom-test.c
--- 80.9.0 8.2.3
pkgsrc_current 3.12.11 25.1.1 80.9.0 8.2.3
Signed-off-by: John Snow
Message-ID: <20250715222548.19-1-js...@redhat.com>
Tested-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
python/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2
ed-by: Philippe Mathieu-Daudé
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Message-ID: <1752248703-217318-2-git-send-email-steven.sist...@oracle.com>
Signed-off-by: Markus Armbruster
---
qapi/qom.json | 50 +++
qom/qom-qmp-
Queued for 10.1. Thanks!
John Snow writes:
> On Wed, Jul 16, 2025, 11:04 AM Markus Armbruster wrote:
>
>> Okay to include this in my next QAPI PR?
>>
>
> That would be very convenient, thank you!
>
> (And thanks to Akihiko Odaki for spotting and fixing the issue, even if it
> took me a
t;
> Until that time, we can make use of a transitional feature in
> pip/setuptools to use "legacy" editable installs, which is enough to fix
> "make check-dev" on modern local workstations for now.
This fixes "make check-dev" for me on Fedora 41. Thank you!
Tested-by: Markus Armbruster
[...]
Okay to include this in my next QAPI PR?
Daniel P. Berrangé writes:
> On Wed, Jul 16, 2025 at 12:41:31PM +0200, Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>>
>> > On Tue, Jul 15, 2025 at 10:35:16AM +0200, Philippe Mathieu-Daudé wrote:
>> >> @errp is always NULL. Remove it, as unused.
Daniel P. Berrangé writes:
> On Tue, Jul 15, 2025 at 10:35:17AM +0200, Philippe Mathieu-Daudé wrote:
>> @errp is always NULL. Remove it, as unused.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> include/system/os-win32.h | 2 +-
>> util/aio-win32.c | 2 +-
>> util/oslib-win32
Daniel P. Berrangé writes:
> On Tue, Jul 15, 2025 at 10:35:16AM +0200, Philippe Mathieu-Daudé wrote:
>> @errp is always NULL. Remove it, as unused.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> include/system/os-win32.h | 2 +-
>> io/channel-socket.c | 4 ++--
>> util/oslib-win32
John Snow writes:
> On Fri, Jul 11, 2025, 10:47 AM Markus Armbruster wrote:
[...]
>> Exception ignored in: > 0x7fcfcd080d60>
>> Traceback (most recent call last):
>> File "/work/armbru/qemu/scripts/qmp/../../python/qemu/qmp/legacy.py",
>> line 31
Philippe Mathieu-Daudé writes:
> Hi Markus,
I missed this one, sorry!
> On 3/7/25 12:54, Philippe Mathieu-Daudé wrote:
>> Extract TCG and KVM definitions from machine.json to accelerator.json.
>> Signed-off-by: Philippe Mathieu-Daudé
>> Reviewed-by: Pierrick Bouvier
>> Reviewed-by: Zhao Liu
oss-references to sockets.json
qapi: add cross-references to ui.json
qapi: add cross-references to virtio.json
qapi: add cross-references to yank.json
qapi: add cross-references to misc modules
Markus Armbruster (2):
qapi: Clean up "This command will do ..." com
Stefan Hajnoczi writes:
> On Mon, Jul 14, 2025 at 11:14 AM Markus Armbruster wrote:
>>
>> The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336:
>>
>> Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into
>> st
tput. This is a bug fix.
Signed-off-by: John Snow
Message-ID: <20250618165353.1980365-4-js...@redhat.com>
Acked-by: Markus Armbruster
Fixes: b61a4eb3f32 (docs/qapidoc: support header-less freeform sections)
[Tweak commit message to say it's a bug fix, add Fixes:]
Signed-off-by: Ma
as
invalid QAPI doc section heading in free-form comments.
Signed-off-by: John Snow
Message-ID: <20250618165353.1980365-5-js...@redhat.com>
Reviewed-by: Markus Armbruster
[Add more detail to commit message]
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-5-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/crypto.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qapi/crypto.json b/qapi/crypt
From: Steve Sistare
Use qom-list-get to speed up the qom-tree command.
Signed-off-by: Steve Sistare
Acked-by: Markus Armbruster
Message-ID: <1752248703-217318-3-git-send-email-steven.sist...@oracle.com>
Tested-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
python/qemu
0250711051045.51110-3-js...@redhat.com>
Reviewed-by: Markus Armbruster
[_insert_near_kind() code replaced by something simpler, commit
message amended to explain why we're doing this]
Signed-off-by: Markus Armbruster
---
docs/sphinx/qapidoc.py | 14 --
qapi/machine.
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-10-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/net.json | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qapi/net.json b/qapi/net.json
ed-by: Philippe Mathieu-Daudé
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Message-ID: <1752248703-217318-2-git-send-email-steven.sist...@oracle.com>
Signed-off-by: Markus Armbruster
---
qapi/qom.json | 50 +++
qom/qom-qmp-
Use the conventional "- If " phrasing, optionally
with ", ".
Signed-off-by: Markus Armbruster
Message-ID: <20250708072828.105185-3-arm...@redhat.com>
Reviewed-by: Daniel P. Berrangé
---
qapi/misc-i386.json | 7 +++
qapi/qom.json | 4 ++--
2 files changed, 5
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-7-js...@redhat.com>
Reviewed-by: Markus Armbruster
[Accidental line rewrap and an unwanted cross-refence dropped]
Signed-off-by: Markus Armbruster
---
qapi/job.jso
John Snow
Message-ID: <20250711051045.51110-4-js...@redhat.com>
Reviewed-by: Markus Armbruster
[Two more Returns: removed, commit message amended to explain
auto-generated returns generated into a different spot]
Signed-off-by: Markus Armbruster
---
qapi/audio.json | 2 --
qapi/
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-2-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/acpi.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/acpi.json b/qapi/acpi.json
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-14-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/run-state.json | 46 ++---
1 file changed, 23 insertions(+), 23 deletions(-)
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-6-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/dump.json | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qapi/dump.json b/qapi/dum
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-11-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/pci.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/pci.json b/qapi/pci.json
index 418e
365-3-js...@redhat.com>
Acked-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
docs/sphinx/qapidoc.py | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/docs/sphinx/qapidoc.py b/docs/sphinx/qapidoc.py
index 5374dee8fa..adc14ade45 100644
--- a/docs/sphinx/qapid
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-17-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/virtio.json | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/qapi/virtio.json b/qapi/virti
Signed-off-by: John Snow
Message-ID: <20250618165353.1980365-6-js...@redhat.com>
Reviewed-by: Markus Armbruster
[Amend commit message to explain why]
Signed-off-by: Markus Armbruster
---
scripts/qapi/parser.py | 4
tests/qapi-schema/doc-bad-section.err | 1 -
t;
Acked-by: Markus Armbruster
Fixes: e9fbf1a0c6c2 (docs/qapidoc: add visit_errors() method)
[Amend commit message to point to reproducer, and add Fixes:]
Signed-off-by: Markus Armbruster
---
docs/sphinx/qapidoc.py | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/
oss-references to sockets.json
qapi: add cross-references to ui.json
qapi: add cross-references to virtio.json
qapi: add cross-references to yank.json
qapi: add cross-references to misc modules
Markus Armbruster (2):
qapi: Clean up "This command will do ..." c
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-8-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/machine-common.json | 20 +-
qapi/machine.json| 80
2 files c
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-16-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/ui.json | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git
From: Steve Sistare
Add a unit test for qom-list-get.
Signed-off-by: Steve Sistare
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Message-ID: <1752248703-217318-4-git-send-email-steven.sist...@oracle.com>
Signed-off-by: Markus Armbruster
---
tests/qtest/qom-test.c
From: John Snow
Signed-off-by: John Snow
Acked-by: Lukas Straub
Message-ID: <20250711054005.60969-18-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/yank.json | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git
:migration.MIGRATION`
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-9-js...@redhat.com>
Reviewed-by: Markus Armbruster
[Commit message amended to explain need for :qapi:event:]
Signed-off-by: Markus Armbruster
---
qapi/migration.json | 68 ++-
2-js...@redhat.com>
Acked-by: Markus Armbruster
[Long line wrapped]
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-domain.rst | 31 +++
docs/sphinx/qapi_domain.py | 8
2 files changed, 39 insertions(+)
diff --git a/docs/devel/qapi-domain.rst b/docs/
From: John Snow
These modules don't have specific maintainers, so they're lumped in
together here as miscellaneous.
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-19-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/cont
From: John Snow
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Message-ID: <20250711054005.60969-15-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/sockets.json | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-13-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/replay.json | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/qapi/replay.json
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-12-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/qdev.json | 4 ++--
qapi/qom.json | 13 +++--
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git
Queued for 10.1. Thanks!
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-3-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/authz.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/authz.json b/qapi/authz.json
Use imperative mood "Do ..." instead.
Signed-off-by: Markus Armbruster
Message-ID: <20250708072828.105185-2-arm...@redhat.com>
Reviewed-by: Daniel P. Berrangé
---
qapi/control.json | 9 +
qapi/misc-i386.json | 11 +--
qapi/qom.json | 10 --
3 f
From: John Snow
Signed-off-by: John Snow
Message-ID: <20250711054005.60969-4-js...@redhat.com>
Reviewed-by: Markus Armbruster
[Two unwanted cross-references dropped]
Signed-off-by: Markus Armbruster
---
qapi/block-core.json | 184 -
qapi
js...@redhat.com>
Acked-by: Markus Armbruster
[Commit message amended to explain why]
Signed-off-by: Markus Armbruster
---
qapi/block-core.json | 6 +++---
qapi/block-export.json | 2 +-
qapi/block.json| 2 +-
qapi/control.json | 5 ++---
qapi/dump.json | 5 ++---
Queued for 10.1. Thanks!
John Snow writes:
> Remove docs/sphinx/qapidoc_legacy.py, and remove special parsing of
> freeform QAPI documentation block sections in favor of using standard
> rST syntax that is included in the final document with no special
> parsing or post-processing.
PATCH 1-3
Acked-by: Marku
Markus Armbruster writes:
> John Snow writes:
>
>> On Fri, Jun 27, 2025, 5:52 AM Markus Armbruster wrote:
>>
>>> John Snow writes:
>>>
>>> > This change removes special parsing for freeform sections and allows
>>> > them to s
Markus Armbruster writes:
> John Snow writes:
>
>> Signed-off-by: John Snow
>
> Let's mention the reproducer: "# Errors: some" in doc-good.json with
> :transmogrify:.
I'm adding
Without this, the line the new QAPI doc generator chokes on
Markus Armbruster writes:
> John Snow writes:
>
>> Well, I tried. Maybe not very hard. Sorry!
>
> Recommend to explain *why* we want to avoid the type name.
>
> "Returns: " is rendered like "Return: –
> ". Mentioning the type in the descrip
Queued for 10.1. Thanks for the review!
Steve Sistare writes:
> Using qom-list and qom-get to get all the nodes and property values in a
> QOM tree can take multiple seconds because it requires 1000's of individual
> QOM requests. Some managers fetch the entire tree or a large subset
> of it when starting a new VM, and this cost is a
a/docs/sphinx/qapi_domain.py b/docs/sphinx/qapi_domain.py
> index ebc46a72c61..f561dc465f8 100644
> --- a/docs/sphinx/qapi_domain.py
> +++ b/docs/sphinx/qapi_domain.py
> @@ -532,6 +532,14 @@ class QAPICommand(QAPIObject):
> names=("return",),
> can_collapse=True,
>
error_setg(errp, "server sent invalid message %" PRId64, msg);
> - close(fd);
> +if (fd >= 0) {
> +close(fd);
> +}
Coverity is overly picky. close(-1) is *fine*. Just like free(NULL).
> return;
> }
Regardless
Reviewed-by: Markus Armbruster
Steven Sistare writes:
> On 7/11/2025 10:47 AM, Markus Armbruster wrote:
>> Steve Sistare writes:
>>
>>> Use qom-list-get to speed up the qom-tree command.
>>>
>>> Signed-off-by: Steve Sistare
>>
>> Quick test... Differences in outpu
This feels ready. Have a look at my (few) comments, and tell me what
you think. Happy to apply finishing touches in my tree, without another
respin.
Thanks your your patience!
d version barfs a stack backtrace (appended), and is ~18x slower:
real0m8.176s
user0m0.395s
sys 0m0.126s
Did you see the stack backtrace, too?
Regardless
Acked-by: Markus Armbruster
$ diff old new
59c59
< rtc-time: {'tm_year': 125, 'tm_sec':
*path, bool recurse)
> {
> char *child_path;
> @@ -85,8 +193,10 @@ static void test_machine(gconstpointer data)
> const char *machine = data;
> QDict *response;
> QTestState *qts;
> +g_autoptr(QList) paths = qlist_new();
>
> -qts = qtest_initf("-machine %s", machine);
> +qts = qtest_initf("-machine %s -object memory-backend-ram,id=%s,size=%d",
> + machine, RAM_NAME, RAM_SIZE);
>
> if (g_test_slow()) {
> /* Make sure we can get the machine class properties: */
> @@ -101,6 +211,10 @@ static void test_machine(gconstpointer data)
>
> test_properties(qts, "/machine", true);
>
> +qlist_append_str(paths, "/machine");
> +test_list_get(qts, paths);
> +test_list_get_value(qts);
> +
> response = qtest_qmp(qts, "{ 'execute': 'quit' }");
> g_assert(qdict_haskey(response, "return"));
> qobject_unref(response);
Reviewed-by: Markus Armbruster
ertiesValuesList *qmp_qom_list_get(strList *paths, Error **errp)
> +{
> +ObjectPropertiesValuesList *head = NULL, **tail = &head;
> +strList *path;
> +
> +for (path = paths; path; path = path->next) {
> +ObjectPropertiesValues *item = g_new0(ObjectPropertiesValues, 1);
> +
> +QAPI_LIST_APPEND(tail, item);
> +
> +item->properties = qom_get_property_value_list(path->value, errp);
> +if (!item->properties) {
> +qapi_free_ObjectPropertiesValuesList(head);
> +return NULL;
> +}
> +}
> +
> +return head;
> +}
> +
> void qmp_qom_set(const char *path, const char *property, QObject *value,
> Error **errp)
> {
Reviewed-by: Markus Armbruster
John Snow writes:
> Well, I tried. Maybe not very hard. Sorry!
Recommend to explain *why* we want to avoid the type name.
"Returns: " is rendered like "Return: –
". Mentioning the type in the description again is
commonly redundant. Rephrase such descriptions not to.
> Signed-off-by:
ties (Since: 2
This is only supported on AMD X86 platforms with KVM enabled.
Return:
- "SevCapability" -- SevCapability objects.
+ "SevCapability"
Clause 2. Else if we have errors, return goes right before them. Good.
Errors:
* If SEV is not available on the platform, GenericError
@@ -19370,7 +19369,7 @@ Command query-sev-attestation-report (Si
base64 (it will be included in report)
Return:
- "SevAttestationReport" -- SevAttestationReport objects.
+ "SevAttestationReport"
Clause 1. If we have arguments, return goes right after them. Good.
Errors:
* This will return an error if the attestation report is
@@ -19414,7 +19413,7 @@ Command query-sgx (Since: 6.2)
Return information about configured SGX capabilities of guest
Return:
- "SgxInfo" -- "SgxInfo"
+ "SgxInfo"
Clause 4. Else return goes right after the intro. Good.
Example::
@@ -19429,7 +19428,7 @@ Command query-sgx-capabilities (Since: 6
Return information about SGX capabilities of host
Return:
- "SgxInfo" -- "SgxInfo"
+ "SgxInfo"
Clause 4. Else return goes right after the intro. Good.
Example::
@@ -19946,7 +19945,7 @@ Command query-audiodevs (Since: 8.0)
Return information about audiodev configuration
Return:
- "[""Audiodev""]" -- array of "Audiodev"
+ "[""Audiodev""]"
Clause 4. Else return goes right after the intro. Good.
ACPI
@@ -21238,12 +21237,12 @@ Command x-query-virtio-queue-element (Si
* **index** ("int", *optional*) -- Index of the element in the
queue (default: head of the queue)
+ Return:
+ "VirtioQueueElement"
+
Clause 1. If we have arguments, return goes right after them. The move
is good.
Features:
* **unstable** -- This command is meant for debugging.
- Return:
- "VirtioQueueElement" -- VirtioQueueElement information
-
Example: Introspect on virtio-net's VirtQueue 0 at index 5:
-> { "execute": "x-query-virtio-queue-element",
@@ -21494,7 +21493,7 @@ Command query-cryptodev (Since: 8.0)
Return information about current crypto devices.
Return:
- "[""QCryptodevInfo""]" -- a list of "QCryptodevInfo"
+ "[""QCryptodevInfo""]"
Clause 4. Else return goes right after the intro. Good.
CXL devices
Placement is all good.
Two more Returns: sections this patch should remove:
# @query-cpu-definitions:
#
# Return a list of supported virtual CPU definitions
#
# Returns: a list of CpuDefinitionInfo
#
# Since: 1.2
##
{ 'command': 'query-cpu-definitions', 'returns': ['CpuDefinitionInfo'] }
and
##
# @query-gic-capabilities:
#
# It will return a list of `GICCapability` objects that describe its
# capability bits.
#
# On non-ARM targets this command will report an error as the GIC
# technology is not applicable.
#
# Returns: a list of GICCapability objects.
#
# Since: 2.6
#
# .. qmp-example::
#
# -> { "execute": "query-gic-capabilities" }
# <- { "return": [{ "version": 2, "emulated": true, "kernel": false },
# { "version": 3, "emulated": false, "kernel": true } ]
}
##
{ 'command': 'query-gic-capabilities', 'returns': ['GICCapability'] }
Tracked down with
$ git-grep '# Returns:.*`'
with your "[PATCH v2 00/18] QAPI: add cross-references to qapi docs"
applied. Shows lines containing QAPI names, which your series helpfully
puts into `backquotes` for easy grepping.
With these two removed, and the commit message amended to note the
moves:
Reviewed-by: Markus Armbruster
Runtime-collected statistics and their names fall outside QEMU's
Placement is all good.
Clauses 1, 3, 4 covered. The next patch will cover clause 2.
In all instances of clause 4 but one, intro is terminated by a Since:
section.
The exception is query-memory-size-summary, which has its Since: at the
end. It therefore needs the "TODO:" hack line you add to separate intro
from example.
All but one of the intro-terminating Since: are followed by an example.
We more commonly put Since: at the very end (roughly 3 out of four
times). But if we moved these to the end, we'd need a "TODO:" hack line
to separate intro from example.
The need for terminating the intro is not obvious when writing doc
comments. Mistakes are bound to happen.
I understand the inliner similarly relies on intro-termination for
placement.
We've toyed with the idea of automating since information. If we pull
that off, the Since: go away.
I think relying on existing Since: for separation is fine for now, but
we'll likely need a more robust solution eventually.
With the commit message amended and preferably with a less clever
version of _insert_near_kind():
Reviewed-by: Markus Armbruster
Markus Armbruster writes:
> John Snow writes:
>
>> Based-on: 20250711051045.51110-1-js...@redhat.com
>> [PATCH v6 0/4] qapi: add auto-generated return docs
>>
>> v2:
>> - Applied a few new transformations I had missed.
>> - Manually excluded t
John Snow writes:
> Signed-off-by: John Snow
> ---
> qapi/crypto.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/crypto.json b/qapi/crypto.json
> index 9ec6301e188..57620d95da6 100644
> --- a/qapi/crypto.json
> +++ b/qapi/crypto.json
> @@ -589,9 +589,9 @@
an drop them in my tree. I also suggested a commit
message amendment. Can do that in my tree, too. With that, series
Reviewed-by: Markus Armbruster
> Hi, this patch series is a *mostly* mechanical application of QAPI
> cross-references to the QAPI/QMP documentation. I exported all
>
John Snow writes:
> Signed-off-by: John Snow
> ---
> qapi/block-core.json | 188 -
> qapi/block-export.json | 36
> qapi/block.json| 14 +--
> qapi/transaction.json | 12 +--
> 4 files changed, 125 insertions(+), 125 deletions(-)
>
John Snow writes:
> Signed-off-by: John Snow
> ---
> qapi/migration.json | 68 ++---
> 1 file changed, 34 insertions(+), 34 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 59a213aeb6c..eda27c18102 100644
> --- a/qapi/migrat
John Snow writes:
> Signed-off-by: John Snow
> ---
> qapi/job.json | 71 ++-
> 1 file changed, 36 insertions(+), 35 deletions(-)
>
> diff --git a/qapi/job.json b/qapi/job.json
> index c1ddae9c0fe..a6026f6a810 100644
> --- a/qapi/job.json
> +++ b/q
Steven Sistare writes:
> On 7/8/2025 6:02 PM, Philippe Mathieu-Daudé wrote:
>> Hi Steve,
>> On 8/7/25 19:24, Steve Sistare wrote:
>>> Add a unit test for qom-list-getv.
>>>
>>> Signed-off-by: Steve Sistare
>>> ---
>>> tests/qtest/qom-test.c | 64
>>> +++
Jonah Palmer writes:
[...]
>> I think I finally know enough to give you constructive feedback.
>>
>> Your commit messages should answer the questions I had. Specifically:
>>
>> * Why are we doing this? To shorten guest-visible downtime.
>>
>> * How are we doing this? We additionally pin me
John Snow writes:
> On Tue, Jul 8, 2025, 7:23 PM Paolo Bonzini wrote:
>
>> On 7/8/25 22:36, John Snow wrote:
>> > centos_stream_9 3.9.23 21.3.1 53.0.0 3.4.3 BaseOS, CRB
>>
>> Ok, so the lowest version of Sphinx (3.4.3) is currently used for CentOS
>> Stream 9. It's supported for r
Marc-André Lureau writes:
> Hi
>
> On Tue, Jul 8, 2025 at 9:07 PM Andrew Keesler wrote:
>>
>> Thanks to 72d277a7, 1ed2cb32, and others, EDID (Extended Display
>> Identification Data) is propagated by QEMU such that a virtual display
>> presents legitimate metadata (e.g., name, serial number, pre
Steve Sistare writes:
> Define the qom-list-getv command, which fetches all the properties and
> values for a list of paths. This is faster than qom-tree-get when
> fetching a subset of the QOM tree. See qom.json for details.
>
> Signed-off-by: Steve Sistare
You cover letter explains *why* we
Philippe Mathieu-Daudé writes:
> Hi Steve,
>
> On 8/7/25 19:24, Steve Sistare wrote:
>> Add a unit test for qom-list-getv.
>> Signed-off-by: Steve Sistare
>> ---
>> tests/qtest/qom-test.c | 64
>> ++
>> 1 file changed, 64 insertions(+)
>> diff
Steven Sistare writes:
> On 7/4/2025 8:22 AM, Markus Armbruster wrote:
>> Steve Sistare writes:
>>
>>> Define the qom-tree-get QAPI command, which fetches an entire tree of
>>> properties and values with a single QAPI call. This is much faster
>>>
1 - 100 of 12185 matches
Mail list logo
