Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-24 Thread Mark Syms
Copying in Tim who did the final phase of the changes. On Mon, 24 Apr 2023 at 11:32, Paul Durrant wrote: > > On 20/04/2023 12:02, mark.s...@citrix.com wrote: > > From: Mark Syms > > > > Ensure the PV ring is drained on disconnect. Also ensure all pending > > AIO is

[PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-20 Thread mark . syms--- via
From: Mark Syms Ensure the PV ring is drained on disconnect. Also ensure all pending AIO is complete, otherwise AIO tries to complete into a mapping of the ring which has been torn down. Signed-off-by: Mark Syms --- CC: Stefano Stabellini CC: Anthony Perard CC: Paul Durrant CC: xen-de

[PATCH 0/1] Updated: Ensure PV ring is drained on disconenct

2023-04-20 Thread Mark Syms via
Updated patch to address intermittent SIGSEGV on domain disconnect/shutdown. Mark Syms (1): Ensure the PV ring is drained on disconnect hw/block/dataplane/xen-block.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) -- 2.40.0 >F

Ensure the PV ring is drained on disconnect

2023-03-29 Thread Mark Syms via
If the Xen PV guest VM sends a close whilst there is outstanding I/O being processed that IO needs to be completed and drained before unrealizing the rings or SEGVs will occurr when the I/O does complete and tries to update an already unmapped grant entry.

[PATCH] Ensure the PV ring is drained on disconnect

2023-03-29 Thread Mark Syms via
Also ensure all pending AIO is complete. Signed-off-by: Mark Syms --- hw/block/dataplane/xen-block.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/block/dataplane/xen-block.c b/hw/block/dataplane/xen-block.c index 734da42ea7..067f8e2f45 100644 --- a/hw/block/dataplane

[Qemu-devel] Valgrind confused by queue macros

2019-09-10 Thread Mark Syms
Hi, While trying to track down an issue in using qemu 4.1 with some development features we needed/wanted to run valgrind on it to find a memory error. Unfortunately the form of the queue macros seems to really confuse valgrind and cause it to report many " Use of uninitialised value " errors.