Re: [Qemu-devel] [PATCH 1/5] slirp: closesocket must be called to close sockets on windows

2015-10-27 Thread Mark Pizzolato
On Tuesday, October 27, 2015 at 7:28 AM, Thomas Huth wrote: > On 22/10/15 01:15, Mark Pizzolato wrote: > > Signed-off-by: Mark Pizzolato > > --- > > slirp/slirp.c | 2 +- > > slirp/socket.c | 3 ++- > > 2 files changed, 3 insertions(+), 2 deletions(-) > >

[Qemu-devel] [PATCH 5/5] slirp: Fix signed/unsigned comparison and variable truncation warnings

2015-10-21 Thread Mark Pizzolato
Some warnings affect potentially wrapping sequence numbers. Careful analysis of intent and consequences is necessary. - Variable type changes where appropriate - Explicit casts where appropriate Signed-off-by: Mark Pizzolato --- slirp/bootp.c | 2 +- slirp/dnssearch.c | 6

[Qemu-devel] [PATCH 3/5] slirp: change tftp to use stdio APIs vs open/read/close

2015-10-21 Thread Mark Pizzolato
Direct use of open/read/write/close on files produces build warnings on Windows when compiling with Visual Studio Signed-off-by: Mark Pizzolato --- slirp/tftp.c | 18 +- slirp/tftp.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/slirp/tftp.c b/slirp

[Qemu-devel] [PATCH 1/5] slirp: closesocket must be called to close sockets on windows

2015-10-21 Thread Mark Pizzolato
Signed-off-by: Mark Pizzolato --- slirp/slirp.c | 2 +- slirp/socket.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 35f819a..d18faa8 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -846,7 +846,7 @@ int slirp_remove_hostfwd(Slirp

[Qemu-devel] [PATCH 4/5] slirp: Generalized debug macros to also support simh debugging

2015-10-21 Thread Mark Pizzolato
() - simh debugging support is enabled when compiling with -DUSE_SIMH_SLIRP_DEBUG Signed-off-by: Mark Pizzolato --- slirp/arp_table.c | 8 slirp/bootp.c | 7 --- slirp/cksum.c | 4 ++-- slirp/debug.h | 57 +++--- slirp

[Qemu-devel] [PATCH 2/5] slirp: Changes needed to build with a pre C99 C compiler

2015-10-21 Thread Mark Pizzolato
packet declaration syntax Signed-off-by: Mark Pizzolato --- slirp/ip.h | 39 +++ slirp/misc.c | 25 ++--- slirp/slirp.c| 30 ++ slirp/slirp.h| 8 ++-- slirp/slirp_config.h | 2

[Qemu-devel] [PATCH 0/5] slirp updates

2015-10-21 Thread Mark Pizzolato
ropped into the simh slirp code. Mark Pizzolato (5): slirp: closesocket must be called to close sockets on windows slirp: Changes needed to build with a pre C99 C compiler slirp: change tftp to use stdio APIs vs open/read/close slirp: Generalized debug macros to also support simh debugging

[Qemu-devel] [Bug 1504513] Re: Socket leak on each call to qemu_socket()

2015-10-12 Thread Mark Pizzolato
On Sunday, October 11, 2015 at 11:58 PM. Markus Armbruster wrote: > Mark Pizzolato writes: > > > Public bug reported: > > > > On any host platform where SOCK_CLOEXEC is defined (Linux at least), a > > socket is leaked on each call to qemu_socket() AND the socket re

[Qemu-devel] [Bug 1504513] Re: Socket leak on each call to qemu_socket()

2015-10-10 Thread Mark Pizzolato
I'm not sure that my original report was distributed to the folks who need to see this. My primary email address has a DKIM policy (DMARC) which says that all messages from my address are signed. I received various DMARC reports which said that the bug report sent as "From: m...@mydomain.com" wer

[Qemu-devel] [Bug 1504513] [NEW] Socket leak on each call to qemu_socket()

2015-10-09 Thread Mark Pizzolato
Public bug reported: On any host platform where SOCK_CLOEXEC is defined (Linux at least), a socket is leaked on each call to qemu_socket() AND the socket returned hasn't been created with the desired SOCK_CLOEXEC attribute. The qemu_socket routine is: Line 272 of util/osdep.c: /* * Opens a sock