Igor Mammedov writes:
> overall looks good.
> Please add a test case for it, see
> tests/qtest/bios-tables-test.c for description how to do it
> an/or at
> "[PATCH v3 08/12] tests/acpi: allow updates for expected data files"
> and follow up patches on the list.
When you say add a test case, do
one missing.
Note that the the OEM Table ID field will not be extended with the
name of the table, but will use either the default name or the user
provided one.
This does not affect the -acpitable option (for user-defined ACPI
tables), which has precedence over -machine option.
Signed-off-by:
Paolo Bonzini writes:
> On 22/12/20 16:39, Marian Posteuca wrote:
>>>> Qemu's ACPI table generation sets the fields OEM ID and OEM table ID
>>>> to "BOCHS " and "BXPC" where "" is replaced by the ACPI
>>>> table na
Thanks for the thorough review.
Igor Mammedov writes:
> On Tue, 22 Dec 2020 13:33:53 +0200
> Marian Posteuca wrote:
>
> I see defaults are now initialized in pcmc->oem_[table_]id fields,
> and sometimes used from there, so question is why
> do we need use_sig_oem
Michael Tokarev writes:
> 22.12.2020 14:33, Marian Posteuca wrote:
>> Qemu's ACPI table generation sets the fields OEM ID and OEM table ID
>> to "BOCHS " and "BXPC" where "" is replaced by the ACPI
>> table name.
>>
>>
ACPI
tables), which has precedence over -machine option.
Signed-off-by: Marian Posteuca
---
hw/acpi/hmat.h | 3 +-
hw/i386/acpi-common.h | 3 +-
include/hw/acpi/aml-build.h | 12 +++--
include/hw/acpi/pci.h | 3 +-
include/hw/acpi/vmgenid.h | 2 +-
include/hw/i386/pc.h
ed ACPI
tables), which has precedence over -acpidefault option.
Signed-off-by: Marian Posteuca
---
hw/acpi/aml-build.c | 51 +++---
hw/arm/virt-acpi-build.c| 2 +-
hw/i386/acpi-build.c| 2 +-
hw/i386/acpi-microvm.c | 2 +-
include/hw/acpi/
