ENOBUF error with a zerocopy sendmsg,
we flush the error queue and retry once more.
Signed-off-by: Manish Mishra
---
include/io/channel-socket.h | 5 +++
io/channel-socket.c | 74 ++---
2 files changed, 65 insertions(+), 14 deletions(-)
V2:
1. Removed
dirty_sync_missed_zero_copy migration stat again.
Signed-off-by: Manish Mishra
---
include/io/channel-socket.h | 5 +++
io/channel-socket.c | 74 ++---
2 files changed, 65 insertions(+), 14 deletions(-)
diff --git a/include/io/channel-socket.h b/include/io/channel-socket.h
dirty_sync_missed_zero_copy migration stat.
2. Made the call to qio_channel_socket_flush_internal() from
qio_channel_socket_writev() non-blocking.
Signed-off-by: Manish Mishra
---
include/io/channel.h | 3 +-
io/channel-socket.c| 57 --
migration/migration
requests fail to
allocate any new SKB, leading to an ENOBUF error.
To workaround this, if we encounter an ENOBUF error with a zerocopy sendmsg,
we flush the error queue and retry once more.
Signed-off-by: Manish Mishra
---
include/io/channel-socket.h | 1 +
io/channel-socket.c | 52
Thanks Zhao, Igor and Xiaoyao, I have sent v1 for this
https://patchwork.ozlabs.org/project/qemu-devel/patch/20240724075226.212882-1-manish.mis...@nutanix.com/.
On 23/07/24 8:33 pm, Igor Mammedov wrote:
!---|
CAUTION: External
Thanks for response Zhao.
On 19/07/24 3:20 pm, Manish Mishra wrote:
!---|
CAUTION: External Email
|---!
Hi Manish,
(+Paolo and Daniel)
On Thu, Jul 18, 2024 at 11:44
all zeros. This seems to work
fine. Our understanding is that current QEMU behaviour is not incorrect but
still does the above mentioned workaround makes sense? And if we look it is the
same as bare-metal so it should not be unreasonable. If so will be happy to
send a patch for same.
Thanks
Manish Mishra
Thanks Wang Lie. Yes sure will do same until we have new version.
Thanks
Manish Mishra
From: Wang, Lei
Date: Tuesday, 23 April 2024 at 12:50 PM
To: Manish Mishra , qemu-devel@nongnu.org
Cc: christopher.r.blev...@intel.com ,
robert...@linux.intel.com
Subject: Re: Missing features in QEMU
/7eb061b06e97af9a8da7f31b839d78997ae737fc.
There may be other features too missing but we were particularly interested in
these three. So just wanted to understand if there is any reason for this. Any
help on this will be really appreciated. 😊
Thanks
Manish Mishra