[PATCH 25/48] hw/arm/xlnx-versal: add support for multiple GICs

2025-07-16 Thread Luc Michel
GIC is stored in the intc array. When connecting an IRQ, a TYPE_SPLIT_IRQ device is created with its num-lines property set to the number of GICs in the SoC. The split device is used to fan out the IRQ to all the GICs. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 1 + hw/arm/xlnx

[PATCH 11/48] hw/arm/xlnx-versal: efuse: refactor creation

2025-07-16 Thread Luc Michel
Refactore the eFuse devices creation using the VersalMap structure. Note that the corresponding FDT nodes are removed. They do not correspond to any real node in standard Versal DTBs. No matching drivers exist for them. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 5 +-- hw

[PATCH 24/48] hw/intc/arm_gicv3: Introduce a 'first-cpu-index' property

2025-07-16 Thread Luc Michel
From: Francisco Iglesias Introduce a 'first-cpu-index' property for specifying the first QEMU CPU connected to the GICv3. This makes it possible to have multiple instances of the GICv3 connected to different CPU clusters. Signed-off-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias ---

[PATCH 05/48] hw/arm/xlnx-versal: canfd: refactor creation

2025-07-16 Thread Luc Michel
controller advertised by the SoC. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 7 +-- hw/arm/xlnx-versal-virt.c| 73 ++ hw/arm/xlnx-versal.c | 86 +--- 3 files changed, 87 insertions(+), 79 deletions(-) diff --git a

[PATCH 31/48] hw/misc/xlnx-versal-crl: remove unnecessary include directives

2025-07-16 Thread Luc Michel
Drop unused include directives from xlnx-versal-crl.c Signed-off-by: Luc Michel --- hw/misc/xlnx-versal-crl.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/misc/xlnx-versal-crl.c b/hw/misc/xlnx-versal-crl.c index 08ff2fcc24f..f288545967a 100644 --- a/hw/misc/xlnx

[PATCH 14/48] hw/arm/xlnx-versal: PMC IOU SCLR: refactor creation

2025-07-16 Thread Luc Michel
Refactor the PMC IOU SLCR device creation using the VersalMap structure. This is the first user of a shared IRQ using an OR gate. The OSPI controller is reconnected to the SLCR. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 5 hw/arm/xlnx-versal.c | 48

[PATCH 28/48] hw/arm/xlnx-versal: ocm: refactor creation

2025-07-16 Thread Luc Michel
Refactor the OCM creation using the VersalMap structure. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 4 hw/arm/xlnx-versal.c | 20 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm

[PATCH 23/48] hw/arm/xlnx-versal: instantiate the GIC ITS in the APU

2025-07-16 Thread Luc Michel
Add the instance of the GIC ITS in the APU. Signed-off-by: Luc Michel --- hw/arm/xlnx-versal.c | 50 1 file changed, 50 insertions(+) diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c index 35c32de0159..ba8c69bd435 100644 --- a/hw/arm/xlnx

[PATCH 12/48] hw/arm/xlnx-versal: ospi: refactor creation

2025-07-16 Thread Luc Michel
Refactor the OSPI controller creation using the VersalMap structure. Note that the connection to the PMC IOU SLCR is removed for now and will be re-added by next commits. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 12 +-- hw/arm/xlnx-versal-virt.c| 41 -- hw/arm

[PATCH 33/48] hw/misc/xlnx-versal-crl: refactor device reset logic

2025-07-16 Thread Luc Michel
Versal SoC. It also fixes a bug where the gem device pointer was mapped to the usb link property. Signed-off-by: Luc Michel --- include/hw/misc/xlnx-versal-crl.h | 8 +- hw/misc/xlnx-versal-crl.c | 163 -- 2 files changed, 92 insertions(+), 79 deletions(-) diff

[PATCH 17/48] hw/arm/xlnx-versal: rtc: refactor creation

2025-07-16 Thread Luc Michel
Refactor the RTC device creation using the VersalMap structure. The sysbus IRQ output 0 (APB IRQ) is connected instead of the output 1 (addr error IRQ). This does not change the current behaviour since the RTC model does not implement those IRQs anyway. Signed-off-by: Luc Michel --- include/hw

[PATCH 35/48] hw/arm/xlnx-versal: use hw/arm/bsa.h for timer IRQ indices

2025-07-16 Thread Luc Michel
Use the bsa.h header for ARM timer and maintainance IRQ indices instead of redefining our owns. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 6 -- hw/arm/xlnx-versal.c | 28 +--- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git

[PATCH 47/48] hw/arm/xlnx-versal-virt: add the xlnx-versal2-virt machine

2025-07-16 Thread Luc Michel
provide a DTB. Signed-off-by: Luc Michel --- docs/system/arm/xlnx-versal-virt.rst | 49 hw/arm/xlnx-versal-virt.c| 37 +++-- 2 files changed, 76 insertions(+), 10 deletions(-) diff --git a/docs/system/arm/xlnx-versal-virt.rst b/docs

[PATCH 21/48] hw/arm/xlnx-versal: refactor CPU cluster creation

2025-07-16 Thread Luc Michel
Refactor the CPU cluster creation using the VersalMap structure. There is no functional change. The clusters properties are now described in the VersalMap structure. For now only the APU is converted. The RPU will be taken care of by next commits. Signed-off-by: Luc Michel --- include/hw/arm

[PATCH 48/48] tests/functional/test_aarch64_xlnx_versal: test the versal2 machine

2025-07-16 Thread Luc Michel
Add a test for the amd-versal2-virt machine using the same command line, kernel, initrd than the ones used for amd-versal-virt. Signed-off-by: Luc Michel --- tests/functional/test_aarch64_xlnx_versal.py | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests

[PATCH 26/48] hw/arm/xlnx-versal: add support for GICv2

2025-07-16 Thread Luc Michel
Add support for GICv2 instantiation in the Versal SoC. This is in preparation for the RPU refactoring. Signed-off-by: Luc Michel --- hw/arm/xlnx-versal.c | 82 +--- 1 file changed, 62 insertions(+), 20 deletions(-) diff --git a/hw/arm/xlnx-versal.c b/hw

[PATCH 27/48] hw/arm/xlnx-versal: rpu: refactor creation

2025-07-16 Thread Luc Michel
Refactor the RPU cluster creation using the VersalMap structure. This effectively instantiate the RPU GICv2 which was not instantiated before. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 11 --- hw/arm/xlnx-versal-virt.c| 1 + hw/arm/xlnx-versal.c | 60

[PATCH 44/48] hw/arm/xlnx-versal-virt: tidy up

2025-07-16 Thread Luc Michel
Remove now unused clock nodes. They have been replaced by the ones created in the SoC. Remove the unused cfg.secure VersalVirt field. Remove unecessary include directives. Signed-off-by: Luc Michel --- hw/arm/xlnx-versal-virt.c | 24 1 file changed, 24 deletions

[PATCH 39/48] hw/arm/xlnx-versal: add the target field in IRQ descriptor

2025-07-16 Thread Luc Michel
be left unconnected. This is in preparation for versal2. Signed-off-by: Luc Michel --- hw/arm/xlnx-versal.c | 41 +++-- 1 file changed, 39 insertions(+), 2 deletions(-) diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c index 9d900fe3127..551671af425

[PATCH 08/48] hw/arm/xlnx-versal: adma: refactor creation

2025-07-16 Thread Luc Michel
Refactor the ADMA creation using the VersalMap structure. Note that the connection to the CRL is removed for now and will be re-added by next commits. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 2 - hw/arm/xlnx-versal-virt.c| 28 -- hw/arm/xlnx-versal.c

[PATCH 22/48] hw/arm/xlnx-versal: add the mp_affinity property to the CPU mapping

2025-07-16 Thread Luc Michel
Add a way to configure the MP affinity value of the CPUs given their core and cluster IDs. For the Versal APU CPUs, the MP affinity value is directly given by the core ID. Signed-off-by: Luc Michel --- hw/arm/xlnx-versal.c | 21 + 1 file changed, 21 insertions(+) diff --git

[PATCH 40/48] target/arm/tcg/cpu64: add the cortex-a78ae CPU

2025-07-16 Thread Luc Michel
Add support for the ARM Cortex-A78AE CPU. Signed-off-by: Luc Michel --- target/arm/tcg/cpu64.c | 75 ++ 1 file changed, 75 insertions(+) diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c index 35cddbafa4c..337f8cf0c8d 100644 --- a/target/arm

[PATCH 42/48] hw/arm/xlnx-versal-virt: rename the machine to amd-versal-virt

2025-07-16 Thread Luc Michel
To align with current branding and ensure coherency with the upcoming versal2 machine, rename the xlnx-versal-virt machine to amd-versal-virt. Keep an alias of the old name to the new one for command-line backward compatibility. Signed-off-by: Luc Michel --- docs/system/arm/xlnx-versal-virt.rst

[PATCH 43/48] hw/arm/xlnx-versal-virt: split into base/concrete classes

2025-07-16 Thread Luc Michel
Split the xlnx-versal-virt machine type into a base abstract type and a concrete type. There is no functional change. This is in preparation for versal2 machine. Signed-off-by: Luc Michel --- hw/arm/xlnx-versal-virt.c | 74 +++ 1 file changed, 52 insertions

[PATCH 45/48] docs/system/arm/xlnx-versal-virt: update supported devices

2025-07-16 Thread Luc Michel
Update the list of supported devices in the Versal SoCs. Signed-off-by: Luc Michel --- docs/system/arm/xlnx-versal-virt.rst | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/system/arm/xlnx-versal-virt.rst b/docs/system/arm/xlnx-versal-virt.rst index 2c63fbf519f

[PATCH 07/48] hw/arm/xlnx-versal: gem: refactor creation

2025-07-16 Thread Luc Michel
Refactor the GEM ethernet controllers creation using the VersalMap structure. Note that the connection to the CRL is removed for now and will be re-added by next commits. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 3 - hw/arm/xlnx-versal-virt.c| 54 - hw

[PATCH 34/48] hw/arm/xlnx-versal: reconnect the CRL to the other devices

2025-07-16 Thread Luc Michel
on the CRL. Signed-off-by: Luc Michel --- hw/arm/xlnx-versal.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c index 5151822ad56..796b4911a02 100644 --- a/hw/arm/xlnx-versal.c +++ b/hw/arm/xlnx

[PATCH 10/48] hw/arm/xlnx-versal: usb: refactor creation

2025-07-16 Thread Luc Michel
Refactor the USB controller creation using the VersalMap structure. Note that the connection to the CRL is removed for now and will be re-added by next commits. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 5 --- hw/arm/xlnx-versal-virt.c| 56

[PATCH 03/48] hw/arm/xlnx-versal: prepare for FDT creation

2025-07-16 Thread Luc Michel
only creates the two clock nodes. The ones from the xlnx-versal virt machine are renamed with a `old-' prefix and will be removed once they are not referenced anymore. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 12 hw/arm/xlnx-versal-virt.c| 11 +++---

[PATCH 46/48] docs/system/arm/xlnx-versal-virt: add a note about dumpdtb

2025-07-16 Thread Luc Michel
Add a note in the DTB section explaining how to dump the generated DTB using the dumpdtb machine option. Signed-off-by: Luc Michel --- docs/system/arm/xlnx-versal-virt.rst | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/system/arm/xlnx-versal-virt.rst b/docs

[PATCH 32/48] hw/misc/xlnx-versal-crl: split into base/concrete classes

2025-07-16 Thread Luc Michel
Split the TYPE_XLNX_VERSAL_CRL type into base and concrete classes. This is in preparation for the versal2 version of the CRL. Signed-off-by: Luc Michel --- include/hw/misc/xlnx-versal-crl.h | 31 ++-- hw/misc/xlnx-versal-crl.c | 48 +++ 2

[PATCH 30/48] hw/arm/xlnx-versal: add the versal_get_num_cpu accessor

2025-07-16 Thread Luc Michel
Add the versal_get_num_cpu accessor to the Versal SoC to retrieve the number of CPUs in the SoC. Use it in the xlnx-versal-virt machine. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 1 + hw/arm/xlnx-versal-virt.c| 7 --- hw/arm/xlnx-versal.c | 8 3 files

[PATCH 29/48] hw/arm/xlnx-versal: ddr: refactor creation

2025-07-16 Thread Luc Michel
Refactor the DDR aperture regions creation using the VersalMap structure. Device creation and FDT node creation are split into two functions because the later must happen during ARM virtual bootloader modify_dtb callback. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 7 +--- hw

[PATCH 20/48] hw/arm/xlnx-versal-virt: virtio: refactor creation

2025-07-16 Thread Luc Michel
Refactor the creation of virtio devices. Use the accessors provided by the Versal SoC to retrieve the reserved MMIO and IRQ space. Those are defined in the VersalMap structure. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 3 +++ hw/arm/xlnx-versal-virt.c| 31

[PATCH 37/48] hw/misc/xlnx-versal-crl: add the versal2 version

2025-07-16 Thread Luc Michel
Add the versal2 version of the CRL device. For the implemented part, it is similar to the versal version but drives reset line of more devices. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal-version.h | 1 + include/hw/misc/xlnx-versal-crl.h| 329 ++ hw/misc

[PATCH 13/48] hw/arm/xlnx-versal: VersalMap: add support for OR'ed IRQs

2025-07-16 Thread Luc Michel
devices. An OR gate is created to connect the devices to the actual IRQ pin. Signed-off-by: Luc Michel --- hw/arm/xlnx-versal.c | 62 +++- 1 file changed, 61 insertions(+), 1 deletion(-) diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c index

[PATCH 36/48] hw/arm/xlnx-versal: tidy up

2025-07-16 Thread Luc Michel
Remove now unused macros in xlnx-versal.[ch]. Those macros have been replaced by the VersalMap structure that serves as a central description for the SoC. The ones still in use in the versal_unimp function are inlined. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 204

[PATCH 18/48] hw/arm/xlnx-versal: cfu: refactor creation

2025-07-16 Thread Luc Michel
Refactor the CFU device creation using the VersalMap structure. All users of the APB IRQ OR gate have now been converted. The OR gate device can be dropped. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 14 -- hw/arm/xlnx-versal.c | 258

[PATCH 38/48] hw/arm/xlnx-versal: add a per_cluster_gic switch to VersalCpuClusterMap

2025-07-16 Thread Luc Michel
Add the per_cluster_gic switch to the VersalCpuClusterMap structure. When set, this indicates that a GIC instance should by created per-cluster instead of globaly for the whole RPU or APU. This is in preparation for versal2. Signed-off-by: Luc Michel --- hw/arm/xlnx-versal.c | 15

[PATCH 41/48] hw/arm/xlnx-versal: add versal2 SoC

2025-07-16 Thread Luc Michel
almost fully describe the implemented parts of versal2. The versal2 eFuse device differs quite a lot from the versal one and is left as future work. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 17 ++- hw/arm/xlnx-versal.c | 212 --- 2 files

[PATCH 19/48] hw/arm/xlnx-versal: crl: refactor creation

2025-07-16 Thread Luc Michel
Refactor the CRL device creation using the VersalMap structure. The connections to the RPU CPUs are temporarily removed and will be reintroduced with next refactoring commits. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 3 --- hw/arm/xlnx-versal.c | 36

[PATCH 15/48] hw/arm/xlnx-versal: bbram: refactor creation

2025-07-16 Thread Luc Michel
Refactor the BBRAM device creation using the VersalMap structure. Note that the corresponding FDT node is removed. It does not correspond to any real node in standard Versal DTBs. No matching drivers exist for it. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 3 +-- hw/arm/xlnx

[PATCH 16/48] hw/arm/xlnx-versal: trng: refactor creation

2025-07-16 Thread Luc Michel
Refactor the TRNG device creation using the VersalMap structure. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 2 -- hw/arm/xlnx-versal.c | 18 ++ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include/hw/arm/xlnx-versal.h b/include/hw

[PATCH 09/48] hw/arm/xlnx-versal: xram: refactor creation

2025-07-16 Thread Luc Michel
Refactor the XRAM devices creation using the VersalMap structure. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 6 hw/arm/xlnx-versal.c | 59 +--- 2 files changed, 35 insertions(+), 30 deletions(-) diff --git a/include/hw/arm/xlnx

[PATCH 02/48] hw/arm/xlnx-versal: split the xlnx-versal type

2025-07-16 Thread Luc Michel
Split the xlnx-versal device into two classes, a base, abstract class and the existing concrete one. Introduce a VersalVersion type that will be used across several device models when versal2 implementation is added. This is in preparation for versal2 implementation. Signed-off-by: Luc Michel

[PATCH 04/48] hw/arm/xlnx-versal: uart: refactor creation

2025-07-16 Thread Luc Michel
-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 2 - hw/arm/xlnx-versal-virt.c| 36 + hw/arm/xlnx-versal.c | 142 --- 3 files changed, 117 insertions(+), 63 deletions(-) diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx

[PATCH 01/48] hw/net/cadence_gem: fix register mask initialization

2025-07-16 Thread Luc Michel
The gem_init_register_masks function was called at init time but it relies on the num-priority-queues property. Call it at realize time instead. Fixes: 4c70e32f05f ("net: cadence_gem: Define access permission for interrupt registers") Signed-off-by: Luc Michel --- hw/net/cadence

[PATCH 06/48] hw/arm/xlnx-versal: sdhci: refactor creation

2025-07-16 Thread Luc Michel
Refactor the SDHCI controllers creation using the VersalMap structure. Signed-off-by: Luc Michel --- include/hw/arm/xlnx-versal.h | 5 +- hw/arm/xlnx-versal-virt.c| 43 ++-- hw/arm/xlnx-versal.c | 96 3 files changed, 83 insertions

[PATCH 00/48] AMD Versal Gen 2 support

2025-07-16 Thread Luc Michel
. Thanks Luc Francisco Iglesias (1): hw/intc/arm_gicv3: Introduce a 'first-cpu-index' property Luc Michel (47): hw/net/cadence_gem: fix register mask initialization hw/arm/xlnx-versal: split the xlnx-versal type hw/arm/xlnx-versal: prepare for FDT creation hw/arm/xlnx-ve

Re: [PATCH v2 1/9] hw/char/pl011: Warn when using disabled receiver

2025-02-20 Thread Luc Michel
splay a warning when this occurs. > > Reviewed-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > hw/char/pl011.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/hw/char/pl011.c b/hw/char/pl011.c > in

Re: [PATCH 9/9] hw/char/sh_serial: Return correct number of empty RX FIFO elements

2025-02-20 Thread Luc Michel
es: 63242a007a1 ("SH4: Serial controller improvement") > Signed-off-by: Philippe Mathieu-Daudé nice one :) Reviewed-by: Luc Michel > --- > hw/char/sh_serial.c | 30 ++ > 1 file changed, 14 insertions(+), 16 deletions(-) > > diff --git a/h

Re: [PATCH 8/9] hw/char/mcf_uart: Really use RX FIFO depth

2025-02-20 Thread Luc Michel
troduced in commit 20dcee94833 ("MCF5208 emulation"), > we only read 1 char at a time! "the MCF UART model" Reviewed-by: Luc Michel > > Have the IOCanReadHandler handler return how many elements are > available, and use that in the IOReadHandler handler. > >

Re: [PATCH 7/9] hw/char/mcf_uart: Use FIFO_DEPTH definition instead of magic values

2025-02-20 Thread Luc Michel
On 22:08 Wed 19 Feb , Philippe Mathieu-Daudé wrote: > Defines FIFO_DEPTH and use it, fixing coding style. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > hw/char/mcf_uart.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) &g

Re: [PATCH 6/9] hw/char/imx_serial: Really use RX FIFO depth

2025-02-20 Thread Luc Michel
On 22:08 Wed 19 Feb , Philippe Mathieu-Daudé wrote: > While we model a 32-elements RX FIFO since the PL011 model was > introduced in commit 988f2442971 ("hw/char/imx_serial: Implement > receive FIFO and ageing timer") we only read 1 char at a time! "the IMX serial m

Re: [PATCH 5/9] hw/char/bcm2835_aux: Really use RX FIFO depth

2025-02-20 Thread Luc Michel
patch and the subsequent ones you keep mentioning the PL011 model while you modify other UARTs. I guess you mean "the BCM2835 AUX model" here? In any case: Reviewed-by: Luc Michel > > Have the IOCanReadHandler handler return how many elements are > available, and use that in th

Re: [PATCH 4/9] hw/char/pl011: Really use RX FIFO depth

2025-02-20 Thread Luc Michel
1_can_receive LCR 0x70, RX FIFO used 0/16, can_receive 16 chars > pl011_can_receive LCR 0x70, RX FIFO used 0/16, can_receive 16 chars > pl011_read addr 0x018 value 0x0090 reg FR > pl011_write addr 0x000 value 0x0072 reg DR > > Inspired-by: Peter Maydell > Signed-off

Re: [PATCH 1/9] hw/char/pl011: Warn when using disabled receiver

2025-02-20 Thread Luc Michel
Hi Phil, On 22:08 Wed 19 Feb , Philippe Mathieu-Daudé wrote: > We shouldn't receive characters when the full UART or its > receiver is disabled. However we don't want to break the > possibly incomplete "my first bare metal assembly program"s, > so we choose to simply display a warning when thi

Re: [PATCH 3/9] hw/char/pl011: Improve RX flow tracing events

2025-02-20 Thread Luc Michel
On 22:08 Wed 19 Feb , Philippe Mathieu-Daudé wrote: > Log FIFO use (availability and depth). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > hw/char/pl011.c | 10 ++ > hw/char/trace-events | 7 --- > 2 files changed

Re: [PATCH 2/9] hw/char/pl011: Simplify a bit pl011_can_receive()

2025-02-20 Thread Luc Michel
On 22:08 Wed 19 Feb , Philippe Mathieu-Daudé wrote: > Introduce 'fifo_depth' and 'fifo_available' local variables > to better express the 'r' variable use. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > hw/char/p

Re: [PATCH v43 2/2] hw/sd/sdcard: Do not store vendor data on block drive (CMD56)

2024-07-03 Thread Luc Michel
On 18:10 Tue 02 Jul , Philippe Mathieu-Daudé wrote: > "General command" (GEN_CMD, CMD56) is described as: > > GEN_CMD is the same as the single block read or write > commands (CMD24 or CMD17). The difference is that [...] > the data block is not a memory payload data but has a > vendor

Re: [PATCH v4 3/3] tests/qtest: Check STM32L4x5 clock connections

2024-07-01 Thread Luc Michel
On 11:43 Sat 22 Jun , Inès Varhol wrote: > For USART, GPIO and SYSCFG devices, check that clock frequency before > and after enabling the peripheral clock in RCC is correct. > > Signed-off-by: Inès Varhol > Reviewed-by: Peter Maydell Reviewed-by: Luc Michel > --- >

Re: [PATCH v4 1/3] hw/misc: Create STM32L4x5 SYSCFG clock

2024-07-01 Thread Luc Michel
On 11:43 Sat 22 Jun , Inès Varhol wrote: > This commit creates a clock in STM32L4x5 SYSCFG and wires it up to the > corresponding clock from STM32L4x5 RCC. > > Signed-off-by: Inès Varhol > Reviewed-by: Peter Maydell > Reviewed-by: Philippe Mathieu-Daudé Revie

Re: [PATCH v42 06/98] hw/sd/sdcard: Do not store vendor data on block drive (CMD56)

2024-07-01 Thread Luc Michel
On 09:00 Fri 28 Jun , Philippe Mathieu-Daudé wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > "General command" (GEN_CMD, CMD56) is described as: > > GEN_CMD is the same as the single blo

Re: [PATCH v42 05/98] hw/sd/sdcard: Trace requested address computed by sd_req_get_address()

2024-06-28 Thread Luc Michel
On 09:00 Fri 28 Jun , Philippe Mathieu-Daudé wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel >

Re: [PATCH v3 3/4] hw/clock: Expose 'qtest-clock-period' QOM property for QTests

2024-05-27 Thread Luc Michel
uot;trace.h" > > @@ -158,6 +160,15 @@ bool clock_set_mul_div(Clock *clk, uint32_t multiplier, > uint32_t divider) > return true; > } > > +static void clock_period_prop_get(Object *obj, Visitor *v, const char *name, > +

Re: [PATCH 6/6] reset: Add RESET_TYPE_SNAPSHOT_LOAD

2024-04-16 Thread Luc Michel
ht reset type for the ShutdownCause it is passed. This > allows us to get rid of the device_reset_reason global we > were using to implement qemu_register_reset_nosnapshotload(). > > Signed-off-by: Peter Maydell Reviewed-by: Luc Michel > --- > docs/devel/reset.rst| 17 ++

Re: [PATCH 1/6] hw/misc: Don't special case RESET_TYPE_COLD in npcm7xx_clk, gcr

2024-04-16 Thread Luc Michel
't know > about should be handled like RESET_TYPE_COLD"; switch these > devices to do that. Then adding a new reset type will only > need to touch those devices where its behaviour really needs > to be different from the standard cold reset. > > Signed-off-by: Peter Mayde

Re: [PATCH 4/6] hw, target: Add ResetType argument to hold and exit phase methods

2024-04-16 Thread Luc Michel
--sp-file scripts/coccinelle/reset-type.cocci \ > --keep-comments --smpl-spacing --in-place \ > --include-headers --dir $dir; done > > and no manual edits. > > Signed-off-by: Peter Maydell Reviewed-by: Luc Michel > --- > incl

Re: [PATCH 5/6] docs/devel/reset: Update to new API for hold and exit phase methods

2024-04-16 Thread Luc Michel
On 17:08 Fri 12 Apr , Peter Maydell wrote: > Update the reset documentation's example code to match the new API > for the hold and exit phase method APIs where they take a ResetType > argument. > > Signed-off-by: Peter Maydell Reviewed-by: Luc Michel > --- >

Re: [PATCH 3/6] scripts/coccinelle: New script to add ResetType to hold and exit phases

2024-04-16 Thread Luc Michel
#x27;s reset method directly >calls the implementation of a different device's method > > Signed-off-by: Peter Maydell Reviewed-by: Luc Michel (I'm not a coccinelle expert but LGTM) > --- > The structure here is a bit of an experiment: usually I would make > the

Re: [PATCH 2/6] allwinner-i2c, adm1272: Use device_cold_reset() for software-triggered reset

2024-04-16 Thread Luc Michel
ture for the hold and exit reset methods. > > Signed-off-by: Peter Maydell Reviewed-by: Luc Michel > --- > hw/i2c/allwinner-i2c.c | 3 +-- > hw/sensor/adm1272.c| 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/i2c/allwinner-i2c.c b/hw/i2c

Re: [PATCH for-9.0] Fix some typos in documentation (found by codespell)

2024-04-01 Thread Luc Michel
On 18:15 Sun 31 Mar , Stefan Weil wrote: > Signed-off-by: Stefan Weil Reviewed-by: Luc Michel > --- > docs/devel/atomics.rst | 2 +- > docs/devel/ci-jobs.rst.inc | 2 +- > docs/devel/clocks.rst | 2 +- > docs/system/i386/sgx.rst | 2 +- > qapi/qom.json

Re: [PATCH-for-9.0 1/2] hw/clock: Let clock_set_mul_div() return boolean value

2024-03-25 Thread Luc Michel
On 09:40 Mon 25 Mar , Luc Michel wrote: > On 16:58 Fri 22 Mar , Philippe Mathieu-Daudé wrote: > > Let clock_set_mul_div() return a boolean value whether the > > clock has been updated or not, similarly to clock_set(). > > > > Signed-off-by: Philippe Mathie

Re: [PATCH-for-9.0 2/2] hw/misc/stm32l4x5_rcc: Propagate period when enabling a clock

2024-03-25 Thread Luc Michel
On 16:39 Fri 22 Mar , Peter Maydell wrote: > On Fri, 22 Mar 2024 at 15:59, Philippe Mathieu-Daudé > wrote: > > > > From: Arnaud Minier > > > > The "clock_set_mul_div" function doesn't propagate the clock period > > to the children if it is changed (e.g. by enabling/disabling a clock > > mult

Re: [PATCH-for-9.0 1/2] hw/clock: Let clock_set_mul_div() return boolean value

2024-03-25 Thread Luc Michel
On 16:58 Fri 22 Mar , Philippe Mathieu-Daudé wrote: > Let clock_set_mul_div() return a boolean value whether the > clock has been updated or not, similarly to clock_set(). > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Luc Michel > --- > include/hw/clock.h |

Re: [PATCH v5 09/12] contrib/plugins/hotblocks: migrate to new per_vcpu API

2024-03-01 Thread Luc Michel
On 14:33 Thu 29 Feb , Alex Bennée wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Luc Michel writes: > > > On 15:09 Tue 27 Feb , Pierrick Bouvier wrote: >

Re: [PATCH v5 06/12] tests/plugin/mem: migrate to new per_vcpu API

2024-02-27 Thread Luc Michel
On 14:56 Tue 27 Feb , Pierrick Bouvier wrote: > Hi Luc, > > On 2/27/24 1:35 PM, Luc Michel wrote: > > Hi Pierrick, > > > > On 13:14 Mon 26 Feb , Pierrick Bouvier wrote: > > > Signed-off-by: Pierrick Bouvier >

Re: [PATCH v5 09/12] contrib/plugins/hotblocks: migrate to new per_vcpu API

2024-02-27 Thread Luc Michel
On 15:09 Tue 27 Feb , Pierrick Bouvier wrote: > On 2/27/24 2:54 PM, Luc Michel wrote: > > Hi Pierrick, > > > > On 13:14 Mon 26 Feb , Pierrick Bouvier wrote: > > > Signed-off-by: Pierrick Bouvier > > > --- &

Re: [PATCH v5 09/12] contrib/plugins/hotblocks: migrate to new per_vcpu API

2024-02-27 Thread Luc Michel
Hi Pierrick, On 13:14 Mon 26 Feb , Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier > --- > contrib/plugins/hotblocks.c | 50 ++--- > 1 file changed, 30 insertions(+), 20 deletions(-) > > diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hot

Re: [PATCH v5 08/12] tests/plugin/bb: migrate to new per_vcpu API

2024-02-27 Thread Luc Michel
On 13:14 Mon 26 Feb , Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier Reviewed-by: Luc Michel > --- > tests/plugin/bb.c | 63 +++ > 1 file changed, 26 insertions(+), 37 deletions(-) > > diff --git a/tests/plugin/b

Re: [PATCH v5 07/12] tests/plugin/insn: migrate to new per_vcpu API

2024-02-27 Thread Luc Michel
On 13:14 Mon 26 Feb , Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier Reviewed-by: Luc Michel > --- > tests/plugin/insn.c | 106 +--- > 1 file changed, 50 insertions(+), 56 deletions(-) > > diff --git a/tests/plugin/ins

Re: [PATCH v5 06/12] tests/plugin/mem: migrate to new per_vcpu API

2024-02-27 Thread Luc Michel
Hi Pierrick, On 13:14 Mon 26 Feb , Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier > --- > tests/plugin/mem.c | 40 +--- > 1 file changed, 25 insertions(+), 15 deletions(-) > > diff --git a/tests/plugin/mem.c b/tests/plugin/mem.c > index 44e9106

Re: [PATCH 0/7] hw/i386: Cleanups around 'hw/i386/pc.h'

2024-02-13 Thread Luc Michel
rt92.c| 1 + > hw/isa/lpc_ich9.c | 1 - > hw/timer/hpet.c | 1 - > target/i386/monitor.c | 1 - > 9 files changed, 8 insertions(+), 12 deletions(-) > > -- > 2.41.0 > > For the series: Reviewed-by: Luc Michel

[PATCH v2] hw/arm/smmuv3: add support for stage 1 access fault

2024-02-13 Thread Luc Michel
An access fault is raised when the Access Flag is not set in the looked-up PTE and the AFFD field is not set in the corresponding context descriptor. This was already implemented for stage 2. Implement it for stage 1 as well. Signed-off-by: Luc Michel --- v2: drop erroneous submodule

[PATCH] hw/arm/smmuv3: add support for stage 1 access fault

2024-02-09 Thread Luc Michel
An access fault is raised when the Access Flag is not set in the looked-up PTE and the AFFD field is not set in the corresponding context descriptor. This was already implemented for stage 2. Implement it for stage 1 as well. Signed-off-by: Luc Michel --- hw/arm/smmuv3-internal.h | 1

Re: [PATCH for-9.0] docs/devel/docs: Document .hx file syntax

2023-12-14 Thread Luc Michel
s process works, > or anything else that developers might need to know about > how to add documentation. > > Make the .hx files refer to this doc file, and clean > up their header comments to be more accurate for the > usage in each file and less cut-n-pasted. > > Signed-off-by:

Re: Questions about clocks emulation

2023-12-13 Thread Luc Michel
Hi, On 20:13 Wed 13 Dec , Philippe Mathieu-Daudé wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Hi Arnaud, > > (Cc'ing Peter and Luc) > > On 12/12/23 14:05, Arnaud Minier wrote: > > Hi

Re: [PATCH trivial 13/21] hw/net/cadence_gem.c: spelling fixes: Octects

2023-11-15 Thread Luc Michel
On 19:58 Tue 14 Nov , Michael Tokarev wrote: > Fixes: c755c943aa2e "hw/net/cadence_gem: use REG32 macro for register > definitions" > Cc: Luc Michel > Cc: Peter Maydell > Signed-off-by: Michael Tokarev Reviewed-by: Luc Michel > --- > hw/net/cadence_gem.c

Re: [PATCH 10/10] hw/arm/xlnx-zynqmp: Remove 'hw/arm/boot.h' from header

2023-10-25 Thread Luc Michel
On 08:53 Wed 25 Oct , Philippe Mathieu-Daudé wrote: > "hw/arm/boot.h" is only required on the source file. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > include/hw/arm/xlnx-zynqmp.h | 1 - > hw/arm/xlnx-zcu102.c | 1 + >

Re: [PATCH 08/10] hw/arm/fsl-imx7: Remove 'hw/arm/boot.h' from header

2023-10-25 Thread Luc Michel
On 08:53 Wed 25 Oct , Philippe Mathieu-Daudé wrote: > "hw/arm/boot.h" is only required on the source file. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > include/hw/arm/fsl-imx7.h | 1 - > hw/arm/mcimx7d-sabre.c| 1 + > 2 f

Re: [PATCH 09/10] hw/arm/xlnx-versal: Remove 'hw/arm/boot.h' from header

2023-10-25 Thread Luc Michel
On 08:53 Wed 25 Oct , Philippe Mathieu-Daudé wrote: > "hw/arm/boot.h" is only required on the source file. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > include/hw/arm/xlnx-versal.h | 1 - > hw/arm/xlnx-versal-virt.c| 1 + >

Re: [PATCH 07/10] hw/arm/fsl-imx6ul: Remove 'hw/arm/boot.h' from header

2023-10-25 Thread Luc Michel
On 08:53 Wed 25 Oct , Philippe Mathieu-Daudé wrote: > "hw/arm/boot.h" is only required on the source file. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > include/hw/arm/fsl-imx6ul.h | 1 - > hw/arm/mcimx6ul-evk.c | 1 + >

Re: [PATCH 05/10] hw/arm/fsl-imx31: Remove 'hw/arm/boot.h' from header

2023-10-25 Thread Luc Michel
On 08:53 Wed 25 Oct , Philippe Mathieu-Daudé wrote: > "hw/arm/boot.h" is only required on the source file. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > include/hw/arm/fsl-imx31.h | 1 - > hw/arm/kzm.c | 1 + > 2 f

Re: [PATCH 06/10] hw/arm/fsl-imx6: Remove 'hw/arm/boot.h' from header

2023-10-25 Thread Luc Michel
On 08:53 Wed 25 Oct , Philippe Mathieu-Daudé wrote: > "hw/arm/boot.h" is only required on the source file. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > include/hw/arm/fsl-imx6.h | 1 - > hw/arm/sabrelite.c| 1 + > 2 f

Re: [PATCH 03/10] hw/arm/allwinner-r40: Remove 'hw/arm/boot.h' from header

2023-10-25 Thread Luc Michel
On 08:53 Wed 25 Oct , Philippe Mathieu-Daudé wrote: > "hw/arm/boot.h" is only required on the source file. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > include/hw/arm/allwinner-r40.h | 1 - > hw/arm/bananapi_m2u.c

Re: [PATCH 02/10] hw/arm/allwinner-h3: Remove 'hw/arm/boot.h' from header

2023-10-25 Thread Luc Michel
On 08:53 Wed 25 Oct , Philippe Mathieu-Daudé wrote: > "hw/arm/boot.h" is only required on the source file. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > include/hw/arm/allwinner-h3.h | 1 - > hw/arm/orangepi.c | 1 + >

Re: [PATCH 04/10] hw/arm/fsl-imx25: Remove 'hw/arm/boot.h' from header

2023-10-25 Thread Luc Michel
On 08:53 Wed 25 Oct , Philippe Mathieu-Daudé wrote: > "hw/arm/boot.h" is only required on the source file. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > include/hw/arm/fsl-imx25.h | 1 - > hw/arm/imx25_pdk.c | 1 + > 2 f

Re: [PATCH 01/10] hw/arm/allwinner-a10: Remove 'hw/arm/boot.h' from header

2023-10-25 Thread Luc Michel
On 08:53 Wed 25 Oct , Philippe Mathieu-Daudé wrote: > "hw/arm/boot.h" is only required on the source file. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > include/hw/arm/allwinner-a10.h | 1 - > hw/arm/cubieboard.c

[PATCH 09/11] hw/net/cadence_gem: use FIELD to describe PHYMNTNC register fields

2023-10-17 Thread Luc Michel
Use the FIELD macro to describe the PHYMNTNC register fields. Signed-off-by: Luc Michel --- hw/net/cadence_gem.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 955a8da134..4c5fe10316 100644

[PATCH 02/11] hw/net/cadence_gem: use FIELD for screening registers

2023-10-17 Thread Luc Michel
Describe screening registers fields using the FIELD macros. Signed-off-by: Luc Michel --- hw/net/cadence_gem.c | 92 ++-- 1 file changed, 47 insertions(+), 45 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 0e5744ecd7

  1   2   3   4   5   6   7   8   >