[Qemu-devel] [PATCH] MAINTAINERS: update block/sheepdog maintainers

2018-10-12 Thread Liu Yuan
From: Liu Yuan E-mail to one of block/sheepdog maintainers Mitake Hitoshi bounces : unknown user: "mitake.hitoshi" and no current address is known. So just remove it. Signed-off-by: Liu Yuan --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAI

Re: [Qemu-devel] [PATCH] sheepdog: discard the payload if the header is invalid

2015-09-01 Thread Liu Yuan
On Tue, Sep 01, 2015 at 10:05:38AM +0800, Liu Yuan wrote: > On Mon, Aug 31, 2015 at 09:51:00PM -0400, Jeff Cody wrote: > > On Tue, Sep 01, 2015 at 09:29:31AM +0800, Liu Yuan wrote: > > > From: Liu Yuan > > > > > > We need to discard the payload if we

Re: [Qemu-devel] [PATCH] sheepdog: discard the payload if the header is invalid

2015-08-31 Thread Liu Yuan
On Mon, Aug 31, 2015 at 09:51:00PM -0400, Jeff Cody wrote: > On Tue, Sep 01, 2015 at 09:29:31AM +0800, Liu Yuan wrote: > > From: Liu Yuan > > > > We need to discard the payload if we get a invalid header due to whatever > > reason > > to avoid data stream

[Qemu-devel] [PATCH] sheepdog: discard the payload if the header is invalid

2015-08-31 Thread Liu Yuan
From: Liu Yuan We need to discard the payload if we get a invalid header due to whatever reason to avoid data stream curruption. For e.g., the response consists of header plus data payload. If we simply read the header then the data payload is left in the socket buffer and the next time we would

Re: [Qemu-devel] [PATCH v3] sheepdog: add reopen support

2015-08-31 Thread Liu Yuan
On Fri, Aug 28, 2015 at 10:53:58AM +0800, Liu Yuan wrote: > From: Liu Yuan > > With reopen supported, block-commit (and offline commit) is now supported for > image files whose base image uses the Sheepdog protocol driver. > > Cc: qemu-devel@nongnu.org > Cc: Jeff Cody &

[Qemu-devel] [PATCH v3] sheepdog: add reopen support

2015-08-27 Thread Liu Yuan
From: Liu Yuan With reopen supported, block-commit (and offline commit) is now supported for image files whose base image uses the Sheepdog protocol driver. Cc: qemu-devel@nongnu.org Cc: Jeff Cody Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- v3: - init cache flags in

Re: [Qemu-devel] [PATCH v2] sheepdog: add reopen support

2015-08-27 Thread Liu Yuan
On Thu, Aug 27, 2015 at 03:00:32PM -0400, Jeff Cody wrote: > On Thu, Aug 27, 2015 at 10:54:01AM +0800, Liu Yuan wrote: > > From: Liu Yuan > > > > With reopen supported, block-commit (and offline commit) is now supported > > for > > image files whose base image

[Qemu-devel] [PATCH v2] sheepdog: add reopen support

2015-08-26 Thread Liu Yuan
From: Liu Yuan With reopen supported, block-commit (and offline commit) is now supported for image files whose base image uses the Sheepdog protocol driver. Cc: qemu-devel@nongnu.org Cc: Jeff Cody Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- v2: - free AioHandler [Jeff

[Qemu-devel] [PATCH] sheepdog: add reopen support

2015-08-26 Thread Liu Yuan
From: Liu Yuan With reopen supported, block-commit (and offline commit) is now supported for image files whose base image uses the Sheepdog protocol driver. Cc: qemu-devel@nongnu.org Cc: Jeff Cody Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/sheepdog.c | 72

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-08-02 Thread Liu Yuan
On Thu, Jul 30, 2015 at 09:27:44AM -0400, Jeff Cody wrote: > On Thu, Jul 30, 2015 at 09:41:08AM +0300, Vasiliy Tolstov wrote: > > 2015-07-29 12:31 GMT+03:00 Liu Yuan : > > > Technically, it won't affect the performance because index updates are > > > not rang

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-08-02 Thread Liu Yuan
On Sun, Aug 02, 2015 at 02:52:08PM +0300, Vasiliy Tolstov wrote: > 2015-07-31 15:08 GMT+03:00 Vasiliy Tolstov : > > Please wait to performance comparison. As i see Liu's patch may be > > more slow then Hitoshi. > > > I'm switch to local cluster driver to test only local ssd and not > network over

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-08-01 Thread Liu Yuan
On Fri, Jul 31, 2015 at 03:08:09PM +0300, Vasiliy Tolstov wrote: > 2015-07-31 14:55 GMT+03:00 Vasiliy Tolstov : > > Liu's patch also works for me. But also like in Hitoshi patch breaks > > when using discards in qemu =(. > > > Please wait to performance comparison. As i see Liu's patch may be > m

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-30 Thread Liu Yuan
On Thu, Jul 30, 2015 at 09:41:08AM +0300, Vasiliy Tolstov wrote: > 2015-07-29 12:31 GMT+03:00 Liu Yuan : > > Technically, it won't affect the performance because index updates are not > > range > > but concrete in terms of underlying 4M block size. Only 2 or 3 inde

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-29 Thread Liu Yuan
On Wed, Jul 29, 2015 at 02:04:55PM +0900, Hitoshi Mitake wrote: > At Wed, 29 Jul 2015 12:02:35 +0800, > Liu Yuan wrote: > > > > From: Liu Yuan > > > > Current sheepdog driver use a range update_inode(min_idx, max_idx) for > > batching > > the updates.

[Qemu-devel] [PATCH] sheepdog: fix overlapping metadata update

2015-07-28 Thread Liu Yuan
From: Liu Yuan Current sheepdog driver use a range update_inode(min_idx, max_idx) for batching the updates. But there is subtle problem by determining min_idx and max_idx: for a single create request, min_idx == max_idx, so actually we just update one one bit as expected. Suppose we have 2

Re: [Qemu-devel] [PATCH] sheepdog: serialize requests to overwrapping area

2015-07-28 Thread Liu Yuan
On Tue, Jul 28, 2015 at 10:31:32PM +0800, Liu Yuan wrote: > On Mon, Jul 27, 2015 at 11:23:02AM -0400, Jeff Cody wrote: > > On Sat, Jul 18, 2015 at 01:44:24AM +0900, Hitoshi Mitake wrote: > > > Current sheepdog driver only serializes create requests in oid > > > unit.

Re: [Qemu-devel] [PATCH] sheepdog: serialize requests to overwrapping area

2015-07-28 Thread Liu Yuan
On Mon, Jul 27, 2015 at 11:23:02AM -0400, Jeff Cody wrote: > On Sat, Jul 18, 2015 at 01:44:24AM +0900, Hitoshi Mitake wrote: > > Current sheepdog driver only serializes create requests in oid > > unit. This mechanism isn't enough for handling requests to > > overwrapping area spanning multiple oids

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: serialize requests to overwrapping area

2015-07-28 Thread Liu Yuan
On Tue, Jul 28, 2015 at 04:50:08PM +0800, Liu Yuan wrote: > On Sat, Jul 18, 2015 at 01:44:24AM +0900, Hitoshi Mitake wrote: > > Current sheepdog driver only serializes create requests in oid > > unit. This mechanism isn't enough for handling requests to > > overwrapping a

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: serialize requests to overwrapping area

2015-07-28 Thread Liu Yuan
On Sat, Jul 18, 2015 at 01:44:24AM +0900, Hitoshi Mitake wrote: > Current sheepdog driver only serializes create requests in oid > unit. This mechanism isn't enough for handling requests to > overwrapping area spanning multiple oids, so it can result bugs like > below: > https://bugs.launchpad.net/

Re: [Qemu-devel] [PATCH v2] sheepdog: fix confused return values

2015-02-26 Thread Liu Yuan
On Wed, Feb 18, 2015 at 11:57:55AM +0800, Liu Yuan wrote: > From: Liu Yuan > > These functions mix up -1 and -errno in return values and would might cause > trouble error handling in the call chain. > > This patch let them return -errno and add some comments. > > Cc: qe

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-25 Thread Liu Yuan
On Wed, Feb 25, 2015 at 10:35:17AM +0100, Markus Armbruster wrote: > Liu Yuan writes: > > > On Wed, Feb 18, 2015 at 09:35:07AM +0100, Markus Armbruster wrote: > >> Liu Yuan writes: > >> > >> > From: Liu Yuan > >> > > >> > The

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-24 Thread Liu Yuan
On Wed, Feb 18, 2015 at 09:35:07AM +0100, Markus Armbruster wrote: > Liu Yuan writes: > > > From: Liu Yuan > > > > These functions mix up -1 and -errno in return values and would might cause > > trouble error handling in the call chain. > > > > This

[Qemu-devel] [PATCH v2] sheepdog: fix confused return values

2015-02-17 Thread Liu Yuan
From: Liu Yuan These functions mix up -1 and -errno in return values and would might cause trouble error handling in the call chain. This patch let them return -errno and add some comments. Cc: qemu-devel@nongnu.org Cc: Markus Armbruster Cc: Kevin Wolf Cc: Stefan Hajnoczi Reported-by

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-17 Thread Liu Yuan
On Mon, Feb 16, 2015 at 12:56:04PM +0100, Kevin Wolf wrote: > Am 13.02.2015 um 04:45 hat Liu Yuan geschrieben: > > From: Liu Yuan > > > > These functions mix up -1 and -errno in return values and would might cause > > trouble error handling in the call chain. > >

Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

2015-02-12 Thread Liu Yuan
> +error_report("failed to create inode for snapshot: %s", > + error_get_pretty(local_err)); > goto cleanup; > } Reviewed-by: Liu Yuan

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-12 Thread Liu Yuan
On Fri, Feb 13, 2015 at 11:45:42AM +0800, Liu Yuan wrote: > From: Liu Yuan > > These functions mix up -1 and -errno in return values and would might cause > trouble error handling in the call chain. > > This patch let them return -errno and add some comments. > > Report

[Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-12 Thread Liu Yuan
From: Liu Yuan These functions mix up -1 and -errno in return values and would might cause trouble error handling in the call chain. This patch let them return -errno and add some comments. Reported-by: Markus Armbruster Signed-off-by: Liu Yuan --- block/sheepdog.c | 11 +++ 1 file

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Liu Yuan
On Fri, Feb 13, 2015 at 10:33:04AM +0900, Teruaki Ishizaki wrote: > (2015/02/12 11:55), Liu Yuan wrote: > >On Thu, Feb 12, 2015 at 11:33:16AM +0900, Teruaki Ishizaki wrote: > >>(2015/02/12 11:19), Liu Yuan wrote: > >>>On Thu, Feb 12, 2015 at 10:51:25AM +0900, Teruaki

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Liu Yuan
On Thu, Feb 12, 2015 at 05:13:55PM +0900, Hitoshi Mitake wrote: > At Thu, 12 Feb 2015 15:42:17 +0800, > Liu Yuan wrote: > > > > On Thu, Feb 12, 2015 at 04:28:01PM +0900, Hitoshi Mitake wrote: > > > At Thu, 12 Feb 2015 15:00:49 +0800, > > > Liu Yuan wrote: >

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Liu Yuan
On Thu, Feb 12, 2015 at 05:01:05PM +0900, Teruaki Ishizaki wrote: > (2015/02/12 16:42), Liu Yuan wrote: > >On Thu, Feb 12, 2015 at 04:28:01PM +0900, Hitoshi Mitake wrote: > >>At Thu, 12 Feb 2015 15:00:49 +0800, > >>Liu Yuan wrote: > >>> > >>>On Th

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-11 Thread Liu Yuan
On Thu, Feb 12, 2015 at 04:28:01PM +0900, Hitoshi Mitake wrote: > At Thu, 12 Feb 2015 15:00:49 +0800, > Liu Yuan wrote: > > > > On Thu, Feb 12, 2015 at 03:19:21PM +0900, Hitoshi Mitake wrote: > > > At Tue, 10 Feb 2015 18:35:58 +0800, > > > Liu Yuan wrote: >

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-11 Thread Liu Yuan
On Thu, Feb 12, 2015 at 03:19:21PM +0900, Hitoshi Mitake wrote: > At Tue, 10 Feb 2015 18:35:58 +0800, > Liu Yuan wrote: > > > > On Tue, Feb 10, 2015 at 06:56:33PM +0900, Teruaki Ishizaki wrote: > > > (2015/02/10 17:58), Liu Yuan wrote: > > > >On Tue, Fe

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-11 Thread Liu Yuan
On Thu, Feb 12, 2015 at 11:33:16AM +0900, Teruaki Ishizaki wrote: > (2015/02/12 11:19), Liu Yuan wrote: > >On Thu, Feb 12, 2015 at 10:51:25AM +0900, Teruaki Ishizaki wrote: > >>(2015/02/10 20:12), Liu Yuan wrote: > >>>On Tue, Jan 27, 2015 at 05:35:27PM

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-11 Thread Liu Yuan
On Thu, Feb 12, 2015 at 10:51:25AM +0900, Teruaki Ishizaki wrote: > (2015/02/10 20:12), Liu Yuan wrote: > >On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: > >>Previously, qemu block driver of sheepdog used hard-coded VDI object size. > >>This pa

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-10 Thread Liu Yuan
On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > This patch enables users to handle "block_size_shift" value for > calculating VDI object size. > > When you start qemu, you don't need to specify additio

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-10 Thread Liu Yuan
On Tue, Feb 10, 2015 at 06:56:33PM +0900, Teruaki Ishizaki wrote: > (2015/02/10 17:58), Liu Yuan wrote: > >On Tue, Feb 10, 2015 at 05:22:02PM +0900, Teruaki Ishizaki wrote: > >>(2015/02/10 12:10), Liu Yuan wrote: > >>>On Tue, Jan 27, 2015 at 05:35:27PM

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-10 Thread Liu Yuan
On Tue, Feb 10, 2015 at 05:22:02PM +0900, Teruaki Ishizaki wrote: > (2015/02/10 12:10), Liu Yuan wrote: > >On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: > >>Previously, qemu block driver of sheepdog used hard-coded VDI object size. > >>This pa

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-09 Thread Liu Yuan
On Tue, Feb 10, 2015 at 11:10:51AM +0800, Liu Yuan wrote: > On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: > > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > > This patch enables users to handle "block_size_shift" valu

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-09 Thread Liu Yuan
On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > This patch enables users to handle "block_size_shift" value for > calculating VDI object size. > > When you start qemu, you don't need to specify additio

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-08 Thread Liu Yuan
On Fri, Feb 06, 2015 at 04:57:55PM +0900, Teruaki Ishizaki wrote: > (2015/02/06 11:18), Liu Yuan wrote: > >On Wed, Feb 04, 2015 at 01:54:19PM +0900, Teruaki Ishizaki wrote: > >>(2015/02/02 15:52), Liu Yuan wrote: > >>>On Tue, Jan 27, 2015 at 05:35:27PM

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-05 Thread Liu Yuan
On Wed, Feb 04, 2015 at 01:54:19PM +0900, Teruaki Ishizaki wrote: > (2015/02/02 15:52), Liu Yuan wrote: > >On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: > >>Previously, qemu block driver of sheepdog used hard-coded VDI object size. > >>This pa

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-01 Thread Liu Yuan
On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > This patch enables users to handle "block_size_shift" value for > calculating VDI object size. > > When you start qemu, you don't need to specify additio

Re: [Qemu-devel] [PATCH 0/8] add basic recovery logic to quorum driver

2014-09-10 Thread Liu Yuan
On Wed, Sep 03, 2014 at 12:19:14AM +0200, Benoît Canet wrote: > The Monday 01 Sep 2014 à 15:43:06 (+0800), Liu Yuan wrote : > > Liu, > > Do you think this could work with qcow2 file backed by NFS servers ? It depends on which client we use. If we use Linux NFS client by '

Re: [Qemu-devel] [PATCH 0/8] add basic recovery logic to quorum driver

2014-09-10 Thread Liu Yuan
On Sun, Sep 07, 2014 at 05:12:31PM +0200, Benoît Canet wrote: > The Monday 01 Sep 2014 à 15:43:06 (+0800), Liu Yuan wrote : > > This patch set mainly add mainly two logics to implement device recover > > - notify qourum driver of the broken states from the child driver(s) > &

Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 11:32:04AM +0200, Benoît Canet wrote: > The Monday 01 Sep 2014 à 17:26:09 (+0800), Liu Yuan wrote : > > On Mon, Sep 01, 2014 at 10:35:27AM +0200, Benoît Canet wrote: > > > The Monday 01 Sep 2014 à 15:43:11 (+0800), Liu Yuan wrote : > > > > Fo

Re: [Qemu-devel] [PATCH 8/8] quorum: add basic device recovery logic

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 11:37:20AM +0200, Benoît Canet wrote: > The Monday 01 Sep 2014 à 15:43:14 (+0800), Liu Yuan wrote : > > For some configuration, quorum allow VMs to continue while some child > > devices > > are broken and when the child devices are repaired and return

Re: [Qemu-devel] [PATCH 2/8] block: add driver operation callbacks

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 11:28:22AM +0200, Benoît Canet wrote: > The Monday 01 Sep 2014 à 17:19:19 (+0800), Liu Yuan wrote : > > On Mon, Sep 01, 2014 at 10:28:54AM +0200, Benoît Canet wrote: > > > The Monday 01 Sep 2014 à 15:43:08 (+0800), Liu Yuan wrote : > > > > Dr

Re: [Qemu-devel] [PATCH 6/8] block/quorum: add broken state to BlockDriverState

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 10:57:43AM +0200, Benoît Canet wrote: > The Monday 01 Sep 2014 à 15:43:12 (+0800), Liu Yuan wrote : > > This allow VM continues to process even if some devices are broken meanwhile > > with proper configuration. > > > > We mark the device br

Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 10:35:27AM +0200, Benoît Canet wrote: > The Monday 01 Sep 2014 à 15:43:11 (+0800), Liu Yuan wrote : > > For a fifo read pattern, we only have one running aio > > >(possible other cases that has less number than num_children in the future) > I have

Re: [Qemu-devel] [PATCH 3/8] block/sheepdog: propagate disconnect/reconnect events to upper driver

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 10:31:47AM +0200, Benoît Canet wrote: > The Monday 01 Sep 2014 à 15:43:09 (+0800), Liu Yuan wrote : > > This is the reference usage how we propagate connection state to upper tier. > > > > Cc: Eric Blake > > Cc: Benoit Canet > > Cc: Ke

Re: [Qemu-devel] [PATCH 2/8] block: add driver operation callbacks

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 10:28:54AM +0200, Benoît Canet wrote: > The Monday 01 Sep 2014 à 15:43:08 (+0800), Liu Yuan wrote : > > Driver operations are defined as callbacks passed from block upper drivers > > to > > lower drivers and are supposed to be called by lower drive

[Qemu-devel] [PATCH 7/8] block: add two helpers

2014-09-01 Thread Liu Yuan
These helpers are needed by later quorum sync device logic. Cc: Eric Blake Cc: Benoit Canet Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block.c | 10 ++ include/block/block.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block.c b/block.c

[Qemu-devel] [PATCH 6/8] block/quorum: add broken state to BlockDriverState

2014-09-01 Thread Liu Yuan
n and threshold, we can easily mimic the DRVD behavior with following configuration: read-pattern=fifo,threshold=1 will two children. Cc: Eric Blake Cc: Benoit Canet Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/quorum.c

[Qemu-devel] [PATCH 3/8] block/sheepdog: propagate disconnect/reconnect events to upper driver

2014-09-01 Thread Liu Yuan
This is the reference usage how we propagate connection state to upper tier. Cc: Eric Blake Cc: Benoit Canet Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/sheepdog.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index

[Qemu-devel] [PATCH 8/8] quorum: add basic device recovery logic

2014-09-01 Thread Liu Yuan
any problem. Cc: Eric Blake Cc: Benoit Canet Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/quorum.c | 189 - trace-events | 5 ++ 2 files changed, 191 insertions(+), 3 deletions(-) diff --git a/block/quorum.c b

[Qemu-devel] [PATCH 2/8] block: add driver operation callbacks

2014-09-01 Thread Liu Yuan
. Cc: Eric Blake Cc: Benoit Canet Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block.c | 7 +++ include/block/block.h | 7 +++ include/block/block_int.h | 3 +++ 3 files changed, 17 insertions(+) diff --git a/block.c b/block.c index c12b8de

[Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Liu Yuan
: Liu Yuan --- block/quorum.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 9e056d6..b9eeda3 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -144,7 +144,9 @@ static void quorum_aio_cancel(BlockDriverAIOCB *blockacb) /* cancel

[Qemu-devel] [PATCH 0/8] add basic recovery logic to quorum driver

2014-09-01 Thread Liu Yuan
control sync bandwidth more smoothly - add auto-reconnection mechanism to other protocol (if not support yet) - add tests Cc: Eric Blake Cc: Benoit Canet Cc: Kevin Wolf Cc: Stefan Hajnoczi Liu Yuan (8): block/quorum: initialize qcrs.aiocb for read block: add driver operation callbacks block

[Qemu-devel] [PATCH 4/8] block/quorum: add quorum_aio_release() helper

2014-09-01 Thread Liu Yuan
Cc: Eric Blake Cc: Benoit Canet Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/quorum.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/block/quorum.c b/block/quorum.c index 5866bca..9e056d6 100644 --- a/block/quorum.c +++ b/block

[Qemu-devel] [PATCH 1/8] block/quorum: initialize qcrs.aiocb for read

2014-09-01 Thread Liu Yuan
This is required by quorum_aio_cancel() Cc: Eric Blake Cc: Benoit Canet Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/quorum.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/block/quorum.c b/block/quorum.c index af48e8c

[Qemu-devel] [PATCH] block: kill tail whitespace in block.c

2014-08-31 Thread Liu Yuan
Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index e9380f6..c12b8de 100644 --- a/block.c +++ b/block.c @@ -2239,7 +2239,7 @@ int bdrv_commit(BlockDriverState *bs) if (!drv

Re: [Qemu-devel] [PATCH v6 0/2] add read-pattern for block qourum

2014-08-28 Thread Liu Yuan
On Thu, Aug 28, 2014 at 11:33:08AM +0100, Stefan Hajnoczi wrote: > On Mon, Aug 18, 2014 at 05:41:03PM +0800, Liu Yuan wrote: > > v6: > > - fix a unused warning introduced by last version > > > > v5: > > - simplify a for loop in quorum_aio_finalize() > &g

[Qemu-devel] [PATCH v2] sheepdog: fix a core dump while do auto-reconnecting

2014-08-28 Thread Liu Yuan
: Assertion `!xcb_xlib_threads_sequence_lost' failed. Aborted (core dumped) Cc: qemu-devel@nongnu.org Cc: Markus Armbruster Cc: Kevin Wolf Cc: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Liu Yuan --- block/sheepdog.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[Qemu-devel] [PATCH] sheepdog: fix a core dump while do auto-reconnecting

2014-08-28 Thread Liu Yuan
`!xcb_xlib_threads_sequence_lost' failed. Aborted (core dumped) Cc: qemu-devel@nongnu.org Cc: Markus Armbruster Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/sheepdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 3a

Re: [Qemu-devel] [PATCH v6 0/2] add read-pattern for block qourum

2014-08-28 Thread Liu Yuan
On Mon, Aug 25, 2014 at 10:46:21AM +0800, Liu Yuan wrote: > On Mon, Aug 18, 2014 at 05:41:03PM +0800, Liu Yuan wrote: > > v6: > > - fix a unused warning introduced by last version > > > > Hi Stefan and Kevin, > >Benoît Canet has added Reviewed-by tag

Re: [Qemu-devel] [PATCH v6 0/2] add read-pattern for block qourum

2014-08-24 Thread Liu Yuan
On Mon, Aug 18, 2014 at 05:41:03PM +0800, Liu Yuan wrote: > v6: > - fix a unused warning introduced by last version > Hi Stefan and Kevin, Benoît Canet has added Reviewed-by tag to both patches, could one of you pick this patch set? Thanks Yuan

Re: [Qemu-devel] [PATCH v5 2/2] block/quorum: add simple read pattern support

2014-08-21 Thread Liu Yuan
On Mon, Aug 18, 2014 at 01:59:28PM +0800, Liu Yuan wrote: > On Fri, Aug 15, 2014 at 03:59:04PM +0200, Benoît Canet wrote: > > The Friday 15 Aug 2014 à 13:05:17 (+0800), Liu Yuan wrote : > > > This patch adds single read pattern to quorum driver and quorum vote is > >

[Qemu-devel] [PATCH v6 2/2] block/quorum: add simple read pattern support

2014-08-18 Thread Liu Yuan
-pattern=fifo,vote-threshold=1 [1] http://en.wikipedia.org/wiki/Distributed_Replicated_Block_Device Cc: Benoit Canet Cc: Eric Blake Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/quorum.c | 177 + 1 file changed, 1

[Qemu-devel] [PATCH v6 0/2] add read-pattern for block qourum

2014-08-18 Thread Liu Yuan
e-threshold=1 [1] http://en.wikipedia.org/wiki/Distributed_Replicated_Block_Device Cc: Benoit Canet Cc: Eric Blake Cc: Kevin Wolf Cc: Stefan Hajnoczi Liu Yuan (2): qapi: add read-pattern enum for quorum block/quorum: add simple read pattern support blo

[Qemu-devel] [PATCH v6 1/2] qapi: add read-pattern enum for quorum

2014-08-18 Thread Liu Yuan
Cc: Eric Blake Reviewed-by: Eric Blake Reviewed-by: Benoît Canet Signed-off-by: Liu Yuan --- qapi/block-core.json | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index e378653..42033d9 100644 --- a/qapi/block

Re: [Qemu-devel] [PATCH v5 2/2] block/quorum: add simple read pattern support

2014-08-17 Thread Liu Yuan
On Fri, Aug 15, 2014 at 03:59:04PM +0200, Benoît Canet wrote: > The Friday 15 Aug 2014 à 13:05:17 (+0800), Liu Yuan wrote : > > This patch adds single read pattern to quorum driver and quorum vote is > > default > > pattern. > > > > For now we do a quorum vote

[Qemu-devel] [PATCH v5 1/2] qapi: add read-pattern enum for quorum

2014-08-14 Thread Liu Yuan
Cc: Eric Blake Reviewed-by: Eric Blake Signed-off-by: Liu Yuan --- qapi/block-core.json | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index e378653..42033d9 100644 --- a/qapi/block-core.json +++ b/qapi/block

[Qemu-devel] [PATCH v5 2/2] block/quorum: add simple read pattern support

2014-08-14 Thread Liu Yuan
-pattern=fifo,vote-threshold=1 [1] http://en.wikipedia.org/wiki/Distributed_Replicated_Block_Device Cc: Benoit Canet Cc: Eric Blake Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/quorum.c | 176 ++--- 1 file changed, 1

[Qemu-devel] [PATCH v5 0/2] add read-pattern for block qourum

2014-08-14 Thread Liu Yuan
icated_Block_Device Cc: Benoit Canet Cc: Eric Blake Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan Liu Yuan (2): qapi: add read-pattern enum for quorum block/quorum: add simple read pattern support block/quorum.c | 176 +-- qap

Re: [Qemu-devel] [PATCH v4 2/2] block/quorum: add simple read pattern support

2014-08-14 Thread Liu Yuan
On Thu, Aug 14, 2014 at 01:09:32PM +0200, Benoît Canet wrote: > The Thursday 17 Jul 2014 à 13:18:56 (+0800), Liu Yuan wrote : > > This patch adds single read pattern to quorum driver and quorum vote is > > default > > pattern. > > > > For now we do a quorum vote

Re: [Qemu-devel] [PATCH v3 0/2] sheepdog driver update related to VDI locking feature

2014-08-14 Thread Liu Yuan
_NOT_LOCKED as a special case > > Hitoshi Mitake (2): > sheepdog: adopting protocol update for VDI locking > sheepdog: improve error handling for a case of failed lock > > block/sheepdog.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > Reviewed-by: Liu Yuan

Re: [Qemu-devel] [PATCH v4 2/2] block/quorum: add simple read pattern support

2014-08-14 Thread Liu Yuan
On Tue, Aug 12, 2014 at 10:41:28AM +0800, Liu Yuan wrote: > On Mon, Aug 11, 2014 at 02:31:43PM +0200, Benoît Canet wrote: > > The Thursday 17 Jul 2014 à 13:18:56 (+0800), Liu Yuan wrote : > > > This patch adds single read pattern to quorum driver and quorum vote is > >

Re: [Qemu-devel] [PATCH v4 2/2] block/quorum: add simple read pattern support

2014-08-11 Thread Liu Yuan
On Mon, Aug 11, 2014 at 02:31:43PM +0200, Benoît Canet wrote: > The Thursday 17 Jul 2014 à 13:18:56 (+0800), Liu Yuan wrote : > > This patch adds single read pattern to quorum driver and quorum vote is > > default > > pattern. > > > > For now we do a quorum vote

Re: [Qemu-devel] [PATCH v4 2/2] block/quorum: add simple read pattern support

2014-08-11 Thread Liu Yuan
On Thu, Jul 17, 2014 at 01:18:56PM +0800, Liu Yuan wrote: > This patch adds single read pattern to quorum driver and quorum vote is > default > pattern. > > For now we do a quorum vote on all the reads, it is designed for unreliable > underlying storage such as non-redundan

Re: [Qemu-devel] [PATCH 1/2] sheepdog: adopting protocol update for VDI locking

2014-08-10 Thread Liu Yuan
On Mon, Aug 11, 2014 at 11:34:56AM +0800, Liu Yuan wrote: > On Mon, Aug 11, 2014 at 11:17:33AM +0900, Hitoshi Mitake wrote: > > At Fri, 8 Aug 2014 15:49:37 +0800, > > Liu Yuan wrote: > > > > > > On Fri, Aug 08, 2014 at 03:12:17PM +0900, Hitoshi Mitake wrote: &g

Re: [Qemu-devel] [PATCH 1/2] sheepdog: adopting protocol update for VDI locking

2014-08-10 Thread Liu Yuan
On Mon, Aug 11, 2014 at 11:17:33AM +0900, Hitoshi Mitake wrote: > At Fri, 8 Aug 2014 15:49:37 +0800, > Liu Yuan wrote: > > > > On Fri, Aug 08, 2014 at 03:12:17PM +0900, Hitoshi Mitake wrote: > > > At Fri, 8 Aug 2014 13:20:39 +0800, > > > Liu Yuan wrote: > &g

Re: [Qemu-devel] [PATCH 1/2] sheepdog: adopting protocol update for VDI locking

2014-08-08 Thread Liu Yuan
On Fri, Aug 08, 2014 at 03:12:17PM +0900, Hitoshi Mitake wrote: > At Fri, 8 Aug 2014 13:20:39 +0800, > Liu Yuan wrote: > > > > On Thu, Aug 07, 2014 at 04:28:39PM +0900, Hitoshi Mitake wrote: > > > The update is required for supporting iSCSI multipath. It doesn'

Re: [Qemu-devel] [PATCH 2/2] sheepdog: improve error handling for a case of failed lock

2014-08-07 Thread Liu Yuan
On Fri, Aug 08, 2014 at 03:17:59PM +0900, Hitoshi Mitake wrote: > At Fri, 8 Aug 2014 13:31:39 +0800, > Liu Yuan wrote: > > > > On Thu, Aug 07, 2014 at 04:28:40PM +0900, Hitoshi Mitake wrote: > > > Recently, sheepdog revived its VDI locking functionality. This patch &g

[Qemu-devel] [PATCH] cluster/zookeeper: add log information for zk auto-recoonect

2014-08-07 Thread Liu Yuan
Reported-by: Valerio Pachera Signed-off-by: Liu Yuan --- sheep/group.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sheep/group.c b/sheep/group.c index 06a80bd..08e3884 100644 --- a/sheep/group.c +++ b/sheep/group.c @@ -979,7 +979,7 @@ static int send_join_request(void

Re: [Qemu-devel] [PATCH 2/2] sheepdog: improve error handling for a case of failed lock

2014-08-07 Thread Liu Yuan
case of failed locking. -EBUSY is a > suitable one. > > Reported-by: Valerio Pachera > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Cc: Liu Yuan > Cc: MORITA Kazutaka > Signed-off-by: Hitoshi Mitake > --- > block/sheepdog.c | 4 > 1 file changed, 4 insertion

Re: [Qemu-devel] [PATCH 1/2] sheepdog: adopting protocol update for VDI locking

2014-08-07 Thread Liu Yuan
On Thu, Aug 07, 2014 at 04:28:39PM +0900, Hitoshi Mitake wrote: > The update is required for supporting iSCSI multipath. It doesn't > affect behavior of QEMU driver but adding a new field to vdi request > struct is required. > > Cc: Kevin Wolf > Cc: Stefan Hajnoczi >

Re: [Qemu-devel] [PATCH] block/quorum: implement .bdrv_co_get_block_status

2014-07-20 Thread Liu Yuan
On Fri, Jul 18, 2014 at 03:35:57PM +0200, Paolo Bonzini wrote: > Il 17/07/2014 13:50, Liu Yuan ha scritto: > > - allow drive-mirror to create sprase mirror on images like qcow2 > > - allow qemu-img map to work as expected on quorum driver > > > > Cc: Benoit Canet

Re: [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly

2014-07-18 Thread Liu Yuan
On Tue, Jul 15, 2014 at 04:16:14PM +0200, Stefan Hajnoczi wrote: > On Mon, Jul 14, 2014 at 11:06:08AM +0800, Hu Tao wrote: > > On Sat, Jul 12, 2014 at 11:17:40AM +0800, Liu Yuan wrote: > > > Cc: Kevin Wolf > > > Signed-off-by: Liu Yuan > > > --- > > &g

Re: [Qemu-devel] [PATCH] block/quorum: implement .bdrv_co_get_block_status

2014-07-17 Thread Liu Yuan
On Fri, Jul 18, 2014 at 11:11:31AM +0800, Fam Zheng wrote: > On Thu, 07/17 19:50, Liu Yuan wrote: > > - allow drive-mirror to create sprase mirror on images like qcow2 > > - allow qemu-img map to work as expected on quorum driver > > > > Cc: Benoit Canet > &g

[Qemu-devel] [PATCH] block/quorum: implement .bdrv_co_get_block_status

2014-07-17 Thread Liu Yuan
- allow drive-mirror to create sprase mirror on images like qcow2 - allow qemu-img map to work as expected on quorum driver Cc: Benoit Canet Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/quorum.c | 16 1 file changed, 16 insertions(+) diff --git a

[Qemu-devel] [PATCH v4 1/2] qapi: add read-pattern enum for quorum

2014-07-16 Thread Liu Yuan
Cc: Eric Blake Signed-off-by: Liu Yuan --- qapi/block-core.json | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index e378653..42033d9 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1384,6

[Qemu-devel] [PATCH v4 0/2] add read-pattern for block qourum

2014-07-16 Thread Liu Yuan
vailibility needs. E.g, Enable single read pattern on 2 children, -drive driver=quorum,children.0.file.filename=0.qcow2,\ children.1.file.filename=1.qcow2,read-pattern=fifo,vote-threshold=1 [1] http://en.wikipedia.org/wiki/Distributed_Replicated_Block_Device Liu Yuan (2): qapi: add read-pat

[Qemu-devel] [PATCH v4 2/2] block/quorum: add simple read pattern support

2014-07-16 Thread Liu Yuan
-pattern=fifo,vote-threshold=1 [1] http://en.wikipedia.org/wiki/Distributed_Replicated_Block_Device Cc: Benoit Canet Cc: Eric Blake Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/quorum.c | 179 + 1 file changed, 1

Re: [Qemu-devel] [PATCH v3 1/2] block/quorum: add simple read pattern support

2014-07-15 Thread Liu Yuan
On Tue, Jul 15, 2014 at 06:14:32AM -0600, Eric Blake wrote: > On 07/15/2014 12:34 AM, Liu Yuan wrote: > > This patch adds single read pattern to quorum driver and quorum vote is > > default > > pattern. > > > > For now we do a quorum vote on all the rea

Re: [Qemu-devel] [PATCH v3 2/2] qapi: add read-pattern support for quorum

2014-07-15 Thread Liu Yuan
On Wed, Jul 16, 2014 at 10:22:20AM +0800, Liu Yuan wrote: > On Tue, Jul 15, 2014 at 06:22:14AM -0600, Eric Blake wrote: > > On 07/15/2014 12:34 AM, Liu Yuan wrote: > > > Cc: Eric Blake > > > Signed-off-by: Liu Yuan > > > --- > > > qapi/block-cor

Re: [Qemu-devel] [PATCH v3 2/2] qapi: add read-pattern support for quorum

2014-07-15 Thread Liu Yuan
On Tue, Jul 15, 2014 at 06:22:14AM -0600, Eric Blake wrote: > On 07/15/2014 12:34 AM, Liu Yuan wrote: > > Cc: Eric Blake > > Signed-off-by: Liu Yuan > > --- > > qapi/block-core.json | 19 ++- > > 1 file changed, 18 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v3 2/2] qapi: add read-pattern support for quorum

2014-07-14 Thread Liu Yuan
Cc: Eric Blake Signed-off-by: Liu Yuan --- qapi/block-core.json | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index e378653..22491bc 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1384,6

[Qemu-devel] [PATCH v3 1/2] block/quorum: add simple read pattern support

2014-07-14 Thread Liu Yuan
,read-pattern=single,vote-threshold=1 [1] http://en.wikipedia.org/wiki/Distributed_Replicated_Block_Device Cc: Benoit Canet Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/quorum.c | 181 + 1 file changed, 131 inse

[Qemu-devel] [PATCH v3 0/2] add read-pattern for block qourum

2014-07-14 Thread Liu Yuan
e.filename=1.qcow2,read-pattern=single,vote-threshold=1 [1] http://en.wikipedia.org/wiki/Distributed_Replicated_Block_Device Liu Yuan (2): block/quorum: add simple read pattern support qapi: add read-pattern support for quorum block/quorum.c | 181 +---

Re: [Qemu-devel] [PATCH v2] block/quorum: add simple read pattern support

2014-07-14 Thread Liu Yuan
On Mon, Jul 14, 2014 at 09:33:59PM -0600, Eric Blake wrote: > On 07/14/2014 09:19 PM, Liu Yuan wrote: > > This patch adds single read pattern to quorum driver and quorum vote is > > default > > pattern. > > > > > This patch generalize the above 2 nodes case

  1   2   3   4   >