Re: [Qemu-devel] [PATCH] target-arm: fix incorrect assertion in access_check_cp_reg helper

2015-06-02 Thread Leon Yu
Argh, that fix is cleaner and I should have checked patchwork first. Lesson learned, thanks. -Leon On Mon, Jun 1, 2015 at 10:20 PM, Peter Maydell wrote: > On 1 June 2015 at 13:27, Leon Yu wrote: >> as comparing boolean with constant 3 is always false. >> >> S

[Qemu-devel] [PATCH] target-arm: fix incorrect assertion in access_check_cp_reg helper

2015-06-01 Thread Leon Yu
as comparing boolean with constant 3 is always false. Signed-off-by: Leon Yu --- target-arm/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c index 3f5b9ab..30f2374 100644 --- a/target-arm/op_helper.c +++ b/target-arm

[Qemu-devel] [PATCH] qmp: unbreak build for non-vnc configuration

2015-02-01 Thread Leon Yu
Signed-off-by: Leon Yu Fixes: df887684603a ("monitor: add query-vnc-servers command") --- qmp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qmp.c b/qmp.c index 963305c..ae55f1e 100644 --- a/qmp.c +++ b/qmp.c @@ -134,6 +134,12 @@ VncInfo *qmp_query_vnc(Error **errp)

[Qemu-devel] [PATCH] target-mips: fix mips16 MULT/DIV (broken by ASE_DSP)

2013-02-19 Thread Leon Yu
using bit[11-12] of opcode as acc is not correct for ASE_MIPS16 instructions. doing so generates RI/DSPDIS exception when decoding MIPS16 MULT/DIV. Signed-off-by: Leon Yu --- target-mips/translate.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/target