Re: [PATCH v3 0/4] virtio: Refactor vhost input stub

2023-12-29 Thread Leo Yan
Hi Michael, On Mon, Dec 25, 2023 at 11:06:35AM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 20, 2023 at 12:37:17PM +0800, Leo Yan wrote: > > This series is to refactor vhost stub vhost-user-input. > > > > Since vhost input stub requires set_config() callback for co

[PATCH v3 1/4] hw/virtio: Support set_config() callback in vhost-user-base

2023-11-19 Thread Leo Yan
The Virtio input device invokes set_config() callback for retrieving the event configuration info, but the callback is not supported in vhost-user-base. This patch adds support set_config() callback in vhost-user-base. Signed-off-by: Leo Yan Reviewed-by: Marc-André Lureau --- hw/virtio/vhost

[PATCH v3 2/4] docs/system: Add vhost-user-input documentation

2023-11-19 Thread Leo Yan
This adds basic documentation for vhost-user-input. Signed-off-by: Leo Yan --- MAINTAINERS | 1 + docs/system/device-emulation.rst | 1 + docs/system/devices/vhost-user-input.rst | 45 docs/system/devices/vhost-user.rst | 4

[PATCH v3 0/4] virtio: Refactor vhost input stub

2023-11-19 Thread Leo Yan
changing folder for vhost-user-input.c. (Manos) Leo Yan (4): hw/virtio: Support set_config() callback in vhost-user-base docs/system: Add vhost-user-input documentation hw/virtio: Move vhost-user-input into virtio folder hw/virtio: derive vhost-user-input from vhost-use

[PATCH v3 3/4] hw/virtio: Move vhost-user-input into virtio folder

2023-11-19 Thread Leo Yan
vhost-user-input is in the input folder. On the other hand, the folder 'hw/virtio' maintains other virtio stubs (e.g. I2C, RNG, GPIO, etc). This patch moves vhost-user-input into the virtio folder for better code organization. No functionality change. Signed-off-by: Leo Yan --- M

[PATCH v3 4/4] hw/virtio: derive vhost-user-input from vhost-user-base

2023-11-19 Thread Leo Yan
or, remove the duplicate property from vhost-user-input-pci. Signed-off-by: Leo Yan --- hw/virtio/vhost-user-input-pci.c | 3 - hw/virtio/vhost-user-input.c | 114 +-- include/hw/virtio/virtio-input.h | 6 +- 3 files changed, 21 insertions(+), 102 deletions(-) di

Re: [PATCH v2 2/4] docs/system: Add vhost-user-input documentation

2023-11-14 Thread Leo Yan
Hi Marc-André, + Mathieu for vhost RNG stuff. On Tue, Nov 14, 2023 at 01:54:50PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Nov 13, 2023 at 11:04 PM Leo Yan wrote: [...] > > @@ -2233,6 +2233,7 @@ L: virtio...@redhat.com > > virtio-input > > M: Gerd Hoffman

Re: [PATCH v1 0/4] virtio: Refactor vhost input stub

2023-11-13 Thread Leo Yan
Hi Michael, On Mon, Nov 13, 2023 at 01:29:49AM -0500, Michael S. Tsirkin wrote: [...] > > The series is based on "[PATCH v8 0/7] virtio: cleanup > > vhost-user-generic and reduce c&p" which introduces vhost-user-base. > > Based-on: <20231107180752.3458672-1-alex.ben...@linaro.org> > > > That p

[PATCH v2 3/4] hw/virtio: Move vhost-user-input into virtio folder

2023-11-13 Thread Leo Yan
vhost-user-input is in the input folder. On the other hand, the folder 'hw/virtio' maintains other virtio stubs (e.g. I2C, RNG, GPIO, etc). This patch moves vhost-user-input into the virtio folder for better code organization. No functionality change. Signed-off-by: Leo Yan --- M

[PATCH v2 4/4] hw/virtio: derive vhost-user-input from vhost-user-base

2023-11-13 Thread Leo Yan
or, remove the duplicate property from vhost-user-input-pci. Signed-off-by: Leo Yan --- hw/virtio/vhost-user-input-pci.c | 3 - hw/virtio/vhost-user-input.c | 114 +-- include/hw/virtio/virtio-input.h | 6 +- 3 files changed, 21 insertions(+), 102 deletions(-) di

[PATCH v2 2/4] docs/system: Add vhost-user-input documentation

2023-11-13 Thread Leo Yan
This adds basic documentation for vhost-user-input. Signed-off-by: Leo Yan --- MAINTAINERS | 1 + docs/system/devices/vhost-user-input.rst | 44 docs/system/devices/vhost-user.rst | 2 +- 3 files changed, 46 insertions(+), 1 deletion

[PATCH v2 1/4] hw/virtio: Support set_config() callback in vhost-user-base

2023-11-13 Thread Leo Yan
The Virtio input device invokes set_config() callback for retrieving the event configuration info, but the callback is not supported in vhost-user-base. This patch adds support set_config() callback in vhost-user-base. Signed-off-by: Leo Yan --- hw/virtio/vhost-user-base.c | 17

[PATCH v2 0/4] virtio: Refactor vhost input stub

2023-11-13 Thread Leo Yan
base. Based-on: <20231107180752.3458672-1-alex.ben...@linaro.org> Changes from v1: - Fixed typo in vhost-user-input.rst. - Updated MAINTAINERS for new added input document and changing folder for vhost-user-input.c. Leo Yan (4): hw/virtio: Support set_config() callback in vhost-user-base do

Re: [PATCH v1 3/4] hw/virtio: Move vhost-user-input into virtio folder

2023-11-13 Thread Leo Yan
Hi Manos, On Mon, Nov 13, 2023 at 09:24:09AM +0200, Manos Pitsidianakis wrote: > Hello Leo, > > On Mon, 13 Nov 2023 03:16, Leo Yan wrote: > > vhost-user-input is in the input folder. On the other hand, the folder > > 'hw/virtio' maintains other virtio

Re: [PATCH v1 2/4] docs/system: Add vhost-user-input documentation

2023-11-12 Thread Leo Yan
On Mon, Nov 13, 2023 at 09:16:40AM +0800, Leo Yan wrote: > This adds basic documentation for vhost-user-input. > > Signed-off-by: Leo Yan > --- > docs/system/devices/vhost-user-input.rst | 44 > docs/system/devices/vhost-user.rst | 2 +- >

[PATCH v1 3/4] hw/virtio: Move vhost-user-input into virtio folder

2023-11-12 Thread Leo Yan
vhost-user-input is in the input folder. On the other hand, the folder 'hw/virtio' maintains other virtio stubs (e.g. I2C, RNG, GPIO, etc). This patch moves vhost-user-input into the virtio folder for better code organization. No functionality change. Signed-off-by: Leo Yan ---

[PATCH v1 0/4] virtio: Refactor vhost input stub

2023-11-12 Thread Leo Yan
base. Based-on: <20231107180752.3458672-1-alex.ben...@linaro.org> Leo Yan (4): hw/virtio: Support set_config() callback in vhost-user-base docs/system: Add vhost-user-input documentation hw/virtio: Move vhost-user-input into virtio folder hw/virtio: derive vhost-user-input from vhost-use

[PATCH v1 4/4] hw/virtio: derive vhost-user-input from vhost-user-base

2023-11-12 Thread Leo Yan
or, remove the duplicate property from vhost-user-input-pci. Signed-off-by: Leo Yan --- hw/virtio/vhost-user-input-pci.c | 3 - hw/virtio/vhost-user-input.c | 114 +-- include/hw/virtio/virtio-input.h | 6 +- 3 files changed, 21 insertions(+), 102 deletions(-) di

[PATCH v1 2/4] docs/system: Add vhost-user-input documentation

2023-11-12 Thread Leo Yan
This adds basic documentation for vhost-user-input. Signed-off-by: Leo Yan --- docs/system/devices/vhost-user-input.rst | 44 docs/system/devices/vhost-user.rst | 2 +- 2 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 docs/system/devices/vhost

[PATCH v1 1/4] hw/virtio: Support set_config() callback in vhost-user-base

2023-11-12 Thread Leo Yan
The Virtio input device invokes set_config() callback for retrieving the event configuration info, but the callback is not supported in vhost-user-base. This patch adds support set_config() callback in vhost-user-base. Signed-off-by: Leo Yan --- hw/virtio/vhost-user-base.c | 17

Re: [PATCH] virtio: rng: Check notifier helpers for VIRTIO_CONFIG_IRQ_IDX

2023-10-25 Thread Leo Yan
On Thu, Oct 26, 2023 at 01:06:21PM +0800, Leo Yan wrote: > On Wed, Oct 25, 2023 at 11:18:41AM -0600, Mathieu Poirier wrote: > > Since the driver doesn't support interrupts, we must return early when > > index is set to VIRTIO_CONFIG_IRQ_IDX. Basically the same thin

Re: [PATCH] virtio: rng: Check notifier helpers for VIRTIO_CONFIG_IRQ_IDX

2023-10-25 Thread Leo Yan
otifier helpers for > VIRTIO_CONFIG_IRQ_IDX". > > Fixes: 544f0278afca ("virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX") > Signed-off-by: Mathieu Poirier Tested this patch and the vhost-user-i2c device works with it: Tested-by: Leo Yan

Re: [PATCH v1 2/2] xen_arm: Initialize RAM and add hi/low memory regions

2023-07-03 Thread Leo Yan
Hi Vikram, On Thu, Jun 29, 2023 at 10:43:10AM -0700, Oleksandr Tyshchenko wrote: [...] > void arch_handle_ioreq(XenIOState *state, ioreq_t *req) > { > hw_error("Invalid ioreq type 0x%x\n", req->type); > @@ -135,6 +170,14 @@ static void xen_arm_init(MachineState *machine) > > xam->s