Re: [RFC V2 0/8] Live update: tap and vhost

2025-07-18 Thread Lei Yang
Hi Steve I tested your patch which hit a problem under enable/disable nic mq state(The full test scenario is live migration vm at local under enable/disable vm nic mq state): Run command: /qemu-img info /home/images/vm1.qcow2 --output=json Error info: qemu-img: Could not open '/home/images/vm1.qco

Re: [PATCH v2] net/tap: drop too small packets

2025-07-18 Thread Lei Yang
Tested this patch v2 again,everything works fine. Tested-by: Lei Yang On Wed, Jul 16, 2025 at 3:29 PM Vladimir Sementsov-Ogievskiy < vsement...@yandex-team.ru> wrote: > Theoretically tap_read_packet() may return size less than > s->host_vnet_hdr_len, and next, we'll wor

Re: [PATCH RFC v2] virtio-net: Fix VLAN filter table reset timing

2025-07-15 Thread Lei Yang
Tested v2 again with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Mon, Jul 14, 2025 at 10:28 PM Konstantin Shkolnyy wrote: > > On 14-Jul-25 04:31, Akihiko Odaki wrote: > > Konstantin, I would also want you to test this new version. Please also > &

Re: [PATCH RFC] virtio-net: Fix VLAN filter table initialization timing

2025-07-15 Thread Lei Yang
Tested this patch with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Mon, Jul 14, 2025 at 5:34 AM Konstantin Shkolnyy wrote: > > On 13-Jul-25 06:52, Akihiko Odaki wrote: > > Konstantin, please see if this patch fixes your workload. > Yes, it does.

Re: [PATCH RFC v2 00/13] virtio: introduce support for GSO over UDP tunnel

2025-07-14 Thread Lei Yang
Hi Paolo Does the compile of this series of patches require support for a special kernel environment? I hit a compile issue after applied you patches: [1440/2928] Compiling C object libsystem.a.p/hw_virtio_vhost.c.o FAILED: libsystem.a.p/hw_virtio_vhost.c.o cc -m64 -Ilibsystem.a.p -I. -I.. -Isubpr

Re: [PATCH RFC v2 00/13] virtio: introduce support for GSO over UDP tunnel

2025-07-14 Thread Lei Yang
On Mon, Jul 14, 2025 at 5:05 PM Paolo Abeni wrote: > > On 7/14/25 10:43 AM, Lei Yang wrote: > > Does the compile of this series of patches require support for a > > special kernel environment? I hit a compile issue after applied you > > patches: > > [1440/2928] Co

Re: [PATCH 0/4] vhost: drop backend_features

2025-07-04 Thread Lei Yang
I tested this series of patches with virtio-net regression tests which were triggered because the virtio-net code was changed. Everything works fine. Tested-by: Lei Yang On Thu, Jul 3, 2025 at 8:55 PM Vladimir Sementsov-Ogievskiy wrote: > > This field is mostly unused and sometimes con

Re: [PATCH] net/tap: drop too small packets

2025-07-04 Thread Lei Yang
I tested this patch with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin wrote: > > On 7/3/25 1:55 PM, Vladimir Sementsov-Ogievskiy wrote: > > > Theoretically tap_read_packet() may return size

Re: [PATCH 0/8] net: Add passt netdev backend

2025-06-24 Thread Lei Yang
Because of these code changes the virtio-net files, CI triggers regression tests for it with virtio-net, everything works fine. Tested-by: Lei Yang On Tue, Jun 24, 2025 at 8:41 AM Jason Wang wrote: > > On Mon, Jun 23, 2025 at 4:10 PM Laurent Vivier wrote: > > > > On 23/06

Re: [PATCH v2] virtio-net: Add queues for RSS during migration

2025-06-03 Thread Lei Yang
Tested this series of patches with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Tue, Jun 3, 2025 at 11:01 AM Jason Wang wrote: > > On Fri, May 30, 2025 at 1:19 PM Akihiko Odaki > wrote: > > > > virtio_net_pre_load_queues() inspects vdev-&g

Re: [PATCH RFC v5 0/5] virtio-net: Offload hashing without eBPF

2025-06-03 Thread Lei Yang
Tested with this series of patches with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Fri, May 30, 2025 at 12:40 PM Akihiko Odaki wrote: > > I'm proposing to add a feature to offload virtio-net RSS/hash report to > Linux. This series contain patches

Re: [PATCH RFC 16/16] net: make vhost-net aware of GSO over UDP tunnel hdr layout

2025-05-27 Thread Lei Yang
Tested this series of patches with vhost-net regression tests, everything works fine. Tested-by: Lei Yang On Fri, May 23, 2025 at 4:24 PM Akihiko Odaki wrote: > > On 2025/05/21 20:34, Paolo Abeni wrote: > > When the GSO over UDP tunnel offload is enabled, the virtio net > &g

Re: [PATCH v4 0/7] Move memory listener register to vhost_vdpa_init

2025-05-13 Thread Lei Yang
Tested pass with vhost_vdpa device's regression tests. Tested-by: Lei Yang On Thu, May 8, 2025 at 2:47 AM Jonah Palmer wrote: > > Current memory operations like pinning may take a lot of time at the > destination. Currently they are done after the source of the migration is

Re: [PATCH] virtio-net: Add queues for RSS during migration

2025-05-13 Thread Lei Yang
I tested this patch with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Sat, May 10, 2025 at 3:25 PM Akihiko Odaki wrote: > > virtio_net_pre_load_queues() inspects vdev->guest_features to tell if > VIRTIO_NET_F_RSS or VIRTIO_NET_F_MQ is enabled

Re: [PATCH v2] virtio-net: Copy received packet to buffer

2025-04-26 Thread Lei Yang
QE tested this patch's v2 with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Thu, Apr 24, 2025 at 11:49 PM Antoine Damhet wrote: > > On Thu, Apr 24, 2025 at 06:49:57PM +0900, Akihiko Odaki wrote: > > Commit e28fbd1c525d ("Revert "virtio-n

Re: [PATCH v5 0/3] vhost: fix the IO error after live migration

2025-04-17 Thread Lei Yang
I tested this series of patches v5 with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Wed, Apr 16, 2025 at 10:49 AM Haoqian He wrote: > > At the end of the VM live migration, the vhost device will be stopped. > Currently, if the vhost-user backend crash

Re: [PATCH v7 1/4] vhost_vdpa : Add a new parameter to enable check mac address

2025-04-17 Thread Lei Yang
I tested this series of patches v7 with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Thu, Apr 17, 2025 at 6:26 PM Cindy Lu wrote: > > When using a VDPA device, it's important to ensure that the MAC > address is correctly set. > This patch adds a

Re: [PATCH v3 0/3] vhost: fix the IO error after live migration

2025-04-05 Thread Lei Yang
QE tested this series v3 with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Thu, Mar 27, 2025 at 2:46 PM Haoqian He wrote: > At the end of the VM live migration, the vhost device will be stopped. > Currently, if the vhost-user backend crashes, vhost de

Re: [PATCH v5 2/4] virtio_net: Add the check for vdpa's mac address

2025-04-05 Thread Lei Yang
QE tested this series of patches with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Wed, Mar 26, 2025 at 9:21 PM Cindy Lu wrote: > When using a VDPA device, it is important to ensure that the MAC > address is correctly set. The MAC address in the hardware

Re: [PATCH v3 0/7] Move memory listener register to vhost_vdpa_init

2025-04-04 Thread Lei Yang
On Thu, Mar 20, 2025 at 11:48 PM Dragos Tatulea wrote: > > Hi Lei, > > On 03/20, Lei Yang wrote: > > Hi Dragos, Si-Wei > > > > 1. I applied [0] [1] [2] to the downstream kernel then tested > > hotplug/unplug, this bug still exists. > > > > [0] 3

Re: [PATCH v2] virtio-net: Fix the interpretation of max_tx_vq

2025-03-24 Thread Lei Yang
QE tested this patch with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Sat, Mar 22, 2025 at 2:48 PM Akihiko Odaki wrote: > > virtio-net uses the max_tx_vq field of struct virtio_net_rss_config to > determine the number of queue pairs and emits an erro

Re: [PATCH v3 0/7] Move memory listener register to vhost_vdpa_init

2025-03-20 Thread Lei Yang
On Wed, Mar 19, 2025 at 8:14 AM Si-Wei Liu wrote: > > Hi Lei, > > On 3/18/2025 7:06 AM, Lei Yang wrote: > > On Tue, Mar 18, 2025 at 10:15 AM Jason Wang wrote: > >> On Tue, Mar 18, 2025 at 9:55 AM Lei Yang wrote: > >>> Hi Jonah > >>> > >>>

Re: [PATCH v3 0/7] Move memory listener register to vhost_vdpa_init

2025-03-18 Thread Lei Yang
On Tue, Mar 18, 2025 at 10:15 AM Jason Wang wrote: > > On Tue, Mar 18, 2025 at 9:55 AM Lei Yang wrote: > > > > Hi Jonah > > > > I tested this series with the vhost_vdpa device based on mellanox > > ConnectX-6 DX nic and hit the host kernel crash. This problem

Re: [PATCH v3 0/7] Move memory listener register to vhost_vdpa_init

2025-03-17 Thread Lei Yang
Hi Jonah I tested this series with the vhost_vdpa device based on mellanox ConnectX-6 DX nic and hit the host kernel crash. This problem can be easier to reproduce under the hotplug/unplug device scenario. For the core dump messages please review the attachment. FW version: # flint -d :0d:00.

Re: [PATCH RFC v4 00/11] virtio-net: Offload hashing without eBPF

2025-03-17 Thread Lei Yang
QE tested this RFC series of patches with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Thu, Mar 13, 2025 at 2:56 PM Akihiko Odaki wrote: > > I'm proposing to add a feature to offload virtio-net RSS/hash report to > Linux. This series contain patches

Re: [PATCH 0/3] vhost: fix the IO error after live migration

2025-03-11 Thread Lei Yang
QE tested this series of patches with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Sun, Mar 9, 2025 at 5:09 PM Haoqian He wrote: > > At the end of the VM live migration, the vhost device will be stopped. > Currently, if the vhost-user backend crash, vhost

Re: [PATCH] vhost: Don't set vring call if guest notifier is disabled

2025-02-28 Thread Lei Yang
I tested this patch with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Tue, Feb 18, 2025 at 8:04 PM Stefano Garzarella wrote: > > On Tue, Feb 18, 2025 at 04:32:08PM +0800, oen...@gmail.com wrote: > >From: Huaitong Han > > > >The vring call

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-15 Thread Lei Yang
On Fri, Feb 14, 2025 at 9:02 PM Konstantin Shkolnyy wrote: > > On 2/13/2025 20:24, Lei Yang wrote: > > I tested this patch with vdpa's regression tests, everything works fine. > > > > Tested-by: Lei Yang > > Could you point me to those tests? Sure, the te

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-13 Thread Lei Yang
I tested this patch with vdpa's regression tests, everything works fine. Tested-by: Lei Yang On Thu, Feb 13, 2025 at 2:51 PM Eugenio Perez Martin wrote: > > On Wed, Feb 12, 2025 at 5:49 PM Konstantin Shkolnyy > wrote: > > > > VDPA didn't work on a big-endian m

Re: [PATCH 0/4] Handling aliased guest memory maps in vhost-vDPA SVQs

2025-02-13 Thread Lei Yang
I tested this series patches with vdpa's regression tests, everything works fine. Tested-by: Lei Yang On Wed, Feb 12, 2025 at 12:20 AM Eugenio Perez Martin wrote: > > On Wed, Feb 5, 2025 at 3:58 PM Jonah Palmer wrote: > > > > An issue arises from aliased memory mappi

Re: [PATCH] virtio-net: Fix num_buffers for version 1

2025-01-09 Thread Lei Yang
I tested this patch with virtio-net regression tests and tests "mrg_rxbuf" on/off status with netperf tests, everything works fine. Tested-by: Lei Yang On Wed, Jan 8, 2025 at 8:23 PM Akihiko Odaki wrote: > > The specification says the device MUST set num

Re: [PATCH v4 4/4] virtio: Convert feature properties to OnOffAuto

2025-01-09 Thread Lei Yang
I tested this series of patches v4 with virtio-net regression tests, everything works fine. And the qemu core dump issues that hit it on v3 have gone. Tested-by: Lei Yang On Wed, Jan 8, 2025 at 2:18 PM Akihiko Odaki wrote: > > Some features are not always available with vhost. Legacy fe

Re: [PATCH v8 0/9] virtio-net: add support for SR-IOV emulation

2025-01-07 Thread Lei Yang
I tested this series of patches with virtio-net regression tests and basic scenario tests (reboot, shutdown, jumbo) for vf, everything works fine. Tested-by: Lei Yang On Sat, Jan 4, 2025 at 4:02 PM Akihiko Odaki wrote: > > Based-on: <20250104-reuse-v18-0-c349eafd8...@daynix.com> &g

Re: [PATCH v3 3/3] virtio: Convert feature properties to OnOffAuto

2025-01-06 Thread Lei Yang
Hi Akihiko I hit qemu core dump when I tested this series of patches with virtio-net regression tests, and based on the test result this bug can be reproduced by just booting a guest. For the details of core dump info please review the attachment. Regards Lei On Sat, Jan 4, 2025 at 3:37 PM Akih

Re: [PATCH v2 2/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()

2025-01-06 Thread Lei Yang
I tested this series of patches with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Sat, Jan 4, 2025 at 4:05 PM Akihiko Odaki wrote: > > g_spawn_sync() gives an informative message if it fails to execute > the script instead of reporting exiting

Re: [PATCH v3 0/2] Move net backend cleanup to NIC cleanup

2025-01-06 Thread Lei Yang
I tested this series of patches with virtio-net regression tests,everything works fine. Tested-by: Lei Yang On Mon, Jan 6, 2025 at 11:57 PM Jonah Palmer wrote: > > Commit a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net > structures if peer nic is present") effe

Re: [PATCH v4 1/2] virtio-net: Convert feature properties to OnOffAuto

2025-01-05 Thread Lei Yang
On Sat, Jan 4, 2025 at 3:50 PM Akihiko Odaki wrote: > > Some features are not always available, and virtio-net used to disable > them when not available even if the corresponding properties were > explicitly set to "on". > > Convert feature properties to OnOffAuto so that the user can explicitly >

Re: [PATCH v2 00/24] More Property cleanups

2024-12-18 Thread Lei Yang
I tested this series v2 with regression tests, due to this series changing some files about virtio-net, everything works fine. Tested-by: Lei Yang On Wed, Dec 18, 2024 at 9:44 PM Richard Henderson wrote: > > - Missed constifying two arrays. > - Eliminate all empty Property lists. &

Re: [PATCH] virtio-net: vhost-user: Implement internal migration

2024-12-18 Thread Lei Yang
I tested this patch with virtio-net regression tests,everything works fine. Tested-by: Lei Yang On Wed, Dec 18, 2024 at 10:36 PM Laurent Vivier wrote: > > Add support of VHOST_USER_PROTOCOL_F_DEVICE_STATE in virtio-net > with vhost-user backend. > > Cc: Hanna Czenczek

Re: [PATCH] include: Rename sysemu/ -> system/

2024-12-04 Thread Lei Yang
I tested this patch with virtio-net regression tests, these changes are working fine related to the virtio-net part. Tested-by: Lei Yang On Wed, Dec 4, 2024 at 2:27 AM Richard Henderson wrote: > > On 12/3/24 11:24, Philippe Mathieu-Daudé wrote: > > Headers in include/sysemu/

Re: [PATCH v4 2/4] virtio_net: Add the check for vdpa's mac address

2024-11-26 Thread Lei Yang
ip from the dhcp server. 3. Re-setup mac address and boot again this guest, it will fail with: vDPA device's mac 00:11:22:33:44:66not same with the cmdline's mac 00:11:22:33:44:55,Please check. Tested-by: Lei Yang On Sat, Nov 9, 2024 at 2:34 PM Cindy Lu wrote: > > When using a V

Re: [PATCH v3 0/6] virtio-net fixes

2024-11-25 Thread Lei Yang
QE tested this series patches with regression tests, everything works well. Tested-by: Lei Yang On Fri, Nov 22, 2024 at 1:04 PM Akihiko Odaki wrote: > > Most of this series are fixes for software RSS and hash reporting, which > should have no production user. > > Howev

Re: [RFC v2] virtio-net: check the mac address for vdpa device

2024-07-15 Thread Lei Yang
Hi Cindy If needed, QE can help test this MR before merging into the master branch. Best Regards Lei On Tue, Jul 16, 2024 at 9:14 AM Cindy Lu wrote: > > When using a VDPA device, it is important to ensure that the MAC address > in the hardware matches the MAC address from the QEMU command line

Re: [RFC v3 0/6] virtio,vhost: Add VIRTIO_F_IN_ORDER support

2024-04-15 Thread Lei Yang
QE tested this series with packed=on/off, in_order=true and vhost=off under regression tests, everything are works fine. Tested-by: Lei Yang On Mon, Apr 8, 2024 at 11:34 PM Jonah Palmer wrote: > > The goal of these patches is to add support to a variety of virtio and > vhost device

Re: [PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

2024-04-14 Thread Lei Yang
QE tested this patch with regression tests, everything works fine. Tested-by: Lei Yang On Fri, Apr 12, 2024 at 2:37 PM Cindy Lu wrote: > > Hi All > I apologize for bothering you again > I send the new patch is because I found that the function > kvm_virtio_pci

Re: [PATCH v1 0/8] virtio, vhost: Add VIRTIO_F_NOTIFICATION_DATA support

2024-03-08 Thread Lei Yang
00/:00:01.3/:05:00.0/virtio1/features Tested-by: Lei Yang On Thu, Mar 7, 2024 at 7:18 PM Eugenio Perez Martin wrote: > > On Wed, Mar 6, 2024 at 8:34 AM Michael S. Tsirkin wrote: > > > > On Wed, Mar 06, 2024 at 08:07:31AM +0100, Eugenio Perez Martin wrote: > >

Re: [PATCH for 9.0 00/12] Map memory at destination .load_setup in vDPA-net migration

2023-12-24 Thread Lei Yang
QE tested this series with regression tests, there are no new regression issues. Tested-by: Lei Yang On Sat, Dec 16, 2023 at 1:28 AM Eugenio Pérez wrote: > > Current memory operations like pinning may take a lot of time at the > destination. Currently they are done after the sour

Re: [PATCH v4 01/13] vdpa: add VhostVDPAShared

2023-12-22 Thread Lei Yang
QE tested this series v4 with regression tests. It has fixed the qemu core issues that hit last time.And everything works fine. Tested-by: Lei Yang On Fri, Dec 22, 2023 at 1:43 AM Eugenio Pérez wrote: > > It will hold properties shared among all vhost_vdpa instances associated > wi

Re: [PATCH 9.0 00/13] Consolidate common vdpa members in VhostVDPAShared

2023-11-30 Thread Lei Yang
On Thu, Nov 30, 2023 at 3:38 PM Eugenio Perez Martin wrote: > > On Thu, Nov 30, 2023 at 4:22 AM Lei Yang wrote: > > > > Hi Eugenio > > > > QE performed regression testing after applying this patch. This series > > patch introduced a qemu core dump bug, for

Re: [PATCH 9.0 00/13] Consolidate common vdpa members in VhostVDPAShared

2023-11-29 Thread Lei Yang
Hi Eugenio QE performed regression testing after applying this patch. This series patch introduced a qemu core dump bug, for the core dump information please review the attached file. Tested-by: Lei Yang On Sat, Nov 25, 2023 at 1:14 AM Eugenio Pérez wrote: > > Current memory oper

Re: [PATCH 0/3] vhost: clean up device reset

2023-10-02 Thread Lei Yang
QE tested a regression testing on this series with vhost-vdpa device, everything is working fine. Tested-by: Lei Yang On Thu, Sep 28, 2023 at 6:40 PM Eugenio Perez Martin wrote: > > On Wed, Sep 27, 2023 at 9:27 PM Stefan Hajnoczi wrote: > > > > Stateful vhost device

Re: [PATCH v2 0/3] Follow VirtIO initialization properly at vdpa net cvq isolation probing

2023-09-20 Thread Lei Yang
QE tested this series with regression testing, everything works fine. Tested-by: Lei Yang On Sat, Sep 16, 2023 at 1:08 AM Eugenio Pérez wrote: > > This series solves a few issues. The most obvious is that the feature set was > done previous to ACKNOWLEDGE | DRIVER status bit set.

Re: [PATCH] vdpa net: zero vhost_vdpa iova_tree pointer at cleanup

2023-09-14 Thread Lei Yang
QE tested this patch with real nic,guest can works well after cancelling migration. Tested-by: Lei Yang On Thu, Sep 14, 2023 at 11:23 AM Jason Wang wrote: > > On Wed, Sep 13, 2023 at 8:34 PM Eugenio Pérez wrote: > > > > Not zeroing it causes a SIGSEGV if the live migratio

Re: [PATCH v3 0/5] Enable vdpa net migration with features depending on CVQ

2023-08-27 Thread Lei Yang
QE tested this series with MAC and MQ changes, and the guest migrated successfully with "x-svq=off" or without this parameter. Tested-by: Lei Yang On Tue, Aug 22, 2023 at 4:53 PM Eugenio Pérez wrote: > > At this moment the migration of net features that depends on CVQ is no

Re: [PATCH v3 0/4] Vhost-vdpa Shadow Virtqueue VLAN support

2023-08-02 Thread Lei Yang
QE tested v3 of this series using the test steps provided by Hawkins and everything works fine. Tested-by: Lei Yang On Sun, Jul 23, 2023 at 8:10 PM Hawkins Jiawei wrote: > > This series enables shadowed CVQ to intercept VLAN commands > through shadowed CVQ, update the virtio NIC dev

Re: [PATCH 0/4] Vhost-vdpa Shadow Virtqueue VLAN support

2023-07-20 Thread Lei Yang
QE tested this series patch with real hardware, it can support setup vlan for the nic, and the vlan id still can be found after finished migrate. In addition, this series patch also help to test another patch, can got the expect result. Tested-by: Lei Yang On Wed, Jul 19, 2023 at 6:54 PM

Re: [PATCH v3 0/8] vdpa: Send all CVQ state load commands in parallel

2023-07-20 Thread Lei Yang
() = 23296 us Case 2, applied this series Source: qemu-system-x86_64: vhost_vdpa_net_load() = 6558 us Dest: qemu-system-x86_64: vhost_vdpa_net_load() = 6539 us Tested-by: Lei Yang On Thu, Jul 20, 2023 at 6:54 AM Lei Yang wrote: > > On Wed, Jul 19, 2023 at 11:25 PM Hawkins Jiawei wrote: >

Re: [PATCH v3 0/8] vdpa: Send all CVQ state load commands in parallel

2023-07-19 Thread Lei Yang
On Wed, Jul 19, 2023 at 11:25 PM Hawkins Jiawei wrote: > > 在 2023/7/19 20:44, Lei Yang 写道: > > Hello Hawkins and Michael > > > > Looks like there are big changes about vp_vdpa, therefore, if needed, > > QE can test this series in QE's environment before the

Re: [PATCH v3 0/8] vdpa: Send all CVQ state load commands in parallel

2023-07-19 Thread Lei Yang
Hello Hawkins and Michael Looks like there are big changes about vp_vdpa, therefore, if needed, QE can test this series in QE's environment before the patch is merged, and provide the result. BR Lei On Wed, Jul 19, 2023 at 8:37 PM Hawkins Jiawei wrote: > > 在 2023/7/19 17:11, Michael S. Tsirkin

Re: [PATCH v3 0/3] vdpa: Return -EIO if device ack is VIRTIO_NET_ERR

2023-07-06 Thread Lei Yang
On Wed, Jul 5, 2023 at 7:03 PM Hawkins Jiawei wrote: > > On 2023/7/5 15:59, Lei Yang wrote: > > Hello Hawkins > > > > QE can help test this series before it is merged into master, I would > > like to know what test steps can cover this series related scenario? >

Re: [PATCH v3 0/3] vdpa: Return -EIO if device ack is VIRTIO_NET_ERR

2023-07-05 Thread Lei Yang
Hello Hawkins QE can help test this series before it is merged into master, I would like to know what test steps can cover this series related scenario? Thanks Lei On Tue, Jul 4, 2023 at 11:36 AM Hawkins Jiawei wrote: > > According to VirtIO standard, "The class, command and > command-specific

Re: [PATCH v3 0/2] vdpa: Refactor vdpa_feature_bits array

2023-07-02 Thread Lei Yang
QE tested this series with regression tests and live migration test on the vhost_vdpa device, there are no new problems. Tested-by: Lei Yang On Fri, Jun 30, 2023 at 9:27 PM Hawkins Jiawei wrote: > > This patchset removes the duplicated VIRTIO_NET_F_RSS entry > in vdpa_feature_bits

Re: [PATCH] vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices

2023-06-07 Thread Lei Yang
QE tested sanity testing for this patch on the vhost_vdpa device, everything works fine. Tested-by: Lei Yang On Tue, Jun 6, 2023 at 9:33 AM Jason Wang wrote: > > On Sat, Jun 3, 2023 at 1:33 AM Eugenio Pérez wrote: > > > > QEMU does not emulate it so it must be disabled as l

Re: [PATCH] vdpa: fix not using CVQ buffer in case of error

2023-06-07 Thread Lei Yang
QE tested sanity testing for this patch on the vhost_vdpa device, everything works fine. Tested-by: Lei Yang On Tue, Jun 6, 2023 at 9:32 AM Jason Wang wrote: > > On Sat, Jun 3, 2023 at 1:35 AM Eugenio Pérez wrote: > > > > Bug introducing when refactoring. Otherway, the gu

Re: [PATCH v2 1/3] vdpa: do not block migration if device has cvq and x-svq=on

2023-06-02 Thread Lei Yang
QE tested this series with vhost_vdpa and x-svq=on, guest can migrate and everything works well. Tested-by: Lei Yang On Fri, Jun 2, 2023 at 10:39 PM Eugenio Pérez wrote: > > It was a mistake to forbid in all cases, as SVQ is already able to send > all the CVQ messages before start f

Re: [PATCH v4 0/6] Vhost-vdpa Shadow Virtqueue Offloads support

2023-06-02 Thread Lei Yang
with features 0x4" after applied this series of patches. Tested-by: Lei Yang On Fri, Jun 2, 2023 at 7:55 PM Hawkins Jiawei wrote: > > This series enables shadowed CVQ to intercept Offloads commands > through shadowed CVQ, update the virtio NIC device model so qemu > send it in a migr

Re: [PATCH v4 0/2] Move ASID test to vhost-vdpa net initialization

2023-06-02 Thread Lei Yang
QE did a sanity test on v4 of this series using the vdpa_sim device,everything is working fine. Tested-by: Lei Yang On Fri, May 26, 2023 at 11:31 PM Eugenio Pérez wrote: > > QEMU v8.0 is able to switch dynamically between vhost-vdpa passthrough > and SVQ mode as long as the net device

Re: [PATCH v3 0/6] Vhost-vdpa Shadow Virtqueue Offloads support

2023-06-02 Thread Lei Yang
t;vdpa svq is not available for feature 4". [1] -device '{"driver": "virtio-net-pci", "mac": "00:11:22:33:44:00", "id": "net0", "netdev": "hostnet0", "ctrl_guest_offloads": true, "bus": &qu

Re: [PATCH v2 0/6] Vhost-vdpa Shadow Virtqueue Offloads support

2023-06-01 Thread Lei Yang
I'm a QE responsible for vhost_vdpa parts. Could you please provide me with the test steps for this series? I can test it in my environment and update the test results. On Thu, Jun 1, 2023 at 4:29 PM Hawkins Jiawei wrote: > > This series enables shadowed CVQ to intercept Offloads commands > t

Re: [PATCH v3 0/5] Move ASID test to vhost-vdpa net initialization

2023-05-16 Thread Lei Yang
QE tested this series with sanity testing on the vdpa_sim device, everything are works fine and there is no any new regression problems. Tested-by: Lei Yang On Tue, May 9, 2023 at 11:44 PM Eugenio Pérez wrote: > > QEMU v8.0 is able to switch dynamically between vhost-vdpa passthrough

Re: [PATCH RESEND] vhost: fix possible wrap in SVQ descriptor ring

2023-05-10 Thread Lei Yang
QE applied this patch to do sanity testing on vhost-vdpa, there is no any regression problem. Tested-by: Lei Yang On Wed, May 10, 2023 at 9:32 AM Lei Yang wrote: > QE applied this patch to do sanity testing on vhost-net, there is no > any regression problem. > > Tested-

Re: [PATCH RESEND] vhost: fix possible wrap in SVQ descriptor ring

2023-05-09 Thread Lei Yang
QE applied this patch to do sanity testing on vhost-net, there is no any regression problem. Tested-by: Lei Yang On Tue, May 9, 2023 at 1:28 AM Eugenio Perez Martin wrote: > > On Sat, May 6, 2023 at 5:01 PM Hawkins Jiawei wrote: > > > > QEMU invokes vhost_svq_add() whe

Re: [PATCH v5 00/14] Dynamically switch to vhost shadow virtqueues at vdpa net migration

2023-03-07 Thread Lei Yang
QE tested this series's V5 again. Creating two vdpa_sim device, and boot two VMs without shadow virtqueues. The migration was successful and everything worked fine. Tested-by: Lei Yang Eugenio Pérez 于2023年3月4日周六 01:24写道: > It's possible to migrate vdpa net devices if they are

Re: [PATCH v2 00/13] Dynamycally switch to vhost shadow virtqueues at vdpa net migration

2023-02-16 Thread Lei Yang
QE tested this series's v3 again. Creating two vdpa_sim devices, and boot two VMs without shadow virtqueues. The migration was successful and everything worked fine. Tested-by: Lei Yang Eugenio Perez Martin 于2023年2月16日周四 02:41写道: > > On Fri, Feb 10, 2023 at 1:58 PM Gautam D

Re: [PATCH] virtio-net: clear guest_announce feature if no cvq backend

2023-02-14 Thread Lei Yang
QE uses the sim_vdpa device to test this patch and add "ctrl_vq=off" in the qemu command line. Guest can find this device, there are no any error messages in guest dmesg, and can migrate successfully. Tested-by: Lei Yang Eugenio Perez Martin 于2023年2月14日周二 14:53写道: > > On Tue, J

Re: [PATCH v2 00/13] Dynamycally switch to vhost shadow virtqueues at vdpa net migration

2023-02-09 Thread Lei Yang
QE tested this series on the rhel. Creating two vdpa_sim devices, and boot two VMs without shadow vq. The migration was successful and everything worked fine Tested-by: Lei Yang Alvaro Karsz 于2023年2月8日周三 18:29写道: > > HI Eugenio, thanks for the series! > > I tested the series

Re: [PATCH 0/4] Endianess and coding style fixes for SVQ event idx support

2022-11-17 Thread Lei Yang
QE tries to test the parameter "event_idx=on". In both environments "virtio-vdpa + vp_vdpa" and "vhost_vdpa + vp_vdpa", there is no network connectivity issue after the guest boot up. Tested-by: Lei Yang > From: Jason Wang > Date: Tue, Nov 1, 2022 a

Re: [PULL 3/3] vdpa: Fix memory listener deletions of iova tree

2022-07-28 Thread Lei Yang
Jason Wang 于2022年7月28日周四 14:27写道: > On Thu, Jul 28, 2022 at 2:14 PM Lei Yang wrote: > > > > I tried to manually changed this line then test this branch on local > host. After the migration is successful, the qemu core dump occurs on the > shutdown inside guest. > &

Re: [PULL 3/3] vdpa: Fix memory listener deletions of iova tree

2022-07-27 Thread Lei Yang
ausing a mapping > with the same iova and device complains, if the next action is a map. > * Next unmap will cause to try to unmap again iova = 0, causing the > device to complain that no region was mapped at iova = 0. > > Fixes: 34e3c94edaef ("vdpa: Add custom IOTLB translatio