is no need to enable debugging mode in the kernel. This leads
> to
> hidden debugging. Our module supports all features of WinDbg regarding remote
> debugging, besides interception of events and exceptions. Only i386 is
> supported
> now.
>
> Changed in v4:
>
> - Add WinDbg
On Mon, Dec 11, 2017 at 2:21 PM, Mihail Abakumov
wrote:
> Added some helper features for windbgstub.
>
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> include/exec/windbgstub-utils.h | 31 +++
> include/e
ent formatting (Markus)
* Patch 3 - added reproducer info to commit message (Markus)
v2->v3:
* Added patch 4
v3->v4:
* Added forward decl of ivshmem_disable_irqfd() instead of moving
ivshmem_reset() (Eric, Markus)
Ladi Prosek (4):
ivshmem: Don't update non-existent MSI routes
ivshmem:
nd crash-reboot the guest by inducing a BSOD.
Signed-off-by: Ladi Prosek
---
hw/misc/ivshmem.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index d1bb246d12..9c7e74ef12 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -758,10 +758,14 @@ sta
again the Windows driver, at the time of writing
available at:
https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem
The issue is believed to have been masked by other guest drivers, notably
Linux ones, not enabling MSI-X on the device.
Signed-off-by: Ladi Prosek
Reviewed-by
able at:
https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem
The issue is believed to have been masked by other guest drivers, notably
Linux ones, not enabling MSI-X on the device.
Fixes: 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications")
Signed-off-by: Ladi
le.
Fixes: 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications")
Signed-off-by: Ladi Prosek
Reviewed-by: Markus Armbruster
---
hw/misc/ivshmem.c | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshm
On Fri, Dec 8, 2017 at 6:28 PM, Markus Armbruster wrote:
> Ladi Prosek writes:
>
>> On Fri, Dec 8, 2017 at 2:36 PM, Markus Armbruster wrote:
>>> Ladi Prosek writes:
>>>
>>>> The effects of ivshmem_enable_irqfd() was not undone on
On Fri, Dec 8, 2017 at 2:36 PM, Markus Armbruster wrote:
> Ladi Prosek writes:
>
>> The effects of ivshmem_enable_irqfd() was not undone on device reset.
>>
>> This manifested as:
>> ivshmem_add_kvm_msi_virq: Assertion `!s->msi_vectors[vector].pdev' faile
On Mon, Nov 20, 2017 at 1:49 PM, Ladi Prosek wrote:
> On Mon, Nov 20, 2017 at 10:07 AM, Ladi Prosek wrote:
>> On Sun, Nov 19, 2017 at 9:39 PM, wrote:
>>> I just updated to the latest build and applied this patch set, now on VM
>>> reset the qemu crashe
nd crash-reboot the guest by inducing a BSOD.
Signed-off-by: Ladi Prosek
---
hw/misc/ivshmem.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index d1bb246d12..4be0d2627b 100644
--- a/hw/misc/ivshmem.c
+++ b
ent formatting (Markus)
* Patch 3 - added reproducer info to commit message (Markus)
v2->v3:
* Added patch 4
Ladi Prosek (4):
ivshmem: Don't update non-existent MSI routes
ivshmem: Always remove irqfd notifiers
ivshmem: Improve MSI irqfd error handling
ivshmem: Disable irqfd on device
le.
Fixes: 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications")
Signed-off-by: Ladi Prosek
Reviewed-by: Markus Armbruster
---
hw/misc/ivshmem.c | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshm
again the Windows driver, at the time of writing
available at:
https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem
The issue is believed to have been masked by other guest drivers, notably
Linux ones, not enabling MSI-X on the device.
Signed-off-by: Ladi Prosek
Reviewed-by
able at:
https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem
The issue is believed to have been masked by other guest drivers, notably
Linux ones, not enabling MSI-X on the device.
Fixes: 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications")
Signed-off-by: Ladi
e. It
is however easy to fix and the expectation that the use and release notifier
invocations
are always balanced is very natural.
Signed-off-by: Ladi Prosek
---
v1->v2:
* fixed typo in commit message "or" -> "to" (Marcel)
* directly set msix_function_ma
On Thu, Dec 7, 2017 at 7:27 PM, Michael S. Tsirkin wrote:
> On Wed, Nov 22, 2017 at 03:22:50PM +0200, Marcel Apfelbaum wrote:
>> On 22/11/2017 14:32, Ladi Prosek wrote:
>> > On Wed, Nov 22, 2017 at 11:46 AM, Marcel Apfelbaum
>> > wrote:
>> > > Hi Ladi,
On Wed, Dec 6, 2017 at 10:00 AM, Mihail Abakumov
wrote:
> Ladi Prosek писал 2017-11-29 11:14:
>
>> On Tue, Nov 21, 2017 at 3:10 PM, Mihail Abakumov
>> wrote:
>>>
>>> Signed-off-by: Mihail Abakumov
>>> Signed-off-by: Pavel Dovgalyuk
>>> Sign
On Wed, Dec 6, 2017 at 8:29 AM, Mihail Abakumov
wrote:
> Ladi Prosek писал 2017-11-29 10:13:
>
>> On Tue, Nov 21, 2017 at 3:10 PM, Mihail Abakumov
>> wrote:
>>>
>>> Added handler registration of gdb debug exception. Its exception also can
>>> be u
This key tends to be located somewhere between right Alt and right
Ctrl and is usually used for opening context menus.
Signed-off-by: Ladi Prosek
---
hw/input/virtio-input-hid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c
index
t of the new api functions from the WinDbg v10.
>
> Changed in v2:
>
> - Move target specific code in the 'target/' directory. (Alistair Francis)
> - Change 'kd_api_fill_memory'. Made a fill of memory by line segments.
> Before that, a full array was immediately
On Tue, Nov 21, 2017 at 3:10 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> include/exec/windbgstub-utils.h |1 +
> windbgstub-utils.c | 22 ++
> windbgstub.c
On Tue, Nov 21, 2017 at 3:11 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> include/exec/windbgstub-utils.h |1 +
> windbgstub-utils.c | 12
> windbgstub.c
On Tue, Nov 21, 2017 at 3:11 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> include/exec/windbgstub-utils.h |1 +
> windbgstub-utils.c | 33 +
> windbgstub
On Tue, Nov 21, 2017 at 3:11 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> include/exec/windbgstub-utils.h |2
> target/i386/windbgstub.c| 319
> +++
> win
On Tue, Nov 21, 2017 at 3:10 PM, Mihail Abakumov
wrote:
> Added handler registration of gdb debug exception. Its exception also can be
> used for windbg.
>
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> cpus.c | 1
On Tue, Nov 21, 2017 at 3:09 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> target/i386/windbgstub.c | 96
> ++
> 1 file changed, 96 insertions(+)
>
> diff --g
On Tue, Nov 21, 2017 at 3:08 PM, Mihail Abakumov
wrote:
> Defined useful sized data buffer. It contains pointer to data and size of
> this data. Also, defined some macros for init and free.
>
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
>
On Tue, Nov 21, 2017 at 3:08 PM, Mihail Abakumov
wrote:
> Added structures for parsing data stream from windbg to packet.
>
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> include/exec/windbgstub-utils.h | 11 +++
> windbgst
On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov
wrote:
> Added useful name arrays of some defines. Not used yet. Needs for the future.
>
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> include/exec/windbgkd.h | 75
> ++
On Tue, Nov 21, 2017 at 3:11 PM, Mihail Abakumov
wrote:
[...]
> diff --git a/windbgstub.c b/windbgstub.c
> index 36372c0ea5..3bcf6a8cbb 100755
> --- a/windbgstub.c
> +++ b/windbgstub.c
> @@ -224,6 +224,14 @@ static void
> windbg_process_manipulate_packet(ParsingContext *ctx)
> kd_api_que
On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> Makefile.target |7 +++
> include/exec/windbgstub-utils.h | 18 ++
> include/exec/windbg
On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov
wrote:
> Added some helper features for windbgstub.
>
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> include/exec/windbgstub-utils.h | 27 +++
> include/exec/
On Wed, Nov 22, 2017 at 11:46 AM, Marcel Apfelbaum wrote:
> Hi Ladi,
>
> On 20/11/2017 16:22, Ladi Prosek wrote:
>>
>> msix_mask_all() is supposed to invoke the release vector notifier if the
>> state of the
>> respective vector changed from unmasked or masked.
evice. It
is however easy to fix and the expectation that the use and release notifier
invocations
are always balanced is very natural.
Signed-off-by: Ladi Prosek
---
hw/pci/msix.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/pci/msix.c b/hw/pci/msix.c
index c944c
On Mon, Nov 20, 2017 at 10:07 AM, Ladi Prosek wrote:
> On Sun, Nov 19, 2017 at 9:39 PM, wrote:
>> I just updated to the latest build and applied this patch set, now on VM
>> reset the qemu crashes with the following assert:
>>
>> ivshmem.c:467: ivshmem_add_kvm
serts too. Even with v1 on top of QEMU v2.10.0 so I must have
missed something.
Looking. And, needless to say, these patches should not be applied just yet :)
Thanks!
Ladi
> On 2017-11-15 18:31, Ladi Prosek wrote:
>>
>> Fixes bugs in the ivshmem device implementation uncovered
able at:
https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem
The issue is believed to have been masked by other guest drivers, notably
Linux ones, not enabling MSI-X on the device.
Fixes: 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications")
Signed-off-by: Ladi
again the Windows driver, at the time of writing
available at:
https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem
The issue is believed to have been masked by other guest drivers, notably
Linux ones, not enabling MSI-X on the device.
Signed-off-by: Ladi Prosek
Reviewed-by
ent formatting (Markus)
* Patch 3 - added reproducer info to commit message (Markus)
Ladi Prosek (3):
ivshmem: Don't update non-existent MSI routes
ivshmem: Always remove irqfd notifiers
ivshmem: Improve MSI irqfd error handling
hw/misc/ivshme
le.
Fixes: 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications")
Signed-off-by: Ladi Prosek
Reviewed-by: Markus Armbruster
---
hw/misc/ivshmem.c | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshm
On Mon, Nov 13, 2017 at 3:36 PM, Markus Armbruster wrote:
> Ladi Prosek writes:
>
>> As of commit 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications"),
>> QEMU crashes with:
>>
>> ivshmem: msix_set_vector_notifiers failed
>&g
On Mon, Nov 13, 2017 at 3:22 PM, Markus Armbruster wrote:
> Ladi Prosek writes:
>
>> As of commit 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications"),
>> QEMU crashes with:
>>
>> kvm_irqchip_commit_routes: Assertion `ret == 0' failed.
&
On Wed, Nov 8, 2017 at 3:28 PM, Mihail Abakumov
wrote:
> Ladi Prosek писал 2017-11-08 16:43:
>
>> On Wed, Nov 8, 2017 at 12:54 PM, Mihail Abakumov
>> wrote:
>>>
>>> Ladi Prosek писал 2017-11-06 18:15:
>>>
>>> In your case windbg does not sen
endor_id = ...
to virtio_pci_class_init(). Except for the problematic statement deleted by this
patch, which reverts the Subsystem Vendor ID back to 0x1af4 for legacy devices
for
no good reason.
Signed-off-by: Ladi Prosek
---
v1->v2:
* Added a comment about the default Subsystem Vendor ID.
hw/virtio/virtio-
le.
Fixes: 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications")
Signed-off-by: Ladi Prosek
---
hw/misc/ivshmem.c | 30 --
1 file changed, 24 insertions(+), 6 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 6e46669744..493a50
Adds a rollback path to ivshmem_enable_irqfd() and fixes
ivshmem_disable_irqfd() to bail if irqfd has not been enabled.
Signed-off-by: Ladi Prosek
---
hw/misc/ivshmem.c | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/hw/misc/ivshmem.c
Fixes bugs in the ivshmem device implementation uncovered with the new
Windows ivshmem driver:
https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem
Ladi Prosek (3):
ivshmem: Don't update non-existent MSI routes
ivshmem: Always remove irqfd notifiers
ivshmem: Im
ed and leads to output
like:
Too many eventfd received, device has 1 vectors
Fixes: 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications")
Signed-off-by: Ladi Prosek
---
hw/misc/ivshmem.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/hw
On Wed, Nov 8, 2017 at 12:54 PM, Mihail Abakumov
wrote:
> Ladi Prosek писал 2017-11-06 18:15:
>
>> On Mon, Oct 23, 2017 at 10:31 AM, Ladi Prosek wrote:
>>>
>>> On Tue, Oct 17, 2017 at 3:08 PM, Mihail Abakumov
>>> wrote:
>>>>
>>>> An
On Mon, Nov 6, 2017 at 5:51 PM, Michael S. Tsirkin wrote:
> On Mon, Nov 06, 2017 at 10:02:54AM +0100, Ladi Prosek wrote:
>> On Fri, Nov 3, 2017 at 4:11 PM, Michael S. Tsirkin wrote:
>> > On Fri, Nov 03, 2017 at 09:23:07AM +0100, Ladi Prosek wrote:
>> >> On Fri
On Mon, Nov 6, 2017 at 7:41 PM, Andrew Baumann
wrote:
> Hi,
>
> I just noticed this thread, and the problem sounded very familiar...
>
>> From: Ladi Prosek
>> Sent: Monday, 6 November 2017 07:16
> [...]
>> FS base passes all the checks in windbg_on_load() as
On Mon, Oct 23, 2017 at 10:31 AM, Ladi Prosek wrote:
> On Tue, Oct 17, 2017 at 3:08 PM, Mihail Abakumov
> wrote:
>> An update of:
>>
>> v1:
>> https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07092.html
>>
>> We made the debugger modu
On Fri, Nov 3, 2017 at 4:11 PM, Michael S. Tsirkin wrote:
> On Fri, Nov 03, 2017 at 09:23:07AM +0100, Ladi Prosek wrote:
>> On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffmann wrote:
>> >
>> >> > > Signed-off-by: Ladi Prosek
>> >> >
>> >&g
On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffmann wrote:
>
>> > > Signed-off-by: Ladi Prosek
>> >
>> > I wonder whether it's a problem that legacy devices ignore
>> > the subsystem ID (that's part of spec).
>>
>> I don't un
On Thu, Nov 2, 2017 at 3:52 PM, Michael S. Tsirkin wrote:
> On Thu, Nov 02, 2017 at 02:31:15PM +0100, Ladi Prosek wrote:
>> The statement being removed doesn't change anything as virtio PCI devices
>> already
>> have Subsystem Vendor ID set to pci_default_sub_v
endor_id = ...
to virtio_pci_class_init(). Except for the problematic statement deleted by this
patch, which reverts the Subsystem Vendor ID back to 0x1af4 for legacy devices
for
no good reason.
Signed-off-by: Ladi Prosek
---
hw/virtio/virtio-pci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/virtio
c code in the 'target/' directory. (Alistair Francis)
> - Change 'kd_api_fill_memory'. Made a fill of memory by line segments.
> Before that, a full array was immediately collected and written in RAM. (Ladi
> Prosek)
> - Change 'kd_api_search_memory&#
On Thu, Oct 19, 2017 at 11:41 AM, wrote:
> On 2017-10-19 20:07, ge...@hostfission.com wrote:
>>
>> On 2017-10-19 20:01, Ladi Prosek wrote:
>>>
>>> On Thu, Oct 19, 2017 at 10:44 AM, wrote:
>>>>
>>>> On 2017-10-19 19:35, Ladi Prosek
On Thu, Oct 19, 2017 at 10:44 AM, wrote:
> On 2017-10-19 19:35, Ladi Prosek wrote:
>>
>> On Wed, Oct 18, 2017 at 5:04 PM, wrote:
>>>
>>> Hi Ladi & Yan,
>>>
>>> I am pleased to present the completed driver for review, please see:
&g
On Wed, Oct 18, 2017 at 5:04 PM, wrote:
> Hi Ladi & Yan,
>
> I am pleased to present the completed driver for review, please see:
>
> https://github.com/gnif/kvm-guest-drivers-windows
Awesome!
Feel free to open pull request, it should be easier to comment on.
* WoW considerations: It would be
On Wed, Oct 18, 2017 at 8:56 AM, wrote:
> On 2017-10-18 17:50, Ladi Prosek wrote:
>>
>> On Wed, Oct 18, 2017 at 7:50 AM, wrote:
>>>
>>> On 2017-10-18 16:31, Ladi Prosek wrote:
>>>>
>>>>
>>>> Hi Geoff,
>>>&g
On Wed, Oct 18, 2017 at 7:50 AM, wrote:
> On 2017-10-18 16:31, Ladi Prosek wrote:
>>
>> Hi Geoff,
>>
>> On Mon, Oct 16, 2017 at 8:31 PM, wrote:
>>>
>>> Hi Yan & Ladi.
>>>
>>> I have written an initial implementation that supp
Hi Geoff,
On Mon, Oct 16, 2017 at 8:31 PM, wrote:
> Hi Yan & Ladi.
>
> I have written an initial implementation that supports just the shared
> memory
> mapping at this time. I plan to add events also but before I go further I
> would
> like some feedback if possible on what I have implemented t
Thanks to Laszlo Ersek for spotting the double semicolon in target/i386/kvm.c
I have trivially grepped the tree for ';;' in C files.
Suggested-by: Laszlo Ersek
Signed-off-by: Ladi Prosek
---
hw/misc/imx6_ccm.c | 2 +-
hw/s390x/virtio-ccw.c | 2 +-
linux-user/signal.c| 2 +-
Hi,
On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov
wrote:
> We made the debugger module WinDbg (like GDB) for QEMU. This is the
> replacement of the remote stub in Windows kernel. Used for remote Windows
> kernel debugging without debugging mode.
>
> WinDbg is a multipurpose debugger for the
On Tue, Sep 26, 2017 at 1:08 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> include/exec/windbgstub-utils.h |1 +
> windbgstub-utils.c | 36
> windbgs
On Tue, Sep 26, 2017 at 1:07 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> include/exec/windbgstub-utils.h |1 +
> windbgstub-utils.c | 30 ++
> windbgstub.c
On Tue, Sep 26, 2017 at 1:07 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> include/exec/windbgstub-utils.h |2 ++
> windbgstub-utils.c | 28
> windbgstub.c
On Tue, Sep 26, 2017 at 1:07 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> windbgstub-utils.c | 60
>
> 1 file changed, 60 insertions(+)
>
> diff --g
On Tue, Sep 26, 2017 at 1:06 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> windbgstub-utils.c | 38 ++
> 1 file changed, 38 insertions(+)
>
> diff --git a/windbgstub-u
On Tue, Sep 26, 2017 at 1:06 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> windbgstub-utils.c | 90
> +++-
> 1 file changed, 89 insertions(+), 1 deletion(
nit: The subject line has "kd_api_read_virtual_memory" twice in it.
Was probably meant to be
[PATCH 22/43] windbg: implemented kd_api_read_virtual_memory and
kd_api_write_virtual_memory
On Tue, Sep 26, 2017 at 1:06 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pa
On Tue, Sep 26, 2017 at 1:05 PM, Mihail Abakumov
wrote:
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> windbgstub.c | 26 +-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/windbgstub.c b/
On Tue, Sep 26, 2017 at 1:05 PM, Mihail Abakumov
wrote:
> Defined useful sized data buffer. It contains pointer to data and size of
> this data. Also, defined some macroses for init and free.
"macros" instead of "macroses", same in patch 31.
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pa
On Tue, Sep 26, 2017 at 1:05 PM, Mihail Abakumov
wrote:
> Defined useful sized data buffer. It contains pointer to data and size of
> this data. Also, defined some macroses for init and free.
"macros" instead of "macroses", same in patch 31.
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pa
On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov
wrote:
> Added handler of fs/gs register. It tries to find and check KPCR and version
> address.
>
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> include/exec/windbgstub-utils.h |
On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov
wrote:
> Inserted hook to wrmsr operation. Windows Kernel put address on KPCR struct
> to fs/gs (x32/x64) register. Needs catch this moment and allow windbg server
> handle packets.
>
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgal
On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov
wrote:
> Added chardev for listening to windbg. Target device is a parameter in the
> '-windbg' option.
>
> Signed-off-by: Mihail Abakumov
> Signed-off-by: Pavel Dovgalyuk
> Signed-off-by: Dmitriy Koltunov
> ---
> windbgstub.c | 26 ++
On Thu, Sep 14, 2017 at 7:59 AM, Ladi Prosek wrote:
> On Fri, Jul 21, 2017 at 5:21 PM, Stefan Hajnoczi wrote:
>> On Mon, Jul 17, 2017 at 10:11:43AM +0200, Ladi Prosek wrote:
>>> Output like "Virtqueue size exceeded" is not much useful in identifying the
>&
On Fri, Jul 21, 2017 at 5:21 PM, Stefan Hajnoczi wrote:
> On Mon, Jul 17, 2017 at 10:11:43AM +0200, Ladi Prosek wrote:
>> Output like "Virtqueue size exceeded" is not much useful in identifying the
>> culprit. This series beefs up virtio_error to print the virtio d
>
> Based on a patch from Marc.
> Added property to enable/disable wheel axis.
> TODO: add compat properties for old machine types.
>
> Cc: Marc-André Lureau
> Signed-off-by: Gerd Hoffmann
Verified that the Windows driver correctly handles axis-based wheel. Thanks!
Tested-by: Ladi Prosek
On Mon, Aug 7, 2017 at 4:19 PM, David Hildenbrand wrote:
> On 07.08.2017 10:57, Ladi Prosek wrote:
>> Switch is easier on the eye and might lead to better codegen.
>>
>> Signed-off-by: Ladi Prosek
>> ---
>> target/i386/kvm.c | 75
>> ++
AX[11] and
CPUID.4003H:EDX[8] as specified in the Hyper-V TLFS and experimentally
verified on a Hyper-V host. The feature is enabled with the existing hv-time CPU
flag, and only if the TSC frequency is stable across migrations and known.
Signed-off-by: Ladi Prosek
---
target/i386/
Timing-related Hyper-V enlightenments will benefit from knowing the final
tsc_khz value. This commit just moves the code in preparation for further
changes.
Signed-off-by: Ladi Prosek
---
target/i386/kvm.c | 38 +++---
1 file changed, 19 insertions(+), 19
Switch is easier on the eye and might lead to better codegen.
Signed-off-by: Ladi Prosek
---
target/i386/kvm.c | 75 +++
1 file changed, 31 insertions(+), 44 deletions(-)
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index 6db7783
only if the TSC frequency is stable across
migration and known, as suggested by Paolo.
v1->v2:
* deleted an extra empty line in patch 1
* added patch 3 introducing a helper function for the "TSC is stable and
known" check (David)
Ladi Prosek (4):
i386/kvm: use a switch stat
Move the "is TSC stable and known" condition to a reusable helper.
Signed-off-by: Ladi Prosek
---
target/i386/kvm.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index 15d56ae..2dc01c9 100644
--- a/target/
On Fri, Aug 4, 2017 at 3:39 PM, David Hildenbrand wrote:
> On 04.08.2017 11:14, Ladi Prosek wrote:
>> As of kernel commit eb82feea59d6 ("KVM: hyperv: support
>> HV_X64_MSR_TSC_FREQUENCY
>> and HV_X64_MSR_APIC_FREQUENCY"), KVM supports two new MSRs which are require
Timing-related Hyper-V enlightenments will benefit from knowing the final
tsc_khz value. This commit just moves the code in preparation for further
changes.
Signed-off-by: Ladi Prosek
---
target/i386/kvm.c | 38 +++---
1 file changed, 19 insertions(+), 19
only if the TSC frequency is stable across
migration and known, as suggested by Paolo.
Ladi Prosek (3):
i386/kvm: use a switch statement for MSR detection
i386/kvm: set tsc_khz before configuring Hyper-V CPUID
i386/kvm: advertise Hyper-V frequency MSRs
target/i386/kvm.c | 130
AX[11] and
CPUID.4003H:EDX[8] as specified in the Hyper-V TLFS and experimentally
verified on a Hyper-V host. The feature is enabled with the existing hv-time CPU
flag, and only if the TSC frequency is stable across migration and known.
Signed-off-by: Ladi Prosek
---
target/i386/
Switch is easier on the eye and might lead to better codegen.
Signed-off-by: Ladi Prosek
---
target/i386/kvm.c | 76 +++
1 file changed, 32 insertions(+), 44 deletions(-)
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index 6db7783
On Tue, Jul 25, 2017 at 3:26 PM, Michael S. Tsirkin wrote:
> On Mon, Jul 24, 2017 at 08:48:48AM +0200, Igor Mammedov wrote:
>> On Sat, 22 Jul 2017 02:40:46 +0300
>> "Michael S. Tsirkin" wrote:
>>
>> > On Fri, Jul 21, 2017 at 12:10:48PM +0200, Igor Mammedov wrote:
>> > > On Fri, 21 Jul 2017 10:49:
On Fri, Jul 21, 2017 at 12:12 PM, Igor Mammedov wrote:
> On Fri, 21 Jul 2017 11:54:20 +0200
> Ladi Prosek wrote:
>
>> On Fri, Jul 21, 2017 at 11:32 AM, Igor Mammedov wrote:
>> > w2k used to boot on QEMU until we bumped revision of FADT to rev3
>> > (commit 77af
compile test since I don't have w2k to test with
Confirming that Windows 2000 boots with this patch and -machine pc-i440fx-2.9.
Tested-by: Ladi Prosek
On Tue, Jul 18, 2017 at 6:18 PM, Marc-André Lureau
wrote:
> Hi
>
> On Tue, Jul 18, 2017 at 6:05 PM Ladi Prosek wrote:
>>
>>
>> > I would like to hear from Ladi how he intended to use the device in
>> > the future, and if he would also prefer ACPI method
Hi Marc-Andre,
On Tue, Jul 18, 2017 at 3:29 PM, Marc-André Lureau
wrote:
> Hi
>
> On Fri, Jul 14, 2017 at 4:29 PM, Michael S. Tsirkin wrote:
>> On Sat, Jul 15, 2017 at 12:31:36AM +0200, Marc-André Lureau wrote:
>>> Hi
>>>
>>> On Sat, Jul 15, 2017 at 12:23 AM, Michael S. Tsirkin
>>> wrote:
>>>
On Mon, Jul 17, 2017 at 10:58 AM, Daniel P. Berrange
wrote:
> On Mon, Jul 17, 2017 at 08:54:18AM +0200, Ladi Prosek wrote:
>> On Fri, Jul 14, 2017 at 12:41 PM, Daniel P. Berrange
>> wrote:
>> > On Thu, Jul 13, 2017 at 02:32:06PM +0100, Stefan Hajnoczi wrote:
>> &g
Two more error functions that should not contain newlines.
Suggested-by: Greg Kurz
Signed-off-by: Ladi Prosek
---
scripts/checkpatch.pl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4e91122..2cd2713 100755
--- a
1 - 100 of 247 matches
Mail list logo
