On Wed, Jul 16, 2025 at 05:23:57PM +0800, Yi Liu wrote:
> On 2025/7/16 12:05, Konstantin Belousov wrote:
> > On Wed, Jul 16, 2025 at 12:01:44PM +0800, Yi Liu wrote:
> > > On 2025/7/15 20:27, CLEMENT MATHIEU--DRIF wrote:
> > > >
> > > >
> > &
On Wed, Jul 16, 2025 at 12:01:44PM +0800, Yi Liu wrote:
> On 2025/7/15 20:27, CLEMENT MATHIEU--DRIF wrote:
> >
> >
> > On 15/07/2025 10:27 am, David Woodhouse wrote:
> > > On Tue, 2025-07-15 at 06:11 +, CLEMENT MATHIEU--DRIF wrote:
> > > >
> >
On Mon, Jul 14, 2025 at 05:41:22PM +0100, David Woodhouse wrote:
> On 14 July 2025 15:28:09 GMT+01:00, Yi Liu wrote:
> >Hi David,
> >
> >On 2025/7/14 16:00, David Woodhouse wrote:
> >> From: David Woodhouse
> >>
> >> FreeBSD does both, and this appears to be perfectly valid. The VT-d
> >> spec e
On 14-Jul-25 04:31, Akihiko Odaki wrote:
Konstantin, I would also want you to test this new version. Please also
give it Tested-by, and, if possible, Reviewed-by.
It works as expected during the boot. All bits in vlans[] remain set
until virtio_pci_common_write(VIRTIO_PCI_GUEST_FEATURES
On 13-Jul-25 06:52, Akihiko Odaki wrote:
Konstantin, please see if this patch fixes your workload.
Yes, it does. It delays vlans[] initialization until
virtio_net_set_status(0xf) which later also calls vhost_net_start()
which is where the NIC is actually programmed.
N IDs" greater than 4095, and QEMU then said:
"unable to start vhost net: 5: falling back on userspace virtio", and
VDPA became disabled.
Convert the VLAN ID to LE before putting it into virtio queue.
Fixes: 8f7e9967484d ("vdpa: Restore vlan filtering state")
Signed-off-by:
N IDs" greater than 4095, and QEMU then said:
"unable to start vhost net: 5: falling back on userspace virtio", and
VDPA became disabled.
Convert the VLAN ID to LE before putting it into virtio queue.
Signed-off-by: Konstantin Shkolnyy
---
net/vhost-vdpa.c | 5 +++--
1 file changed
Windows has no native equivalent API, but it would be possible to
simulate it as illustrated here (BSD-3-Clause):
https://github.com/giampaolo/psutil/pull/1485
Reviewed-by: Daniel P. Berrangé
Tested-by: Dehan Meng
Reviewed-by: Yan Vugenfirer
Signed-off-by: Konstantin Kostiuk
---
qga
Tested-by: Dehan Meng
Reviewed-by: Yan Vugenfirer
Signed-off-by: Konstantin Kostiuk
---
tests/unit/test-qga.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c
index 541b08a5e7..587e30c7e4 100644
--- a/tests/unit/test-qga.c
2025-06-12
----
Konstantin Kostiuk (2):
qga-win: implement a 'guest-get-load' command
qga: Add tests for guest-get-load command
qga/commands-win32.c | 148 +
qga/guest-agent-core.h | 10
qga/main.c | 39 ++
On 3/19/2025 19:58, Jason Wang wrote:
Adding Cindy and Eugenio
On Thu, Mar 20, 2025 at 12:34 AM Konstantin Shkolnyy wrote:
I’m observing a problem while testing VDPA with Nvidia ConnectX-6 (mlx5)
on s390.
Upon start, virtio_net_device_realize() tries to set a new MAC address
by
On 3/20/2025 01:54, Eugenio Perez Martin wrote:
On Thu, Mar 20, 2025 at 1:59 AM Jason Wang wrote:
Adding Cindy and Eugenio
On Thu, Mar 20, 2025 at 12:34 AM Konstantin Shkolnyy wrote:
I’m observing a problem while testing VDPA with Nvidia ConnectX-6 (mlx5)
on s390.
Upon start
Tested-by: Dehan Meng
Reviewed-by: Yan Vugenfirer
Signed-off-by: Konstantin Kostiuk
---
tests/unit/test-qga.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c
index 541b08a5e7..587e30c7e4 100644
--- a/tests/unit/test-qga.c
Windows has no native equivalent API, but it would be possible to
simulate it as illustrated here (BSD-3-Clause):
https://github.com/giampaolo/psutil/pull/1485
Reviewed-by: Daniel P. Berrangé
Tested-by: Dehan Meng
Reviewed-by: Yan Vugenfirer
Signed-off-by: Konstantin Kostiuk
---
qga
v1 -> v2:
- Added comments about init_load_avg_counter
v1: https://patchew.org/QEMU/20250314113847.109460-1-kkost...@redhat.com/
Konstantin Kostiuk (2):
qga-win: implement a 'guest-get-load' command
qga: Add tests for guest-get-load command
qga/commands-wi
On 3/20/2025 20:22, Jason Wang wrote:
On Fri, Mar 21, 2025 at 12:45 AM Konstantin Shkolnyy wrote:
On 3/19/2025 19:58, Jason Wang wrote:
On Thu, Mar 20, 2025 at 12:34 AM Konstantin Shkolnyy wrote:
Upon reading this forum, I see that VHOST_VDPA_SET_CONFIG is
“deprecated”, and so
On 3/19/2025 19:58, Jason Wang wrote:
On Thu, Mar 20, 2025 at 12:34 AM Konstantin Shkolnyy wrote:
Upon reading this forum, I see that VHOST_VDPA_SET_CONFIG is
“deprecated”, and so VIRTIO_NET_CTRL_MAC_ADDR_SET must be the right
method, but it’s apparently called too late
On Wed, Mar 19, 2025 at 5:02 PM Daniel P. Berrangé
wrote:
> On Fri, Mar 14, 2025 at 01:38:46PM +0200, Konstantin Kostiuk wrote:
> > Windows has no native equivalent API, but it would be possible to
> > simulate it as illustrated here (BSD-3-Clause):
> >
> > https://
I’m observing a problem while testing VDPA with Nvidia ConnectX-6 (mlx5)
on s390.
Upon start, virtio_net_device_realize() tries to set a new MAC address
by VHOST_VDPA_SET_CONFIG which doesn’t do anything.
Later, the VM gets started and learns about the old address from
virtio_net_get_config(
Windows has no native equivalent API, but it would be possible to
simulate it as illustrated here (BSD-3-Clause):
https://github.com/giampaolo/psutil/pull/1485
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32.c | 140 +
qga/guest-agent-core.h
Signed-off-by: Konstantin Kostiuk
---
tests/unit/test-qga.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c
index 541b08a5e7..587e30c7e4 100644
--- a/tests/unit/test-qga.c
+++ b/tests/unit/test-qga.c
@@ -332,6 +332,22 @@ static
Konstantin Kostiuk (2):
qga-win: implement a 'guest-get-load' command
qga: Add tests for guest-get-load command
qga/commands-win32.c | 140 +
qga/guest-agent-core.h | 10 +++
qga/main.c | 39
qga/meson.build
Best Regards,
Konstantin Kostiuk.
On Fri, Mar 14, 2025 at 12:23 PM Alex Bennée wrote:
> It was reported this breaks the final artefacts on windows when run
> under Wine.
>
Not only Wine, but Windows as well. Tested on Windows Server 2022.
>
> Signed-off-by: Alex Bennée
&
On Wed, Mar 12, 2025 at 6:24 PM Alex Bennée wrote:
> Daniel P. Berrangé writes:
>
> > On Wed, Mar 12, 2025 at 02:05:09PM +, Daniel P. Berrangé wrote:
> >> On Wed, Mar 12, 2025 at 03:52:45PM +0200, Konstantin Kostiuk wrote:
> >> > Hi All,
> >> >
On 2/23/2025 19:57, Jason Wang wrote:
On Sat, Feb 22, 2025 at 3:08 AM Konstantin Shkolnyy wrote:
Add .set_vnet_le() function that always returns success, assuming that
vDPA h/w always implements LE data format. Otherwise, QEMU disables vDPA and
outputs the message:
"backend does not su
: section below image base
/usr/lib/gcc/x86_64-w64-mingw32/14.1.1/../../../../x86_64-w64-mingw32/bin/ld:
tests/qtest/fuzz-e1000e-test.exe:/24: section below image base
Best Regards,
Konstantin Kostiuk.
On Wed, Mar 12, 2025 at 4:05 PM Daniel P. Berrangé
wrote:
> On Wed, Mar 12, 2025 at 03:52:4
b.com/qemu-project/qemu/-/commit/563b1a35ed1f1151505d4fe5f723827d1b3fd4bc
Adding --disable-split-debug to the configure CLI fixes the issue.
$ x86_64-w64-mingw32-gcc --version
x86_64-w64-mingw32-gcc (GCC) 14.2.0
My question is, is this expected behavior or is this a bug?
Best Regards,
Konstantin Kostiuk.
On 2/27/2025 00:33, Michael Tokarev wrote:
25.02.2025 15:39, Konstantin Shkolnyy wrote:
On 2/25/2025 03:30, Michael Tokarev wrote:
This looks like a qemu-stable material.
Please let me know if it is not.
It won't help without my other "[PATCH v2] vdpa: Allow vDPA to work on
Related bug: https://bugs.gentoo.org/810628
Signed-off-by: Michal Privoznik
Reviewed-by: Ján Tomko
Reviewed-by: Konstantin Kostiuk
Message-ID:
<7a42b0cbda5c7e01cf76bc1b29a1210cd018fa78.1736261360.git.mpriv...@redhat.com>
Signed-off-by: Konstantin Kostiuk
---
qga/main.c | 24 ++
Reviewed-by: Daniel P. Berrangé
Message-ID: <20241216154552.213961-2-kkost...@redhat.com>
Signed-off-by: Konstantin Kostiuk
---
qga/commands-posix.c | 2 ++
qga/commands-win32.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 6e3c
d set
it explicitly to success value in that one specific case.
Signed-off-by: Michal Privoznik
Reviewed-by: Ján Tomko
Reviewed-by: Konstantin Kostiuk
Message-ID:
<8a28265f50177a8dc4c10fcf4146e85a7fd748ee.1736261360.git.mpriv...@redhat.com>
Signed-off-by: Konstantin Kostiuk
---
qga/m
pull-2025-02-26
----
Konstantin Kostiuk (1):
qga: Add log to guest-fsfreeze-thaw command
Michal Privoznik (2):
qga: Invert logic on return value in main()
qga: Don't daemonize before channel is initialized
qga/commands-posix.c | 2 ++
qga/commands-win32.c
Reviewed-by: Konstantin Kostiuk
On Tue, Jan 7, 2025 at 4:52 PM Michal Privoznik wrote:
> Current logic on return value ('ret' variable) in main() is error
> prone. The variable is initialized to EXIT_SUCCESS and then set
> to EXIT_FAILURE on error paths. This makes it very
Reviewed-by: Konstantin Kostiuk
On Tue, Jan 7, 2025 at 4:52 PM Michal Privoznik wrote:
> If the agent is set to daemonize but for whatever reason fails to
> init the channel, the error message is lost. Worse, the agent
> daemonizes needlessly and returns success. For instance:
>
&
On 2/25/2025 03:30, Michael Tokarev wrote:
12.02.2025 19:49, Konstantin Shkolnyy wrote:
VDPA didn't work on a big-endian machine due to missing/incorrect
CPU<->LE data format conversions.
Signed-off-by: Konstantin Shkolnyy
This looks like a qemu-stable material.
Please let me kn
Add .set_vnet_le() function that always returns success, assuming that
vDPA h/w always implements LE data format. Otherwise, QEMU disables vDPA and
outputs the message:
"backend does not support LE vnet headers; falling back on userspace virtio"
Signed-off-by: Konstantin Shkolnyy
---
On 2/20/2025 09:57, Michael S. Tsirkin wrote:
On Tue, Feb 11, 2025 at 10:19:23AM -0600, Konstantin Shkolnyy wrote:
Add .set_vnet_le() function that always returns success, assuming that
vDPA h/w always implements LE data format. Otherwise, QEMU disables vDPA and
outputs the message:
"ba
On 2/12/2025 14:01, Konstantin Shkolnyy wrote:
On 2/12/2025 12:07, Philippe Mathieu-Daudé wrote:
On 12/2/25 18:24, Konstantin Shkolnyy wrote:
On 2/12/2025 08:52, Philippe Mathieu-Daudé wrote:
On 11/2/25 17:19, Konstantin Shkolnyy wrote:
Add .set_vnet_le() function that always returns success
On 2/13/2025 20:24, Lei Yang wrote:
vdpa's regression tests
On 2/13/2025 20:24, Lei Yang wrote:
I tested this patch with vdpa's regression tests, everything works fine.
Tested-by: Lei Yang
Could you point me to those tests?
On 2/12/2025 12:07, Philippe Mathieu-Daudé wrote:
On 12/2/25 18:24, Konstantin Shkolnyy wrote:
On 2/12/2025 08:52, Philippe Mathieu-Daudé wrote:
On 11/2/25 17:19, Konstantin Shkolnyy wrote:
Add .set_vnet_le() function that always returns success, assuming that
vDPA h/w always implements LE
On 2/12/2025 08:52, Philippe Mathieu-Daudé wrote:
On 11/2/25 17:19, Konstantin Shkolnyy wrote:
Add .set_vnet_le() function that always returns success, assuming that
vDPA h/w always implements LE data format. Otherwise, QEMU disables
vDPA and
outputs the message:
"backend does not suppo
VDPA didn't work on a big-endian machine due to missing/incorrect
CPU<->LE data format conversions.
Signed-off-by: Konstantin Shkolnyy
---
Changes in v2: Change desc_next[] from LE format to "CPU".
hw/virtio/vhost-shadow-virtqueue.c | 18 ++
1 file changed
On 2/12/2025 09:06, Eugenio Perez Martin wrote:
-i = cpu_to_le16(svq->desc_next[i]);
+i = le16_to_cpu(svq->desc_next[i]);
Both svq->desc_next and "i" are in QEMU. We can skip the conversion
and assign directly.
Are you saying that desc_next[] should be in "CPU" and not LE form
On 2/12/2025 07:38, Eugenio Perez Martin wrote:
On Tue, Feb 11, 2025 at 5:20 PM Konstantin Shkolnyy wrote:
Add .set_vnet_le() function that always returns success, assuming that
vDPA h/w always implements LE data format. Otherwise, QEMU disables vDPA and
outputs the message:
"backend doe
Add .set_vnet_le() function that always returns success, assuming that
vDPA h/w always implements LE data format. Otherwise, QEMU disables vDPA and
outputs the message:
"backend does not support LE vnet headers; falling back on userspace virtio"
Signed-off-by: Konstantin Shkolnyy
---
VDPA didn't work on a big-endian machine due to missing/incorrect
CPU<->LE data format conversions.
Signed-off-by: Konstantin Shkolnyy
---
hw/virtio/vhost-shadow-virtqueue.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/hw/virtio/vhost-shadow-
ping
On Mon, Jan 6, 2025 at 11:37 AM Konstantin Kostiuk
wrote:
> ping
>
> On Mon, Dec 16, 2024 at 5:47 PM Konstantin Kostiuk
> wrote:
>
>> Signed-off-by: Konstantin Kostiuk
>> ---
>> qga/commands-posix.c | 2 ++
>> qga/commands-win32.c | 3 +++
>>
left as an exercise for future contributors.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Message-ID: <20241202121927.864335-1-berra...@redhat.com>
Signed-off-by: Konstantin Kostiuk
---
meson.build | 1 +
qga/commands-posix.c | 20
qga/qa
The following changes since commit 9ee90cfc25747ab25c7da31a50f167fc5122e20e:
Merge tag 'qtest-20250102-pull-request' of https://gitlab.com/farosas/qemu
into staging (2025-01-03 09:14:11 -0500)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git tags/qga-pull-2025-
From: Dehan Meng
Make sure the error log of fsfreeze hooks
when freeze/thaw/snapshot could be logged
to system logs if the default logfile of
qga can't be written or other situations
Signed-off-by: Dehan Meng
Reviewed-by: Yan Vugenfirer
Reviewed-by: Konstantin Kostiuk
Messa
ping
On Mon, Dec 16, 2024 at 5:47 PM Konstantin Kostiuk
wrote:
> Signed-off-by: Konstantin Kostiuk
> ---
> qga/commands-posix.c | 2 ++
> qga/commands-win32.c | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix
Reviewed-by: Konstantin Kostiuk
On Wed, Dec 25, 2024 at 10:37 AM Dehan Meng wrote:
> Make sure the error log of fsfreeze hooks
> when freeze/thaw/snapshot could be logged
> to system logs if the default logfile of
> qga can't be written or other situations
>
> Si
On Sun, Dec 22, 2024 at 04:53:41PM +, Jiaxun Yang wrote:
> +[b4]
> +send-series-to = qemu-devel@nongnu.org
> +send-auto-to-cmd = echo
Hmm... does it not work without the above line? If so, can you please send a
bug report to to...@kernel.org?
Thanks!
-K
Hi Daniel,
Sorry, I just missed it.
I will send one more PR in a few days and include it.
Best Regards,
Konstantin Kostiuk.
On Wed, Dec 18, 2024 at 2:07 PM Daniel P. Berrangé
wrote:
> Any reason this skipped inclusion of my patch:
>
> Subject: [PATCH] qga: implement a '
Hi Michal,
The PULL with this patch was sent. Skip it in the next version of this
series.
Best Regards,
Konstantin Kostiuk.
On Thu, Dec 5, 2024 at 6:19 PM Michal Privoznik wrote:
> The run_agent_once() function is already given GAState via an
> argument. There's no need to access
From: Dehan Meng
There is a typo error for api 'guest-get-osinfo',
the win2025's version in WIN_10_0_SERVER_VERSION_MATRIX
should be adjusted.
Signed-off-by: Dehan Meng
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link: https://lore.kernel.org/r/202412100546
The following changes since commit 8032c78e556cd0baec111740a6c636863f9bd7c8:
Merge tag 'firmware-20241216-pull-request' of https://gitlab.com/kraxel/qemu
into staging (2024-12-16 14:20:33 -0500)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git tags/qga-pull-202
/open-vm-tools/commit/d58847b497e212737007958c945af1df22a8ab58
Signed-off-by: Jean-Louis Dupond
Reviewed-by: Konstantin Kostiuk
Link: https://lore.kernel.org/r/20241002100634.162499-2-jean-lo...@dupond.be
Signed-off-by: Konstantin Kostiuk
---
qga/commands-linux.c | 25 +
1
e the global variable. Stick with the
function argument.
Signed-off-by: Michal Privoznik
Reviewed-by: Ján Tomko
Reviewed-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/8ae7f5d5032b14a5b956fe8aaf47bae5ca401699.1733414906.git.mpriv...@redhat.com
Signed-off-by: Konstantin Kostiuk
---
qga/m
On Mon, Dec 16, 2024 at 7:12 PM Peter Xu wrote:
> On Mon, Dec 16, 2024 at 04:56:33PM +, Peter Maydell wrote:
> > On Mon, 16 Dec 2024 at 16:14, Peter Xu wrote:
> > >
> > > QEMU uses g_mkdir_with_parents() a lot, especially in the case where
> the
> > > failure case is ignored so an abort is e
On Thu, Dec 5, 2024 at 6:19 PM Michal Privoznik wrote:
> After previous commits, run_agent_once() can't return anything
> else but EXIT_SUCCESS. Transitionally, run_agent() can't return
> anything else but EXIT_SUCCESS too. There's not much value in
> having these function return an integer. Make
v1 -> v2:
Log only in case of successful thawing
v1: https://patchew.org/QEMU/20241209111817.31307-1-kkost...@redhat.com/
Konstantin Kostiuk (1):
qga: Add log to guest-fsfreeze-thaw command
qga/commands-posix.c | 2 ++
qga/commands-win32.c | 3 +++
2 files changed, 5 insertions(+)
--
2.47.1
Signed-off-by: Konstantin Kostiuk
---
qga/commands-posix.c | 2 ++
qga/commands-win32.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 636307bedf..359a56be81 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -805,8 +805,10
Reviewed-by: Konstantin Kostiuk
Best Regards,
Konstantin Kostiuk.
On Tue, Dec 10, 2024 at 10:13 AM Daniel P. Berrangé
wrote:
> On Tue, Dec 10, 2024 at 01:46:16PM +0800, Dehan Meng wrote:
> > There is a typo error for api 'guest-get-osinfo',
> >
Best Regards,
Konstantin Kostiuk.
On Mon, Dec 9, 2024 at 1:30 PM Daniel P. Berrangé
wrote:
> On Mon, Dec 09, 2024 at 01:18:17PM +0200, Konstantin Kostiuk wrote:
> > Signed-off-by: Konstantin Kostiuk
> > ---
> > qga/commands-posix.c | 3 +++
> > qga/commands-
Signed-off-by: Konstantin Kostiuk
---
qga/commands-posix.c | 3 +++
qga/commands-win32.c | 2 ++
2 files changed, 5 insertions(+)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 636307bedf..ac8d150582 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -805,6 +805,9
On Mon, Nov 4, 2024 at 11:54 AM Michal Privoznik
wrote:
> If the agent is set to daemonize but for whatever reason fails to
> init the channel, the error message is lost. Worse, the agent
> daemonizes needlessly and returns success. For instance:
>
> # qemu-ga -m virtio-serial \
> -
Hi Michal,
Please fix the issue that Jan mentioned.
All commits should be logically correct even if it part of one series.
Applying this will cause regression.
Best Regards,
Konstantin Kostiuk.
On Wed, Nov 6, 2024 at 6:07 PM Ján Tomko wrote:
> On a Monday in 2024, Michal Privoznik wr
Reviewed-by: Konstantin Kostiuk
On Mon, Nov 4, 2024 at 11:54 AM Michal Privoznik
wrote:
> The run_agent_once() function is already given GAState via an
> argument. There's no need to access the global ga_state variable
> which points to the argument anyways (thanks to
>
Reviewed-by: Konstantin Kostiuk
On Mon, Dec 2, 2024 at 2:19 PM Daniel P. Berrangé
wrote:
> Provide a way to report the process load average, via a new
> 'guest-get-load' command.
>
> This is only implemented for POSIX platforms providing 'getloadavg'.
>
&
Reviewed-by: Konstantin Kostiuk
I will merge it into the next QEMU release.
On Mon, Oct 28, 2024 at 2:15 PM Jean-Louis Dupond
wrote:
> Hi Konstantin,
>
> Thanks for your response.
> What I observed was when running CloudLinux is that with a /tmp on a loop
> device, is that th
Hi Peter,
Please update me regarding the coverity issues. Is everything fixed or not?
Best Regards,
Konstantin Kostiuk.
On Fri, Nov 8, 2024 at 12:22 PM Peter Maydell
wrote:
> On Thu, 7 Nov 2024 at 10:40, Konstantin Kostiuk
> wrote:
> >
> > The following ch
From: Dehan Meng
It's now only freed at the end of the function.
Signed-off-by: Dehan Meng
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Message-ID: <20241107102155.57573-4-kkost...@redhat.com>
Signed-off-by: Konstantin Kostiuk
---
qga/commands-linux.c | 3
The following changes since commit f15f7273ea55472d5904c53566c82369d81214c1:
Merge tag 'pull-target-arm-20241105' of
https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-11-05
21:27:18 +)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git tags/
From: Dehan Meng
sscanf return values are checked and add 'Null' check for
mandatory parameters. And merged redundant route and
networkroute variables.
Signed-off-by: Dehan Meng
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Message-ID: <20241107102155.
From: Dehan Meng
Variable declarations moved to the beginning of blocks
Followed the coding style of using snake_case for variable names.
Proper initialization of param 'size_t n' to '0' for
Signed-off-by: Dehan Meng
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin
v6:
Fix compilation errors
v5:
Summarize and merge commits
v4:
Handle g_autoptr() to simplify code and memory leak
v3:
Modify commits message and do some minor update.
v2:
Split v1 up to separate commits for each logically independent change
Konstantin Kostiuk (3):
qemu-ga: Add 'Null&#
Variable declarations moved to the beginning of blocks
Followed the coding style of using snake_case for variable names.
Proper initialization of param 'size_t n' to '0' for
Signed-off-by: Dehan Meng
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Signe
It's now only freed at the end of the function.
Signed-off-by: Dehan Meng
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-linux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qga/commands-linu
sscanf return values are checked and add 'Null' check for
mandatory parameters. And merged redundant route and
networkroute variables.
Signed-off-by: Dehan Meng
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-li
On Wed, Nov 6, 2024 at 10:42 AM Dehan Meng wrote:
> It's now only freed at the end of the function.
>
> Signed-off-by: Dehan Meng
> ---
> qga/commands-linux.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/qga/commands-linux.c b/qga/commands-linux.c
> index 55c3
Best Regards,
Konstantin Kostiuk.
On Wed, Nov 6, 2024 at 10:41 AM Dehan Meng wrote:
> sscanf return values are checked and add 'Null' check for
> mandatory parameters. And merged redundant route and
> networkroute variables.
>
> Signed-off-by: Dehan Meng
> ---
Reviewed-by: Konstantin Kostiuk
On Wed, Nov 6, 2024 at 3:38 PM Daniel P. Berrangé
wrote:
> On Wed, Nov 06, 2024 at 04:41:34PM +0800, Dehan Meng wrote:
> > It's now only freed at the end of the function.
> >
> > Signed-off-by: Dehan Meng
> > ---
> > q
Reviewed-by: Konstantin Kostiuk
On Wed, Nov 6, 2024 at 3:36 PM Daniel P. Berrangé
wrote:
> On Wed, Nov 06, 2024 at 04:41:33PM +0800, Dehan Meng wrote:
> > Variable declarations moved to the beginning of blocks
> > Followed the coding style of using snake_case for variable na
Reviewed-by: Konstantin Kostiuk
On Wed, Nov 6, 2024 at 3:35 PM Daniel P. Berrangé
wrote:
> On Wed, Nov 06, 2024 at 04:41:32PM +0800, Dehan Meng wrote:
> > sscanf return values are checked and add 'Null' check for
> > mandatory parameters. And merged redundant r
Hi Sunil,
I updated the commit message according to Daniel's comment and got this
patch to merge.
Best Regards,
Konstantin Kostiuk.
On Mon, Oct 21, 2024 at 11:26 AM Daniel P. Berrangé
wrote:
> On Fri, Oct 18, 2024 at 03:34:39PM +0530, Sunil Nimmagadda wrote:
> > qemu-ga on a N
Hi Pierrick,
I got this patch in my PULL with QGA patches.
Best Regards,
Konstantin Kostiuk.
On Thu, Oct 31, 2024 at 3:32 PM Konstantin Kostiuk
wrote:
> Reviewed-by: Konstantin Kostiuk
>
> On Thu, Oct 31, 2024 at 6:05 AM Pierrick Bouvier <
> pierrick.bouv...@linaro.org> wr
Hi Pierrick,
I got this patch in my PULL with QGA patches.
Best Regards,
Konstantin Kostiuk.
On Thu, Oct 31, 2024 at 3:32 PM Konstantin Kostiuk
wrote:
> Reviewed-by: Konstantin Kostiuk
>
> On Thu, Oct 31, 2024 at 6:05 AM Pierrick Bouvier <
> pierrick.bouv...@linaro.org> wr
tDll, DWORD dwReason, LPVOID
lpReserved)
| ^
| static
Signed-off-by: Pierrick Bouvier
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/20241031040426.772604-7-pierrick.bouv...@linaro.org
Signed-off-by: Konstantin Kostiuk
---
qga/vss-win32
nitialized whenever 'if' condition is true
[-Werror,-Wsometimes-uninitialized]
383 | if (!create_acl(userInfo, &pACL, errp)) {
| ^~~~~~
../qga/commands-windows-ssh.c:415:15: note: uninitialized use occurs here
415 | LocalFree(userPSID);
\
-device virtio-serial \
-device virtconsole,chardev=qga0,name=org.qemu.guest_agent.0
This patch rectifies the operator precedence while assigning the NUL
terminator.
Fixes: c3f32c13a325f1ca9a0b08c19fefe9e5cc04289d
Signed-off-by: Sunil Nimmagadda
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Da
The following changes since commit c94bee4cd6693c1c65ba43bb8970cf909dec378b:
Merge tag 'for-upstream-i386' of https://gitlab.com/bonzini/qemu into staging
(2024-11-02 16:21:38 +)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git tags/qga-pull-2024-11-4
for
Reviewed-by: Konstantin Kostiuk
On Thu, Oct 31, 2024 at 6:05 AM Pierrick Bouvier <
pierrick.bouv...@linaro.org> wrote:
> Reported by clang, but not gcc.
>
> [5123/5678] Compiling C object qga/qemu-ga.exe.p/commands-windows-ssh.c.obj
> FAILED: qga/qemu-ga.exe.p/commands-windo
Reviewed-by: Konstantin Kostiuk
On Thu, Oct 31, 2024 at 6:05 AM Pierrick Bouvier <
pierrick.bouv...@linaro.org> wrote:
> Reported by clang++, but not by g++.
>
> ../qga/vss-win32/provider.cpp:48:6: error: no previous prototype for
> function 'LockModule' [-Werror,-
Hi Jean-Louis,
Thanks for your patch. I hope next week, I will test and review this patch.
Just a question, did you have a chance to test that this patch fix kernel
crash?
Best Regards,
Konstantin Kostiuk.
On Fri, Oct 25, 2024 at 1:06 PM Jean-Louis Dupond
wrote:
> On 9/10/2024 10:34, J
On Mon, Oct 21, 2024 at 7:45 PM Daniel P. Berrangé
wrote:
> On Mon, Oct 21, 2024 at 09:28:36PM +0800, Dehan Meng wrote:
> > sscanf return values are checked and add 'Null' check for
> > mandatory parameters.
> >
> > Signed-off-by: Dehan Meng
> > ---
> > qga/commands-linux.c | 12 +++-
>
Reviewed-by: Konstantin Kostiuk
On Fri, Oct 18, 2024 at 1:14 PM Sunil Nimmagadda
wrote:
> qemu-ga on a NetBSD -current VM terminates with a SIGSEGV upon receiving
> 'guest-set-time' command...
>
> Core was generated by `qemu-ga'.
> Program terminated with sign
add `qemu-ga:` suffix for
each commit
Best Regards,
Konstantin Kostiuk.
> Signed-off-by: Dehan Meng
>
> qga/commands-linux.c | 128 ---
> 1 file changed, 59 insertions(+), 69 deletions(-)
>
> --
> 2.40.1
>
>
On Fri, Sep 27, 2024 at 06:29:22AM GMT, Jamin Lin wrote:
> > Also, your emails have an invalid "From" field set to
> > "qemu-devel@nongnu.org" when retrieved with the b4 command.
This is almost certainly done by the mailman list running on nongnu.org. It's
a very patch-hostile setting, so I'm surp
1 - 100 of 606 matches
Mail list logo
