RE: [PATCH 1/3] target/riscv: add a trap-misaligned-access property

2024-12-16 Thread Konrad, Frederic
> -Original Message- > From: Alistair Francis > Sent: 16 December 2024 05:55 > To: Konrad, Frederic > Cc: qemu-ri...@nongnu.org; pal...@dabbelt.com; alistair.fran...@wdc.com; > bmeng...@gmail.com; liwei1...@gmail.com; > dbarb...@ventanamicro.com; zhiwei_...@linux

RE: [PATCH 3/3] target/riscv: fix the trap generation for conditional store

2024-12-13 Thread Konrad, Frederic
+CC maintainers > -Original Message- > From: qemu-devel-bounces+fkonrad=amd@nongnu.org > On > Behalf Of Richard Henderson > Sent: 11 December 2024 22:43 > To: qemu-devel@nongnu.org > Subject: Re: [PATCH 3/3] target/riscv: fix the trap generation for > conditional store > > On 12/11

RE: [PATCH 2/3] target/riscv: generate misaligned access trap for rvi insn

2024-12-13 Thread Konrad, Frederic
Hi Richard, Thanks for the comment. > -Original Message- > From: Richard Henderson > Sent: 11 December 2024 22:50 > To: Konrad, Frederic ; qemu-ri...@nongnu.org > Cc: pal...@dabbelt.com; alistair.fran...@wdc.com; bmeng...@gmail.com; > liwei1...@gmail.com; > dbar

RE: [PATCH RFC] prevent overflow in xlnx_dpdma_desc_get_source_address()

2024-04-17 Thread Konrad, Frederic
Hi, > -Original Message- > From: qemu-devel-bounces+fkonrad=amd@nongnu.org > On Behalf Of > Peter Maydell > Sent: Friday, April 12, 2024 12:07 PM > To: Alexandra Diupina > Cc: Alistair Francis ; Edgar E. Iglesias > ; qemu-...@nongnu.org; qemu- > de...@nongnu.org; sdl.q...@linuxtest

RE: [PATCH] hw/display/xlnx_dp: fix overflow in xlnx_dp_aux_push_tx_fifo()

2023-01-10 Thread Konrad, Frederic
Hi, > -Original Message- > From: qemu-devel-bounces+fkonrad=amd@nongnu.org > On Behalf Of > Qiang Liu > Sent: 09 January 2023 07:00 > To: qemu-devel@nongnu.org > Cc: Qiang Liu ; Alistair Francis > ; Edgar E. Iglesias ; Peter > Maydell ; open list:Xilinx ZynqMP and... > > Subject:

RE: REG: TTC Timer

2022-12-05 Thread Konrad, Frederic
est Regards, Fred -Original Message- From: Philippe Mathieu-Daudé Sent: 05 December 2022 09:24 To: Gowri Shankar ; QEMU Developers ; qemu-arm Cc: qemu-disc...@nongnu.org; Konrad, Frederic ; Iglesias, Francisco ; Alistair Francis Subject: Re: REG: TTC Timer On 22/11/22 12:27, Gowri Shankar

RE: [PATCH] xlnx_dp: drop unsupported AUXCommand in xlnx_dp_aux_set_command

2022-08-08 Thread Konrad, Frederic
> -Original Message- > From: Qemu-devel bounces+fkonrad=amd@nongnu.org> On Behalf Of Qiang Liu > Sent: 08 August 2022 08:55 > To: qemu-devel@nongnu.org > Cc: Qiang Liu ; Thomas Huth ; > Alistair Francis ; Edgar E. Iglesias > ; Peter Maydell ; > open list:Xilinx ZynqMP and... > Subje

RE: [PATCH for-7.1] hw/misc/grlib_ahb_apb_pnp: Support 8 and 16 bit accesses

2022-08-08 Thread Konrad, Frederic
> -Original Message- > From: Peter Maydell > Sent: 02 August 2022 15:34 > To: Konrad, Frederic > Cc: qemu-devel@nongnu.org; Fabien Chouteau ; > Frederic Konrad ; f4...@amsat.org > Subject: Re: [PATCH for-7.1] hw/misc/grlib_ahb_apb_pnp: Support 8 and 16 > bit acc

RE: [PATCH for-7.1] hw/misc/grlib_ahb_apb_pnp: Support 8 and 16 bit accesses

2022-08-02 Thread Konrad, Frederic
Hi Peter, CC'ing Philippe. > -Original Message- > From: Qemu-devel bounces+fkonrad=amd@nongnu.org> On Behalf Of Peter Maydell > Sent: 02 August 2022 14:19 > To: qemu-devel@nongnu.org > Cc: Fabien Chouteau ; Frederic Konrad > > Subject: [PATCH for-7.1] hw/misc/grlib_ahb_apb_pnp: Supp

Re: [PATCH 1/2] softfloat: m68k: infinity is a valid encoding

2020-04-29 Thread KONRAD Frederic
Le 4/29/20 à 10:42 AM, Laurent Vivier a écrit : Le 28/04/2020 à 19:17, KONRAD Frederic a écrit : The MC68881 say about infinities (3.2.4): "*For the extended precision format, the most significant bit of the mantissa (the integer bit) is a don't care." https://www.nxp.com/do

Re: [PATCH 2/2] target/m68k: fix gdb for m68xxx

2020-04-29 Thread KONRAD Frederic
Le 4/29/20 à 11:38 AM, Laurent Vivier a écrit : Le 29/04/2020 à 11:28, Alex Bennée a écrit : Laurent Vivier writes: Le 28/04/2020 à 19:17, KONRAD Frederic a écrit : Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is it uses the "org.gnu.gd

[PATCH 1/2] softfloat: m68k: infinity is a valid encoding

2020-04-28 Thread KONRAD Frederic
fmoved %fp@(-8), %fp0 1: $fp0 = inf (gdb) si end () at main.S:12 12 bra end 1: $fp0 = nan(0xf800) (gdb) x/1xg $fp-8 0x4120 : 0x7fff Signed-off-by: KONRAD Frederic --- include/fpu/softfloat.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/

[PATCH 0/2] m68k fpu fixes

2020-04-28 Thread KONRAD Frederic
DEFINE_M68K_CPU_TYPE_CF and dropped DEFINE_M68K_CPU_TYPE_WITH_CLASS (Suggested by Laurent) * target/m68k/cpu.c: reworked DEFINE_M68K_CPU_TYPE_* to guess the cpu_initfn from the cpu_model (Suggested by Laurent). Cheers, Fred KONRAD Frederic (2): softfloat

[PATCH 2/2] target/m68k: fix gdb for m68xxx

2020-04-28 Thread KONRAD Frederic
ng the "file" command. 0x in ?? () (gdb) p $fp0 $1 = nan(0x) Signed-off-by: KONRAD Frederic --- configure | 2 +- gdb-xml/m68k-core.xml | 29 target/m68k/cpu.c | 52 ---

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

2020-04-28 Thread KONRAD Frederic
Le 4/28/20 à 4:13 PM, Laurent Vivier a écrit : Le 28/04/2020 à 15:19, KONRAD Frederic a écrit : Le 4/27/20 à 9:53 AM, Laurent Vivier a écrit : Le 20/04/2020 à 16:01, frederic.kon...@adacore.com a écrit : From: KONRAD Frederic ... I would prefer to have two macros with no class

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

2020-04-28 Thread KONRAD Frederic
Le 4/27/20 à 9:53 AM, Laurent Vivier a écrit : Le 20/04/2020 à 16:01, frederic.kon...@adacore.com a écrit : From: KONRAD Frederic Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is it uses the "org.gnu.gdb.coldfire.core" feature name and gd

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

2020-04-21 Thread KONRAD Frederic
Le 4/20/20 à 10:43 PM, Laurent Vivier a écrit : Le 20/04/2020 à 21:08, KONRAD Frederic a écrit : Le 4/20/20 à 5:46 PM, Laurent Vivier a écrit : Le 20/04/2020 à 16:01, frederic.kon...@adacore.com a écrit : From: KONRAD Frederic Currently "cf-core.xml" is sent to GDB when usin

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

2020-04-20 Thread KONRAD Frederic
Le 4/20/20 à 5:46 PM, Laurent Vivier a écrit : Le 20/04/2020 à 16:01, frederic.kon...@adacore.com a écrit : From: KONRAD Frederic Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is it uses the "org.gnu.gdb.coldfire.core" feature name and gd

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

2020-04-20 Thread KONRAD Frederic
Le 4/20/20 à 6:13 PM, Alex Bennée a écrit : frederic.kon...@adacore.com writes: From: KONRAD Frederic Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then expects a coldfir

Re: m68k: gdbstub crashing setting float register on cfv4e cpu

2020-04-20 Thread KONRAD Frederic
Le 4/16/20 à 1:18 PM, Laurent Vivier a écrit : Le 14/04/2020 à 18:56, Alex Bennée a écrit : Philippe Mathieu-Daudé writes: gdbstub/m68k seems broken with floats, previous to refactor commit a010bdbe719 ("extend GByteArray to read register helpers"). HEAD at 6fb1603aa2: $ qemu-system-m68

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

2020-04-14 Thread KONRAD Frederic
Le 4/13/20 à 11:07 PM, Philippe Mathieu-Daudé a écrit : [Cc'ing Peter] On 4/13/20 12:12 PM, KONRAD Frederic wrote: Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit : On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (7):    hw/misc/grlib_ahb_apb_pnp:

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

2020-04-13 Thread KONRAD Frederic
Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit : On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (7): hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP registers hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses Ping ^^^ for 5.0?

Re: [PATCH-for-5.1 7/7] target/sparc/int32_helper: Extract and use excp_name_str()

2020-04-01 Thread KONRAD Frederic
cs->exception_index); +cpu_abort(cs, "Trap 0x%02x (%s) while interrupts disabled, " + "Error state", + cs->exception_index, excp_name_str(cs->exception_index)); } return; } Reviewed-by: KONRAD Frederic Thanks, Fred

Re: [PATCH-for-5.1 6/7] target/sparc/int32_helper: Remove DEBUG_PCALL definition

2020-04-01 Thread KONRAD Frederic
for (i = 0; i < 16; i++) { qemu_log(" %02x", ldub(ptr + i)); } qemu_log("\n"); } #endif Should we drop that as well? count++; } -#endif #if !defined(CONFIG_USER_ONLY) if (env->psret == 0) { if (cs->exception_index == 0x80 && In any case LGTM: Reviewed-by: KONRAD Frederic

Re: [PATCH-for-5.1 5/7] hw/timer/grlib_gptimer: Display frequency in decimal

2020-04-01 Thread KONRAD Frederic
x freq:%uHz" grlib_gptimer_hit(int id) "timer:%d HIT" grlib_gptimer_readl(int id, uint64_t addr, uint32_t val) "timer:%d addr 0x%"PRIx64" 0x%x" grlib_gptimer_writel(int id, uint64_t addr, uint32_t val) "timer:%d addr 0x%"PRIx64" 0x%x" Reviewed-by: KONRAD Frederic

Re: [PATCH-for-5.1 4/7] hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses

2020-04-01 Thread KONRAD Frederic
md_pram_sect_write(int sector, int offset, int addr, int value) "sector=%u offset=%u addr=%d value=0x%02x" + +# grlib_ahb_apb_pnp.c +grlib_ahb_pnp_read(uint64_t addr, uint32_t value) "AHB PnP read addr:0x%03"PRIx64" data:0x%08x" +grlib_apb_pnp_read(uint64_t addr, uint32_t value) "APB PnP read addr:0x%03"PRIx64" data:0x%08x" Reviewed-by: KONRAD Frederic

Re: [PATCH-for-5.0 3/7] hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses

2020-04-01 Thread KONRAD Frederic
static void grlib_ahb_pnp_realize(DeviceState *dev, Error **errp) Reviewed-by: KONRAD Frederic

Re: [PATCH-for-5.0 2/7] hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP registers

2020-04-01 Thread KONRAD Frederic
val, unsigned size) +{ +qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__); +} + static const MemoryRegionOps grlib_ahb_pnp_ops = { .read = grlib_ahb_pnp_read, +.write = grlib_ahb_pnp_write, .endianness = DEVICE_BIG_ENDIAN, }; Reviewed-by: KONRAD Frederic

Re: [PATCH v1 2/2] hw/arm: versal: Generate xlnx-versal-virt zdma FDT nodes

2020-02-27 Thread KONRAD Frederic
Le 2/27/20 à 4:44 PM, Edgar E. Iglesias a écrit : From: "Edgar E. Iglesias" Generate xlnx-versal-virt zdma FDT nodes. Signed-off-by: Edgar E. Iglesias Reviewed-by: KONRAD Frederic --- hw/arm/xlnx-versal-virt.c | 28 1 file changed, 28

Re: [PATCH v1 1/2] hw/arm: versal: Add support for the LPD ADMAs

2020-02-27 Thread KONRAD Frederic
Le 2/27/20 à 4:44 PM, Edgar E. Iglesias a écrit : From: "Edgar E. Iglesias" Add support for the Versal LPD ADMAs. Signed-off-by: Edgar E. Iglesias Looks good to me. Reviewed-by: KONRAD Frederic --- hw/arm/xlnx-versal.c | 24 include/h

Re: [PATCH RESEND v2 14/32] hw/sparc: Use memory_region_init_rom() with read-only regions

2020-02-25 Thread KONRAD Frederic
Le 2/24/20 à 9:55 PM, Philippe Mathieu-Daudé a écrit : This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Signed-off-by: Philippe Mathieu-Daudé Looks good to me. Reviewed-by: KONRAD Frederic Thanks, Fred --- hw/sparc/leon3.c | 3

Re: [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default

2020-02-17 Thread KONRAD Frederic
('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout') def test_leon3_helenos_uimage(self): """ :avocado: tags=arch:sparc Reviewed-by: KONRAD Frederic Thanks Philippe!

Re: [PATCH 00/10] Add Allwinner H3 SoC and Orange Pi PC Machine

2019-12-10 Thread KONRAD Frederic
here needed. With kind regards, Niek Linnenbank [1] http://www.orangepi.org/downloadresources/ [2] https://buildroot.org/download.html [3] https://www.armbian.com/orange-pi-pc/ Works well on my side with vanilla linux-4.9.13 built with gcc-8.3.0 + busybox and sun8i-h3-orangepi-one.dtb. Tested-by: K

Re: [PATCH 10/10] arm: allwinner-h3: add EMAC ethernet device

2019-12-04 Thread KONRAD Frederic
Le 12/4/19 à 4:14 PM, Philippe Mathieu-Daudé a écrit : On 12/3/19 10:33 AM, KONRAD Frederic wrote: Le 12/2/19 à 10:09 PM, Niek Linnenbank a écrit : The Allwinner H3 System on Chip includes an Ethernet MAC (EMAC) which provides 10M/100M/1000M Ethernet connectivity. This commit adds support

Re: [PATCH 10/10] arm: allwinner-h3: add EMAC ethernet device

2019-12-03 Thread KONRAD Frederic
Le 12/2/19 à 10:09 PM, Niek Linnenbank a écrit : The Allwinner H3 System on Chip includes an Ethernet MAC (EMAC) which provides 10M/100M/1000M Ethernet connectivity. This commit adds support for the Allwinner H3 EMAC, including emulation for the following functionality: * DMA transfers *

Re: [PATCH v3 24/33] leon3: use qemu_irq framework instead of callback as property

2019-11-18 Thread KONRAD Frederic
env->irq_manager = dev; diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h index 778aa8e073..709215f8c1 100644 --- a/target/sparc/cpu.h +++ b/target/sparc/cpu.h @@ -508,6 +508,7 @@ struct CPUSPARCState { #endif sparc_def_t def; +qemu_irq pil_irq; void *irq_manager; void (*qemu_irq_ack)(CPUSPARCState *env, void *irq_manager, int intno); Seems ok to me. Reviewed-by: KONRAD Frederic Thanks, Fred

Re: [PATCH 2/2] hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses

2019-10-25 Thread KONRAD Frederic
cess_size = 4, +.max_access_size = 4, +}, }; static void grlib_apb_pnp_realize(DeviceState *dev, Error **errp) Reviewed-by: KONRAD Frederic Thanks

Re: [PATCH 1/2] hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers

2019-10-25 Thread KONRAD Frederic
attrs=..., buf=0x7fff07d01120 "E", len=1, is_write=true) at exec.c:3301 #8 0x555f4bcdb388 in qtest_process_command (chr=0x555f4c2ed7e0 , words=0x555f4db0c5d0) at qtest.c:432 Instead of crashing, log the access as unimplemented. Signed-off-by: Philippe Mathieu-Daudé oops,

Re: [Qemu-devel] [PATCH] target/m68k/fpu_helper.c: rename the access arguments

2019-09-12 Thread KONRAD Frederic
Le 9/12/19 à 4:32 PM, Philippe Mathieu-Daudé a écrit : On 9/12/19 4:02 PM, KONRAD Frederic wrote: The "access" arguments clash with a macro under Windows with MinGW: CC m68k-softmmu/target/m68k/fpu_helper.o target/m68k/fpu_helper.c: In function 'fmovem_predec&#

[Qemu-devel] [PATCH] target/m68k/fpu_helper.c: rename the access arguments

2019-09-12 Thread KONRAD Frederic
2 size = access(env, addr, &env->fregs[i], ra); So this renames them access_fn. Tested with: ./configure --target-list=m68k-softmmu make -j8 Signed-off-by: KONRAD Frederic --- target/m68k/fpu_helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) di

[Qemu-devel] [PATCH v1] gdbstub: riscv: fix the fflags registers

2019-09-10 Thread KONRAD Frederic
the csr_register_map in order to reach the riscv_cpu_get_fflags callback. Signed-off-by: KONRAD Frederic --- target/riscv/gdbstub.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/riscv/gdbstub.c b/target/riscv/gdbstub.c index 27be932..ded140e 100644 --- a/ta

Re: [Qemu-devel] [PATCH] riscv: htif: use qemu_log_mask instead of qemu_log

2019-07-22 Thread KONRAD Frederic
Hi Philippe, Le 7/20/19 à 11:50 AM, Philippe Mathieu-Daudé a écrit : Cc'ing Stefan On 7/20/19 11:44 AM, Philippe Mathieu-Daudé wrote: Hi Frederic, On 7/20/19 8:18 AM, KONRAD Frederic wrote: There are some debug trace appearing when using GDB with the HTIF mapped @0: Invalid htif

[Qemu-devel] [PATCH] riscv: htif: use qemu_log_mask instead of qemu_log

2019-07-19 Thread KONRAD Frederic
nally. Signed-off-by: KONRAD Frederic --- hw/riscv/riscv_htif.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/hw/riscv/riscv_htif.c b/hw/riscv/riscv_htif.c index 4f7b11d..6a8f0c2 100644 --- a/hw/riscv/riscv_htif.c +++ b/hw/riscv/riscv_htif.c @@ -119,7 +

Re: [Qemu-devel] [PATCH 0/3] tests/acceptance: Add tests for the Leon3 board

2019-06-27 Thread KONRAD Frederic
Hi Philippe, Thanks for that! I'm not aware at all of the tests/acceptance/* stuff.. How can we launch those tests? Appart of that it looks good to me :). Regards, Fred Le 6/27/19 à 1:53 PM, Philippe Mathieu-Daudé a écrit : Quick tests worth to avoid regressions, idea from https://lists.gnu.

Re: [Qemu-devel] [PATCH v3 0/7] Leon3 patches

2019-05-17 Thread KONRAD Frederic
Le 5/17/19 à 10:51 AM, Mark Cave-Ayland a écrit : On 15/05/2019 13:31, KONRAD Frederic wrote: Hi all, Those are some little fixes for the leon3 machine: * The first patch makes an error message more friendly when no kernel / bios are provided. * The three next one remove the old

[Qemu-devel] [PATCH v3 3/7] grlib, gptimer: get rid of the old-style create function

2019-05-15 Thread KONRAD Frederic
Suggested-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- hw/sparc/leon3.c | 17 - hw/timer/grlib_gptimer.c | 4 ++-- include/hw/sparc/grlib.h | 27 +-- 3 files changed, 19 insertions(+), 29 deletions(-) diff --git a/hw/sparc/leon3.c b

[Qemu-devel] [PATCH v3 2/7] grlib, irqmp: get rid of the old-style create function

2019-05-15 Thread KONRAD Frederic
Suggested-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- hw/intc/grlib_irqmp.c| 3 +-- hw/sparc/leon3.c | 12 ++-- include/hw/sparc/grlib.h | 31 ++- 3 files changed, 13 insertions(+), 33 deletions(-) diff --git a/hw/intc/grlib_irqmp.c

[Qemu-devel] [PATCH v3 6/7] leon3: introduce the plug and play mechanism

2019-05-15 Thread KONRAD Frederic
This adds the AHB and APB plug and play devices. They are scanned during the linux boot to discover the various peripheral. Reviewed-by: Fabien Chouteau Signed-off-by: KONRAD Frederic --- MAINTAINERS | 2 +- hw/misc/Makefile.objs | 2 + hw/misc

[Qemu-devel] [PATCH v3 7/7] MAINTAINERS: add myself for leon3

2019-05-15 Thread KONRAD Frederic
Reviewed-by: Fabien Chouteau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index bc54c6d..9424a49 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[Qemu-devel] [PATCH v3 4/7] grlib, apbuart: get rid of the old-style create function

2019-05-15 Thread KONRAD Frederic
Suggested-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- hw/char/grlib_apbuart.c | 4 ++-- hw/sparc/leon3.c | 9 - include/hw/sparc/grlib.h | 20 +--- 3 files changed, 11 insertions(+), 22 deletions(-) diff --git a/hw/char/grlib_apbuart.c b/hw/char

[Qemu-devel] [PATCH v3 5/7] leon3: add a little bootloader

2019-05-15 Thread KONRAD Frederic
This adds a little bootloader to the leon3_machine when a ram image is given through the kernel parameter and no bios are provided: * The UART transmiter is enabled. * The TIMER is initialized. Reviewed-by: Fabien Chouteau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: KONRAD Frederic

[Qemu-devel] [PATCH v3 1/7] leon3: fix the error message when no bios are provided

2019-05-15 Thread KONRAD Frederic
o use LEON3_PROM_FILENAME instead of filename in case it is NULL to get a less cryptic message: $ ./qemu-system-sparc -M leon3_generic qemu-system-sparc: Can't read bios image 'u-boot.bin' Suggested-by: Mark Cave-Ayland Signed-off-by: KONRAD Frederic --- hw/sparc/leon3.c | 10 ++

[Qemu-devel] [PATCH v3 0/7] Leon3 patches

2019-05-15 Thread KONRAD Frederic
the MAINTAINED file as suggested by Mark. V1 -> V2: * minor fixes in the first patch suggested by Philippe. Regards, Fred KONRAD Frederic (7): leon3: fix the error message when no bios are provided grlib,irqmp: get rid of the old-style create function grlib,gptimer: get rid of the old-style

Re: [Qemu-devel] [PATCH v2 0/3] Leon3 patches

2019-05-03 Thread KONRAD Frederic
Le 5/3/19 à 10:19 AM, Mark Cave-Ayland a écrit : On 25/04/2019 13:18, KONRAD Frederic wrote: Hi all, Those are some little fixes for the leon3 machine: * The first part initializes the uart and the timer when no bios are provided. * The second part adds AHB and APB plug and play

Re: [Qemu-devel] [PATCH v2 2/3] leon3: introduce the plug and play mecanism

2019-05-03 Thread KONRAD Frederic
Le 5/3/19 à 10:09 AM, Mark Cave-Ayland a écrit : On 25/04/2019 13:18, KONRAD Frederic wrote: This adds the AHB and APB plug and play devices. They are scanned during the linux boot to discover the various peripheral. Reviewed-by: Fabien Chouteau Signed-off-by: KONRAD Frederic --- hw

Re: [Qemu-devel] [PATCH v2 1/3] leon3: add a little bootloader

2019-05-03 Thread KONRAD Frederic
Hi Mark, } I think this patch is basically okay, however if you don't supply both a kernel and bios then you get the slightly enigmatic message below: $ ./qemu-system-sparc -M leon3_generic qemu-system-sparc: Can't read bios image (null) Perhaps add a define for LEON3_BIOS_FILENAME an

Re: [Qemu-devel] [PATCH v1 4/5] hw/arm: Add the STM32F4xx SoC

2019-04-30 Thread KONRAD Frederic
Le 4/29/19 à 7:00 PM, Alistair Francis a écrit : On Mon, Apr 29, 2019 at 5:38 AM KONRAD Frederic wrote: Hi Alistair, Le 4/29/19 à 7:33 AM, Alistair Francis a écrit : Signed-off-by: Alistair Francis --- MAINTAINERS | 8 + default-configs/arm-softmmu.mak | 1

Re: [Qemu-devel] [PATCH v1 4/5] hw/arm: Add the STM32F4xx SoC

2019-04-29 Thread KONRAD Frederic
Hi Alistair, Le 4/29/19 à 7:33 AM, Alistair Francis a écrit : Signed-off-by: Alistair Francis --- MAINTAINERS | 8 + default-configs/arm-softmmu.mak | 1 + hw/arm/Kconfig | 3 + hw/arm/Makefile.objs| 1 + hw/arm/stm32f405_soc.c

Re: [Qemu-devel] [PATCH v2] hw/sparc/leon3: Allow load of uImage firmwares

2019-04-29 Thread KONRAD Frederic
0001 fsr: y: But this has nothing to do with the uImage loading so it seems ok to me. Reviewed-by: KONRAD Frederic Tested-by: KONRAD Frederic --- v2: Fixed GIT_AUTHOR_EMAIL --- hw/sparc/leon3.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/sparc/leon3.c b/hw

[Qemu-devel] [PATCH v2 2/3] leon3: introduce the plug and play mecanism

2019-04-25 Thread KONRAD Frederic
This adds the AHB and APB plug and play devices. They are scanned during the linux boot to discover the various peripheral. Reviewed-by: Fabien Chouteau Signed-off-by: KONRAD Frederic --- hw/misc/Makefile.objs | 2 + hw/misc/grlib_ahb_apb_pnp.c | 269

[Qemu-devel] [PATCH v2 1/3] leon3: add a little bootloader

2019-04-25 Thread KONRAD Frederic
This adds a little bootloader to the leon3_machine when a ram image is given through the kernel parameter and no bios are provided: * The UART transmiter is enabled. * The TIMER is initialized. Reviewed-by: Fabien Chouteau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: KONRAD Frederic

[Qemu-devel] [PATCH v2 0/3] Leon3 patches

2019-04-25 Thread KONRAD Frederic
red KONRAD Frederic (3): leon3: add a little bootloader leon3: introduce the plug and play mecanism MAINTAINERS: add myself for leon3 MAINTAINERS | 1 + hw/misc/Makefile.objs | 2 + hw/misc/grlib_ahb_apb_pnp.c |

[Qemu-devel] [PATCH v2 3/3] MAINTAINERS: add myself for leon3

2019-04-25 Thread KONRAD Frederic
Reviewed-by: Fabien Chouteau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: KONRAD Frederic --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 23db6f8..6f7d237 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1151,6 +1151,7 @@ F: include/hw

Re: [Qemu-devel] [PATCH V1 1/3] leon3: add a little bootloader

2019-04-23 Thread KONRAD Frederic
Hi Philippe, Le 4/23/19 à 4:20 PM, Philippe Mathieu-Daudé a écrit : Hi Frederic, On 4/19/19 12:18 PM, KONRAD Frederic wrote: This adds a little bootloader to the leon3_machine when a ram image is given through the kernel parameter and no bios are provided: * The UART transmiter is enabled

[Qemu-devel] [PATCH V1 0/3] Leon3 patches

2019-04-19 Thread KONRAD Frederic
Tested with: qemu-system-sparc -M leon3_generic --nographic --kernel image.ram Regards, Fred KONRAD Frederic (3): leon3: add a little bootloader leon3: introduce the plug and play mecanism MAINTAINERS: add myself for leon3 MAINTAINERS | 1 + hw/misc/Makefile.obj

[Qemu-devel] [PATCH V1 2/3] leon3: introduce the plug and play mecanism

2019-04-19 Thread KONRAD Frederic
This adds the AHB and APB plug and play devices. They are scanned during the linux boot to discover the various peripheral. Signed-off-by: KONRAD Frederic --- hw/misc/Makefile.objs | 2 + hw/misc/grlib_ahb_apb_pnp.c | 269 hw/sparc

[Qemu-devel] [PATCH V1 1/3] leon3: add a little bootloader

2019-04-19 Thread KONRAD Frederic
This adds a little bootloader to the leon3_machine when a ram image is given through the kernel parameter and no bios are provided: * The UART transmiter is enabled. * The TIMER is initialized. Signed-off-by: KONRAD Frederic --- hw/sparc/leon3.c | 80

[Qemu-devel] [PATCH V1 3/3] MAINTAINERS: add myself for leon3

2019-04-19 Thread KONRAD Frederic
Signed-off-by: KONRAD Frederic --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 56139ac..3543035 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1151,6 +1151,7 @@ F: include/hw/timer/sun4v-rtc.h Leon3 M: Fabien Chouteau +M: KONRAD Frederic

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-04-16 Thread KONRAD Frederic
Le 3/12/19 à 6:36 PM, Markus Armbruster a écrit : Dear board code maintainers, Hi Markus, This is a (rather late) follow-up to the last QEMU summit. Minutes[*]: [...] = hw/sparc/leon3.c = Fabien Chouteau (maintainer:Leon3) Mark Cave-Ayland (maintainer:SPARC) Ar

Re: [Qemu-devel] [PATCH 3/9] chardev: use a child source for qio input source

2019-04-05 Thread KONRAD Frederic
Hi Marc, I did more experiments.. It seems to be an issue in glib-2.44.1 which is quite old. I updated and it seems I don't see the issue anymore. Thanks for your input on this! Cheers, Fred Le 4/4/19 à 5:49 PM, KONRAD Frederic a écrit : Le 4/4/19 à 5:44 PM, Marc-André Lureau a écrit 

Re: [Qemu-devel] [PATCH 3/9] chardev: use a child source for qio input source

2019-04-04 Thread KONRAD Frederic
Le 4/4/19 à 5:44 PM, Marc-André Lureau a écrit : Hi On Thu, Apr 4, 2019 at 5:18 PM KONRAD Frederic wrote: Hi guys, We have some random delays with gdbstub since this commit under Windows. Basically while debugging the next command can sometimes take more than 5 seconds while it usually

Re: [Qemu-devel] [PATCH 3/9] chardev: use a child source for qio input source

2019-04-04 Thread KONRAD Frederic
Hi guys, We have some random delays with gdbstub since this commit under Windows. Basically while debugging the next command can sometimes take more than 5 seconds while it usually tooks 30ms before. It is not target dependent I see that happening with sparc, ppc, riscv, etc.. but only on Windows

Re: [Qemu-devel] [PATCH v2] gdbstub: allow killing QEMU via vKill command

2019-02-01 Thread KONRAD Frederic
ess. Fixes: 7cf48f6752e5 ("gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo") Cc: Luc Michel Signed-off-by: Max Filippov Reviewed-by: Luc Michel Reviewed-by: KONRAD Frederic Tested-By: KONRAD Frederic Thanks! Fred --- Changes v1->v2: - terminate QEMU i

Re: [Qemu-devel] [PATCH] gdbstub: allow killing QEMU via vKill command

2019-01-30 Thread KONRAD Frederic
Le 1/30/19 à 3:31 PM, Luc Michel a écrit : Hi, On 1/30/19 2:37 PM, KONRAD Frederic wrote: Hi, Le 1/29/19 à 9:32 PM, Max Filippov a écrit : With multiprocess extensions gdb uses 'vKill' packet instead of 'k' to kill the inferior. Handle 'vKill' the same way &

Re: [Qemu-devel] [PATCH] gdbstub: allow killing QEMU via vKill command

2019-01-30 Thread KONRAD Frederic
Hi, Le 1/29/19 à 9:32 PM, Max Filippov a écrit : With multiprocess extensions gdb uses 'vKill' packet instead of 'k' to kill the inferior. Handle 'vKill' the same way 'k' was handled in the presence of single process. Fixes: 7cf48f6752e5 ("gdbstub: add multiprocess support to (f|s)ThreadInfo an

Re: [Qemu-devel] [PATCH] gdbstub: shutdown guest when the target is killed

2019-01-24 Thread KONRAD Frederic
Le 1/24/19 à 2:04 PM, Peter Maydell a écrit : On Thu, 24 Jan 2019 at 12:47, KONRAD Frederic wrote: Under MinGW when the target is killed no "W00" packet are received by GDB because gdbstub takes the "exit(0)" path. Why is this a problem? The gdb protocol documentatio

[Qemu-devel] [PATCH] gdbstub: shutdown guest when the target is killed

2019-01-24 Thread KONRAD Frederic
Under MinGW when the target is killed no "W00" packet are received by GDB because gdbstub takes the "exit(0)" path. So replace the "exit(0)" call by a normal guest shutdown so the "W00" packet has a chance to be sent in "gdb_cleanup". Signed-of

Re: [Qemu-devel] [Qemu-arm] Problems adding TMS570LC43 - Cortex-R5f

2019-01-18 Thread KONRAD Frederic
Le 1/17/19 à 7:00 PM, Philippe Mathieu-Daudé a écrit : Hi, On 1/17/19 5:54 PM, João Gaspar wrote: Hi! I'm new at QEMU so I have some questions. I'm trying to create a new support machine to QEMU, the TMS570LC43 board, this board use the Cortex-R5f microcontroller. At this moment when I do t

Re: [Qemu-devel] [PATCH] cpus.c: Fix race condition in cpu_stop_current()

2018-12-10 Thread KONRAD Frederic
Le 12/10/18 à 3:39 PM, Peter Maydell a écrit : On Mon, 10 Dec 2018 at 14:30, KONRAD Frederic wrote: Hi Peter, Thanks for that patch! I'm seeing the same kind of issue when I run 8 qemu in parallel but it doesn't seem to be fixed by this patch. Is it supposed to fix the issue w

Re: [Qemu-devel] [PATCH] cpus.c: Fix race condition in cpu_stop_current()

2018-12-10 Thread KONRAD Frederic
Hi Peter, Thanks for that patch! I'm seeing the same kind of issue when I run 8 qemu in parallel but it doesn't seem to be fixed by this patch. Is it supposed to fix the issue when we are doing a reset_request through a MMIO device? It happens (rarely) with this kind of guest code: exit: wri

Re: [Qemu-devel] crashes with win2008 host

2018-09-17 Thread KONRAD Frederic
requirement seems a good idea to me. Fred Andrew From: KONRAD Frederic Sent: Friday, September 14, 2018 4:17:36 AM To: Andrew Baumann; Andrey Shedel Cc: Paolo Bonzini; QEMU Developers Subject: Re: [Qemu-devel] crashes with win2008 host Ok finally got it, The

Re: [Qemu-devel] crashes with win2008 host

2018-09-14 Thread KONRAD Frederic
n Seven or 2008 R2. Cheers, Fred Le 09/14/2018 à 10:29 AM, KONRAD Frederic a écrit : Le 09/13/2018 à 07:29 PM, Andrew Baumann a écrit : Does this crash always happen at startup? Is it deterministic? Hi Andrew, Thanks for your reactivity! Yes it crashes all the time.. c135 is STATUS_DLL

Re: [Qemu-devel] crashes with win2008 host

2018-09-14 Thread KONRAD Frederic
42417 Is there anything I can do appart swaping back locally to the CS? Thanks, Fred BTW, you’ll probably get a better stack trace from a native debugger (windbg, etc.) in this scenario. Cheers, Andrew From: KONRAD Frederic Sent: Thursday, Septemb

[Qemu-devel] crashes with win2008 host

2018-09-13 Thread KONRAD Frederic
Hi Andrey, I've strange crashes since this commit: (yes its old) commit 12f8def0e02232d7c6416ad9b66640f973c531d1 Author: Andrey Shedel Date: Fri Mar 24 15:01:41 2017 -0700 win32: replace custom mutex and condition variable with native primitives Basically it just crashes.. (e

Re: [Qemu-devel] [PATCH 1/3] hw/ssi/xilinx_spips: Remove unneeded MMIO request_ptr code

2018-08-20 Thread KONRAD Frederic
Le 08/20/2018 à 10:53 AM, Peter Maydell a écrit : On 20 August 2018 at 09:49, KONRAD Frederic wrote: Le 08/17/2018 à 01:46 PM, Peter Maydell a écrit : We now support direct execution from MMIO regions in the core memory subsystem. This means that we don't need to have device-spe

Re: [Qemu-devel] [PATCH 3/3] hw/misc: Remove mmio_interface device

2018-08-20 Thread KONRAD Frederic
ydell Reviewed-by: KONRAD Frederic --- hw/misc/Makefile.objs| 1 - include/hw/misc/mmio_interface.h | 49 --- hw/misc/mmio_interface.c | 135 --- 3 files changed, 185 deletions(-) delete mode 100644 include/hw/misc/mmio_interface.h d

Re: [Qemu-devel] [PATCH 2/3] memory: Remove MMIO request_ptr APIs

2018-08-20 Thread KONRAD Frederic
Le 08/17/2018 à 01:46 PM, Peter Maydell a écrit : Remove the obsolete MMIO request_ptr APIs; they have no users now. Signed-off-by: Peter Maydell Reviewed-by: KONRAD Frederic --- include/exec/memory.h | 35 -- memory.c | 110

Re: [Qemu-devel] [PATCH 1/3] hw/ssi/xilinx_spips: Remove unneeded MMIO request_ptr code

2018-08-20 Thread KONRAD Frederic
calls by q->lqspi_cached_addr = ~0ULL; Otherwise: Reviewed-by: KONRAD Frederic { -XilinxSPIPS *s = &q->parent_obj; - -if ((q->mmio_execution_enabled) && (q->lqspi_cached_addr != ~0ULL)) { -/* Invalidate the current mapped mmio */ -memory_region_

Re: [Qemu-devel] [RFC PATCH 0/6] Clock and power gating support

2018-07-27 Thread KONRAD Frederic
Le 07/27/2018 à 04:59 PM, Peter Maydell a écrit : On 27 July 2018 at 15:37, Damien Hedde wrote: This set of patches add support for power and clock gating in device objects. It adds two booleans to the state, one for power state and one of clock state. The state is controlled trough 2 funct

[Qemu-devel] [PATCH for-3.0] qcow: fix a reference leak

2018-07-25 Thread KONRAD Frederic
bdrv_open_blockdev_ref(..) and in blk_insert_bs(..) but we unref it only once in blk_unref which leads to the reference leak. Note that I didn't tested much QCOW after this change as I don't use it much. Signed-off-by: KONRAD Frederic --- block/qcow.c | 1 + 1 file changed, 1 insertion(+) d

Re: [Qemu-devel] [PATCH 0/6] accel/tcg: Support execution from MMIO and small MMU regions

2018-07-16 Thread KONRAD Frederic
Hi Peter, Nice! Thanks for that. A little question though.. What will happen in the case where the CPU start executing code at random place because of eg: a badly configured kernel? Seeing the patch 5 I guess it will really execute stuff.. So maybe this is less user-friendly? Cheers, Fred On

Re: [Qemu-devel] [PATCH 4/4] audio/hda: detect output buffer overruns and underruns

2018-05-11 Thread KONRAD Frederic
On 04/25/2018 03:05 PM, Gerd Hoffmann wrote: On Mon, Apr 23, 2018 at 11:31:34AM +0200, KONRAD Frederic wrote: On 04/19/2018 03:10 PM, Gerd Hoffmann wrote: If some event caused some larger playback hickup the fine-grained timer adjust isn't able to recover. Use a buffer overrun

Re: [Qemu-devel] [PATCH V2 0/3] riscv: some little fix.

2018-05-03 Thread KONRAD Frederic
s/fix/fixes in the subject :/ Fred On 05/03/2018 05:17 PM, KONRAD Frederic wrote: Hi all, Here are some fixes for RISCV. The two firsts allow to map the HTIF @0x. The third one requires fdt to be present on the build machine so the build doesn't end with a linker error. Thanks,

[Qemu-devel] [PATCH V2 1/3] riscv: spike: allow base == 0

2018-05-03 Thread KONRAD Frederic
The sanity check on base doesn't allow htif to be mapped @0. Check if the symbol exists instead so we can map it where we want. Reviewed-by: Michael Clark Signed-off-by: KONRAD Frederic --- V1 -> V2: * Check that both symbols are set as suggested by Michael. --- hw/riscv/riscv_ht

[Qemu-devel] [PATCH V2 3/3] riscv: requires libfdt

2018-05-03 Thread KONRAD Frederic
tem-riscv64] Error 1 make: *** [subdir-riscv64-softmmu] Error 2 Reviewed-by: Bastian Koppelmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael Clark Signed-off-by: KONRAD Frederic --- V1 -> V2: * Requires libfdt for riscv*-softmmu instead of riscv64-softmmu only. --- configure

[Qemu-devel] [PATCH V2 2/3] riscv: htif: increase the priority of the htif subregion

2018-05-03 Thread KONRAD Frederic
8000-87ff (prio 0, ram): riscv.spike.ram Reviewed-by: Michael Clark Signed-off-by: KONRAD Frederic --- hw/riscv/riscv_htif.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/riscv/riscv_htif.c b/hw/riscv/riscv_htif.c index be252ec..f735129 100644 --- a/hw

[Qemu-devel] [PATCH V2 0/3] riscv: some little fix.

2018-05-03 Thread KONRAD Frederic
Hi all, Here are some fixes for RISCV. The two firsts allow to map the HTIF @0x. The third one requires fdt to be present on the build machine so the build doesn't end with a linker error. Thanks, Fred KONRAD Frederic (3): riscv: spike: allow base == 0 riscv: htif: increas

Re: [Qemu-devel] [PATCH v1 2/2] xlnx-zynqmp: Swap Cortex-R5 for Cortex-R5F

2018-05-03 Thread KONRAD Frederic
On 05/03/2018 01:56 PM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" The ZynqMP has Cortex-R5Fs with the optional FPU enabled. Seems ok to me according to the documentation. Reviewed-by: KONRAD Frederic Signed-off-by: Edgar E. Iglesias --- hw/arm/xlnx-zynqmp.c | 2 +

Re: [Qemu-devel] [PATCH v1 1/2] target-arm: Add the Cortex-R5F

2018-05-03 Thread KONRAD Frederic
On 05/03/2018 01:56 PM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Add the Cortex-R5F with the optional FPU enabled. Seems ok to me. Reviewed-by: KONRAD Frederic Signed-off-by: Edgar E. Iglesias --- target/arm/cpu.c | 9 + 1 file changed, 9 insertion

Re: [Qemu-devel] [PATCH 4/4] audio/hda: detect output buffer overruns and underruns

2018-05-02 Thread KONRAD Frederic
Hi Gerd, Sorry I didn't had time to try that yet. I'll try today! Thanks, Fred On 04/25/2018 03:05 PM, Gerd Hoffmann wrote: On Mon, Apr 23, 2018 at 11:31:34AM +0200, KONRAD Frederic wrote: On 04/19/2018 03:10 PM, Gerd Hoffmann wrote: If some event caused some larger playback

  1   2   3   >