ping
On 02/07/2018 12:48 PM, Klim Kireev wrote:
On one of our client's node, due to trying to read from closed ioc,
a segmentation fault occured. Corresponding backtrace:
0 object_get_class (obj=obj@entry=0x0)
1 qio_channel_readv_full (ioc=0x0, iov=0x7ffe55277180 ...
2 qio_channel_read
On 02/08/2018 10:13 PM, Thomas Huth wrote:
> On 30.01.2018 20:49, Paolo Bonzini wrote:
>> On 25/01/2018 08:51, Klim Kireev wrote:
>>> The following behavior was observed for QEMU configured by libvirt
>>> to use guest agent as usual for the guests without virtio-serial
such an occurrence.
Signed-off-by: Klim Kireev
---
Changelog:
v2: Attach the backtrace
v3: Change checks
ui/vnc-jobs.c | 6 --
ui/vnc.c | 15 ++-
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
index e326679dd0..868dddef4b 1006
close socket after recieving.
Signed-off-by: Klim Kireev
---
tests/test-filter-redirector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-filter-redirector.c b/tests/test-filter-redirector.c
index f2566144cf..fbaf19bbd8 100644
--- a/tests/test-filter-redirector.c
vents due to some
reasons the ioc_tag was set again and after vnc_disconnect_finish
the handler is running with freed ioc,
which led to the segmentation fault.
The patch checks vs->disconnecting in places where we call
qio_channel_add_watch to prevent such an occurrence.
Signed-off-by: Kli
vents due to some
reasons the ioc_tag was set again and after vnc_disconnect_finish
the handler is running with freed ioc,
which led to the segmentation fault.
I suggest to check ioc_tag in vnc_disconnect_finish to prevent such
an occurrence.
Signed-off-by: Klim Kireev
---
Changelog:
v2: Appl
e two events due to some
reasons the ioc_tag was set again and after vnc_disconnect_finish
the handler is running with freed ioc,
which led to the segmentation fault.
I suggest to check ioc_tag in vnc_disconnect_finish to prevent such
an occurrence.
Signed-off-by: Klim Kireev
---
ui/vnc.c | 4 ++
or not.
Signed-off-by: Klim Kireev
---
Changelog:
v2: Remove timer as a redundant feature
v3: Remove read call and return G_SOURCE_REMOVE
v4: Move to GSource API
v5: Fix git typos
chardev/char-socket.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/chardev/char-soc
or not.
Signed-off-by: Klim Kireev
---
Changelog:
v2: Remove timer as a redundant feature
v3: Remove read call and return G_SOURCE_REMOVE
v4: Move to GSource API
chardev/char-socket.c | 22 ++
dtc | 2 +-
2 files changed, 23 insertions(+), 1 deletion(-
or not.
Signed-off-by: Klim Kireev
---
Changelog:
v2: Remove timer as a redundant feature
v3: Remove read call and return G_SOURCE_REMOVE
chardev/char-socket.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/chardev/char-socket.c b/chardev/char
or not.
Signed-off-by: Klim Kireev
---
Changelog:
v2: Remove timer as a redundant feature
chardev/char-socket.c | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index 77cdf487eb..d3fe903ab6 100644
---
Signed-off-by: Klim Kireev
Reviewed-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
---
block/parallels.c | 5 +++--
block/parallels.h | 2 ++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index
understand libxml2 types.
Signed-off-by: Denis V. Lunev
Signed-off-by: Klim Kireev
Signed-off-by: Edgar Kaziakhmedov
CC: Stefan Hajnoczi
---
block/Makefile.objs | 2 ++
configure | 27 +++
scripts/checkpatch.pl | 1 +
3 files changed, 30 insertions
From: Edgar Kaziakhmedov
Since parallels format supports backing files, refine
readv/writev (allocate_clusters) to redirect read/write requests
to a backing file (if cluster is not available in the current bs).
Signed-off-by: Edgar Kaziakhmedov
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signe
Parallels Desktop and Parallels Cloud Server uses images glued with the
bundle description in XML format. This series contains very basic
description of this XML files and makes preparations for actual
implementation to be followed.
Signed-off-by: Edgar Kaziakhmedov
Signed-off-by: Klim Kireev
This patch adds main information about Parallels Disk
format, which consists of DiskDescriptor.xml and other files.
Signed-off-by: Edgar Kaziakhmedov
Signed-off-by: Klim Kireev
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
---
docs/interop/prl
To implement xml format, some defines and structures
from parallels.c are required.
Signed-off-by: Klim Kireev
Reviewed-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
---
block/parallels.c | 53 +-
block/parallels.h | 86
Signed-off-by: Klim Kireev
Reviewed-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
---
block/parallels.c | 5 +++--
block/parallels.h | 2 ++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index
understand libxml2 types.
Signed-off-by: Denis V. Lunev
Signed-off-by: Klim Kireev
Signed-off-by: Edgar Kaziakhmedov
CC: Stefan Hajnoczi
---
block/Makefile.objs | 2 ++
configure | 27 +++
scripts/checkpatch.pl | 1 +
3 files changed, 30 insertions
From: Edgar Kaziakhmedov
Since parallels format supports backing files, refine
readv/writev (allocate_clusters) to redirect read/write requests
to a backing file (if cluster is not available in the current bs).
Signed-off-by: Edgar Kaziakhmedov
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signe
This patch adds main information about Parallels Disk
format, which consists of DiskDescriptor.xml and other files.
Signed-off-by: Edgar Kaziakhmedov
Signed-off-by: Klim Kireev
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
---
docs/interop/prl
To implement xml format, some defines and structures
from parallels.c are required.
Signed-off-by: Klim Kireev
Reviewed-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
---
block/parallels.c | 53 +-
block/parallels.h | 86
Parallels Desktop and Parallels Cloud Server uses images glued with the
bundle description in XML format. This series contains very basic
description of this XML files and makes preparations for actual
implementation to be followed.
Signed-off-by: Edgar Kaziakhmedov
Signed-off-by: Klim Kireev
a or not. After closing the connection,
the guest has a capability to read the data within timeout.
Signed-off-by: Klim Kireev
---
chardev/char-socket.c | 55 ++-
1 file changed, 54 insertions(+), 1 deletion(-)
diff --git a/chardev/char-socket.c
heuristic to recognize the image format
for qcow, qcow2, vmdk, vhdx, vdi
It warns users about guessed format and informs them about '-f' option.
Signed-off-by: Klim Kireev
---
qemu-img.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/qemu-im
simple heuristic to recognize the image format
for qcow, qcow2, vmdk, vhdx, vdi
It warns users about guessed format and informs them about '-f' option.
Signed-off-by: Klim Kireev
---
qemu-img.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/qe
simple heuristic to recognize the image format
for qcow, qcow2, vmdk, vhdx, vdi
Signed-off-by: Klim Kireev
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
qemu-img.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 02a6e27beb
27 matches
Mail list logo
