[PATCH v4] tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test

Add test for issue #345 Signed-off-by: Kit Westneat --- tests/qtest/virtio-scsi-test.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c index 1b7ecc1c8f..8ceb12aacd 100644 --- a/tests/qtest

[PATCH v3 3/3] block/blkdebug: add log-blocksize and phys-blocksize parameters

Allow users to specify the logical and physical block sizes of the qdev for testing purposes. Signed-off-by: Kit Westneat --- block/blkdebug.c | 39 +-- qapi/block-core.json | 7 +++ 2 files changed, 40 insertions(+), 6 deletions(-) diff --git a

[PATCH v3 0/3] testing block device blocksizes

These patches add a few parameters to blkdebug to allow modification of the block device block sizes, both logical and physical. It also adds a test that uses the parameter to verify correct UNMAP behavior in devices with 4k blocks. v2: fixes style issues v3: adds parameters to qapi Kit Westneat

[PATCH v3 2/3] tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test

Add test for issue #345 Signed-off-by: Kit Westneat --- tests/qtest/virtio-scsi-test.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c index 1b7ecc1c8f..e569bda7d0 100644 --- a/tests/qtest

[PATCH v3 1/3] block/blkdebug: add blocksize parameter

Allow users to specify the block size of the qdev for testing purposes. Signed-off-by: Kit Westneat --- block/blkdebug.c | 29 + qapi/block-core.json | 4 2 files changed, 33 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug.c index 2c0b9b0ee8

Re: [PATCH 1/3] block/blkdebug: add blocksize parameter

Makes sense. Sorry for the basic question, but is that just a matter of adding it to qapi/block-core.json? Thanks, Kit On Tue, May 25, 2021 at 10:46 AM Eric Blake wrote: > On Tue, May 25, 2021 at 12:47:51PM +0000, Kit Westneat wrote: > > Allow users to specify the block size of the

[PATCH v2 3/3] block/blkdebug: add log-blocksize and phys-blocksize parameters

Allow users to specify the logical and physical block sizes of the qdev for testing purposes. Signed-off-by: Kit Westneat --- block/blkdebug.c | 39 +-- 1 file changed, 33 insertions(+), 6 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index

[PATCH v2 2/3] tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test

Add test for issue #345 Signed-off-by: Kit Westneat --- tests/qtest/virtio-scsi-test.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c index 1b7ecc1c8f..e569bda7d0 100644 --- a/tests/qtest

[PATCH v2 1/3] block/blkdebug: add blocksize parameter

Allow users to specify the block size of the qdev for testing purposes. Signed-off-by: Kit Westneat --- block/blkdebug.c | 29 + 1 file changed, 29 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug.c index 2c0b9b0ee8..d5f589920c 100644 --- a/block

[PATCH v2 0/3] testing block device blocksizes

These patches add a few parameters to blkdebug to allow modification of the block device block sizes, both logical and physical. It also adds a test that uses the parameter to verify correct UNMAP behavior in devices with 4k blocks. v2: fixes style issues Kit Westneat (3): block/blkdebug: add

[PATCH 2/3] tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test

Add test for issue #345 Signed-off-by: Kit Westneat --- tests/qtest/virtio-scsi-test.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c index 1b7ecc1c8f..6557e4f422 100644 --- a/tests/qtest

[PATCH 3/3] block/blkdebug: add log-blocksize and phys-blocksize parameters

Allow users to specify the logical and physical block sizes of the qdev for testing purposes. Signed-off-by: Kit Westneat --- block/blkdebug.c | 36 +++- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index

[PATCH 1/3] block/blkdebug: add blocksize parameter

Allow users to specify the block size of the qdev for testing purposes. Signed-off-by: Kit Westneat --- block/blkdebug.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug.c index 2c0b9b0ee8..c7500746a8 100644 --- a/block

[PATCH 0/3] testing block device blocksizes

These patches add a few parameters to blkdebug to allow modification of the block device block sizes, both logical and physical. It also adds a test that uses the parameter to verify correct UNMAP behavior in devices with 4k blocks. Kit Westneat (3): block/blkdebug: add blocksize parameter

Re: [PATCH] hw/scsi: Fix sector translation bug in scsi_unmap_complete_noio

h adding a blocksize parameter to blkdebug? (or maybe log-blksize & phys-blksize?) Or is there another way to set the blocksize of a qdev? Thanks, Kit On Fri, May 21, 2021 at 11:20 AM Paolo Bonzini wrote: > On 21/05/21 16:28, Kit Westneat wrote: > > check_lba_range expects sectors to b

[PATCH] hw/scsi: Fix sector translation bug in scsi_unmap_complete_noio

-off-by: Kit Westneat --- hw/scsi/scsi-disk.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 3580e7ee61..e8a547dbb7 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -1582,6 +1582,7 @@ invalid_field