When I try to build qga-vss.dll I get the following link error:
LINKqga/vss-win32/qga-vss.dll
/usr/lib64/gcc/i686-w64-mingw32/8.2.0/../../../../i686-w64-mingw32/bin/ld:
qga/vss-win32/requester.o: in function `requester_freeze':
/src/qemu/qga/vss-win32/requester.cpp:284: undefined reference to
>>>
> Quoting Paolo Bonzini (2015-11-11 08:49:57)
>>
>>
>> On 11/11/2015 15:02, Michael Roth wrote:
>> >> GENERIC_READ for files
>> >> = FILE_READ_DATA
>> >> + FILE_READ_ATTRIBUTES
>> >> + FILE_READ_EA
>> >> + SYNCHRONIZE
>> >> + STANDARD_RIGHTS_READ (wh
will append to the end fo the file.
Added white space to maintain the alignment of the guest_file_open_modes[].
Signed-off-by: Kirk Allan
---
qga/commands-win32.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-
>>>
>
> On 10/11/2015 16:40, Michael Roth wrote:
>>
>> I hit an issue testing this though, this does fix the append
>> case, but a+, ab+, a+b all imply append+read, while
>> FILE_APPEND_DATA only grants append access.
>>
>> FILE_APPEND_DATA|GENERIC_READ seems to work, but I'm not
>> finding
For append file open modes, use FILE_APPEND_DATA for the desired access for
writing at the end of the file.
Signed-off-by: Kirk Allan
---
qga/commands-win32.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index a5306e7
OnLinkPrefixLength. Setting --extra-cflags
in the build configuration to "-D_WIN32_WINNT=0x600"
or greater makes OnLinkPrefixLength available. Setting --extra-cflags
is not required and if not set, the default approach to get the prefix
will be taken.
Signed-off-by: Kirk Allan
---
qga/commands-win
commands-win32.c takes advantage of _WIN32_WINNT if set to 0x600
or greater for Windows Vista/2008 guests or newer to use OnLinkPrefixLength
for prefixes. WSAStringToAddress is used for inet_ntop functionality.
Kirk Allan (2):
qga: add win32 library iphlpapi
qga: win32
Add the iphlpapi library to use APIs such as GetAdaptersInfo and
GetAdaptersAddresses.
Signed-off-by: Kirk Allan
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 4e2f78a..60df96d 100755
--- a/configure
+++ b/configure
@@ -724,7 +724,7
>>>
>
> On 01/06/2015 23:19, Kirk Allan wrote:
>>> Elsewhere on the list, we've discussed putting extra cflags
>>> _after_ the configure-detected QEMU_CFLAGS. This would fix the
>>> issue in the first part of this patch too.
>>
>>
OnLinkPrefixLength. Setting --extra-cflags
in the build configuration to "-D_WIN32_WINNT=0x600 -DWINVER=0x600"
or greater makes OnLinkPrefixLength available. Setting --extra-cflags
is not required and if not set, the default approach to get the prefix
will be taken.
Signed-off-by: Kirk Allan
---
qg
implementation patch for commands-win32.c takes advantage of
_WIN32_WINNT if set to 0x600 or greater for Windows Vista/2008 guests
or newer to use OnLinkPrefixLength for prefixes. WSAStringToAddress
is used for inet_ntop functionality.
Kirk Allan (2):
qga: add additional win32 cflags and
: Kirk Allan
---
configure | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 4e2f78a..67bd9af 100755
--- a/configure
+++ b/configure
@@ -708,7 +708,12 @@ fi
if test "$mingw32" = "yes" ; then
EXESUF=".exe"
>>>
>
> On 01/06/2015 20:56, Kirk Allan wrote:
>> Test if *-extra-cflags is being used to include flags such as
>> _WIN32_WINVER and WINVER to gain additional functionality offered
>> by Windows Vista/2008 and newer. If not, default WINVER to 0x501.
>&
to 0x600 or greater for Windows Vista/2008 guests
or newer to use OnLinkPrefixLength for prefixes. WSAStringToAddress
is used for inet_ntop functionality.
Kirk Allan (2):
qga: add additional win32 cflags and libraries
qga: win32 qmp_guest_network_get_interfaces implementation
configure
: Kirk Allan
---
configure | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 4e2f78a..67bd9af 100755
--- a/configure
+++ b/configure
@@ -708,7 +708,12 @@ fi
if test "$mingw32" = "yes" ; then
EXESUF=".exe"
OnLinkPrefixLength. Setting -–extra-cflags
in the build configuration to ”- D_WIN32_WINNT-0x600 -DWINVER=0x600”
or greater makes OnLinkPrefixLength available. Setting –-ectra-cflags
is not required and if not set, the default approach to get the prefix
will be taken.
Signed-off-by: Kirk Allan
---
qga/commands
>>>
> On 05/28/2015 12:41 PM, Kirk Allan wrote:
>> Use *extra-cflags to set cflags to such as _WIN32_WINVER and WINVER to
>
> That Unicode mdash looks suspicious; did you mean for it to be two ASCII
> -- instead?
Your right, it is --extra-clfags. I'l
prefixes.
Kirk Allan (2):
qga: add additional win32 cflags and libraries
qga: win32 implementation of qmp_guest_network_get_interfaces
configure| 9 +-
qga/commands-win32.c | 292 ++-
2 files changed, 297 insertions(+), 4 deletions
Use –extra-cflags to set cflags to such as _WIN32_WINVER and WINVER to
add additional functionality offered in Windows Visat/2008 and newer.
Add the -DARCH_$ARCH cflag.
Add the iphlpapi library to use APIs such as GetAdaptersInfo and
GetAdaptersAddresses.
Signed-off-by: Kirk Allan
-cflags is not required and if not used,
the default approach will be taken.
Signed-off-by: Kirk Allan
---
qga/commands-win32.c | 292 ++-
1 file changed, 290 insertions(+), 2 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index
Thanks for the feedback. I'll make the necessary adjustments and create a new
patch.
Kirk
>>>
> On 01/04/15 18:39, Kirk Allan wrote:
>> By default, IP addresses and prefixes will be derived from information
>> obtained by various calls and structures. IPv
Use –extra-cflags to set cflags to such as _WIN32_WINVER and WINVER to
add additional functionality offered in Windows Visat/2008 and newer.
Add the -DARCH_$ARCH cflag.
Add the iphlpapi library to use APIs such as GetAdaptersInfo and
GetAdaptersAddresses.
Signed-off-by: Kirk Allan
.
The implementation patch for commands-win32.c is that same as before.
It will take advantage of _WIN32_WINNT if set to 0x600 or greater for
Windows Vista/2008 guests or newer to use inet_ntop and OnLinkPrefixLength
for getting addresses and prefixes.
Kirk Allan (2):
qga: add additional win32
-cflags is not required and if not used,
the default approach will be taken.
Signed-off-by: Kirk Allan
---
qga/commands-win32.c | 319 ++-
1 file changed, 317 insertions(+), 2 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index
>>>
> Hi Kirk,
>
> Am 30.03.2015 um 22:44 schrieb Kirk Allan:
>> Ping.
>>
>> Looking for feedback anyone might have regarding this patch.
>
> I would recommend to make the patch smaller and the commit message more
> intuitive by splitting
or
> greater,
> and 64 bit for Windows Vista/2008 or greater. The non Vista/2008 builds
> will
> run on Vista/2008 and greater without the extended functionality described
> above.
>
> Signed-off-by: Kirk Allan
> ---
> configure| 22 +++-
> qga/commands
the guest agent for 32 bit, 64 bit, 32 bit for Windows Vista/2008 or greater,
and 64 bit for Windows Vista/2008 or greater. The non Vista/2008 builds will
run on Vista/2008 and greater without the extended functionality described
above.
Signed-off-by: Kirk Allan
---
configure|
27 matches
Mail list logo
