Just a ping to make sure this patch hasn't been lost in the noise.
The relevant patchew page is
https://patchew.org/QEMU/20240403055002.890760-1-justinien.bou...@gmail.com/
Regards,
Justinien Bouron
> Again, QAPI schema
Pardon my ignorance, but are you writing this because there is a problem with
the QAPI schema changes that I would need to fix and re-submit?
Or is it just here to indicate that you've reviewed the change made to the
schema?
Regards,
Justinien Bouron
> Missed one little thing: the doc comment needs a (since 9.1).
Thanks for the input, I just submitted a v3 with the missing "(since 9.1)":
https://patchew.org/QEMU/20240403055002.890760-1-justinien.bou...@gmail.com/
Regards,
Justinien Bouron
toggle combination is entered. To avoid breaking
existing setups, the default value of grab-on-startup is true, i.e. same
behaviour as before this change.
Signed-off-by: Justinien Bouron
---
Changes since v2:
- Added missing (since 9.1) to the new option in qapi/qom.json
qapi/qom.json
Just a ping to make sure this patch hasn't been lost in the noise.
The relevant patchew page is
https://patchew.org/QEMU/20240322034311.2980970-1-justinien.bou...@gmail.com/.
Any chance to get this merged before the next release?
Regards,
Justinien
toggle combination is entered. To avoid breaking
existing setups, the default value of grab-on-startup is true, i.e. same
behaviour as before this change.
Signed-off-by: Justinien Bouron
---
Changes since v1:
- Revised commit message.
- Revised grab-on-startup description in qapi
Just a ping to make sure this patch hasn't been lost in the noise.
Any chance to get this merged? Should I send a v2 with a revised commit message?
Regards,
Justinien
> > > This last two lines doesn't make sense to me. Isn't the grab
> > > toggling entirely in control of the QEMU process, regardless
> > > of what state the guest is at ?
> >
> > Actually, you're right, they do not make sense. This issue of having the
> > guest
> > taking a while to start and the
> This last two lines doesn't make sense to me. Isn't the grab
> toggling entirely in control of the QEMU process, regardless
> of what state the guest is at ?
Actually, you're right, they do not make sense. This issue of having the guest
taking a while to start and the toggle keys not working, on
.
Signed-off-by: Justinien Bouron
---
qapi/qom.json| 13 -
ui/input-linux.c | 20 +++-
2 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/qapi/qom.json b/qapi/qom.json
index 032c6fa037..50e66d55cc 100644
--- a/qapi/qom.json
+++ b/qapi/qom.json
@@ -508,13
10 matches
Mail list logo
