Re: [PATCH v2 00/14] meson: Deprecate 32-bit host support

2025-02-04 Thread Juergen Gross
On 03.02.25 23:43, Stefano Stabellini wrote: +Xen maintainers On Mon, 3 Feb 2025, Richard Henderson wrote: On 2/3/25 04:54, Paolo Bonzini wrote: On 2/3/25 04:18, Richard Henderson wrote: v1: 20250128004254.33442-1-richard.hender...@linaro.org For v2, immediately disable 64-on-32 TCG. I *su

Re: [QEMU][PATCHv2 0/8] Xen: support grant mappings.

2023-11-13 Thread Juergen Gross
On 13.11.23 21:24, David Woodhouse wrote: On Fri, 2023-10-27 at 07:27 +0200, Juergen Gross wrote: On 26.10.23 22:56, Stefano Stabellini wrote: On Thu, 26 Oct 2023, David Woodhouse wrote: On Thu, 2023-10-26 at 13:36 -0700, Stefano Stabellini wrote: This seems like a lot of code to replace

Re: [QEMU][PATCHv2 0/8] Xen: support grant mappings.

2023-10-26 Thread Juergen Gross
On 26.10.23 22:56, Stefano Stabellini wrote: On Thu, 26 Oct 2023, David Woodhouse wrote: On Thu, 2023-10-26 at 13:36 -0700, Stefano Stabellini wrote: This seems like a lot of code to replace that simpler option... is there a massive performance win from doing it this way? Would we want to use

Re: [QEMU][PATCH v1 5/7] memory: add MemoryRegion map and unmap callbacks

2023-10-11 Thread Juergen Gross
On 10.10.23 02:17, Stefano Stabellini wrote: On Thu, 5 Oct 2023, Vikram Garhwal wrote: From: Juergen Gross In order to support mapping and unmapping guest memory dynamically to and from qemu during address_space_[un]map() operations add the map() and unmap() callbacks to MemoryRegionOps

Re: [QEMU][PATCH v2 10/11] hw/arm: introduce xenpv machine

2022-12-01 Thread Juergen Gross
On 02.12.22 04:00, Vikram Garhwal wrote: Add a new machine xenpv which creates a IOREQ server to register/connect with Xen Hypervisor. Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a TPM emulator and connects to swtpm running on host machine via chardev socket and

[Qemu-devel] [PATCH] pvusb: set max grants only in initialise

2018-12-06 Thread Juergen Gross
Don't call xen_be_set_max_grant_refs() in usbback_alloc(), as the gnttabdev pointer won't be initialised yet. The call can easily be moved to usbback_connect(). Signed-off-by: Juergen Gross --- hw/usb/xen-usb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-09 Thread Juergen Gross
On 09/11/2018 10:57, Li Zhijian wrote: > On 11/9/2018 3:20 PM, Ingo Molnar wrote: >> * Li Zhijian wrote: >> If the kernel initrd creation process creates an initrd which is larger than 2GB and also claims that it can't be placed with any part of it above 2GB, then that sounds like a

Re: [Qemu-devel] [PATCH RFC 1/6] xen: link against xentoolcore

2017-09-25 Thread Juergen Gross
On 25/09/17 17:08, Anthony PERARD wrote: > On Fri, Sep 22, 2017 at 02:14:16PM +0200, Juergen Gross wrote: >> On 15/09/17 20:09, Ian Jackson wrote: >>> Signed-off-by: Ian Jackson >>> --- >>> configure | 4 ++-- >>> 1 file changed, 2 insertions(+), 2

Re: [Qemu-devel] [PATCH RFC 1/6] xen: link against xentoolcore

2017-09-22 Thread Juergen Gross
On 15/09/17 20:09, Ian Jackson wrote: > Signed-off-by: Ian Jackson > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index fd7e3a5..c59a0c0 100755 > --- a/configure > +++ b/configure > @@ -2072,14 +2072,14 @@ if test "$xen" !=

[Qemu-devel] [PATCH v2 1/2] xen: add a global indicator for grant copy being available

2017-09-22 Thread Juergen Gross
availability of grant copy in xen_be_init() opening the gnttab device just for that purpose and closing it again afterwards. Advertise the availability via a global flag and use that flag in the qdisk backend. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD --- V2: - gboolean -> bool (Anth

[Qemu-devel] [PATCH v2 0/2] xen: fix gnttab handling with old dom0 kernels

2017-09-22 Thread Juergen Gross
Juergen Gross (2): xen: add a global indicator for grant copy being available xen: dont try setting max grants multiple times hw/block/xen_disk.c | 34 ++ hw/xen/xen_backend.c | 11 +++ include/hw/xen/xen_backend.h | 1 + 3 files changed

[Qemu-devel] [PATCH v2 2/2] xen: dont try setting max grants multiple times

2017-09-22 Thread Juergen Gross
of letting the generic backend code open the gnttab device do it in blk_connect() and close it again in blk_disconnect. Signed-off-by: Juergen Gross --- V2: - always call blk_disconnect() from blk_free() in order to have the gnttab device node closed (Anthony Perard) --- hw/block/xen_disk.c | 16

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen: dont try setting max grants multiple times

2017-09-22 Thread Juergen Gross
On 20/09/17 17:00, Anthony PERARD wrote: > On Tue, Sep 19, 2017 at 01:50:55PM +0200, Juergen Gross wrote: >> Trying to call xengnttab_set_max_grants() with the same file handle >> might fail on some kernels, as this operation is allowed only once. >> >> This is a probl

Re: [Qemu-devel] [PATCH 1/2] xen: add a global indicator for grant copy being available

2017-09-22 Thread Juergen Gross
On 20/09/17 16:53, Anthony PERARD wrote: > On Tue, Sep 19, 2017 at 01:50:54PM +0200, Juergen Gross wrote: >> The Xen qdisk backend needs to test whether grant copy operations is >> available in the kernel. Unfortunately this collides with using >> xengnttab_set_max_grants() on

[Qemu-devel] [PATCH 0/2] xen: fix gnttab handling with old dom0 kernels

2017-09-19 Thread Juergen Gross
Juergen Gross (2): xen: add a global indicator for grant copy being available xen: dont try setting max grants multiple times hw/block/xen_disk.c | 30 +- hw/xen/xen_backend.c | 11 +++ include/hw/xen/xen_backend.h | 1 + 3 files changed

[Qemu-devel] [PATCH 2/2] xen: dont try setting max grants multiple times

2017-09-19 Thread Juergen Gross
of letting the generic backend code open the gnttab device do it in blk_connect() and close it again in blk_disconnect. Signed-off-by: Juergen Gross --- hw/block/xen_disk.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c

[Qemu-devel] [PATCH 1/2] xen: add a global indicator for grant copy being available

2017-09-19 Thread Juergen Gross
availability of grant copy in xen_be_init() opening the gnttab device just for that purpose and closing it again afterwards. Advertise the availability via a global flag and use that flag in the qdisk backend. Signed-off-by: Juergen Gross --- hw/block/xen_disk.c | 18 ++ hw

Re: [Qemu-devel] [Xen-devel] [PATCH] configure: introduce --enable-xen-fb-backend

2017-04-17 Thread Juergen Gross
On 14/04/17 19:52, Stefano Stabellini wrote: > On Fri, 14 Apr 2017, Juergen Gross wrote: >> On 14/04/17 08:06, Oleksandr Andrushchenko wrote: >>> On 04/14/2017 03:12 AM, Stefano Stabellini wrote: >>>> On Tue, 11 Apr 2017, Oleksandr Andrushchenko wrote: >&

Re: [Qemu-devel] [Xen-devel] [PATCH] configure: introduce --enable-xen-fb-backend

2017-04-14 Thread Juergen Gross
On 14/04/17 08:06, Oleksandr Andrushchenko wrote: > On 04/14/2017 03:12 AM, Stefano Stabellini wrote: >> On Tue, 11 Apr 2017, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> For some use cases when Xen framebuffer/input backend >>> is not a part of Qemu it is required to d

Re: [Qemu-devel] [PATCH v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-04-05 Thread Juergen Gross
raf > Cc: Alex Williamson > Cc: Alistair Francis > Cc: Beniamino Galvani > Cc: Christian Borntraeger > Cc: Cornelia Huck > Cc: David Gibson > Cc: "Edgar E. Iglesias" > Cc: Eduardo Habkost > Cc: Frank Blaschka > Cc: Gabriel L. Somlo > Cc: Gerd Hof

Re: [Qemu-devel] [PATCH v4 1/8] xen: import ring.h from xen

2017-03-28 Thread Juergen Gross
On 29/03/17 01:54, Stefano Stabellini wrote: > On Tue, 28 Mar 2017, Juergen Gross wrote: >> On 28/03/17 00:48, Stefano Stabellini wrote: >>> On Mon, 27 Mar 2017, Juergen Gross wrote: >>>> On 24/03/17 18:37, Stefano Stabellini wrote: >>>>> On Fri, 24 M

Re: [Qemu-devel] [PATCH v4 1/8] xen: import ring.h from xen

2017-03-27 Thread Juergen Gross
On 28/03/17 00:48, Stefano Stabellini wrote: > On Mon, 27 Mar 2017, Juergen Gross wrote: >> On 24/03/17 18:37, Stefano Stabellini wrote: >>> On Fri, 24 Mar 2017, Juergen Gross wrote: >>>> On 23/03/17 19:22, Stefano Stabellini wrote: >>>>> On Thu, 23 M

Re: [Qemu-devel] [PATCH v4 1/8] xen: import ring.h from xen

2017-03-27 Thread Juergen Gross
On 24/03/17 18:37, Stefano Stabellini wrote: > On Fri, 24 Mar 2017, Juergen Gross wrote: >> On 23/03/17 19:22, Stefano Stabellini wrote: >>> On Thu, 23 Mar 2017, Paolo Bonzini wrote: >>>> On 23/03/2017 14:55, Juergen Gross wrote: >>>>> On 23/03/17 14:00

Re: [Qemu-devel] [PATCH v2] configure: use pkg-config for obtaining xen version

2017-03-27 Thread Juergen Gross
On 27/03/17 11:07, Paul Durrant wrote: >> -Original Message- >> From: Juergen Gross [mailto:jgr...@suse.com] >> Sent: 27 March 2017 08:43 >> To: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org >> Cc: Anthony Perard ; kra...@redhat.com; >>

[Qemu-devel] [PATCH v2] configure: use pkg-config for obtaining xen version

2017-03-27 Thread Juergen Gross
f the pkg-config output. This will avoid breaking an in-tree Xen build of an old Xen version while a new Xen version is installed on the build machine: pkg-config would pick up the installed Xen config files as the Xen tree wouldn't contain any of them. Signed-off-by: Juergen Gross --- V2:

Re: [Qemu-devel] [PATCH RESEND] xen: limit pkg-config to PKG_CONFIG_PATH for xen libraries

2017-03-26 Thread Juergen Gross
On 24/03/17 20:34, Paul Durrant wrote: >> -Original Message- >> From: Qemu-devel [mailto:qemu-devel- >> bounces+paul.durrant=citrix@nongnu.org] On Behalf Of Paul Durrant >> Sent: 24 March 2017 19:18 >> To: 'Stefano Stabellini' ; Juergen Gros

Re: [Qemu-devel] [PATCH RESEND] xen: limit pkg-config to PKG_CONFIG_PATH for xen libraries

2017-03-24 Thread Juergen Gross
ack to > previous methods of probing. > > Signed-off-by: Paul Durrant NAK. You are breaking normal qemu build with installed Xen pkg-config files. Juergen > --- > Cc: Anthony Perard > Cc: Stefano Stabellini > Cc: Juergen Gross > --- > configure | 12 >

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Juergen Gross
On 24/03/17 17:42, Paul Durrant wrote: >> -Original Message- > [snip] That's a change in behaviour that I, and probably others, have long been >> used to. What we really want, presumably, is to have pkg-config just look >> under tools/pkgconfig when querying for the version of xencontr

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Juergen Gross
On 24/03/17 16:51, Juergen Gross wrote: > On 24/03/17 16:44, Paul Durrant wrote: >>> -Original Message- >>> From: Juergen Gross [mailto:jgr...@suse.com] >>> Sent: 24 March 2017 15:35 >>> To: Paul Durrant ; 'Stefano Stabellin

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Juergen Gross
On 24/03/17 16:44, Paul Durrant wrote: >> -Original Message- >> From: Juergen Gross [mailto:jgr...@suse.com] >> Sent: 24 March 2017 15:35 >> To: Paul Durrant ; 'Stefano Stabellini' >> >> Cc: Anthony Perard ; xen- >> de...@lists.xenp

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Juergen Gross
On 24/03/17 16:12, Paul Durrant wrote: >> -Original Message- >> From: Stefano Stabellini [mailto:sstabell...@kernel.org] >> Sent: 22 March 2017 18:22 >> To: Juergen Gross >> Cc: Stefano Stabellini ; qemu-devel@nongnu.org; >> xen-de...@lists.xen

Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

2017-03-24 Thread Juergen Gross
On 24/03/17 14:50, Eduardo Habkost wrote: > On Fri, Mar 24, 2017 at 01:27:31PM +0100, Juergen Gross wrote: >> On 24/03/17 12:10, Eduardo Habkost wrote: >>> On Fri, Mar 24, 2017 at 11:24:31AM +0100, Juergen Gross wrote: >>>> On 24/03/17 11:09, Peter Maydell wrote: &

Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

2017-03-24 Thread Juergen Gross
On 24/03/17 12:10, Eduardo Habkost wrote: > On Fri, Mar 24, 2017 at 11:24:31AM +0100, Juergen Gross wrote: >> On 24/03/17 11:09, Peter Maydell wrote: >>> On 24 March 2017 at 08:23, Juergen Gross wrote: >>>> On 23/03/17 22:28, Eduardo Habkost wrote: >>>>&g

Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

2017-03-24 Thread Juergen Gross
On 24/03/17 11:09, Peter Maydell wrote: > On 24 March 2017 at 08:23, Juergen Gross wrote: >> On 23/03/17 22:28, Eduardo Habkost wrote: >>> The xen-backend devices created by the Xen code are not supposed >>> to be treated as dynamic sysbus devices. This is an attempt

Re: [Qemu-devel] [RFC 0/4] Replace has_dynamic_sysbus with device type whitelist

2017-03-24 Thread Juergen Gross
On 23/03/17 22:28, Eduardo Habkost wrote: > Summary > --- > > This series replaces the existing has_dynamic_sysbus flag (that > makes the machine accept every single sysbus device type on the > command-line) with a short whitelist. > > This will be helpful when implementing the new query-devi

Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

2017-03-24 Thread Juergen Gross
ll break Xen. NAK as a standalone patch. Juergen > > Cc: Juergen Gross > Cc: Stefano Stabellini > Signed-off-by: Eduardo Habkost > --- > hw/xen/xen_backend.c | 11 --- > 1 file changed, 11 deletions(-) > > diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c

Re: [Qemu-devel] [PATCH v4 1/8] xen: import ring.h from xen

2017-03-23 Thread Juergen Gross
On 23/03/17 19:22, Stefano Stabellini wrote: > On Thu, 23 Mar 2017, Paolo Bonzini wrote: >> On 23/03/2017 14:55, Juergen Gross wrote: >>> On 23/03/17 14:00, Greg Kurz wrote: >>>> On Mon, 20 Mar 2017 11:19:05 -0700 >>>> Stefano Stabellini wrote: >>&g

Re: [Qemu-devel] [PATCH v4 1/8] xen: import ring.h from xen

2017-03-23 Thread Juergen Gross
On 23/03/17 14:00, Greg Kurz wrote: > On Mon, 20 Mar 2017 11:19:05 -0700 > Stefano Stabellini wrote: > >> Do not use the ring.h header installed on the system. Instead, import >> the header into the QEMU codebase. This avoids problems when QEMU is >> built against a Xen version too old to provide

Re: [Qemu-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-21 Thread Juergen Gross
On 21/03/17 19:54, Stefano Stabellini wrote: > On Tue, 21 Mar 2017, Juergen Gross wrote: >> On 17/03/17 19:33, Stefano Stabellini wrote: >>> On Fri, 17 Mar 2017, Juergen Gross wrote: >>>> On 16/03/17 21:20, Stefano Stabellini wrote: >>>>> On Thu, 16 Mar

Re: [Qemu-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-20 Thread Juergen Gross
On 17/03/17 19:33, Stefano Stabellini wrote: > On Fri, 17 Mar 2017, Juergen Gross wrote: >> On 16/03/17 21:20, Stefano Stabellini wrote: >>> On Thu, 16 Mar 2017, Juergen Gross wrote: >>>> Instead of trying to guess the Xen version to use by compiling various >>

Re: [Qemu-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-16 Thread Juergen Gross
On 16/03/17 21:20, Stefano Stabellini wrote: > On Thu, 16 Mar 2017, Juergen Gross wrote: >> Instead of trying to guess the Xen version to use by compiling various >> test programs first just ask the system via pkg-config. Only if it >> can't return the version fall back

[Qemu-devel] [PATCH 0/2] xen: use pkg-config for configure

2017-03-16 Thread Juergen Gross
This small patch set is to be applied on top of Paul's series for support of libxendevicemodel, or (maybe even better) it should be merged into this series. Juergen Gross (2): xen: use 5 digit xen versions configure: use pkg-config for obtaining xen version configure

[Qemu-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-16 Thread Juergen Gross
Instead of trying to guess the Xen version to use by compiling various test programs first just ask the system via pkg-config. Only if it can't return the version fall back to the test program scheme. Signed-off-by: Juergen Gross --- configure | 31 +++ 1

[Qemu-devel] [PATCH 1/2] xen: use 5 digit xen versions

2017-03-16 Thread Juergen Gross
Today qemu is using e.g. the value 480 for Xen version 4.8.0. As some Xen version tests are using ">" relations this scheme will lead to problems when Xen version 4.10.0 is being reached. Instead of the 3 digit schem use a 5 digit scheme (e.g. 40800 for version 4.8.0). Signed-of

Re: [Qemu-devel] [PATCH v2 5/9] xen/9pfs: connect to the frontend

2017-03-14 Thread Juergen Gross
On 14/03/17 00:55, Stefano Stabellini wrote: > Write the limits of the backend to xenstore. Connect to the frontend. > Upon connection, allocate the rings according to the protocol > specification. > > Initialize a QEMUBH to schedule work upon receiving an event channel > notification from the fro

Re: [Qemu-devel] [PATCH v2 4/9] xen/9pfs: introduce Xen 9pfs backend

2017-03-14 Thread Juergen Gross
On 14/03/17 00:55, Stefano Stabellini wrote: > Introduce the Xen 9pfs backend: add struct XenDevOps to register as a > Xen backend and add struct V9fsTransport to register as v9fs transport. > > All functions are empty stubs for now. > > Signed-off-by: Stefano Stabellini > Reviewed-by: Greg Kurz

Re: [Qemu-devel] [Xen-devel] [PATCH 4/5] configure: detect presence of libxendevicemodel

2017-03-02 Thread Juergen Gross
On 02/03/17 12:06, Paul Durrant wrote: >> -Original Message- >> From: Juergen Gross [mailto:jgr...@suse.com] >> Sent: 02 March 2017 11:01 >> To: Anthony Perard ; Paul Durrant >> >> Cc: xen-de...@lists.xenproject.org; Stefano Stabellini >> ; qemu-d

Re: [Qemu-devel] [Xen-devel] [PATCH 4/5] configure: detect presence of libxendevicemodel

2017-03-02 Thread Juergen Gross
On 02/03/17 11:54, Anthony PERARD wrote: > On Thu, Mar 02, 2017 at 09:06:43AM +, Paul Durrant wrote: >>> -Original Message- >>> From: Anthony PERARD [mailto:anthony.per...@citrix.com] >>> Sent: 01 March 2017 17:18 >>> To: Paul Durrant >>> Cc: xen-de...@lists.xenproject.org; qemu-devel@

Re: [Qemu-devel] [PATCH v2] xen: use qdev_unplug() instead of g_free() in xen_pv_find_xendev()

2017-02-02 Thread Juergen Gross
On 01/02/17 21:20, Peter Maydell wrote: > On 1 February 2017 at 19:37, Stefano Stabellini > wrote: >> Hi Peter, >> >> do you think this is acceptable? > > The set of operations here is basically what I suggested > in review of v1, so I think it is the right thing. > OTOH this is a bit of an odd

[Qemu-devel] [PATCH v2] xen: use qdev_unplug() instead of g_free() in xen_pv_find_xendev()

2017-01-31 Thread Juergen Gross
evice"). Reported-by: Roger Pau Monné Tested-by: Roger Pau Monné Signed-off-by: Juergen Gross --- V2: set free method to avoid memory leak (Peter Maydell) use DEVICE(xendev) instead of &xendev->qdev (Peter Maydell) --- hw/xen/xen_backend.c | 13 +++-- 1 file changed, 7 insertion

Re: [Qemu-devel] [PATCH] xen: use qdev_unplug() insteda of g_free() in xen_pv_find_xendev()

2017-01-30 Thread Juergen Gross
On 30/01/17 16:46, Peter Maydell wrote: > On 30 January 2017 at 15:14, Juergen Gross wrote: >> The error exits of xen_pv_find_xendev() free the new xen-device via >> g_free() which is wrong. >> >> As the xen-device has been initialized as qdev it must be removed >&

[Qemu-devel] [PATCH] xen: use qdev_unplug() insteda of g_free() in xen_pv_find_xendev()

2017-01-30 Thread Juergen Gross
evice"). Reported-by: Roger Pau Monné Tested-by: Roger Pau Monné Signed-off-by: Juergen Gross --- hw/xen/xen_backend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c index d119004..030772b 100644 --- a/hw/xen/xen_backend.c ++

Re: [Qemu-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen

2017-01-27 Thread Juergen Gross
On 24/01/17 17:42, Roger Pau Monné wrote: > Hello, > > The following commit: > > commit 3a6c9172ac5951e6dac2b3f6cbce3cfccdec5894 > Author: Juergen Gross > Date: Tue Nov 22 07:10:58 2016 +0100 > > xen: create qdev for each backend device > > Prevents me from

Re: [Qemu-devel] [Xen-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen

2017-01-27 Thread Juergen Gross
On 26/01/17 22:21, Peter Maydell wrote: > On 26 January 2017 at 20:47, Peter Maydell wrote: >> On 26 January 2017 at 19:36, Stefano Stabellini >> wrote: >>> It should be just a matter of replacing qdev_init_nofail with something >>> that can fail. I couldn't find a regular qdev_init that can ret

[Qemu-devel] [PATCH v3 2/4] qdev: add function qdev_set_id()

2016-11-21 Thread Juergen Gross
In order to have an easy way to add a new qdev with a specific id carve out the needed functionality from qdev_device_add() into a new function qdev_set_id(). Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini --- include/monitor/qdev.h | 1 + qdev-monitor.c | 36

[Qemu-devel] [PATCH v3 0/4] xen: add qdevs for each backend, correct pvUSB

2016-11-21 Thread Juergen Gross
pvUSB only Juergen Gross (4): xen: add an own bus for xen backend devices qdev: add function qdev_set_id() xen: create qdev for each backend device xen: attach pvusb usb bus to backend qdev hw/usb/xen-usb.c | 23 +++ hw/xen/xen_backend.c | 66

[Qemu-devel] [PATCH v3 1/4] xen: add an own bus for xen backend devices

2016-11-21 Thread Juergen Gross
Add a bus for Xen backend devices in order to be able to establish a dedicated device path for pluggable devices. Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini --- hw/xen/xen_backend.c | 19 --- include/hw/xen/xen_backend.h | 4 2 files changed, 20

[Qemu-devel] [PATCH v3 4/4] xen: attach pvusb usb bus to backend qdev

2016-11-21 Thread Juergen Gross
Attach the usb bus of a new pvusb controller to the qdev associated with the Xen backend. Any device connected to that controller can now specify the bus and port directly via its properties. Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini --- hw/usb/xen-usb.c | 23

[Qemu-devel] [PATCH v3 3/4] xen: create qdev for each backend device

2016-11-21 Thread Juergen Gross
er which it is to be found in xenstore. Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini --- hw/xen/xen_backend.c | 47 hw/xen/xen_pvdev.c | 4 +++- include/hw/xen/xen_backend.h | 4 include/hw/xen/xen_pvdev.h |

[Qemu-devel] [PATCH v2 1/4] xen: add an own bus for xen backend devices

2016-11-02 Thread Juergen Gross
Add a bus for Xen backend devices in order to be able to establish a dedicated device path for pluggable devices. Signed-off-by: Juergen Gross --- hw/xen/xen_backend.c | 19 --- include/hw/xen/xen_backend.h | 4 2 files changed, 20 insertions(+), 3 deletions

[Qemu-devel] [PATCH v2 2/4] qdev: add function qdev_set_id()

2016-11-02 Thread Juergen Gross
In order to have an easy way to add a new qdev with a specific id carve out the needed functionality from qdev_device_add() into a new function qdev_set_id(). Signed-off-by: Juergen Gross --- include/monitor/qdev.h | 1 + qdev-monitor.c | 36 2

[Qemu-devel] [PATCH v2 4/4] xen: attach pvusb usb bus to backend qdev

2016-11-02 Thread Juergen Gross
Attach the usb bus of a new pvusb controller to the qdev associated with the Xen backend. Any device connected to that controller can now specify the bus and port directly via its properties. Signed-off-by: Juergen Gross --- hw/usb/xen-usb.c | 23 ++- 1 file changed, 10

[Qemu-devel] [PATCH v2 0/4] xed: add qdevs for each backend, correct pvUSB

2016-11-02 Thread Juergen Gross
possible the pvUSB controller has to be a hotpluggable qemu device. This is achieved by adding a qdev for each Xen backend all attached to a new Xen specific bus. Changes in V2: - one qdev for each backend instead of pvUSB only Juergen Gross (4): xen: add an own bus for xen backend devices qdev

[Qemu-devel] [PATCH v2 3/4] xen: create qdev for each backend device

2016-11-02 Thread Juergen Gross
er which it is to be found in xenstore. Signed-off-by: Juergen Gross --- hw/xen/xen_backend.c | 48 +++- hw/xen/xen_pvdev.c | 5 - include/hw/xen/xen_backend.h | 4 include/hw/xen/xen_pvdev.h | 1 + 4 files changed, 56 insert

Re: [Qemu-devel] [PATCH] xen-usb.c/usbif.h: fix ARM64 build issue

2016-10-19 Thread Juergen Gross
On 19/10/16 11:22, Wei Liu wrote: > On Wed, Oct 19, 2016 at 11:09:21AM +0200, Juergen Gross wrote: >> On 19/10/16 10:50, Wei Liu wrote: >>> On Tue, Oct 18, 2016 at 12:09:55PM -0700, Stefano Stabellini wrote: >>>> Hi all, >>>> >>>> While I w

Re: [Qemu-devel] [PATCH] xen-usb.c/usbif.h: fix ARM64 build issue

2016-10-19 Thread Juergen Gross
On 19/10/16 10:50, Wei Liu wrote: > On Tue, Oct 18, 2016 at 12:09:55PM -0700, Stefano Stabellini wrote: >> Hi all, >> >> While I was investigating the recent libxl ARM64 build issue, I found >> another ARM64 build problem. This one is in QEMU: >> >> >> CChw/usb/xen-usb.o >> hw/usb/xen-usb.c:

Re: [Qemu-devel] [PATCH 2/2] xen: add qemu device for each pvusb backend

2016-09-29 Thread Juergen Gross
On 27/09/16 11:08, Gerd Hoffmann wrote: > Hi, > >> struct usbback_info { >> struct XenDevice xendev; /* must be first */ >> +char id[24]; >> +struct USBBACKDevice *dev; >> USBBus bus; >> void *urb_srin

Re: [Qemu-devel] [PATCH 2/2] xen: add qemu device for each pvusb backend

2016-09-29 Thread Juergen Gross
On 27/09/16 11:00, Daniel P. Berrange wrote: > On Mon, Sep 26, 2016 at 02:43:57PM +0200, Juergen Gross wrote: >> In order to be able to specify to which pvusb controller a new pvusb >> device should be added we need a qemu device for each pvusb controller >> with an associated

Re: [Qemu-devel] [PATCH 1/2] xen: add an own bus for xen backend devices

2016-09-29 Thread Juergen Gross
On 27/09/16 10:53, Gerd Hoffmann wrote: > On Mo, 2016-09-26 at 14:43 +0200, Juergen Gross wrote: >> Add a bus for Xen backend devices in order to be able to establish a >> dedicated device path for pluggable devices. > > Looks sane to me. Can take this through the usb

Re: [Qemu-devel] [PATCH 0/2] Xen pvUSB correction

2016-09-29 Thread Juergen Gross
On 27/09/16 10:51, Gerd Hoffmann wrote: > On Mo, 2016-09-26 at 14:43 +0200, Juergen Gross wrote: >> Trying to use pvUSB in a Xen guest with a qemu emulated USB controller >> will crash qemu as it tries to attach a pvUSB device to the emulated >> controller. > > Hmm. -

[Qemu-devel] [PATCH 0/2] Xen pvUSB correction

2016-09-26 Thread Juergen Gross
possible the pvUSB controller has to be a hotpluggable qemu device. Juergen Gross (2): xen: add an own bus for xen backend devices xen: add qemu device for each pvusb backend hw/usb/xen-usb.c | 81 +--- hw/xen/xen_backend.c | 19

[Qemu-devel] [PATCH 2/2] xen: add qemu device for each pvusb backend

2016-09-26 Thread Juergen Gross
to that controller can now specify the bus and port directly via its properties. Signed-off-by: Juergen Gross --- hw/usb/xen-usb.c | 81 +++- 1 file changed, 68 insertions(+), 13 deletions(-) diff --git a/hw/usb/xen-usb.c b/hw/usb/xen-usb.c

[Qemu-devel] [PATCH 1/2] xen: add an own bus for xen backend devices

2016-09-26 Thread Juergen Gross
Add a bus for Xen backend devices in order to be able to establish a dedicated device path for pluggable devices. Signed-off-by: Juergen Gross --- hw/xen/xen_backend.c | 19 --- include/hw/xen/xen_backend.h | 4 2 files changed, 20 insertions(+), 3 deletions

Re: [Qemu-devel] [Xen-devel] [PATCH v2] xen: use native disk xenbus protocol if possible

2016-08-30 Thread Juergen Gross
On 05/07/16 16:55, Stefano Stabellini wrote: > On Wed, 29 Jun 2016, Anthony PERARD wrote: >> On Wed, Jun 29, 2016 at 05:50:48PM +0200, Juergen Gross wrote: >>> The qdisk implementation is using the native xenbus protocol only in >>> case of no protocol specified at al

Re: [Qemu-devel] [PATCH] xen: use a common function for pv and hvm guest backend register calls

2016-08-02 Thread Juergen Gross
On 02/08/16 20:27, Stefano Stabellini wrote: > On Tue, 2 Aug 2016, Juergen Gross wrote: >> Instead of calling xen_be_register() for each supported backend type >> for hvm and pv guests in their machine init functions use a common >> function in order not to have to a

[Qemu-devel] [PATCH v2 0/2] xen: bug fixes in Xen backend handling

2016-08-02 Thread Juergen Gross
Juergen Gross (2): xen: when removing a backend don't remove many of them xen: drain submit queue in xen-usb before removing device hw/usb/xen-usb.c | 94 ++-- hw/xen/xen_backend.c | 58 +++- 2 files change

[Qemu-devel] [PATCH v2 2/2] xen: drain submit queue in xen-usb before removing device

2016-08-02 Thread Juergen Gross
the call of complete, so add a flag to the request indicating it should be just dropped on complete. Signed-off-by: Juergen Gross --- hw/usb/xen-usb.c | 94 +--- 1 file changed, 62 insertions(+), 32 deletions(-) diff --git a/hw/usb/xen-usb.c b

[Qemu-devel] [PATCH v2 1/2] xen: when removing a backend don't remove many of them

2016-08-02 Thread Juergen Gross
endev() instead of only the domid and device index. This at once removes the open coded QTAILQ_FOREACH_SAVE() in xen_be_del_xendev() as there is no need to search for the correct xendev any longer. Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini --- hw/xen/xen_backend.c

Re: [Qemu-devel] [PATCH 2/2] xen: drain submit queue in xen-usb before removing device

2016-08-02 Thread Juergen Gross
On 02/08/16 13:37, Gerd Hoffmann wrote: > On Fr, 2016-07-29 at 13:17 +0200, Juergen Gross wrote: >> When unplugging a device in the Xen pvusb backend drain the submit >> queue before deallocation of the control structures. Otherwise there >> will be bogus memory accesses w

[Qemu-devel] [PATCH] xen: use a common function for pv and hvm guest backend register calls

2016-08-01 Thread Juergen Gross
Instead of calling xen_be_register() for each supported backend type for hvm and pv guests in their machine init functions use a common function in order not to have to add new backends twice. This at once fixes the error that hvm domains couldn't use the qusb backend. Signed-off-by: Ju

Re: [Qemu-devel] bug in usb_bus_release() ?

2016-07-29 Thread Juergen Gross
On 27/07/16 16:56, Juergen Gross wrote: > I can reproduce a problem in qemu with Xen just by adding and removing a > USB bus. The bus is added via usb_bus_new() in hw/usb/xen-usb.c and > removed later via usb_bus_release(). > > Nothing bad happens until I close an active VNC view

[Qemu-devel] [PATCH 2/2] xen: drain submit queue in xen-usb before removing device

2016-07-29 Thread Juergen Gross
the call of complete, so add a flag to the request indicating it should be just dropped on complete. Signed-off-by: Juergen Gross --- hw/usb/xen-usb.c | 93 1 file changed, 60 insertions(+), 33 deletions(-) diff --git a/hw/usb/xen-usb.c b

[Qemu-devel] [PATCH 1/2] xen: when removing a backend don't remove many of them

2016-07-29 Thread Juergen Gross
endev() instead of only the domid and device index. This at once removes the open coded QTAILQ_FOREACH_SAVE() in xen_be_del_xendev() as there is no need to search for the correct xendev any longer. Signed-off-by: Juergen Gross --- hw/xen/xen_backend.c

[Qemu-devel] [PATCH 0/2] xen: bug fixes in Xen backend handling

2016-07-29 Thread Juergen Gross
When testing qemu based pvusb backend two bugs have been discovered: - detaching of a usb controller leads to memory clobbering in qemu - detaching of a usb device with active I/O requests could result in crash of qemu Juergen Gross (2): xen: when removing a backend don't remove many of

[Qemu-devel] bug in usb_bus_release() ?

2016-07-27 Thread Juergen Gross
I can reproduce a problem in qemu with Xen just by adding and removing a USB bus. The bus is added via usb_bus_new() in hw/usb/xen-usb.c and removed later via usb_bus_release(). Nothing bad happens until I close an active VNC viewer connected to the graphical console emulated by the same qemu proc

Re: [Qemu-devel] [Xen-devel] Regression with commit 095497ffc66b7f031

2016-07-15 Thread Juergen Gross
On 15/07/16 14:42, Paolo Bonzini wrote: > > > On 15/07/2016 12:41, Juergen Gross wrote: >> On 15/07/16 12:35, Paolo Bonzini wrote: >>> >>> >>> On 15/07/2016 12:12, Gerd Hoffmann wrote: >>>> On Fr, 2016-07-15 at 12:02 +0200, Paolo Bonzini

Re: [Qemu-devel] Regression with commit 095497ffc66b7f031

2016-07-15 Thread Juergen Gross
On 15/07/16 12:35, Paolo Bonzini wrote: > > > On 15/07/2016 12:12, Gerd Hoffmann wrote: >> On Fr, 2016-07-15 at 12:02 +0200, Paolo Bonzini wrote: >>> >>> On 15/07/2016 10:47, Juergen Gross wrote: >>>> Nothing scaring and no real difference

Re: [Qemu-devel] Regression with commit 095497ffc66b7f031

2016-07-15 Thread Juergen Gross
On 15/07/16 11:03, Peter Lieven wrote: > Am 15.07.2016 um 10:47 schrieb Juergen Gross: >> On 15/07/16 09:39, Peter Lieven wrote: >>> Am 15.07.2016 um 08:32 schrieb Juergen Gross: >>>> Commit 095497ffc66b7f031ff2a17f1e50f5cb105ce588 ("vnc-enc-tight: use &g

Re: [Qemu-devel] Regression with commit 095497ffc66b7f031

2016-07-15 Thread Juergen Gross
On 15/07/16 09:39, Peter Lieven wrote: > Am 15.07.2016 um 08:32 schrieb Juergen Gross: >> Commit 095497ffc66b7f031ff2a17f1e50f5cb105ce588 ("vnc-enc-tight: use >> thread local storage for palette") introduced a regression with Xen: >> Since this commit qemu used

[Qemu-devel] Regression with commit 095497ffc66b7f031

2016-07-14 Thread Juergen Gross
Commit 095497ffc66b7f031ff2a17f1e50f5cb105ce588 ("vnc-enc-tight: use thread local storage for palette") introduced a regression with Xen: Since this commit qemu used as a device model is no longer capable to register Xenstore watches (that's the effect visible to a user). Reverting this commit make

Re: [Qemu-devel] [Xen-devel] [PATCH] xen: remove xenstore watches of backends when terminating qemu

2016-07-14 Thread Juergen Gross
On 13/07/16 14:31, Juergen Gross wrote: > Xenstore watches of the /local/domain//backend/ directories > are never removed. This can lead to a memory leak in xenstored, > especially when xenstored is running in another domain (this will be > the case either for a system with xenstore

[Qemu-devel] [PATCH] xen: remove xenstore watches of backends when terminating qemu

2016-07-13 Thread Juergen Gross
). Avoid this problem by calling xs_unwatch() for these directories when terminating qemu. Signed-off-by: Juergen Gross --- hw/xen/xen_backend.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c index

[Qemu-devel] [PATCH v2] xen: use native disk xenbus protocol if possible

2016-06-29 Thread Juergen Gross
native protocol in case word sizes of frontend and backend match. Signed-off-by: Juergen Gross --- V2: use native protocol in case of unknown protocol specified as requested by Anthony Perard --- hw/block/xen_disk.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff

Re: [Qemu-devel] [PATCH] xen: use native disk xenbus protocol if possible

2016-06-29 Thread Juergen Gross
On 29/06/16 17:20, Anthony PERARD wrote: > On Fri, Jun 17, 2016 at 01:14:56PM +0200, Juergen Gross wrote: >> The qdisk implementation is using the native xenbus protocol only in >> case of no protocol specified at all. As using the explicit 32- or >> 64-bit protocol is slowe

Re: [Qemu-devel] [Xen-devel] [PATCH] xen: use native disk xenbus protocol if possible

2016-06-27 Thread Juergen Gross
On 17/06/16 13:14, Juergen Gross wrote: > The qdisk implementation is using the native xenbus protocol only in > case of no protocol specified at all. As using the explicit 32- or > 64-bit protocol is slower than the native one due to copying requests > not by memcpy but element for e

Re: [Qemu-devel] [PATCH] xen-usb: Fix 32bit build

2016-06-23 Thread Juergen Gross
On 23/06/16 13:08, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross > --- > hw/usb/xen-usb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/usb/xen-usb.c b/hw/usb/xen-usb.c > index 0fd34c6..7bed0ce 100644 >

[Qemu-devel] [PATCH v3 2/2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-20 Thread Juergen Gross
in the BLKIF_OP_DISCARD case, too. Signed-off-by: Juergen Gross --- hw/block/xen_blkif.h | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/hw/block/xen_blkif.h b/hw/block/xen_blkif.h index 7ccf92e..0738684 100644 --- a/hw/block/xen_blkif.h +++ b/hw/block

[Qemu-devel] [PATCH v3 1/2] xen: fix style of hw/block/xen_blkif.h

2016-06-20 Thread Juergen Gross
Fix hw/block/xen_blkif.h to match qemu coding style. Signed-off-by: Juergen Gross --- hw/block/xen_blkif.h | 151 +++ 1 file changed, 81 insertions(+), 70 deletions(-) diff --git a/hw/block/xen_blkif.h b/hw/block/xen_blkif.h index e3b133b

[Qemu-devel] [PATCH v3 0/2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-20 Thread Juergen Gross
in the BLKIF_OP_DISCARD case, too. Changes in V3: - revert V2 - add patch 1 to use qemu coding style for hw/block/xen_blkif.h Changes in V2: - resync with Linux kernel version of hw/block/xen_blkif.h as suggested by Paul Durrant Juergen Gross (2): xen: fix style of hw/block/xen_blkif.h xen

Re: [Qemu-devel] [Xen-devel] [PATCH v2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-19 Thread Juergen Gross
On 17/06/16 18:10, Stefano Stabellini wrote: > On Fri, 17 Jun 2016, Paul Durrant wrote: >>> -Original Message- >>> From: Juergen Gross [mailto:jgr...@suse.com] >>> Sent: 17 June 2016 11:40 >>> To: Paul Durrant; Jan Beulich >>> Cc: Anthony

  1   2   >