Re: [Qemu-devel] Re: [kvm-devel] [PATCH][RFC] Allowing QEMU to directly execute a directory (and storing command line options in it)

2007-09-01 Thread Jorge Lucángeli Obes
On 9/1/07, Andreas Färber <[EMAIL PROTECTED]> wrote: > > What you are basically doing is taking up the concept of a bundle but > call it directory, do not give it a mandatory folder name extension > and limit the usefulness of the configuration file to your personal > needs. I think the problem he

Re: [Qemu-devel] Re: [kvm-devel] [PATCH][RFC] Allowing QEMU to directly execute a directory (and storing command line options in it)

2007-09-01 Thread Jorge Lucángeli Obes
> And I don't understand why, when going along with the bundle idea, > you are suddenly creating a new configuration file format of your > own. There is a standard format, XML or text based, which can be > easily parsed with OSX APIs (and thus likely *Step APIs as well) as a > dictionary, allowing

[Qemu-devel] Re: [kvm-devel] [PATCH][RFC] Allowing QEMU to directly execute a directory (and storing command line options in it)

2007-08-31 Thread Jorge Lucángeli Obes
On 8/31/07, Anthony Liguori <[EMAIL PROTECTED]> wrote: > It makes little sense to pass a directory when you can pass a config > file and assume that the directory the config file is in is the CWD. > > For instance, if vm.cfg contained just the command line arguments, you > could have: > > MyImage/v

[Qemu-devel] [PATCH][RFC] Allowing QEMU to directly execute a directory (and storing command line options in it)

2007-08-31 Thread Jorge Lucángeli Obes
tions separated by spaces or newlines. Careful reconstruction of the command line makes sure the speficied image file gets executed even if other image files were included later in the configuration file. Signed-off-by: Jorge Lucángeli Obes --- diff --git a/qemu/vl.c b/qemu/vl.c index fcc899b..88

[Qemu-devel] Making qemu images executable (and store command line arguments in them =P)

2007-08-15 Thread Jorge Lucángeli Obes
I've been giving some thought to Anthony's idea: http://kvm.qumranet.com/kvmwiki/Specs/StoringCommandLineInImage However, maybe I'm just too much on vacations, but I don't seem to come up with a nice way of doing this. Everything keeps coming back to creating a new 'container' image format and th

Re: [kvm-devel] [Qemu-devel] Re: Storing command line options in images

2007-08-14 Thread Jorge Lucángeli Obes
On 8/14/07, Laurent Vivier <[EMAIL PROTECTED]> wrote: > Markus Hitter wrote: > > > > Am 13.08.2007 um 11:19 schrieb Laurent Vivier: > > > >> We can modify qemu to test if the argument is a directory, if yes, it > >> reads args > >> from file args in this directory and for security the disk image mu

Re: [kvm-devel] [Qemu-devel] Re: Storing command line options in images

2007-08-13 Thread Jorge Lucángeli Obes
On 8/14/07, Anthony Liguori <[EMAIL PROTECTED]> wrote: > > On Mon, 2007-08-13 at 20:39 +0100, Thiemo Seufer wrote: > > Jorge Lucángeli Obes wrote: > > [snip] > > > When I read Avi's TODO, I basically thought about getting rid of the > > > long comma

Re: [Qemu-devel] [PATCH 4/4][RFC] Add logic to QEMU to read command line options from qcow2 images

2007-08-12 Thread Jorge Lucángeli Obes
On 8/11/07, Anthony Liguori <[EMAIL PROTECTED]> wrote: > On Sat, 2007-08-11 at 22:28 +0100, Philip Boulain wrote: > > This works, so long as qemu disregards "-read-args-from-image" unless it's > > being called as an interpreter. Otherwise, you've put the lock and the key > > in > > the same place.

Re: [kvm-devel] [Qemu-devel] Re: Storing command line options in images

2007-08-10 Thread Jorge Lucángeli Obes
> > My feeling is that config files are outdated. When used with a gui, > > you end up writing silly parsers and stuff and still wrecking things > > horribly when the the gui writer's expectations don't match reality. > > When used without a gui, they increase the amount of details one has > > to

[Qemu-devel] Storing command line options in images

2007-08-09 Thread Jorge Lucángeli Obes
Hi all, >From what I've gathered, it seems that we have basically four options at hand. I think it's important to notice, however, that whatever comes out of this will probably be, as Avi said, a "low-end" solution. IMHO there's room to have both the high-end libvirt-like approach, and the "shell

[Qemu-devel] [PATCH 4/4][RFC] Add logic to QEMU to read command line options from qcow2 images

2007-08-08 Thread Jorge Lucángeli Obes
This patch makes QEMU check for command line options stored in qcow2 images. Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> Signed-off-by: Jorge Lucángeli Obes <[EMAIL PROTECTED]> --- diff --git a/qemu/vl.c b/qemu/vl.c index 4ad39f1..1d28794 100644 --- a/qemu/vl.c +++ b/qemu/vl

[Qemu-devel] [PATCH 3/4][RFC] Add qemu-img option to store command line options into qcow2 images

2007-08-08 Thread Jorge Lucángeli Obes
This patch adds a new qemu-img option to store command line arguments in qcow2 snapshots. Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> Signed-off-by: Jorge Lucángeli Obes <[EMAIL PROTECTED]> --- diff --git a/qemu/qemu-img.c b/qemu/qemu-img.c index a259546..afa1fcc 100644 ---

[Qemu-devel] [PATCH 2/4][RFC] Add functions to manipulate image annotations

2007-08-08 Thread Jorge Lucángeli Obes
This patch adds block driver functions to use qcow2 image annotations. Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> Signed-off-by: Jorge Lucángeli Obes <[EMAIL PROTECTED]> --- diff --git a/qemu/block.c b/qemu/block.c index 39ec37a..4d794f6 100644 --- a/qemu/block.c +++ b/

[Qemu-devel] [PATCH 1/4][RFC] Allow storing arbitrary annotations in qcow2 images

2007-08-08 Thread Jorge Lucángeli Obes
This patch adds an extra 'annot' field to qcow2 snapshots, and updates serialization functions. Signed-off-by: Jorge Lucángeli Obes <[EMAIL PROTECTED]> --- diff --git a/qemu/block-qcow2.c b/qemu/block-qcow2.c index 0f7a069..361d300 100644 --- a/qemu/block-qcow2.c +++ b/qe

[Qemu-devel] Re: [kvm-devel] Storing command line options in qcow2 images

2007-08-06 Thread Jorge Lucángeli Obes
On 8/6/07, Anthony Liguori <[EMAIL PROTECTED]> wrote: > I don't think adding annotations as snapshots is the right approach. I > think proper support should be added in the header. I wouldn't be too > concerned with breaking compatibility in qcow2. That's why it's qcow2 > and not just an updated

[Qemu-devel] Re: [kvm-devel] Storing command line options in qcow2 images

2007-07-31 Thread Jorge Lucángeli Obes
On 7/30/07, Avi Kivity <[EMAIL PROTECTED]> wrote: > Jorge Lucángeli Obes wrote: > > Hi Avi, hi all, > > I believe that Laurent (copied) is also interested in this area. Copied him. > > I've started some (very minor) groundwork for this task. My idea was > >