[Qemu-devel] [PATCH] qemu: Fix -version with configure --with-pkgversion

2017-03-16 Thread Jordan Justen
version 2.8.90 (foo) Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers Cc: Paolo Bonzini Cc: Fam Zheng Fixes: https://bugs.launchpad.net/bugs/1673373 Cc: 1673...@bugs.launchpad.net Signed-off-by: Jordan Justen --- Makefile | 2 +- configure | 2 +- vl.c | 2 +- 3

[Qemu-devel] [Bug 1673373] [NEW] qemu -version output is incorrect with configure --with-pkgversion

2017-03-16 Thread Jordan Justen
-softmmu/qemu-system-x86_64 -version QEMU emulator version 2.6.50 (foo), Copyright (c) 2003-2008 Fabrice Bellard ** Affects: qemu Importance: Undecided Assignee: Jordan Justen (jljusten) Status: New ** Changed in: qemu Assignee: (unassigned) => Jordan Justen (jljusten)

Re: [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT

2015-10-23 Thread Jordan Justen
On 2015-10-23 05:53:17, Laszlo Ersek wrote: > On 10/23/15 09:26, Paolo Bonzini wrote: > > > > On 23/10/2015 06:41, Jordan Justen wrote: > >> On 2015-10-22 12:46:56, Paolo Bonzini wrote: > >>> > >>> On 22/10/2015 20:04, Kevin O'Connor wrote: &

[Qemu-devel] fw_cfg DMA security

2015-10-22 Thread Jordan Justen
Back when I was looking at fw_cfg support for -kernel in OVMF, I noted that it took a while to read the kernel. We improved the perf substantially by using a 'rep insb' instruction, which I think kvm special cases to minimize VM traps. Nevertheless, I thought that it would be good to implement a D

Re: [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT

2015-10-22 Thread Jordan Justen
On 2015-10-22 12:46:56, Paolo Bonzini wrote: > > On 22/10/2015 20:04, Kevin O'Connor wrote: > > On Thu, Oct 22, 2015 at 10:40:08AM +0200, Paolo Bonzini wrote: > >> On 21/10/2015 20:36, Jordan Justen wrote: > >>> On 2015-10-20 11:14:00, Laszlo Ersek wrote:

Re: [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT

2015-10-21 Thread Jordan Justen
s called by the TCO > watchdog; a watchdog is likely in its right to (asynchronously) inject > interrupts on the first CPU only. > > This patch allows the combined edk2/OVMF SMM driver stack to work with > multiple VCPUs on TCG, using both qemu-system-i386 and qemu-system-x86_64. >

Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable

2015-10-02 Thread Jordan Justen
On 2015-10-02 06:25:50, Laszlo Ersek wrote: > On 10/02/15 14:07, Gerd Hoffmann wrote: > > Hi, > > > >>> Any -kernel boot on x86 will use either linuxboot.bin or multiboot.bin. > >> > >> (Except when your firmware is OVMF -- OVMF has its own LoadLinuxLib. So, > >> if you decide to extend linuxboo

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Jordan Justen
On 2015-09-09 20:26:54, Andrew Fish wrote: > > On Sep 9, 2015, at 5:41 PM, Jordan Justen wrote: > > On 2015-09-09 16:05:20, Andrew Fish wrote: > >> So you have a legal degree and are speaking on behalf of your > >> employer on this subject? > > > > No an

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Jordan Justen
On 2015-09-09 16:05:20, Andrew Fish wrote: > > > On Sep 9, 2015, at 3:24 PM, Jordan Justen wrote: > > > > On 2015-09-09 12:11:26, El-Haj-Mahmoud, Samer wrote: > >> The recent expansions beyond BSD where all permissive licenses (BSD > >> like) as far as I c

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Jordan Justen
here. (And, why that doesn't also apply to FatBinPkg.) -Jordan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan > Justen > Sent: Wednesday, September 09, 2015 12:58 PM > To: Andrew Fish > Cc: Lenny Szubowicz ;

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Jordan Justen
On 2015-09-09 10:04:50, Andrew Fish wrote: > > > On Sep 9, 2015, at 9:17 AM, Jordan Justen wrote: > > > > So, related to this, I wonder how the community would feel about a > > GplDriverPkg. Would the community allow it as a new package in EDK II > > dire

[Qemu-devel] EDK II & GPL - Re: [edk2] OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Jordan Justen
On 2015-09-09 01:57:51, Laszlo Ersek wrote: > On 08/10/15 18:24, Laszlo Ersek wrote: > > Hi. > > > > Let's do an OVMF BoF at this year's KVM Forum too. > > Here's a preliminary task list, after some off-list discussion (I tried > to incorporate comments): > > - create GPL'd fork called "ovmf" fo

Re: [Qemu-devel] [PATCH v5 2/2] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-09 Thread Jordan Justen
Series Reviewed-by: Jordan Justen and committed. Thanks for the contribution! On 2015-06-08 17:16:14, Paulo Alcantara wrote: > This patch initialises root complex register block BAR in order to > support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT bit > not set

Re: [Qemu-devel] [edk2] [PATCH v3] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Jordan Justen
111 KB > +// 0xFED1C000RCRB 16 KB Should we make this conditional? // 0xFED1C000gap (PIIX4) / RCRB (ICH9) 16 KB ... and make mHostBridgeDevId a global var, and then conditionally add the memory io HOB? I don't think it is critical, but

Re: [Qemu-devel] [edk2] [PATCH] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Jordan Justen
On 2015-06-08 02:06:40, Laszlo Ersek wrote: > On 06/06/15 21:10, Paulo Alcantara wrote: > > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > > index 4cb70dc..a6586f3 100644 > > --- a/OvmfPkg/OvmfPkg.dec > > +++ b/OvmfPkg/OvmfPkg.dec > > @@ -78,6 +78,10 @@ > ># to PIIX4 function 3 offse

Re: [Qemu-devel] [edk2] [PATCH] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-06 Thread Jordan Justen
On 2015-06-06 12:10:03, Paulo Alcantara wrote: > This patch initialises root complex register block BAR in order to > support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT bit > not set) on QEMU. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Paulo Alcan

Re: [Qemu-devel] [PATCH] piix: fix 32bit pci hole

2013-11-26 Thread Jordan Justen
On Tue, Nov 26, 2013 at 8:16 AM, Gerd Hoffmann wrote: > Make the 32bit pci hole start at end of ram, so all possible address > space is covered. Of course the firmware can use less than that. > Leaving space unused is no problem, mapping pci bars outside the > hole causes problems though. > > Sig

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Jordan Justen
On Tue, Nov 26, 2013 at 5:32 AM, Laszlo Ersek wrote: > On 11/26/13 13:36, Markus Armbruster wrote: > >> Your stated purpose for multiple -pflash: >> >> This accommodates the following use case: suppose that OVMF is split in >> two parts, a writeable host file for non-volatile variable stor

Re: [Qemu-devel] [edk2 PATCH 1/1] OvmfPkg/AcpiPlatformDxe: download ACPI tables from QEMU

2013-11-22 Thread Jordan Justen
On Fri, Nov 22, 2013 at 10:49 AM, Laszlo Ersek wrote: > On 11/22/13 19:10, Jordan Justen wrote: >> Do we need to print all those fields? >> >> Anyway, maybe a better centralized place for this would be: >> MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c &g

Re: [Qemu-devel] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Jordan Justen
On Fri, Nov 22, 2013 at 12:54 PM, Eric Blake wrote: > On 11/22/2013 01:51 PM, Jordan Justen wrote: > >> Tangentially related idea: if the user specifies -pflash to a >> non-existent file, then QEMU could copy 'pflash-$(arch).bin' from the >> roms folder into that

Re: [Qemu-devel] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Jordan Justen
On Fri, Nov 22, 2013 at 10:43 AM, Laszlo Ersek wrote: > OTOH building all three FDs per default might be confusing for > end-users. We know for a fact that they usually don't read the README > (or not thoroughly enough). If we only give them one output file per > default, that's less potential for

Re: [Qemu-devel] [edk2 PATCH 1/1] OvmfPkg/AcpiPlatformDxe: download ACPI tables from QEMU

2013-11-22 Thread Jordan Justen
On Tue, Nov 12, 2013 at 7:11 AM, Laszlo Ersek wrote: > Qemu v1.7.0-rc0 features an ACPI linker/loader interface, available over > fw_cfg, written by Michael Tsirkin. > > Qemu composes all ACPI tables on the host side, according to the target > hardware configuration, and makes the tables available

Re: [Qemu-devel] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Jordan Justen
On Thu, Nov 21, 2013 at 2:21 PM, Laszlo Ersek wrote: > Split the variable store off to a separate file when SPLIT_VARSTORE is > defined. Is the goal to allow the central OVMF to be updated so the VM will automatically be running the newest firmware? (While preserving variables) I think in your s

Re: [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_system_flash_init() to pc_init1()

2013-11-07 Thread Jordan Justen
On Thu, Nov 7, 2013 at 2:23 PM, Laszlo Ersek wrote: > ... upwards through the following call chain: > > pc_init1() | pc_q35_init() > pc_memory_init() > pc_system_firmware_init() > pc_system_flash_init() > > Signed-off-by: Laszlo Ersek > --- > include/hw/i386/pc.h | 6 --

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-07 Thread Jordan Justen
On Sun, Nov 3, 2013 at 12:48 PM, Marcel Apfelbaum wrote: > The commit: > > Commit: a53ae8e934cd54686875b5bcfc2f434244ee55d6 > Author: Marcel Apfelbaum > Date: Mon Sep 16 11:21:16 2013 +0300 > > hw/pci: partially handle pci master abort > > introduced a regression on make check: Laszlo poin

Re: [Qemu-devel] [edk2] OVMF hung on qemu 1.6.0 with KVM

2013-08-31 Thread Jordan Justen
On Thu, Aug 29, 2013 at 8:28 PM, Gary Ching-Pang Lin wrote: > On Fri, Aug 30, 2013 at 02:04:40AM +1000, Bruce Rogers wrote: >> I tried this out, and I get the black screen as well when ept=n, but it boots >> successfully to the efi shell when ept=y. >> >> Gary, what does 'cat /sys/module/kvm_intel

Re: [Qemu-devel] [edk2] OVMF hung on qemu 1.6.0 with KVM

2013-08-30 Thread Jordan Justen
On Fri, Aug 30, 2013 at 11:44 AM, Paolo Bonzini wrote: > Il 30/08/2013 19:39, Jordan Justen ha scritto: >>> However, if you guys can figure out a patch for >>> > UefiCpuPkg/ResetVector/Vtf0/Ia32/Flat32ToFlat64.asm so that it builds >>> > the page tables in RAM

Re: [Qemu-devel] [edk2] OVMF hung on qemu 1.6.0 with KVM

2013-08-30 Thread Jordan Justen
On Fri, Aug 30, 2013 at 4:58 AM, Paolo Bonzini wrote: > However, if you guys can figure out a patch for > UefiCpuPkg/ResetVector/Vtf0/Ia32/Flat32ToFlat64.asm so that it builds > the page tables in RAM (and removing the page table Python code), that > would also work. That path is not quite how it

Re: [Qemu-devel] [edk2] OVMF hung on qemu 1.6.0 with KVM

2013-08-30 Thread Jordan Justen
On Fri, Aug 30, 2013 at 5:42 AM, Paolo Bonzini wrote: > Il 30/08/2013 14:10, Gleb Natapov ha scritto: >> On Fri, Aug 30, 2013 at 01:58:59PM +0200, Paolo Bonzini wrote: >>> Il 30/08/2013 11:37, Laszlo Ersek ha scritto: Disclaimer: I don't know what I'm talking about. >>> >>> No problem. :) >>>

Re: [Qemu-devel] support using KVM_MEM_READONLY flag for regions commit and OVMF UEFI incompatibility

2013-07-18 Thread Jordan Justen
11 >> open("/usr/share/qemu/vgabios-cirrus.bin", O_RDONLY) = 11 >> >>> file -L "/usr/share/qemu/vgabios-cirrus.bin" >> >> /usr/share/qemu/vgabios-cirrus.bin: BIOS (ia32) ROM Ext. IBM comp. Video >> (71*512) >> >> I managed to run it withou

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Jordan Justen
On Mon, Jun 10, 2013 at 6:03 PM, Anthony Liguori wrote: > On Mon, Jun 10, 2013 at 7:28 PM, Jordan Justen wrote: >> It couldn't hurt if more people that actually care about this spoke up >> on edk2-devel about the issue, or perhaps within a UEFI working group. >> Be

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Jordan Justen
On Mon, Jun 10, 2013 at 2:45 PM, Anthony Liguori wrote: > OVMF is proprietary. I don't agree that not-OSI means proprietary. I agree that the FAT driver is not 'free software' and I agree that is a problem for usage with free software projects, such as QEMU. This is a big deal, but unfortunately

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-06-04 Thread Jordan Justen
t; Il 04/06/2013 05:47, Dunrong Huang ha scritto: >> > > > >> > > > QEMU command: >> > > > ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 debian-append.img >> > > > >> > > > git bisect tells that the followi

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-06-03 Thread Jordan Justen
Fixed in 651eb0f4? On Mon, Jun 3, 2013 at 8:47 PM, Dunrong Huang wrote: > > QEMU command: > ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 debian-append.img > > git bisect tells that the following commit causes this bug: > > commit 235e8982ad393e5611cb892df54881c872ee

Re: [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-06-03 Thread Jordan Justen
On Mon, Jun 3, 2013 at 4:12 PM, Anthony Liguori wrote: > Jordan Justen writes: >> I mentioned in the other thread that perhaps QEMU could also consider >> making the ACPI code available under some 'appropriate' license, which >> would allow firmware writers t

Re: [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-06-03 Thread Jordan Justen
On Tue, May 14, 2013 at 6:34 AM, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > >> On Mon, May 13, 2013 at 03:38:51PM -0500, Anthony Liguori wrote: >>> I don't think it's a good idea to move BIOS functionality in QEMU. >> >> Just to clarify: generating ACPI tables is not BIOS >> function

Re: [Qemu-devel] [PATCH 0/3] Remove legacy sysfw code

2013-06-03 Thread Jordan Justen
as in QEMU 1.6 the same command may succeed if the kernel supports the READONLY kvm feature. Will one other result of this series be that basically any of the older pc machines can now use -pflash? Anyway, that doesn't seem like a big issue to me, so for the series: Reviewed-by: Jordan Justen

Re: [Qemu-devel] [PATCH 2/3] pc_sysfw: remove the rom_only property

2013-06-03 Thread Jordan Justen
On Mon, Jun 3, 2013 at 8:19 AM, Paolo Bonzini wrote: > With the new semantics of pc_sysfw (no -pflash implies "old-style" ROM setup, > -pflash implies "new-style" ROM setup), there is no need anymore for a compat > property. Old machines simply will never use -pflash, and thus will always > use o

Re: [Qemu-devel] [PATCH 3/3] pc_sysfw: do not make it a device anymore

2013-06-03 Thread Jordan Justen
Could you separate out the isapc_ram_fw part? It seems like a viable separate change, and a better way to handle that situation. -Jordan On Mon, Jun 3, 2013 at 8:19 AM, Paolo Bonzini wrote: > Move the code to hw/i386, the sole remaining property is available > as !pci_enabled. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible

2013-06-03 Thread Jordan Justen
On Mon, Jun 3, 2013 at 8:19 AM, Paolo Bonzini wrote: > The variable is not written anymore. > > Signed-off-by: Paolo Bonzini > --- > hw/block/pc_sysfw.c | 26 +- > 1 file changed, 1 insertion(+), 25 deletions(-) > > diff --git a/hw/block/pc_sysfw.c b/hw/block/pc_sysfw.c >

Re: [Qemu-devel] QEMU aborts since "kvm: support using KVM_MEM_READONLY flag for regions"

2013-06-03 Thread Jordan Justen
QEMU to operate, but without KVM. > > commit 235e8982ad393e5611cb892df54881c872eea9e1 > Author: Jordan Justen > Date: Wed May 29 01:27:26 2013 -0700 > > kvm: support using KVM_MEM_READONLY flag for regions > > For readonly memory regions and rom devices in romd_mode, > we m

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-06-03 Thread Jordan Justen
On Sun, Jun 2, 2013 at 2:43 AM, Michael S. Tsirkin wrote: > On Fri, May 31, 2013 at 01:45:55PM +0200, Laszlo Ersek wrote: >> On 05/31/13 09:09, Jordan Justen wrote: >> >> > Why is updating the ACPI tables in seabios viewed as such a burden? >> > Either qemu does

Re: [Qemu-devel] [PATCH uq/master] fix double free the memslot in kvm_set_phys_mem

2013-06-02 Thread Jordan Justen
Reviewed-by: Jordan Justen On Fri, May 31, 2013 at 1:52 AM, Xiao Guangrong wrote: > Luiz Capitulino reported that guest refused to boot and qemu > complained with: > kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument > > It is caused by commit 235e8982ad

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Jordan Justen
On Fri, May 31, 2013 at 5:01 PM, Laszlo Ersek wrote: > On 05/31/13 23:03, Jordan Justen wrote: > >> Of course, the fact that the current FAT driver is exclusionary for >> free software projects is a point that is not lost on me. I just don't >> agree that the best re

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread Jordan Justen
On Fri, May 31, 2013 at 2:32 AM, Gerd Hoffmann wrote: > Hi, > >> I guess -bios would load coreboot. Coreboot would siphon the data >> necessary for ACPI table building through the current (same) fw_cfg >> bottleneck, build the tables, > > Yes. So, this is really about making coreboot+seabios th

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Jordan Justen
On Fri, May 31, 2013 at 1:27 PM, Anthony Liguori wrote: > Jordan Justen writes: > >> On Fri, May 31, 2013 at 7:38 AM, Anthony Liguori >> wrote: >>> In terms of creating a FAT module, the most likely source would seem to >>> be the kernel code and since tha

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Jordan Justen
On Fri, May 31, 2013 at 11:35 AM, Anthony Liguori wrote: > As I think more about it, I think forking edk2 is inevitable. We need a > clean repo that doesn't include the proprietary binaries. I doubt > upstream edk2 is willing to remove the binaries. No, probably not unless a BSD licensed altern

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Jordan Justen
On Fri, May 31, 2013 at 7:38 AM, Anthony Liguori wrote: > In terms of creating a FAT module, the most likely source would seem to > be the kernel code and since that's GPL, I don't think it's terribly > avoidable to end up with a GPL'd uefi implementation. Why would OpenBSD not be a potential sou

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-31 Thread Jordan Justen
On Fri, May 31, 2013 at 12:14 AM, Jordan Justen wrote: > On Thu, May 30, 2013 at 11:51 PM, Xiao Guangrong > wrote: >> On 05/31/2013 12:50 AM, Jordan Justen wrote: >>> On Thu, May 30, 2013 at 9:08 AM, Luiz Capitulino >>> wrote: >>>> On Thu, 30 May 201

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-31 Thread Jordan Justen
On Thu, May 30, 2013 at 11:51 PM, Xiao Guangrong wrote: > On 05/31/2013 12:50 AM, Jordan Justen wrote: >> On Thu, May 30, 2013 at 9:08 AM, Luiz Capitulino >> wrote: >>> On Thu, 30 May 2013 18:03:04 +0200 >>> Paolo Bonzini wrote: >>> >>&g

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Jordan Justen
On Thu, May 30, 2013 at 7:34 PM, Kevin O'Connor wrote: > On Tue, May 28, 2013 at 07:53:09PM -0400, Kevin O'Connor wrote: >> There were discussions on potentially introducing a middle component >> to generate the tables. Coreboot was raised as a possibility, and >> David thought it would be okay t

Re: [Qemu-devel] [PATCH v7 1/4] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-30 Thread Jordan Justen
On Thu, May 30, 2013 at 7:06 PM, Kevin O'Connor wrote: > On Wed, May 29, 2013 at 01:27:24AM -0700, Jordan Justen wrote: >> The isapc machine with seabios currently requires the BIOS region >> to be read/write memory rather than read-only memory. >> >> KVM curren

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-30 Thread Jordan Justen
On Thu, May 30, 2013 at 2:23 PM, Paolo Bonzini wrote: > Il 30/05/2013 22:32, Luiz Capitulino ha scritto: >> On Thu, 30 May 2013 20:05:29 +0200 >> Paolo Bonzini wrote: >> >>> Il 30/05/2013 19:56, Luiz Capitulino ha scritto: >>>> On Thu, 30 May 201

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-30 Thread Jordan Justen
On Thu, May 30, 2013 at 10:03 AM, Luiz Capitulino wrote: > On Thu, 30 May 2013 09:50:10 -0700 > Jordan Justen wrote: >> On Thu, May 30, 2013 at 9:08 AM, Luiz Capitulino >> wrote: >> > On Thu, 30 May 2013 18:03:04 +0200 >> > Paolo Bonzini wrote: >> &g

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-30 Thread Jordan Justen
On Thu, May 30, 2013 at 9:41 AM, Laszlo Ersek wrote: > On 05/30/13 18:20, Jordan Justen wrote: >> I think ACPI table generation lives in firmware on real products, >> because on real products the firmware is the point that best >> understands the actual hardware layout for th

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-30 Thread Jordan Justen
On Thu, May 30, 2013 at 9:08 AM, Luiz Capitulino wrote: > On Thu, 30 May 2013 18:03:04 +0200 > Paolo Bonzini wrote: > >> Il 30/05/2013 17:46, Luiz Capitulino ha scritto: >> > The culprit is commit: >> > >> > commit 235e8982ad393e5611cb892df54881c872ee

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-30 Thread Jordan Justen
On Thu, May 30, 2013 at 5:19 AM, David Woodhouse wrote: > On Thu, 2013-05-30 at 13:13 +0200, Laszlo Ersek wrote: >> Where is CorebootPkg available from? > > https://github.com/pgeorgi/edk2/tree/coreboot-pkg Is the license on this actually BSD as the License.txt indicates? Is this planned to be u

[Qemu-devel] [PATCH v7 3/4] kvm: support using KVM_MEM_READONLY flag for regions

2013-05-29 Thread Jordan Justen
to the region will exit to qemu. (Note that a memory region in this state is not executable within kvm.) v7: * Update for readable => romd_mode rename (5f9a5ea1) Signed-off-by: Jordan Justen Reviewed-by: Xiao Guangrong (v4) Reviewed-by: Paolo Bonzini (v5) --- kvm-all.c |

[Qemu-devel] [PATCH v7 4/4] pc_sysfw: allow flash (-pflash) memory to be used with KVM

2013-05-29 Thread Jordan Justen
flash device is used with an older kvm which does not support this capability. If a flash device is not used, then qemu/kvm will operate in the original rom-mode. Signed-off-by: Jordan Justen Reviewed-by: Paolo Bonzini --- hw/block/pc_sysfw.c | 50

[Qemu-devel] [PATCH v7 1/4] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-29 Thread Jordan Justen
, this change avoids marking the BIOS as readonly for isapc. This change also will allow KVM to start supporting ROM mode via KVM_CAP_READONLY_MEM. Signed-off-by: Jordan Justen Reviewed-by: Paolo Bonzini --- hw/block/pc_sysfw.c | 16 +++- hw/i386/pc_piix.c |5 + 2 files

[Qemu-devel] [PATCH v7 2/4] kvm: add kvm_readonly_mem_enabled

2013-05-29 Thread Jordan Justen
Signed-off-by: Jordan Justen Reviewed-by: Paolo Bonzini --- include/sysemu/kvm.h | 10 ++ kvm-all.c|6 ++ kvm-stub.c |1 + 3 files changed, 17 insertions(+) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 08284ef..8b19322 100644 --- a

[Qemu-devel] [PATCH v7 0/4] KVM flash memory support

2013-05-29 Thread Jordan Justen
g a 'workaround' in patch 3 was actually what is required by the KVM READONLY memory support. v2: * Remove rom_only from PC_COMPAT_1_4 * Only enable flash when a pflash drive is created. Jordan Justen (4): isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS) kvm: add kv

Re: [Qemu-devel] [PATCH v2] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-15 Thread Jordan Justen
On Tue, May 14, 2013 at 7:57 AM, Anthony Liguori wrote: > Jordan Justen writes: > >> The isapc machine with seabios currently requires the BIOS region >> to be read/write memory rather than read-only memory. >> >> KVM currently cannot support the BIOS as a ROM regio

[Qemu-devel] [PATCH v6 0/4] KVM flash memory support

2013-05-15 Thread Jordan Justen
equired by the KVM READONLY memory support. v2: * Remove rom_only from PC_COMPAT_1_4 * Only enable flash when a pflash drive is created. Jordan Justen (4): isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS) kvm: add kvm_readonly_mem_enabled kvm: support using KVM_MEM_READONLY

[Qemu-devel] [PATCH v6 3/4] kvm: support using KVM_MEM_READONLY flag for regions

2013-05-15 Thread Jordan Justen
reads or writes to the region will exit to qemu. (Note that a memory region in this state is not executable within kvm.) Signed-off-by: Jordan Justen Reviewed-by: Xiao Guangrong (v4) Reviewed-by: Paolo Bonzini --- kvm-all.c | 38 +- 1 file changed, 29

[Qemu-devel] [PATCH v6 4/4] pc_sysfw: allow flash (-pflash) memory to be used with KVM

2013-05-15 Thread Jordan Justen
flash device is used with an older kvm which does not support this capability. If a flash device is not used, then qemu/kvm will operate in the original rom-mode. Signed-off-by: Jordan Justen Reviewed-by: Paolo Bonzini --- hw/block/pc_sysfw.c | 50

[Qemu-devel] [PATCH v6 2/4] kvm: add kvm_readonly_mem_enabled

2013-05-15 Thread Jordan Justen
Signed-off-by: Jordan Justen Reviewed-by: Paolo Bonzini --- include/sysemu/kvm.h | 10 ++ kvm-all.c|6 ++ kvm-stub.c |1 + 3 files changed, 17 insertions(+) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 08284ef..8b19322 100644 --- a

[Qemu-devel] [PATCH v6 1/4] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-15 Thread Jordan Justen
, this change avoids marking the BIOS as readonly for isapc. This change also will allow KVM to start supporting ROM mode via KVM_CAP_READONLY_MEM. Signed-off-by: Jordan Justen Reviewed-by: Paolo Bonzini --- hw/block/pc_sysfw.c | 16 +++- hw/i386/pc_piix.c |5 + 2 files

[Qemu-devel] [PATCH v2] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-13 Thread Jordan Justen
, this change avoids marking the BIOS as readonly for isapc. This change also will allow KVM to start supporting ROM mode via KVM_CAP_READONLY_MEM. Signed-off-by: Jordan Justen Reviewed-by: Paolo Bonzini --- v2: * Fix build issue with this patch. Apologies for not testing this patch outside

[Qemu-devel] [PATCH for-1.5] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-10 Thread Jordan Justen
, this change avoids marking the BIOS as readonly for isapc. This change also will allow KVM to start supporting ROM mode via KVM_CAP_READONLY_MEM. Signed-off-by: Jordan Justen Reviewed-by: Paolo Bonzini --- hw/block/pc_sysfw.c | 14 ++ hw/i386/pc_piix.c |5 + 2 files

[Qemu-devel] [PATCH v5 3/5] kvm: support using KVM_MEM_READONLY flag for regions

2013-05-08 Thread Jordan Justen
reads or writes to the region will exit to qemu. (Note that a memory region in this state is not executable within kvm.) Signed-off-by: Jordan Justen Reviewed-by: Xiao Guangrong (v4) --- kvm-all.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff

[Qemu-devel] [PATCH v5 1/5] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-08 Thread Jordan Justen
, this change avoids marking the BIOS as readonly for isapc. This change also will allow KVM to start supporting ROM mode via KVM_CAP_READONLY_MEM. Signed-off-by: Jordan Justen --- hw/block/pc_sysfw.c | 14 ++ hw/i386/pc_piix.c |5 + 2 files changed, 15 insertions(+), 4

[Qemu-devel] [PATCH v5 2/5] kvm: add kvm_readonly_mem_enabled

2013-05-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- include/sysemu/kvm.h | 10 ++ kvm-all.c|6 ++ kvm-stub.c |1 + 3 files changed, 17 insertions(+) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 9735c1d..13c4b2e 100644 --- a/include/sysemu/kvm.h +++ b

[Qemu-devel] [PATCH v5 5/5] pc_sysfw: change rom_only default to 0

2013-05-08 Thread Jordan Justen
Now KVM can support a flash memory. This feature depends on KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7. Flash memory will only be enabled if a pflash device is created. (For example, by using the -pflash command line parameter.) Signed-off-by: Jordan Justen --- hw/block/pc_sysfw.c

[Qemu-devel] [PATCH v5 4/5] pc_sysfw: allow flash (-pflash) memory to be used with KVM

2013-05-08 Thread Jordan Justen
flash device is used with an older kvm which does not support this capability. If a flash device is not used, then qemu/kvm will operate in the original rom-mode. Signed-off-by: Jordan Justen --- hw/block/pc_sysfw.c | 50 +++--- 1 file changed, 31

[Qemu-devel] [PATCH v5 0/5] KVM flash memory support

2013-05-08 Thread Jordan Justen
tch 2 & 3 based on Xiao's feedback that what I was calling a 'workaround' in patch 3 was actually what is required by the KVM READONLY memory support. v2: * Remove rom_only from PC_COMPAT_1_4 * Only enable flash when a pflash drive is created. Jordan Justen (5): isap

Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-07 Thread Jordan Justen
On Tue, May 7, 2013 at 3:25 PM, Paolo Bonzini wrote: > Il 08/05/2013 00:01, Jordan Justen ha scritto: >> On Tue, May 7, 2013 at 1:35 PM, Paolo Bonzini wrote: >>> Il 07/05/2013 19:15, Jordan Justen ha scritto: >>>> A slot that uses KVM_MEM_READONLY can be read from

Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-07 Thread Jordan Justen
On Tue, May 7, 2013 at 1:35 PM, Paolo Bonzini wrote: > Il 07/05/2013 19:15, Jordan Justen ha scritto: >> A slot that uses KVM_MEM_READONLY can be read from and code >> can execute from the region, but writes will trap. >> >> For regions that are readonly and also not

Re: [Qemu-devel] [PATCH v4 0/6] KVM flash memory support

2013-05-07 Thread Jordan Justen
On Tue, May 7, 2013 at 1:28 PM, Paolo Bonzini wrote: > Il 07/05/2013 19:15, Jordan Justen ha scritto: >> git://github.com/jljusten/qemu.git kvm-flash-v4 >> >> Utilize KVM_CAP_READONLY_MEM to support PC system flash emulation >> with KVM. >> >> v4: >>

Re: [Qemu-devel] [PATCH v2] gtk: Fix accelerator filtering

2013-05-07 Thread Jordan Justen
On Sun, Mar 24, 2013 at 11:06 AM, Jan Kiszka wrote: > On 2013-02-25 16:44, Jan Kiszka wrote: >> On 2013-02-25 16:39, Anthony Liguori wrote: >>> Jan Kiszka writes: >>> This is in fact very simply: When the input in grabbed, everything should be exclusively passed to the guest - except it

[Qemu-devel] [PATCH v4 4/6] pflash_cfi01: memory region should be set to enable readonly mode

2013-05-07 Thread Jordan Justen
mory region.) Signed-off-by: Jordan Justen --- hw/block/pflash_cfi01.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 3ff20e0..b65225e 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -596,6 +596,8 @@ static

[Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-07 Thread Jordan Justen
kvm.) Signed-off-by: Jordan Justen Reviewed-by: Xiao Guangrong --- kvm-all.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 1686adc..fffd2f4 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -201,12 +201,18

[Qemu-devel] [PATCH v4 0/6] KVM flash memory support

2013-05-07 Thread Jordan Justen
om PC_COMPAT_1_4 * Only enable flash when a pflash drive is created. Jordan Justen (6): isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS) kvm: add kvm_readonly_mem_enabled kvm: support using KVM_MEM_READONLY flag for readonly regions pflash_cfi01: memory region should be set

[Qemu-devel] [PATCH v4 1/6] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-07 Thread Jordan Justen
, this change avoids marking the BIOS as readonly for isapc. This change also will allow KVM to start supporting ROM mode via KVM_CAP_READONLY_MEM. Signed-off-by: Jordan Justen --- hw/block/pc_sysfw.c | 14 ++ hw/i386/pc_piix.c |5 + 2 files changed, 15 insertions(+), 4

[Qemu-devel] [PATCH v4 6/6] pc_sysfw: change rom_only default to 0

2013-05-07 Thread Jordan Justen
Now KVM can support a flash memory. This feature depends on KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7. Flash memory will only be enabled if a pflash device is created. (For example, by using the -pflash command line parameter.) Signed-off-by: Jordan Justen --- hw/block/pc_sysfw.c

[Qemu-devel] [PATCH v4 5/6] pc_sysfw: allow flash (-pflash) memory to be used with KVM

2013-05-07 Thread Jordan Justen
abort if a flash device is used with an older kvm which does not support this capability. If a flash device is not used, then qemu/kvm will operate in the original rom-mode. Signed-off-by: Jordan Justen --- hw/block/pc_sysfw.c | 50 +++--- 1 file

[Qemu-devel] [PATCH v4 2/6] kvm: add kvm_readonly_mem_enabled

2013-05-07 Thread Jordan Justen
Signed-off-by: Jordan Justen --- include/sysemu/kvm.h | 10 ++ kvm-all.c|6 ++ kvm-stub.c |1 + 3 files changed, 17 insertions(+) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 9735c1d..13c4b2e 100644 --- a/include/sysemu/kvm.h +++ b

Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Jordan Justen
On Mon, May 6, 2013 at 1:31 PM, Anthony Liguori wrote: > Jordan Justen writes: > >> On Mon, May 6, 2013 at 7:42 AM, Anthony Liguori wrote: >>> I believe I have processed all of the outstanding pull requests and >>> patches tagged for 1.5. If there are any other pa

Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Jordan Justen
On Mon, May 6, 2013 at 1:41 PM, Paolo Bonzini wrote: > Il 06/05/2013 22:31, Anthony Liguori ha scritto: >> Jordan Justen writes: >> >>> On Mon, May 6, 2013 at 7:42 AM, Anthony Liguori wrote: >>>> I believe I have processed all of the outstanding pull requ

Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Jordan Justen
On Mon, May 6, 2013 at 7:42 AM, Anthony Liguori wrote: > I believe I have processed all of the outstanding pull requests and > patches tagged for 1.5. If there are any other patches or pull requests > you would like to be considered, please respond to this note with a > pointer to the patch or ma

[Qemu-devel] [PATCH v3 4/5] pc_sysfw: allow flash (-pflash) memory to be used with KVM

2013-05-06 Thread Jordan Justen
abort if a flash device is used with an older kvm which does not support this capability. If a flash device is not used, then qemu/kvm will operate in the original rom-mode. Signed-off-by: Jordan Justen --- hw/block/pc_sysfw.c | 50 +++--- 1 file

[Qemu-devel] [PATCH v3 5/5] pc_sysfw: change rom_only default to 0

2013-05-06 Thread Jordan Justen
Now KVM can support a flash memory. This feature depends on KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7. Flash memory will only be enabled if a pflash device is created. (For example, by using the -pflash command line parameter.) Signed-off-by: Jordan Justen --- hw/block/pc_sysfw.c

[Qemu-devel] [PATCH v3 3/5] pflash_cfi01: memory region should be set to enable readonly mode

2013-05-06 Thread Jordan Justen
mory region.) Signed-off-by: Jordan Justen --- hw/block/pflash_cfi01.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 3ff20e0..b65225e 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -596,6 +596,8 @@ static

[Qemu-devel] [PATCH v3 1/5] kvm: add kvm_readonly_mem_enabled

2013-05-06 Thread Jordan Justen
Signed-off-by: Jordan Justen --- include/sysemu/kvm.h | 10 ++ kvm-all.c|6 ++ kvm-stub.c |1 + 3 files changed, 17 insertions(+) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 9735c1d..13c4b2e 100644 --- a/include/sysemu/kvm.h +++ b

[Qemu-devel] [PATCH v3 2/5] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-06 Thread Jordan Justen
kvm.) Signed-off-by: Jordan Justen Reviewed-by: Xiao Guangrong --- kvm-all.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 1686adc..fffd2f4 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -201,12 +201,18

[Qemu-devel] [PATCH v3 0/5] KVM flash memory support

2013-05-06 Thread Jordan Justen
ONLY memory support. v2: * Remove rom_only from PC_COMPAT_1_4 * Only enable flash when a pflash drive is created. Jordan Justen (5): kvm: add kvm_readonly_mem_enabled kvm: support using KVM_MEM_READONLY flag for readonly regions pflash_cfi01: memory region should be set to enable reado

[Qemu-devel] [PATCH v2 5/6] pc_sysfw: allow flash (-pflash) memory to be used with KVM

2013-05-01 Thread Jordan Justen
abort if a flash device is used with an older kvm which does not support this capability. If a flash device is not used, then qemu/kvm will operate in the original rom-mode. Signed-off-by: Jordan Justen --- hw/block/pc_sysfw.c | 50 +++--- 1 file

[Qemu-devel] [PATCH v2 3/6] kvm: workaround a possible KVM bug when using KVM_MEM_READONLY

2013-05-01 Thread Jordan Justen
On a Linux 3.8.0 based kernel, I occasionally saw a situation where the memory region would continue to trap on memory read even though KVM_MEM_READONLY was set. I found that if I set the slot to a size of 0, and before setting the slot, it would then behave as expected. Signed-off-by: Jordan

[Qemu-devel] [PATCH v2 2/6] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-01 Thread Jordan Justen
kvm.) Signed-off-by: Jordan Justen Cc: Xiao Guangrong --- kvm-all.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index f634c41..95e6bf2 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -266,9 +266,14 @@ err: * dirty pages

[Qemu-devel] [PATCH v2 6/6] pc_sysfw: change rom_only default to 0

2013-05-01 Thread Jordan Justen
Now KVM can support a flash memory. This feature depends on KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7. Flash memory will only be enabled if a pflash device is created. (For example, by using the -pflash command line parameter.) Signed-off-by: Jordan Justen --- hw/block/pc_sysfw.c

  1   2   3   >