Re: [RFC PATCH v3 08/15] hw/arm/smmuv3-accel: Add set/unset_iommu_device callback

2025-07-16 Thread Jonathan Cameron via
On Tue, 15 Jul 2025 10:01:21 -0700 Nicolin Chen wrote: > On Tue, Jul 15, 2025 at 11:29:41AM +0100, Jonathan Cameron wrote: > > > +if (!iommufd_backend_alloc_viommu(idev->iommufd, idev->devid, > > > + I

Re: [RFC PATCH v3 15/15] hw/arm/smmu-common: Add accel property for SMMU dev

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:41 +0100 Shameer Kolothum wrote: > Now user can set "accel=on". Have fun! > > Signed-off-by: Shameer Kolothum Hard to argue with this one ;) Reviewed-by: Jonathan Cameron > --- > hw/arm/smmu-common.c | 1 + > 1 file changed, 1 inser

Re: [RFC PATCH v3 14/15] Read and validate host SMMUv3 feature bits

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:40 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Not all fields in the SMMU IDR registers are meaningful for userspace. > Only the following fields can be used: > >   - IDR0: ST_LEVEL, TERM_MODEL, STALL_MODEL, TTENDIAN, CD2L, ASID16, TTF   >   - IDR1: SIDSIZE

Re: [RFC PATCH v3 13/15] hw/arm/smmuv3: Forward invalidation commands to hw

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:39 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Use the provided smmuv3-accel helper functions to issue the > invalidation commands to host SMMUv3. > > Signed-off-by: Nicolin Chen > Signed-off-by: Shameer Kolothum > --- > hw/arm/smmuv3-internal.h | 11 +++

Re: [RFC PATCH v3 12/15] hw/arm/smmuv3-accel: Introduce helpers to batch and issue cache invalidations

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:38 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Helpers will batch the commands and issue at once to host SMMUv3. > > Signed-off-by: Nicolin Chen > Signed-off-by: Shameer Kolothum > --- > hw/arm/smmuv3-accel.c| 65 +

Re: [RFC PATCH v3 08/15] hw/arm/smmuv3-accel: Add set/unset_iommu_device callback

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:34 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Implement a set_iommu_device callback: > -If found an existing viommu reuse that. >(Devices behind the same physical SMMU should share an S2 HWPT) > -Else, > Allocate a viommu with the nested parent S2

Re: [RFC PATCH v3 06/15] hw/arm/smmuv3-accel: Restrict accelerated SMMUv3 to vfio-pci endpoints with iommufd

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:32 +0100 Shameer Kolothum wrote: > Accelerated SMMUv3 is only useful when the device can take advantage of > the host's SMMUv3 in nested mode. To keep things simple and correct, we > only allow this feature for vfio-pci endpoint devices that use the iommufd > backend. We

Re: [RFC PATCH v3 05/15] hw/arm/smmuv3-accel: Introduce smmuv3 accel device

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:31 +0100 Shameer Kolothum wrote: > Also setup specific PCIIOMMUOps for accel SMMUv3 as accel > SMMUv3 will have different handling for those ops callbacks > in subsequent patches. > > The "accel" property is not yet added, so users cannot set it at this > point. It will

Re: [RFC PATCH v3 04/15] hw/arm/smmu-common: Introduce smmu_iommu_ops_by_type() helper

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:30 +0100 Shameer Kolothum wrote: > Allows to retrieve the PCIIOMMUOps based on the SMMU type. This will be > useful when we add support for accelerated SMMUV3 in subsequent patches > as that requires a different set of callbacks for iommu ops. > > No special handling is

Re: [RFC PATCH v3 03/15] hw/arm/smmu-common: Factor out common helper functions and export

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:29 +0100 Shameer Kolothum wrote: > Subsequent patches for smmuv3 accel support will make use of this. > > Signed-off-by: Nicolin Chen > Reviewed-by: Eric Auger > Signed-off-by: Shameer Kolothum Various trivial things inline. In general looks fine. J > --- > hw/ar

Re: [RFC PATCH v3 02/15] backends/iommufd: Introduce iommufd_vdev_alloc

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:28 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Add a helper to allocate an iommufd device's virtual device (in the user > space) per a viommu instance. Same trivial suggestion as in patch 1. Also feel free to ignore.

Re: [RFC PATCH v3 01/15] backends/iommufd: Introduce iommufd_backend_alloc_viommu

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:27 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Add a helper to allocate a viommu object. > > Signed-off-by: Nicolin Chen > Reviewed-by: Eric Auger > Signed-off-by: Shameer Kolothum One trivial comment inline. Feel free to ignore. > --- > backends/iomm

Re: [PATCH v7 00/36] ACPI PCI Hotplug support on ARM

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 10:04:44 +0200 Eric Auger wrote: > This series enables ACPI PCI hotplug/hotunplug on ARM. > It is not enabled by default and ACPI PCI hotplug can > be selected by setting: > > -global acpi-ged.acpi-pci-hotplug-with-bridge-support=on > > Expected benefits should be similar t

[PATCH qemu v2 09/11] hw/cxl: Create helper function to create DC Event Records from extents

2025-07-14 Thread Jonathan Cameron via
by cxl-mailbox-utils.c and cxl-events.c, where the helper function is defined. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- v2 of set to merge: Picked up Fan's tag. Thanks! --- include/hw/cxl/cxl.h| 1 + include/hw/cxl/cxl_device.h | 4 h

[PATCH qemu v2 06/11] hw/mem: cxl_type3: Add DC Region bitmap lock

2025-07-14 Thread Jonathan Cameron via
that add/release extents (meaning they update the bitmap too) are enabled on a different CCI than the CCI on which the FMAPI commands are enabled. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 1 + hw/mem/cxl_type3.c | 4 ++

[PATCH qemu v2 11/11] hw/cxl: mailbox-utils: 0x5605 - FMAPI Initiate DC Release

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5605 implemented per CXL r3.2 Spec Section 7.6.7.6.6 Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 88 ++ 1 file changed, 88 insertions(+) diff

[PATCH qemu v2 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5602 implemented per CXL r3.2 Spec Section 7.6.7.6.3 Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- v2 of set to merge: - Fixed blksize check in set dc region config - Added check that it is a power of 2 (and host

[PATCH qemu v2 10/11] hw/cxl: mailbox-utils: 0x5604 - FMAPI Initiate DC Add

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5604 implemented per CXL r3.2 Spec Section 7.6.7.6.5 Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 4 ++ hw/cxl/cxl-mailbox-utils.c | 109 hw

[PATCH qemu v2 08/11] hw/cxl: mailbox-utils: 0x5603 - FMAPI Get DC Region Extent Lists

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5603 implemented per CXL r3.2 Spec Section 7.6.7.6.4 Very similar to previously implemented command 0x4801. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- v2 for merge: - Added a missing : in a comment similar to Fan

[PATCH qemu v2 04/11] hw/cxl: mailbox-utils: 0x5601 - FMAPI Get Host Region Config

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5601 implemented per CXL r3.2 Spec Section 7.6.7.6.2 Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 106 + 1 file changed, 106 insertions(+) diff

[PATCH qemu v2 05/11] hw/cxl: Move definition for dynamic_capacity_uuid and enum for DC event types to header

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su Move definition/enum to cxl_events.h for shared use in next patch Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_events.h | 15 +++ hw/mem/cxl_type3.c | 15 --- 2 files changed, 15 insertions

[PATCH qemu v2 03/11] hw/mem: cxl_type3: Add dsmas_flags to CXLDCRegion struct

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su Add booleans to DC Region struct to represent dsmas flags (defined in CDAT) in preparation for the next command, which returns the flags in the next mailbox command 0x5601. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- v2 for merge - Added

[PATCH qemu v2 02/11] hw/cxl: mailbox-utils: 0x5600 - FMAPI Get DCD Info

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5600 implemented per CXL 3.2 Spec Section 7.6.7.6.1. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- v2 series for merge. - Modify the code that fills in the support blk sizes to not do effectively 2**log2(x) when

[PATCH qemu v2 01/11] hw/cxl: fix DC extent capacity tracking

2025-07-14 Thread Jonathan Cameron via
ot;total_extent_count" to include both accepted and pending extents counting. Signed-off-by: Fan Ni Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 3 ++- hw/cxl/cxl-mailbox-utils.c | 26 ++ hw/mem/cxl_type3.c | 1 + 3 files changed,

[PATCH qemu v2 00/11] hw/cxl: DCD Fabric Management Command Set (for 10.1)

2025-07-14 Thread Jonathan Cameron via
v2: - Missing colon and tags (Fan) - Simpler handling block size parameters. The spec constrains these to be power of 2 so the v1 code of BITUL((int)log2(x) is equivalent of just using x directly. (Michael) - Check for power of 2 (Fan + Anisa) Hi Michael, I consider these ready for upstream

Re: [PATCH qemu 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 17:21:10 + Anisa Su wrote: > On Mon, Jul 14, 2025 at 06:02:26PM +0100, Jonathan Cameron wrote: > > On Mon, 14 Jul 2025 09:45:31 -0700 > > Fan Ni wrote: > > > > > On Mon, Jul 14, 2025 at 03:16:38PM +0100, Jonathan Cameron wrote: > &

Re: [PATCH qemu 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 09:45:31 -0700 Fan Ni wrote: > On Mon, Jul 14, 2025 at 03:16:38PM +0100, Jonathan Cameron wrote: > > On Mon, 14 Jul 2025 15:15:12 +0100 > > Jonathan Cameron wrote: > > > > > On Mon, 14 Jul 2025 15:02:18 +0100 > > > Jonathan Cameron

Re: [PATCH v6 3/4] hw/acpi/aml-build: Build a root node in the PPTT table

2025-07-14 Thread Jonathan Cameron via
ard for the OS to know the whole system is homogeneous or not > > > > (actually we're in the current implementation) since no parent node > > > > to telling the identical implementation informentation. Add a > > > > root node for indicating this. > > &g

Re: [PATCH qemu 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 15:02:18 +0100 Jonathan Cameron wrote: > On Mon, 14 Jul 2025 05:32:19 -0400 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 02, 2025 at 05:02:13PM +0100, Jonathan Cameron wrote: > > > From: Anisa Su > > > > > > FM DC

Re: [PATCH qemu 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 15:15:12 +0100 Jonathan Cameron wrote: > On Mon, 14 Jul 2025 15:02:18 +0100 > Jonathan Cameron wrote: > > > On Mon, 14 Jul 2025 05:32:19 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jul 02, 2025 at 05:02:13PM +

Re: [PATCH qemu 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 05:32:19 -0400 "Michael S. Tsirkin" wrote: > On Wed, Jul 02, 2025 at 05:02:13PM +0100, Jonathan Cameron wrote: > > From: Anisa Su > > > > FM DCD Management command 0x5602 implemented per CXL r3.2 Spec Section > > 7.6.7.6.3 > >

Re: [PATCH qemu 10/11] hw/cxl: mailbox-utils: 0x5604 - FMAPI Initiate DC Add

2025-07-04 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 16:23:57 + Fan Ni wrote: > On Wed, Jul 02, 2025 at 05:02:16PM +0100, Jonathan Cameron wrote: > > From: Anisa Su > > > > FM DCD Management command 0x5604 implemented per CXL r3.2 Spec Section > > 7.6.7.6.5 > > > > Signed-off-by

Re: [PATCH v5 36/36] qtest/bios-tables-test: Generate reference blob for DSDT.acpipcihp

2025-07-03 Thread Jonathan Cameron via
} > Local0 [Zero] = BSEL /* \_SB_.PCI0.BSEL */ > Local0 [One] = ASUN /* \_SB_.PCI0.S08_.ASUN */ > Return (PDSM (Arg0, Arg1, Arg2, Arg3, Local0)) > } > > Name (_SUN, One) // _SUN: Slot User

Re: [PATCH v5 35/36] qtest/bios-tables-test: Generate reference blob for DSDT.hpoffacpiindex

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 14:35:35 +0200 Eric Auger wrote: > The disassembled DSDT table is given below I'd suggest maybe a spot of cropping to bring this down to a reasonable length. See inline. Otherwise LGTM Reviewed-by: Jonathan Cameron > > * Original Table Header: >

Re: [PATCH v5 32/36] hw/arm/virt: Let virt support pci hotplug/unplug GED event

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 14:35:32 +0200 Eric Auger wrote: > Set up the IO registers used to communicate between QEMU > and ACPI. > > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron

Re: [PATCH v5 28/36] hw/acpi/ged: Prepare the device to react to PCI hotplug events

2025-07-03 Thread Jonathan Cameron via
gt; The GED device uses a dedicated MMIO region that will be mapped > by the machine code. > > At this point the GED still does not support PCI device hotplug in > its TYPE_HOTPLUG_HANDLER implementation. This will come in a > subsequent patch. > > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron

Re: [PATCH v5 22/36] tests/qtest/bios-tables-test: Update ARM DSDT reference blobs

2025-07-03 Thread Jonathan Cameron via
; +Name (_ADR, Zero) // _ADR: Address > +} > + > +Device (S08) > +{ > +Name (_ADR, 0x0001) // _ADR: Address > + } > + > +Device (S10) > +{ > +Name (_ADR, 0x0002) // _ADR: Address > +} > +} > } > > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron

Re: [PATCH v5 19/36] qtest/bios-tables-test: Generate DSDT.viot

2025-07-03 Thread Jonathan Cameron via
ortant though given how short a time this lasts for. Reviewed-by: Jonathan Cameron > > Signed-off-by: Eric Auger > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 - > tests/data/acpi/aarch64/virt/DSDT.viot | Bin 0 -> 5158 bytes > 2 files changed, 1 deletion

Re: [PATCH v5 17/36] qtest/bios-tables-test: Prepare for fixing the aarch64 viot test

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 14:35:17 +0200 Eric Auger wrote: > The test misses a variant and this puts the mess on subsequent > rebuild-expected-aml.sh where a first DSDT reference blob is > overriden by another one. > > Signed-off-by: Eric Auger For completeness.. Reviewed-by: Jonathan Cameron

Re: [PATCH v5 18/36] qtest/bios-tables-test: Add a variant to the aarch64 viot test

2025-07-03 Thread Jonathan Cameron via
er than base tests that has this problem but might be wrong. Anyhow, this looks right Reviewed-by: Jonathan Cameron > --- > tests/qtest/bios-tables-test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c >

Re: [PATCH v3 1/7] hw/cxl/events: Update for rev3.2 common event record format

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 10:16:50 +0100 wrote: > From: Shiju Jose > > CXL spec 3.2 section 8.2.9.2.1 Table 8-55, Common Event Record > format has updated with optional Maintenance Operation Subclass, > LD ID and ID of the device head information. > > Add updates for the above optional parameters in

[PATCH qemu v17 5/5] qtest/cxl: Add aarch64 virt test for CXL

2025-07-03 Thread Jonathan Cameron via
Add a single complex case for aarch64 virt machine. Given existing much more comprehensive tests for x86 cover the common functionality, a single test should be enough to verify that the aarch64 part continues to work. Tested-by: Itaru Kitayama Reviewed-by: Eric Auger Signed-off-by: Jonathan

[PATCH qemu v17 4/5] docs/cxl: Add an arm/virt example.

2025-07-03 Thread Jonathan Cameron via
: Eric Auger Signed-off-by: Jonathan Cameron --- v17: Tag from Eric plus expanded on the intro text for the arm example. --- docs/system/devices/cxl.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/system/devices/cxl.rst b/docs/system/devices/cxl.rst index e307caf3f8

[PATCH qemu v17 3/5] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2025-07-03 Thread Jonathan Cameron via
: Jonathan Cameron --- v17: Updated patch description to cover some feedback from Eric. Added a comment in the high memory map where the CXL Fixed Memory Windows will be placed. Given the size can only be established at runtime, explicit entries don't work. This is simil

[PATCH qemu v17 2/5] hw/cxl: Make the CXL fixed memory windows devices.

2025-07-03 Thread Jonathan Cameron via
n x86 only implementation. Reviewed-by: Li Zhijian Tested-by: Li Zhijian Signed-off-by: Jonathan Cameron --- v16: Add a comment about there being no dynamic state so no reset or migration support is needed. (Peter Maydell) --- include/hw/cxl/cxl.h | 4 +- include/hw/cxl/cxl_host.h

[PATCH qemu v17 1/5] hw/cxl-host: Add an index field to CXLFixedMemoryWindow

2025-07-03 Thread Jonathan Cameron via
-off-by: Jonathan Cameron --- v17: Tag from Eric. --- include/hw/cxl/cxl.h | 1 + hw/cxl/cxl-host.c| 9 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h index 3ae4303383..83096b2300 100644 --- a/include/hw/cxl/cxl.h +++ b

[PATCH qemu v17 0/5] arm/virt: CXL support via pxb_cxl

2025-07-03 Thread Jonathan Cameron via
possible to support limited use with KVM but that needs additional patches not yet ready for upstream. The challenge is interleave - and the solution is don't interleave if you want to run with KVM. Jonathan Cameron (5): hw/cxl-host: Add an index field to CXLFixedMemoryWindow hw/cxl:

Re: [PATCH v6 01/12] hw/arm/virt-acpi-build: Don't create ITS id mappings by default

2025-07-03 Thread Jonathan Cameron via
that we don't have a test for this case (yet) - later in this series there is one and I guess Gustavo knew that was coming! Anyhow, the patch looks good to me. Reviewed-by: Jonathan Cameron > --- > hw/arm/virt-acpi-build.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --g

Re: [QEMU PATCH v4 09/10] cxl-mailbox-utils: 0x5604 - FMAPI Initiate DC Add

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 04:17:28 + Fan Ni wrote: > On Thu, Jun 26, 2025 at 10:23:32PM +, anisa.su...@gmail.com wrote: > > From: Anisa Su > > > > FM DCD Management command 0x5604 implemented per CXL r3.2 Spec Section > > 7.6.7.6.5 > > > > Signed-off-by: Anisa Su > > --- > > Minor commen

Re: [QEMU PATCH v4 10/10] cxl-mailbox-utils: 0x5605 - FMAPI Initiate DC Release

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 04:21:25 + Fan Ni wrote: > On Thu, Jun 26, 2025 at 10:23:33PM +, anisa.su...@gmail.com wrote: > > From: Anisa Su > > > > FM DCD Management command 0x5605 implemented per CXL r3.2 Spec Section > > 7.6.7.6.6 > > > > Signed-off-by: Anisa Su > > --- > Minor comments

[PATCH qemu 11/11] hw/cxl: mailbox-utils: 0x5605 - FMAPI Initiate DC Release

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5605 implemented per CXL r3.2 Spec Section 7.6.7.6.6 Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 88 ++ 1 file changed, 88 insertions(+) diff --git a/hw/cxl/cxl

[PATCH qemu 09/11] hw/cxl: Create helper function to create DC Event Records from extents

2025-07-02 Thread Jonathan Cameron via
by cxl-mailbox-utils.c and cxl-events.c, where the helper function is defined. Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl.h| 1 + include/hw/cxl/cxl_device.h | 4 hw/cxl/cxl-events.c | 38 + hw/cxl/cxl

[PATCH qemu 10/11] hw/cxl: mailbox-utils: 0x5604 - FMAPI Initiate DC Add

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5604 implemented per CXL r3.2 Spec Section 7.6.7.6.5 Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 4 ++ hw/cxl/cxl-mailbox-utils.c | 109 hw/mem/cxl_type3.c

[PATCH qemu 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5602 implemented per CXL r3.2 Spec Section 7.6.7.6.3 Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 3 ++ include/hw/cxl/cxl_mailbox.h | 6 +++ hw/cxl/cxl-mailbox-utils.c | 86

[PATCH qemu 08/11] hw/cxl: mailbox-utils: 0x5603 - FMAPI Get DC Region Extent Lists

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5603 implemented per CXL r3.2 Spec Section 7.6.7.6.4 Very similar to previously implemented command 0x4801. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 76

[PATCH qemu 06/11] hw/mem: cxl_type3: Add DC Region bitmap lock

2025-07-02 Thread Jonathan Cameron via
that add/release extents (meaning they update the bitmap too) are enabled on a different CCI than the CCI on which the FMAPI commands are enabled. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 1 + hw/mem/cxl_type3.c | 4 ++

[PATCH qemu 05/11] hw/cxl: Move definition for dynamic_capacity_uuid and enum for DC event types to header

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su Move definition/enum to cxl_events.h for shared use in next patch Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_events.h | 15 +++ hw/mem/cxl_type3.c | 15 --- 2 files changed, 15 insertions

[PATCH qemu 04/11] hw/cxl: mailbox-utils: 0x5601 - FMAPI Get Host Region Config

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5601 implemented per CXL r3.2 Spec Section 7.6.7.6.2 Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 106 + 1 file changed, 106 insertions(+) diff

[PATCH qemu 02/11] hw/cxl: mailbox-utils: 0x5600 - FMAPI Get DCD Info

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5600 implemented per CXL 3.2 Spec Section 7.6.7.6.1. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 1 + hw/cxl/cxl-mailbox-utils.c | 59 + hw/mem

[PATCH qemu 03/11] hw/mem: cxl_type3: Add dsmas_flags to CXLDCRegion struct

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su Add booleans to DC Region struct to represent dsmas flags (defined in CDAT) in preparation for the next command, which returns the flags in the next mailbox command 0x5601. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl

[PATCH qemu 00/11] hw/cxl: DCD Fabric Management Command Set (for 10.1)

2025-07-02 Thread Jonathan Cameron via
Hi Michael, I consider these ready for upstream. They are only lightly tweaked from Anisa's last posting to drop some long lines and change a few patch titles + drag them to be directly based on upstream rather than on top of some stuff on my gitlab tree (trivial fuzz + context stuff only in the

[PATCH qemu 01/11] hw/cxl: fix DC extent capacity tracking

2025-07-02 Thread Jonathan Cameron via
ot;total_extent_count" to include both accepted and pending extents counting. Signed-off-by: Fan Ni Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 3 ++- hw/cxl/cxl-mailbox-utils.c | 26 ++ hw/mem/cxl_type3.c | 1 + 3 files changed,

Re: [PATCH qemu v16 3/5] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2025-07-01 Thread Jonathan Cameron via
On Tue, 1 Jul 2025 18:12:39 +0200 Eric Auger wrote: > Hi Jonathan, > On 7/1/25 5:52 PM, Jonathan Cameron wrote: > > On Tue, 1 Jul 2025 17:34:36 +0200 > > Eric Auger wrote: > > > >> Hi Jonathan, > >> > >> On 6/25/25 6:19 PM, Jonathan Cameron

Re: [PATCH qemu v16 3/5] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2025-07-01 Thread Jonathan Cameron via
On Tue, 1 Jul 2025 17:34:36 +0200 Eric Auger wrote: > Hi Jonathan, > > On 6/25/25 6:19 PM, Jonathan Cameron via wrote: > > Code based on i386/pc enablement. > > The memory layout places space for 16 host bridge register regions after > > the GIC_REDIST2 in the extende

Re: [PATCH qemu v16 3/5] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2025-07-01 Thread Jonathan Cameron via
On Tue, 1 Jul 2025 15:26:26 +0200 Eric Auger wrote: > Hi Jonathan, > > On 6/25/25 6:19 PM, Jonathan Cameron via wrote: > > Code based on i386/pc enablement. > > The memory layout places space for 16 host bridge register regions after > > the GIC_REDIST2 in the extende

Re: [HACK QEMU PATCH v1 1/1] hw/cxl: Fix MCTP Binding Check

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 16:38:16 + Anisa Su wrote: > On Fri, Jun 27, 2025 at 10:48:59AM +0100, Jonathan Cameron wrote: > > On Thu, 26 Jun 2025 23:41:15 + > > anisa.su...@gmail.com wrote: > > > > > From: Anisa Su > > > > > > Per the spe

Re: [QEMU PATCH v4 10/10] cxl-mailbox-utils: 0x5605 - FMAPI Initiate DC Release

2025-06-30 Thread Jonathan Cameron via
On Thu, 26 Jun 2025 22:23:33 + anisa.su...@gmail.com wrote: > From: Anisa Su > > FM DCD Management command 0x5605 implemented per CXL r3.2 Spec Section > 7.6.7.6.6 > > Signed-off-by: Anisa Su A few more long line related tweaks. > --- > hw/cxl/cxl-mailbox-utils.c | 79 ++

Re: [QEMU PATCH v4 09/10] cxl-mailbox-utils: 0x5604 - FMAPI Initiate DC Add

2025-06-30 Thread Jonathan Cameron via
On Thu, 26 Jun 2025 22:23:32 + anisa.su...@gmail.com wrote: > From: Anisa Su > > FM DCD Management command 0x5604 implemented per CXL r3.2 Spec Section > 7.6.7.6.5 There are a few long lines in here check patch doesn't like. I tweaked as described inline whilst picking them up. > > Si

Re: [QEMU PATCH v4 03/10] cxl-mailbox-utils: 0x5601 - FMAPI Get Host Region Config

2025-06-30 Thread Jonathan Cameron via
On Thu, 26 Jun 2025 22:23:26 + anisa.su...@gmail.com wrote: > From: Anisa Su > > FM DCD Management command 0x5601 implemented per CXL r3.2 Spec Section > 7.6.7.6.2 > > Reviewed-by: Fan Ni > Signed-off-by: Anisa Su > --- > hw/cxl/cxl-mailbox-utils.c | 103

Re: [PATCH v4 31/32] tests/qtest/bios-tables-test: Add aarch64 ACPI PCI hotplug test

2025-06-30 Thread Jonathan Cameron via
t_port_hpoff tests static-acpi index > on a root port with disabled hotplug > > Signed-off-by: Gustavo Romero > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron

Re: [PATCH v4 30/32] tests/qtest/bios-tables-test: Prepare for addition of acpi pci hp tests

2025-06-30 Thread Jonathan Cameron via
t/DSDT.hpoffacpiindex > > Signed-off-by: Gustavo Romero > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron

Re: [PATCH v4 29/32] hw/arm/virt: Let virt support pci hotplug/unplug GED event

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:18 +0200 Eric Auger wrote: > Set up the IO registers used to communicate between QEMU > and ACPI. > > Signed-off-by: Eric Auger Follow on comment inline. Otherwise LGTM Reviewed-by: Jonathan Cameron > > --- > v2 -> v3: &

Re: [PATCH v4 28/32] hw/arm/virt: Minor code reshuffling in create_acpi_ged

2025-06-30 Thread Jonathan Cameron via
d it becomes difficult to guess the index of > a region. Better refer to a region by its name. > > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron

Re: [PATCH v4 25/32] hw/acpi/ged: Prepare the device to react to PCI hotplug events

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:14 +0200 Eric Auger wrote: > QEMU will notify the OS about PCI hotplug/hotunplug events through > GED interrupts. Let the GED device handle a new PCI hotplug event. > On its occurrence it calls the \\_SB.PCI0.PCNT method with the BLCK > mutex held. > > The GED device us

Re: [PATCH v4 26/32] hw/acpi/ged: Support migration of AcpiPciHpState

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:15 +0200 Eric Auger wrote: > Add a subsection to migrate the AcpiPciHpState state. > > Signed-off-by: Eric Auger > Reviewed-by: Igor Mammedov Reviewed-by: Jonathan Cameron

Re: [PATCH v4 24/32] hw/acpi/pcihp: Remove root arg in acpi_pcihp_init

2025-06-30 Thread Jonathan Cameron via
that change is to be consistent with the forecoming ARM > implementation where the machine passes the root bus (steming from GPEX) > to the GED device through a link property. > > Signed-off-by: Eric Auger > Suggested-by: Igor Mammedov Seems reasonable to me. Reviewed-by: Jonathan Cameron

Re: [PATCH v4 20/32] hw/arm/virt-acpi-build: Modify the DSDT ACPI table to enable ACPI PCI hotplug

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:09 +0200 Eric Auger wrote: > Modify the DSDT ACPI table to enable ACPI PCI hotplug. > > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron

Re: [PATCH v4 19/32] tests/qtest/bios-tables-test: Update ARM DSDT reference blobs

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 12:00:51 +0200 Eric Auger wrote: > Hi, > > On 6/27/25 11:55 AM, Eric Auger wrote: > > Changes relate to the introduction of pieces related to > > acpi-index static support along with root ports with no hotplug. > > > > + > > +Scope (\_SB.PCI0) > > +{ > > +Meth

Re: [PATCH v4 18/32] hw/arm/virt-acpi-build: Let non hotplug ports support static acpi-index

2025-06-30 Thread Jonathan Cameron via
i386 code so LGTM Reviewed-by: Jonathan Cameron

Re: [PATCH v4 17/32] tests/qtest/bios-tables-test: Prepare for changes in the arm virt DSDT table

2025-06-30 Thread Jonathan Cameron via
s slightly silly to give tags to these, but for FWIW Reviewed-by: Jonathan Cameron > --- > --- > tests/qtest/bios-tables-test-allowed-diff.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h > b/tests/qtest/bios-

Re: [PATCH v4 16/32] hw/i386/acpi-build: Move aml_pci_edsm to a generic place

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:05 +0200 Eric Auger wrote: > Move aml_pci_edsm to pci-bridge.c since we want to reuse that for > ARM and acpi-index support. Also rename it into build_pci_bridge_edsm. > > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron

Re: [PATCH v4 10/32] tests/qtest/bios-tables-test: Update DSDT blobs after GPEX _OSC change

2025-06-30 Thread Jonathan Cameron via
> Else > { > CDW1 |= 0x04 > -Return (Arg3) > } > + > +Return (Arg3) > } > > Method (_DSM, 4, NotSerialized) // _DSM: Device-Specific Method > > Signed-off-by: Eric Auger > Signed-off-by: Gustavo Romero Reviewed-by: Jonathan Cameron

Re: [PATCH v4 09/32] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method

2025-06-30 Thread Jonathan Cameron via
I0.CTRL */ > -Return (Arg3) > +CDW3 = Local0 > } > Else > { > CDW1 |= 0x04 > -Return (Arg3) > } > + > + Return (Arg3) > } > > Method (_DSM, 4, NotSerialized) // _DSM: Device-Specific Method > > Signed-off-by: Eric Auger > Reviewed-by: Igor Mammedov > > --- > > v3 -> v3: v3->v4? Reviewed-by: Jonathan Cameron

Re: [PATCH v4 07/32] hw/pci-host/gpex-acpi: Use GED acpi pcihp property

2025-06-30 Thread Jonathan Cameron via
r Reviewed-by: Jonathan Cameron

Re: [HACK QEMU PATCH v1 1/1] hw/cxl: Fix MCTP Binding Check

2025-06-27 Thread Jonathan Cameron via
On Thu, 26 Jun 2025 23:41:15 + anisa.su...@gmail.com wrote: > From: Anisa Su > > Per the spec, FMAPI commands (0x51-0x59) must be bound with > MCTP_MT_CXL_FMAPI. Fix the conditions ensuring this in i2c_mctp_cxl.c > and dev-mctp.c > > Move the opcode enum from cxl-mailbox-utils.c to cxl_mail

[PATCH qemu v16 4/5] docs/cxl: Add an arm/virt example.

2025-06-25 Thread Jonathan Cameron via
: Jonathan Cameron --- docs/system/devices/cxl.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/system/devices/cxl.rst b/docs/system/devices/cxl.rst index e307caf3f8..73e80e672f 100644 --- a/docs/system/devices/cxl.rst +++ b/docs/system/devices/cxl.rst @@ -384,6 +384,16 @@ An

[PATCH qemu v16 3/5] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2025-06-25 Thread Jonathan Cameron via
create the CEDT table if cxl=on set for the machine. Default to off. Signed-off-by: Jonathan Cameron --- v16: Some additional comments on the memory map in the patch description. Added an 'off by default' statement to he patch description. Update highest_gpa to include CXL Fi

[PATCH qemu v16 5/5] qtest/cxl: Add aarch64 virt test for CXL

2025-06-25 Thread Jonathan Cameron via
Add a single complex case for aarch64 virt machine. Given existing much more comprehensive tests for x86 cover the common functionality, a single test should be enough to verify that the aarch64 part continue to work. Tested-by: Itaru Kitayama Signed-off-by: Jonathan Cameron --- v16: Update to

[PATCH qemu v16 2/5] hw/cxl: Make the CXL fixed memory windows devices.

2025-06-25 Thread Jonathan Cameron via
n x86 only implementation. Reviewed-by: Li Zhijian Tested-by: Li Zhijian Signed-off-by: Jonathan Cameron --- v16: Add a comment about there being no dynamic state so no reset or migration support is needed. (Peter Maydell) --- include/hw/cxl/cxl.h | 4 +- include/hw/cxl/cxl_host.h

[PATCH qemu v16 1/5] hw/cxl-host: Add an index field to CXLFixedMemoryWindow

2025-06-25 Thread Jonathan Cameron via
To enable these to be found in a fixed order, that order needs to be known. This will later be used to sort a list of these structures so that address map and ACPI table entries are predictable. Tested-by: Li Zhijian Reviewed-by: Li Zhijian Reviewed-by: Fan Ni Signed-off-by: Jonathan Cameron

[PATCH qemu v16 0/5] arm/virt: CXL support via pxb_cxl

2025-06-25 Thread Jonathan Cameron via
nal patches not yet ready for upstream. The challenge is interleave - and the solution is don't interleave if you want to run with KVM. Jonathan Cameron (5): hw/cxl-host: Add an index field to CXLFixedMemoryWindow hw/cxl: Make the CXL fixed memory windows devices. hw/arm/virt: Bas

Re: [PATCH v15 3/4] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2025-06-25 Thread Jonathan Cameron via
On Fri, 13 Jun 2025 18:21:25 +0100 Jonathan Cameron wrote: > On Fri, 13 Jun 2025 17:07:24 +0100 > Peter Maydell wrote: > > > On Fri, 13 Jun 2025 at 16:20, Jonathan Cameron > > wrote: > > > > > > On Fri, 13 Jun 2025 13:57:39 +0100 > > > Peter

Re: [PATCH -qemu] hw/cxl: Use runtime for bg cmd running semantics

2025-06-23 Thread Jonathan Cameron via
On Tue, 17 Jun 2025 14:48:32 -0700 Davidlohr Bueso wrote: > The current check incorrectly misses the 0% case, which semantically > can either be not running or one that just started. The runtime > is a better way to check for 0%, 100% or aborted. This is currently > benign in the kernel equivalen

Re: [PATCH v5 11/11] qtest/bios-tables-test: Update tables for smmuv3 tests

2025-06-23 Thread Jonathan Cameron via
ne by line but looks correct to me. Reviewed-by: Jonathan Cameron

Re: [PATCH v5 10/11] qtest/bios-tables-test: Add tests for legacy smmuv3 and smmuv3 device

2025-06-23 Thread Jonathan Cameron via
ies so that we can verify nothing changed, then bring only the test for the new stuff at the end. Meh. I don't care that much as it's good to have tests either way. > Signed-off-by: Shameer Kolothum LGTM Reviewed-by: Jonathan Cameron

Re: [PATCH v5 09/11] bios-tables-test: Allow for smmuv3 test data.

2025-06-23 Thread Jonathan Cameron via
On Mon, 23 Jun 2025 10:42:28 +0100 Shameer Kolothum wrote: > The tests to be added exercises both legacy(iommu=smmuv3) and new > -device arm-smmuv3,.. cases. > > Signed-off-by: Shameer Kolothum Reviewed-by: Jonathan Cameron

Re: [PATCH v5 08/11] qemu-options.hx: Document the arm-smmuv3 device

2025-06-23 Thread Jonathan Cameron via
On Mon, 23 Jun 2025 10:42:27 +0100 Shameer Kolothum wrote: > Now that arm,virt can have user-creatable smmuv3 devices, document it. > > Signed-off-by: Shameer Kolothum Reviewed-by: Jonathan Cameron > --- > qemu-options.hx | 7 +++ > 1 file changed, 7 insertions(+) >

Re: [PATCH v5 07/11] hw/arm/virt: Allow user-creatable SMMUv3 dev instantiation

2025-06-23 Thread Jonathan Cameron via
; limited to cases where it is attached to the default pcie.0 root complex. > > Signed-off-by: Shameer Kolothum LGTM Reviewed-by: Jonathan Cameron

Re: [PATCH v5 06/11] hw/pci: Introduce pci_setup_iommu_per_bus() for per-bus IOMMU ops retrieval

2025-06-23 Thread Jonathan Cameron via
e a new helper pci_setup_iommu_per_bus() that > explicitly sets the new iommu_per_bus field in the PCIBus structure. Maybe call out where this will later be called from? Otherwise seems like a reasonable solution to me. One trivial comment inline. Reviewed-by: Jonathan Cameron > Update

Re: [PATCH v5 05/11] hw/arm/virt: Add an SMMU_IO_LEN macro

2025-06-23 Thread Jonathan Cameron via
> Tested-by: Nathan Chen > Signed-off-by: Shameer Kolothum Reviewed-by: Jonathan Cameron > --- > hw/arm/virt.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 71b923f786..ae30320c38 100644 > --- a/hw/

  1   2   3   4   5   6   7   8   9   10   >