Re: [PATCH 0/2] docs, python: bump sphinx preferred version

On Wed, Jul 16, 2025, 11:04 AM Markus Armbruster wrote: > Okay to include this in my next QAPI PR? > That would be very convenient, thank you! (And thanks to Akihiko Odaki for spotting and fixing the issue, even if it took me a while to sort through our policy.) >

Re: [PATCH] python: fix editable installs for modern pip/setuptools

On Tue, Jul 15, 2025, 6:27 PM John Snow wrote: > The way editable installs work has changed at some point since Fedora 40 > was released. Generally, we should be opting to use pyproject.toml > installs (PEP517/518) - but those are not fully supported until v61 of > setuptools, and C

[PATCH] python: fix editable installs for modern pip/setuptools

8.2.3 pkgsrc_current 3.12.11 25.1.1 80.9.0 8.2.3 Signed-off-by: John Snow --- python/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/Makefile b/python/Makefile index 764b79ccb23..32aedce4137 100644 --- a/python/Makefile +++ b/python/Makefile @

Re: [PATCH 0/2] docs, python: bump sphinx preferred version

fwiw, I think this is important enough / harmless enough to sneak into the rc releases, if possible. On Tue, Jul 15, 2025 at 5:28 PM John Snow wrote: > > CI: https://gitlab.com/jsnow/qemu/-/pipelines/1928836481 > > Unlike the previous series, this series only adjusts the *preferr

[PATCH 2/2] MAINTAINERS: Add docs/requirements.txt

From: Akihiko Odaki Add docs/requirements.txt to "Sphinx documentation configuration and build machinery". Signed-off-by: Akihiko Odaki Signed-off-by: John Snow --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e88ed2c0a97..809cd1aa

[PATCH 0/2] docs, python: bump sphinx preferred version

CI: https://gitlab.com/jsnow/qemu/-/pipelines/1928836481 Unlike the previous series, this series only adjusts the *preferred* sphinx version to be higher, leaving the accepted version at 3.4.3, the version that CentOS Stream 9 still ships with. Unfortunately, this means we can't cut out the compa

[PATCH 1/2] docs: Bump sphinx to 6.2.1

ed if they are present and functional. The version used for building docs on readthedocs is pinned to the recommended version, 6.2.1.) Signed-off-by: Akihiko Odaki Tested-by: Markus Armbruster Reviewed-by: John Snow Signed-off-by: John Snow --- docs/requirements.txt | 4 ++-- pythondeps.toml

Re: [PATCH V4 2/3] python: use qom-list-get

On Fri, Jul 11, 2025, 10:47 AM Markus Armbruster wrote: > Steve Sistare writes: > > > Use qom-list-get to speed up the qom-tree command. > > > > Signed-off-by: Steve Sistare > > Quick test... Differences in output before and after match expectations > (see appended diff). > > New version: > >

Re: [PATCH v2 00/18] QAPI: add cross-references to qapi docs

On Fri, Jul 11, 2025, 5:04 AM Markus Armbruster wrote: > John Snow writes: > > > Based-on: 20250711051045.51110-1-js...@redhat.com > > [PATCH v6 0/4] qapi: add auto-generated return docs > > > > v2: > > - Applied a few new transformations I had missed. &

Re: [PATCH v2 08/18] qapi: add cross-references to migration.json

On Fri, Jul 11, 2025, 4:55 AM Markus Armbruster wrote: > John Snow writes: > > > Signed-off-by: John Snow > > --- > > qapi/migration.json | 68 ++--- > > 1 file changed, 34 insertions(+), 34 deletions(-) > > > &g

[PATCH v2 16/18] qapi: add cross-references to virtio.json

Signed-off-by: John Snow --- qapi/virtio.json | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qapi/virtio.json b/qapi/virtio.json index d1556dbf24a..3bc8700e943 100644 --- a/qapi/virtio.json +++ b/qapi/virtio.json @@ -135,7 +135,7 @@ # @num-vqs: VirtIODevice

[PATCH v2 12/18] qapi: add cross-references to replay.json

Signed-off-by: John Snow --- qapi/replay.json | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi/replay.json b/qapi/replay.json index 35e0c4a6926..78244a9d0bf 100644 --- a/qapi/replay.json +++ b/qapi/replay.json @@ -47,8 +47,8 @@ # @query-replay: # # Retrieve

[PATCH v2 17/18] qapi: add cross-references to yank.json

Signed-off-by: John Snow Acked-by: Lukas Straub --- qapi/yank.json | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/qapi/yank.json b/qapi/yank.json index 5f26d6c0149..f1b737e87d6 100644 --- a/qapi/yank.json +++ b/qapi/yank.json @@ -9,7 +9,7

[PATCH v2 04/18] qapi: add cross-references to crypto.json

Signed-off-by: John Snow --- qapi/crypto.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/crypto.json b/qapi/crypto.json index 9ec6301e188..57620d95da6 100644 --- a/qapi/crypto.json +++ b/qapi/crypto.json @@ -589,9 +589,9 @@ # # Specific parameters for RSA

[PATCH v2 15/18] qapi: add cross-references to ui.json

Signed-off-by: John Snow --- qapi/ui.json | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 7136c985c38..5bc54403cc2 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -39,7 +39,7 @@ ## # @SetPasswordOptions

[PATCH v2 09/18] qapi: add cross-references to net.json

Signed-off-by: John Snow --- qapi/net.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qapi/net.json b/qapi/net.json index 371ade0dc6a..8631c8dd61c 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -655,7 +655,7 @@ # this to zero disables this function. This

[PATCH v2 11/18] qapi: add cross-references to QOM

Signed-off-by: John Snow --- qapi/qdev.json | 4 ++-- qapi/qom.json | 13 +++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/qapi/qdev.json b/qapi/qdev.json index 5d18fb8e0e0..ff3f06a36d6 100644 --- a/qapi/qdev.json +++ b/qapi/qdev.json @@ -95,10 +95,10 @@ #from

[PATCH v2 03/18] qapi: add cross-references to block layer

Signed-off-by: John Snow --- qapi/block-core.json | 188 - qapi/block-export.json | 36 qapi/block.json| 14 +-- qapi/transaction.json | 12 +-- 4 files changed, 125 insertions(+), 125 deletions(-) diff --git a/qapi/block-core.json

[PATCH v2 18/18] qapi: add cross-references to misc modules

These modules don't have specific maintainers, so they're lumped in together here as miscellaneous. Signed-off-by: John Snow --- qapi/control.json| 2 +- qapi/ebpf.json | 2 +- qapi/introspect.json | 24 qapi/misc-arm.json | 4 ++-- qapi/misc

[PATCH v2 10/18] qapi: add cross-references to pci.json

Signed-off-by: John Snow --- qapi/pci.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/pci.json b/qapi/pci.json index 29549d94551..4aad5f98e2a 100644 --- a/qapi/pci.json +++ b/qapi/pci.json @@ -83,7 +83,7 @@ # # @bus: information about the bus the device resides on

[PATCH v2 06/18] qapi: add cross-references to job.json

Signed-off-by: John Snow --- qapi/job.json | 71 ++- 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/qapi/job.json b/qapi/job.json index c1ddae9c0fe..a6026f6a810 100644 --- a/qapi/job.json +++ b/qapi/job.json @@ -10,26 +10,26

[PATCH v2 13/18] qapi: add cross-references to run-state.json

Signed-off-by: John Snow --- qapi/run-state.json | 46 ++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 759f8730059..bafbbf695b2 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json

[PATCH v2 08/18] qapi: add cross-references to migration.json

Signed-off-by: John Snow --- qapi/migration.json | 68 ++--- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index 59a213aeb6c..eda27c18102 100644 --- a/qapi/migration.json +++ b/qapi/migration.json

[PATCH v2 14/18] qapi: add cross-references to sockets.json

Signed-off-by: John Snow Reviewed-by: Eric Blake --- qapi/sockets.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qapi/sockets.json b/qapi/sockets.json index f9f559dabae..e7f8b42bda3 100644 --- a/qapi/sockets.json +++ b/qapi/sockets.json @@ -209,14 +209,14

[PATCH v2 00/18] QAPI: add cross-references to qapi docs

his QAPI codegen section: https://www.qemu.org/docs/master/devel/qapi-code-gen.html#definition-documentation John Snow (18): qapi: add cross-references to acpi.json qapi: add cross-references to authz.json qapi: add cross-references to block layer qapi: add cross-references t

[PATCH v2 07/18] qapi: add cross-references to Machine core

Signed-off-by: John Snow --- qapi/machine-common.json | 20 +- qapi/machine.json| 82 2 files changed, 51 insertions(+), 51 deletions(-) diff --git a/qapi/machine-common.json b/qapi/machine-common.json index 298e51f373a..a9f56cbbb43

[PATCH v2 05/18] qapi: add cross-references to dump.json

Signed-off-by: John Snow --- qapi/dump.json | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qapi/dump.json b/qapi/dump.json index 3a9b67efb1b..a615e73a64a 100644 --- a/qapi/dump.json +++ b/qapi/dump.json @@ -110,7 +110,7 @@ # # Describe the status of a long

[PATCH v2 02/18] qapi: add cross-references to authz.json

Signed-off-by: John Snow --- qapi/authz.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/authz.json b/qapi/authz.json index 7fc6e3032ea..cbd9399c461 100644 --- a/qapi/authz.json +++ b/qapi/authz.json @@ -75,7 +75,7 @@ # Properties for authz-listfile objects

[PATCH v2 01/18] qapi: add cross-references to acpi.json

Signed-off-by: John Snow --- qapi/acpi.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/acpi.json b/qapi/acpi.json index 2d53b823656..8e48d8874dd 100644 --- a/qapi/acpi.json +++ b/qapi/acpi.json @@ -106,7 +106,7 @@ ## # @query-acpi-ospm-status: # -# Return a list

Re: [PATCH 08/18] qapi: add cross-references to migration.json

On Wed, Jul 2, 2025 at 4:04 AM Markus Armbruster wrote: > > John Snow writes: > > > Signed-off-by: John Snow > > --- > > qapi/migration.json | 62 ++--- > > 1 file changed, 31 insertions(+), 31 deletions(-) > > >

[PATCH v6 2/4] docs, qapi: generate undocumented return sections

m, a "TODO:" hack line is used to separate the intro from the remainder of the documentation block in cases where there are no other sections to separate the intro from e.g. examples and additional detail meant to appear below the key sections of interest. Signed-off-by: John Snow --- do

[PATCH v6 1/4] docs/qapi-domain: add return-nodesc

because Sphinx always expects both a type and a description for the prior form and will format it accordingly. To have a reasonable rendering when the body is missing, we need to use a different info field list entirely. Signed-off-by: John Snow --- docs/devel/qapi-

[PATCH v6 4/4] qapi: rephrase return docs to avoid type name

Well, I tried. Maybe not very hard. Sorry! Signed-off-by: John Snow --- qapi/block-core.json | 6 +++--- qapi/block-export.json | 2 +- qapi/block.json| 2 +- qapi/control.json | 5 ++--- qapi/dump.json | 5 ++--- qapi/introspect.json | 6 +++--- qapi/job.json

[PATCH v6 0/4] qapi: add auto-generated return docs

ferred insertion algorithm v4: rebased on origin/master (2025-06-12) v3: rebased on top of python-qapi-linting (v4) pull request; removed commits that are no longer needed. v2: fix multi-return-sections bug :( John Snow (4): docs/qapi-domain: add return-nodesc docs, qapi: generate undoc

[PATCH v6 3/4] qapi: remove trivial "Returns:" sections

m differentiate the introductory paragraph(s) from the rest of the documentation. Signed-off-by: John Snow --- qapi/audio.json | 2 -- qapi/block-core.json | 8 qapi/char.json | 8 qapi/cryptodev.json | 2 -- qapi/machine.json| 22 -- qapi

Re: Build platform guarantees, docs, tests, and snakes in the garden

On Wed, Jul 9, 2025, 3:40 PM Paolo Bonzini wrote: > > > Il mer 9 lug 2025, 20:39 John Snow ha scritto: > >> You are right. However, the mkvenv configuration tool we pioneered has >> been largely un-noticed by contributors and appears to "just work" for >>

Re: Build platform guarantees, docs, tests, and snakes in the garden

On Mon, Jul 7, 2025 at 5:11 AM Daniel P. Berrangé wrote: > > On Wed, Jul 02, 2025 at 03:24:09PM -0400, Paolo Bonzini wrote: > > Il mar 24 giu 2025, 02:45 Markus Armbruster ha scritto: > > > > > > ... I think I value this a bit higher than Markus, but not really > > > because of offline builds. R

Re: Python ecosystem versions overview

time, but it's still potentially a quite useful reference and I don't know where else to put it. I know we have a wiki, but I think the wiki is not really a great source of information for our project as *most* pages there are quite rotted. On Tue, Jul 8, 2025 at 4:36 PM John Snow

Re: Python ecosystem versions overview

On Tue, Jul 8, 2025, 7:23 PM Paolo Bonzini wrote: > On 7/8/25 22:36, John Snow wrote: > > centos_stream_9 3.9.23 21.3.1 53.0.0 3.4.3 BaseOS, CRB > > Ok, so the lowest version of Sphinx (3.4.3) is currently used for CentOS > Stream 9. It's supported for roug

Python ecosystem versions overview

Hi, recently there was some discussion and debate over what versions of which things in the Python ecosystem we need to support with regards to our build platform promise. I don't address those issues in this mail at all. O:-) In researching that problem, I created a CLI script to automatically po

Re: [PATCH v3 4/5] docs/sphinx: remove special parsing for freeform sections

On Fri, Jun 27, 2025, 5:52 AM Markus Armbruster wrote: > John Snow writes: > > > This change removes special parsing for freeform sections and allows > > them to simply be unmodified rST syntax. The existing headings in the > > QAPI schema are adjusted to reflect the n

Re: [PATCH v3 4/5] docs/sphinx: remove special parsing for freeform sections

On Fri, Jun 27, 2025, 5:52 AM Markus Armbruster wrote: > John Snow writes: > > > This change removes special parsing for freeform sections and allows > > them to simply be unmodified rST syntax. The existing headings in the > > QAPI schema are adjusted to reflect the n

Re: [PATCH v3 2/5] docs/sphinx: parse @references in freeform text

On Fri, Jun 27, 2025, 5:54 AM Markus Armbruster wrote: > John Snow writes: > > > Oversight in the new qapidoc transmogrifier: @references in freeform > > documentation blocks were not being transformed to literals. This fixes > > that, and the next patch ensures that

[PATCH v5 3/4] qapi: remove trivial "Returns:" sections

ly touch other "Returns" lines that could be rephrased to omit repeating type information; it only removes lines that appear appropriate to wholly remove. Signed-off-by: John Snow --- qapi/audio.json | 2 -- qapi/block-core.json | 8 qapi/char.json | 8

[PATCH v5 1/4] docs/qapi-domain: add return-nodesc

because Sphinx always expects both a type and a description for the prior form and will format it accordingly. To have a reasonable rendering when the body is missing, we need to use a different info field list entirely. Signed-off-by: John Snow --- docs/devel/qapi-

[PATCH v5 4/4] qapi: rephrase return docs to avoid type name

Well, I tried. Maybe not very hard. Sorry! Signed-off-by: John Snow --- qapi/block-core.json | 6 +++--- qapi/block-export.json | 2 +- qapi/block.json| 2 +- qapi/control.json | 5 ++--- qapi/dump.json | 5 ++--- qapi/introspect.json | 6 +++--- qapi/job.json

[PATCH v5 2/4] docs, qapi: generate undocumented return sections

This patch changes the qapidoc parser to generate stub Return value documentation for any command that has a return value but does not have a "Returns:" doc section. The stubs include just the type name, which will be rendered with a cross-reference link in the HTML output. Signed-of

[PATCH v5 0/4] qapi: add auto-generated return docs

removed commits that are no longer needed. v2: fix multi-return-sections bug :( John Snow (4): docs/qapi-domain: add return-nodesc docs, qapi: generate undocumented return sections qapi: remove trivial "Returns:" sections qapi: rephrase return docs to avoid type name docs/d

Re: Build platform guarantees, docs, tests, and snakes in the garden

On Tue, Jun 24, 2025 at 2:45 AM Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 6/5/25 21:35, John Snow wrote: > >> However, if we take as iron-clad our commitment to the build platform > promise -- *and* guarantee offline/tarball builds as well -- then De

Re: [PATCH v2 06/12] python: upgrade to python3.9+ syntax

On Tue, Jun 24, 2025 at 3:34 AM Markus Armbruster wrote: > John Snow writes: > > > This patch is fully automated, using pymagic, isort and autoflake. > > > > Create a script named pymagic.sh: > > > > = > > > > pyupgrade -

[PATCH v3 3/5] docs/sphinx: remove legacy QAPI manual generator

entional change. Signed-off-by: John Snow --- docs/interop/qemu-ga-ref.rst | 1 - docs/interop/qemu-qmp-ref.rst| 1 - docs/interop/qemu-storage-daemon-qmp-ref.rst | 1 - docs/sphinx/qapidoc.py | 25 +- docs/sphinx/qa

[PATCH v3 2/5] docs/sphinx: parse @references in freeform text

Oversight in the new qapidoc transmogrifier: @references in freeform documentation blocks were not being transformed to literals. This fixes that, and the next patch ensures that we're testing for this O:-) Signed-off-by: John Snow --- docs/sphinx/qapidoc.py | 10 +++--- 1 file chang

[PATCH v3 1/5] docs/sphinx: adjust qapidoc to cope with same-line error sections

Signed-off-by: John Snow --- docs/sphinx/qapidoc.py | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/sphinx/qapidoc.py b/docs/sphinx/qapidoc.py index 8011ac9efaf..5374dee8fad 100644 --- a/docs/sphinx/qapidoc.py +++ b/docs/sphinx/qapidoc.py @@ -267,10 +267,14

[PATCH v3 4/5] docs/sphinx: remove special parsing for freeform sections

This change removes special parsing for freeform sections and allows them to simply be unmodified rST syntax. The existing headings in the QAPI schema are adjusted to reflect the new paradigm. Tests and documentation are updated to match. Signed-off-by: John Snow --- docs/devel/qapi-code

[PATCH v3 0/5] docs: remove legacy qapidoc

restrictions on QAPI-style headers - Updated test output so make check passes ... v2: - rebased on origin/master (2025-06-12) - Revised commit messages with increased detail John Snow (5): docs/sphinx: adjust qapidoc to cope with same-line error sections docs/sphinx: parse @references in

[PATCH v3 5/5] qapi: lift restriction on using '=' in doc blocks

Signed-off-by: John Snow --- scripts/qapi/parser.py | 4 tests/qapi-schema/doc-bad-section.err | 1 - tests/qapi-schema/doc-bad-section.json | 10 -- tests/qapi-schema/doc-bad-section.out | 0 tests/qapi-schema/meson.build | 1 - 5 files changed, 16

Re: [PATCH v2 2/3] docs: remove legacy QAPI manual generator

On Mon, Jun 16, 2025 at 8:20 AM Markus Armbruster wrote: > John Snow writes: > > > Thanks for your service! > > > > Remove the old qapidoc and the option to enable the transmogrifier, > > leaving the "transmogrifier" as the ONLY qapi doc generator. This i

Re: [PULL v2 4/6] python: add qapi static analysis tests

On Tue, Jun 17, 2025, 7:44 AM Markus Armbruster wrote: > John Snow writes: > > > Update the python tests to also check QAPI and the QAPI Sphinx > > extensions. The docs/sphinx/qapidoc_legacy.py file is not included in > > these checks, as it is destined for remova

Re: [PATCH v2 06/12] python: upgrade to python3.9+ syntax

On Tue, Jun 17, 2025, 5:16 AM Mads Ynddal wrote: > > > diff --git a/scripts/simpletrace.py b/scripts/simpletrace.py > > index cef81b0707f..a013e4402de 100755 > > --- a/scripts/simpletrace.py > > +++ b/scripts/simpletrace.py > > @@ -9,13 +9,15 @@ > > # > > # For help see docs/devel/tracing.rst > >

Re: [PATCH v2 1/3] docs: fix errors formatting in tests/qapi-schema/doc-good

On Mon, Jun 16, 2025 at 7:36 AM Markus Armbruster wrote: > John Snow writes: > > > If we remove the legacy parser, the doc-good.json formatting begins to > > "parser"? You mean docs/sphinx/qapidoc_legacy.py, don't you? > Mmm... yes, I'm conflatin

Re: [PATCH 03/18] qapi: add cross-references to block layer

On Mon, Jun 16, 2025, 12:31 PM Eric Blake wrote: > On Fri, Jun 13, 2025 at 04:36:05PM -0400, John Snow wrote: > > Signed-off-by: John Snow > > --- > > qapi/block-core.json | 186 - > > qapi/block-export.json | 36 ++

Re: [PATCH 1/1] docs/qapi-domain: Improve QAPI indices

On Fri, May 23, 2025 at 2:08 PM John Snow wrote: > This patch changes the "by type" categorization in favor of using > sub-categories of a literal "By type" category instead. A new "By > module" categorization is also added that follows a similar pat

[PATCH 04/18] qapi: add cross-references to crypto.json

Signed-off-by: John Snow --- qapi/crypto.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/crypto.json b/qapi/crypto.json index 9ec6301e188..57620d95da6 100644 --- a/qapi/crypto.json +++ b/qapi/crypto.json @@ -589,9 +589,9 @@ # # Specific parameters for RSA

[PATCH 05/18] qapi: add cross-references to dump.json

Signed-off-by: John Snow --- qapi/dump.json | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi/dump.json b/qapi/dump.json index 3a9b67efb1b..c311ccb4d2d 100644 --- a/qapi/dump.json +++ b/qapi/dump.json @@ -110,7 +110,7 @@ # # Describe the status of a long

[PATCH 10/18] qapi: add cross-references to pci.json

Signed-off-by: John Snow --- qapi/pci.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/pci.json b/qapi/pci.json index 29549d94551..4aad5f98e2a 100644 --- a/qapi/pci.json +++ b/qapi/pci.json @@ -83,7 +83,7 @@ # # @bus: information about the bus the device resides on

[PATCH 17/18] qapi: add cross-references to yank.json

Signed-off-by: John Snow --- qapi/yank.json | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/qapi/yank.json b/qapi/yank.json index 9bd8ecce27f..931d4b22d4b 100644 --- a/qapi/yank.json +++ b/qapi/yank.json @@ -9,7 +9,7 @@ ## # @YankInstanceType

[PATCH 15/18] qapi: add cross-references to ui.json

Signed-off-by: John Snow --- qapi/ui.json | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 7136c985c38..5bc54403cc2 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -39,7 +39,7 @@ ## # @SetPasswordOptions

[PATCH 08/18] qapi: add cross-references to migration.json

Signed-off-by: John Snow --- qapi/migration.json | 62 ++--- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index d7c5047462e..fec6479a23e 100644 --- a/qapi/migration.json +++ b/qapi/migration.json

[PATCH 13/18] qapi: add cross-references to run-state.json

Signed-off-by: John Snow --- qapi/run-state.json | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 759f8730059..b7cc182707c 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json

[PATCH 14/18] qapi: add cross-references to sockets.json

Signed-off-by: John Snow --- qapi/sockets.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qapi/sockets.json b/qapi/sockets.json index f9f559dabae..e7f8b42bda3 100644 --- a/qapi/sockets.json +++ b/qapi/sockets.json @@ -209,14 +209,14 @@ '

[PATCH 18/18] qapi: add cross-references to misc modules

These modules don't have specific maintainers, so they're lumped in together here as miscellaneous. Signed-off-by: John Snow --- qapi/control.json| 2 +- qapi/ebpf.json | 2 +- qapi/introspect.json | 22 +++--- qapi/misc-arm.json | 4 ++-- qapi/misc

[PATCH 09/18] qapi: add cross-references to net.json

Signed-off-by: John Snow --- qapi/net.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/net.json b/qapi/net.json index 371ade0dc6a..ab0b9aba46e 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -655,7 +655,7 @@ # this to zero disables this function. This

[PATCH 16/18] qapi: add cross-references to virtio.json

Signed-off-by: John Snow --- qapi/virtio.json | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qapi/virtio.json b/qapi/virtio.json index d1556dbf24a..3bc8700e943 100644 --- a/qapi/virtio.json +++ b/qapi/virtio.json @@ -135,7 +135,7 @@ # @num-vqs: VirtIODevice

[PATCH 12/18] qapi: add cross-references to replay.json

Signed-off-by: John Snow --- qapi/replay.json | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi/replay.json b/qapi/replay.json index 35e0c4a6926..78244a9d0bf 100644 --- a/qapi/replay.json +++ b/qapi/replay.json @@ -47,8 +47,8 @@ # @query-replay: # # Retrieve

[PATCH 07/18] qapi: add cross-references to Machine core

Signed-off-by: John Snow --- qapi/machine-common.json | 20 qapi/machine.json| 100 +++ 2 files changed, 60 insertions(+), 60 deletions(-) diff --git a/qapi/machine-common.json b/qapi/machine-common.json index 298e51f373a..a9f56cbbb43 100644

[PATCH 11/18] qapi: add cross-references to QOM

Signed-off-by: John Snow --- qapi/qdev.json | 4 ++-- qapi/qom.json | 9 + 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/qapi/qdev.json b/qapi/qdev.json index 5d18fb8e0e0..ff3f06a36d6 100644 --- a/qapi/qdev.json +++ b/qapi/qdev.json @@ -95,10 +95,10 @@ #from the

[PATCH 01/18] qapi: add cross-references to acpi.json

Signed-off-by: John Snow --- qapi/acpi.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/acpi.json b/qapi/acpi.json index 2d53b823656..8e48d8874dd 100644 --- a/qapi/acpi.json +++ b/qapi/acpi.json @@ -106,7 +106,7 @@ ## # @query-acpi-ospm-status: # -# Return a list

[PATCH 06/18] qapi: add cross-references to job.json

Signed-off-by: John Snow --- qapi/job.json | 73 ++- 1 file changed, 37 insertions(+), 36 deletions(-) diff --git a/qapi/job.json b/qapi/job.json index c1ddae9c0fe..ffeac7989dd 100644 --- a/qapi/job.json +++ b/qapi/job.json @@ -10,26 +10,26

[PATCH 03/18] qapi: add cross-references to block layer

Signed-off-by: John Snow --- qapi/block-core.json | 186 - qapi/block-export.json | 36 qapi/block.json| 14 ++-- qapi/transaction.json | 20 ++--- 4 files changed, 128 insertions(+), 128 deletions(-) diff --git a/qapi/block

[PATCH 02/18] qapi: add cross-references to authz.json

Signed-off-by: John Snow --- qapi/authz.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/authz.json b/qapi/authz.json index 7fc6e3032ea..cbd9399c461 100644 --- a/qapi/authz.json +++ b/qapi/authz.json @@ -75,7 +75,7 @@ # Properties for authz-listfile objects

[PATCH 00/18] QAPI: add cross-references to qapi docs

c cross-referencing syntax is documented at https://www.qemu.org/docs/master/devel/qapi-domain.html#cross-references * QMP Example syntax is documented towards the bottom of this QAPI codegen section: https://www.qemu.org/docs/master/devel/qapi-code-gen.html#definition-documentation Jo

Re: [PATCH v2 01/12] python: convert packages to PEP517/pyproject.toml

On Fri, Jun 13, 2025 at 4:36 AM Thomas Huth wrote: > On 12/06/2025 22.54, John Snow wrote: > > Newer versions of setuptools increasingly expect that packages are > > defined using the pyproject.toml/PEP517 packaging layout format. With > > 3.9 as our minimum, I believe it&

[PATCH v2 2/3] docs: remove legacy QAPI manual generator

Thanks for your service! Remove the old qapidoc and the option to enable the transmogrifier, leaving the "transmogrifier" as the ONLY qapi doc generator. This in effect also converts the QAPI test to use the new documentation generator, too. Signed-off-by: John Snow --- docs/inter

[PATCH v2 3/3] docs: remove special parsing for freeform sections

This change removes special parsing for freeform sections and allows them to simply be unmodified rST syntax. The existing headings in the QAPI schema are adjusted to reflect the new paradigm. Signed-off-by: John Snow --- docs/devel/qapi-code-gen.rst | 28 ++--- docs

[PATCH v2 1/3] docs: fix errors formatting in tests/qapi-schema/doc-good

|:error: tests/qapi-schema/doc-good.json:0168 |- some which compiles successfully. Signed-off-by: John Snow --- tests/qapi-schema/doc-good.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qapi-schema/doc-good.json b/tests/qapi-schema/doc-good.json index

[PATCH v2 0/3] docs: remove legacy qapidoc

messages with increased detail Markus: this one should be pretty short and sweet with good payoff. Makes a good candidate for your first post-vacation review ;) John Snow (3): docs: fix errors formatting in tests/qapi-schema/doc-good docs: remove legacy QAPI manual generator docs: remove

[PATCH v4 4/4] qapi: rephrase return docs to avoid type name

Well, I tried. Maybe not very hard. Sorry! Signed-off-by: John Snow --- qapi/block-core.json | 6 +++--- qapi/block-export.json | 2 +- qapi/block.json| 2 +- qapi/control.json | 5 ++--- qapi/dump.json | 5 ++--- qapi/introspect.json | 6 +++--- qapi/job.json

[PATCH v4 0/4] qapi: add auto-generated return docs

o do the copy-editing you'd like to see directly instead. (Sorry!) This patch is also possibly incomplete depending on taste. v3: rebased on top of python-qapi-linting (v4) pull request; removed commits that are no longer needed. Markus: I forget where we left off... shall we refresh?

[PATCH v4 2/4] docs, qapi: generate undocumented return sections

This patch changes the qapidoc transmogrifier to generate Return value documentation for any command that has a return value but hasn't explicitly documented that return value. Signed-off-by: John Snow --- docs/sphinx/qapidoc.py | 14 -- scripts/qapi/parser.py

[PATCH v4 1/4] docs/qapi-domain: add return-nodesc

because Sphinx always expects both a type and a description for the prior form and will format it accordingly. To have a reasonable rendering when the body is missing, we need to use a different info field list entirely. Signed-off-by: John Snow --- docs/devel/qapi-

[PATCH v4 3/4] qapi: remove trivial "Returns:" sections

ly touch other "Returns" lines that could be rephrased to omit repeating type information; it only removes lines that appear appropriate to wholly remove. Signed-off-by: John Snow --- qapi/audio.json | 2 -- qapi/block-core.json | 8 qapi/char.json | 8

[PATCH v2 12/12] scripts/codeconverter: remove * imports

,E265,E301,E302,E303,\ E305,E306,E501,E502,E703,E712,E731,E741,F841,\ W292,W391,W503,W504 \ *.py I am also using pylint's errors-only mode: pylint -E *.py Signed-off-by: John Snow --- .../codeconverter/codeconverter/patching.py | 4 +

[PATCH v2 11/12] scripts/codeconverter: remove unused code

Remove (select) bits of unused code, as it is not typed correctly and appears to not be in use. The quickest solution is to remove it entirely. 'Match' is not defined, and neither is 'TypeInfoReference'. What these bits of code were meant to do is unclear. Signed-off-by: Joh

[PATCH v2 10/12] python: remove version restriction for mypy

. Signed-off-by: John Snow --- python/setup.cfg | 1 - 1 file changed, 1 deletion(-) diff --git a/python/setup.cfg b/python/setup.cfg index 02cc076eaea..9b6dbc520aa 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -78,7 +78,6 @@ exclude = __pycache__, [mypy] strict = True -python_version

[PATCH v2 08/12] python: further 3.9+ syntax upgrades

pyupgrade does not catch absolutely everything - there are still a few deprecated type aliases we need to shift away from using. Signed-off-by: John Snow --- docs/sphinx/compat.py | 8 ++-- docs/sphinx/qapi_domain.py| 6 +++--- python/qemu/machine

[PATCH v2 09/12] python: update mkvenv to type-check under different python versions

import logic in mkvenv.py to make it type check under a wider range of python versions. It's largely arbitrary, to work around some mypy fussiness. Signed-off-by: John Snow --- python/scripts/mkvenv.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/p

[PATCH v2 07/12] fixup

don't perform any "optional" cleanups. (i.e. this patch strictly prevents regressions.) Signed-off-by: John Snow --- python/qemu/utils/qom_fuse.py | 1 + scripts/qapi/common.py| 28 ++-- 2 files changed, 15 insertions(+), 14 deletions(-) diff --gi

[PATCH v2 05/12] python: fix illegal escape sequences

\{ is an illegal escape sequence, to get a literal backslash we need to use \\. This is being fixed because of an issue spotted when attempting to use the pyupgrade script. Signed-off-by: John Snow --- scripts/feature_to_c.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v2 04/12] python: update shebangs to standard, using /usr/bin/env

This is the standard shebang we should always be using, as it plays nicely with virtual environments and our desire to always be using a specific python interpreter in our environments. (It also makes sure I can find all of the python scripts in our tree easily.) Signed-off-by: John Snow

[PATCH v2 03/12] python: sync changes from external qemu.qmp package

for now, it is. NB: A few changes are not synchronized; mostly license and documentation strings. Everything functional is fully copied verbatim. The license strings are not sync'd only because they point to different LICENSE filenames for the different repositories. Signed-off-by: John

  1   2   3   4   5   6   7   8   9   10   >