Passing `sizeof(cdb)` to `scsi_req_new()` looks like a correct fix to
me, but I'm not familiar enough with megasas / MegaRAID to be confident.
A possible slight alteration is to have `megasas_encode_lba()` return
the length of the CDB it synthesized, which IMO would make the
dependency more clear.
Gentle ping again.
I'd really like to get this ~6 line patch into mainline so I can pop it
off my TODO list.
On Mon, Sep 12, 2022 at 04:54:52PM +0900, John Millikin wrote:
> Gentle ping -- is there anything blocking this patch from going in?
>
> It's been about a month now s
ew revision.
On Mon, Sep 05, 2022 at 09:43:20AM +0200, Paolo Bonzini wrote:
> Probably just my screw up, or it broke something when testing... let me
> check.
>
> Paolo
>
> Il lun 5 set 2022, 05:30 John Millikin ha scritto:
>
> > I notice this patch wasn't inclu
ow.
On Sat, Aug 20, 2022 at 09:42:25AM +0200, Paolo Bonzini wrote:
> No, I had not seen it indeed. Queued now, thanks.
>
> Paolo
>
> Il gio 4 ago 2022, 14:39 John Millikin ha scritto:
>
> > SunOS expects CD-ROM devices to have a block size of 512, and will
> > fail
Gentle ping
On Sat, Aug 20, 2022 at 10:56:48AM +0900, John Millikin wrote:
> When a SCSI command is received from the guest, the CDB length implied
> by the first byte might exceed the number of bytes the guest sent. In
> this case scsi_req_new() will read uninitialized data
Thank you for the suggestions for CDB sizes! Especially the tricky ones
in spapr_vscsi.c and dev-uas.c.
v2: https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg02997.html
On Fri, Aug 19, 2022 at 06:06:13PM +0200, Paolo Bonzini wrote:
> On 8/17/22 07:34, John Millikin wrote:
> >
Gentle ping
On Thu, Aug 04, 2022 at 09:29:51PM +0900, John Millikin wrote:
> SunOS expects CD-ROM devices to have a block size of 512, and will
> fail to mount or install using QEMU's default block size of 2048.
>
> When initializing the SCSI device, allow the `physical_bl
le to successfully boot from
disk.
Signed-off-by: John Millikin
Buglink: https://gitlab.com/qemu-project/qemu/-/issues/1127
---
hw/scsi/scsi-bus.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
index b35fde0a30..abe195b22a 100644
--- a/hw
the
call stack.
Signed-off-by: John Millikin
Buglink: https://gitlab.com/qemu-project/qemu/-/issues/1127
---
hw/scsi/esp.c | 2 +-
hw/scsi/lsi53c895a.c | 2 +-
hw/scsi/megasas.c | 12 +++-
hw/scsi/mptsas.c | 3 ++-
hw/scsi/scsi-bus.c | 21
ition, the SunOS installer's early userspace doesn't set
the installation source location to sr0 and the miniroot copy fails.
Signed-off-by: John Millikin
Suggested-by: Bill Paul
Buglink: https://gitlab.com/qemu-project/qemu/-/issues/1127
---
hw/scsi/esp.c | 6 ++
1 file change
le to successfully boot from
disk.
Signed-off-by: John Millikin
Buglink: https://gitlab.com/qemu-project/qemu/-/issues/1127
---
hw/scsi/scsi-bus.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
index 288ea12969..1beb1b0cfc 100644
--- a/hw
the
call stack.
The sigil SCSI_CMD_BUF_LEN_TODO() is used to indicate that the buffer
length calculation is TODO it should be replaced by a better value,
such as the length of a successful DMA read.
Signed-off-by: John Millikin
Buglink: https://gitlab.com/qemu-project/qemu/-/issues/1127
---
hw
Per investigation on the linked ticket, SunOS issues a SCSI bus reset
to the ESP as part of its boot sequence. If this ESP command doesn't
cause devices to assert sense flag UNIT ATTENTION, SunOS will consider
the CD-ROM device to be non-compliant with Common Command Set (CCS).
In this condition, t
SunOS expects CD-ROM devices to have a block size of 512, and will
fail to mount or install using QEMU's default block size of 2048.
When initializing the SCSI device, allow the `physical_block_size'
block device option to override the default block size.
Signed-off-by: John Milliki
Gentle ping -- this is my first time sending a patch for QEMU and it
hasn't shown up in the qemu-devel mailing list web UI yet, so I can't
tell whether the mail is being sent/received successfully.
On Tue, Jul 26, 2022 at 12:42:06PM +0900, John Millikin wrote:
> SunOS expects CD-R
15 matches
Mail list logo
