se also add a Signed-off-by line.
>
> Cheers
Ok, I have removed the superfluous comments, added defines for magic
numbers, added braces to conform to the QEMU coding style guidelines,
and regression tested it in my system. Patch included below.
Thanks.
- John
Signed-off-by: John Clark
--
targe
-target_ulong helper_4xx_tlbre_hi (target_ulong entry)
+target_ulong helper_4xx_tlbre_lo (target_ulong entry)
>>>
>>> Huh?
>>
>> To summarize, 'tlbre' has two forms: one to retrieve the high bits of
>> a TLB entry (TLBHI), and one to retrieve the low bits (TLBLO) of a TLB
>> entry.
>> /* Check from TLB entry */
>> -/* XXX: there is a problem here or in the TLB fill code... */
>> +/* There is no longer a need to force PAGE_EXEC permission here
>> */
>> +/* because of the tlb->attr fix in helper_4xx_tlbwe_lo() */
>
> I guess tha
Diffs are included below.
Thank you.
- John Clark
diff --git a/target-ppc/helper.c b/target-ppc/helper.c
index 3bc8a34..a8c1802 100644
--- a/target-ppc/helper.c
+++ b/target-ppc/helper.c
@@ -1172,9 +1172,9 @@ static int mmu40x_get_physical_address (CPUState *env,
mmu_ctx_t *ctx,
