Re: [PATCH v2 4/4] qga: Add cross-references

On Thu, Jul 17, 2025 at 7:52 AM Markus Armbruster wrote: > > Enclose command and type names in `backquotes`, so they become links > in generated HTML. > > We did this for qapi/ in merge commit 504632dcc631. > > Signed-off-by: Markus Armbruster Reviewed-by: John Sno

Re: [PATCH v2 3/4] qga: Rephrase return docs to avoid type name

gt; > We did this for qapi/ in commit f7296f8de5c (qapi: rephrase return > docs to avoid type name). > > Signed-off-by: Markus Armbruster > Reviewed-by: Daniel P. Berrangé Reviewed-by: John Snow > --- > qga/qapi-schema.json | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH v2 2/4] qga: Remove trivial "Returns:" sections

The auto-generated returns all are in the exact same spot. > > We did this for qapi/ in commit 0462da9d6b1 (qapi: remove trivial > "Returns:" sections). > > Signed-off-by: Markus Armbruster > Reviewed-by: Daniel P. Berrangé Reviewed-by: John Snow > --- > qga/qap

Re: [PATCH] tests/functional: add --debug CLI arg

On Thu, Jul 17, 2025 at 4:44 AM Alex Bennée wrote: > > Manos Pitsidianakis writes: > > > Add argument parsing to functional tests to improve developer experience > > when running individual tests. All logs are printed to stdout > > interspersed with TAP output. > > > > ./pyvenv/bin/python3 ../t

Re: [PATCH v2 1/4] qga: Fix guest-network-get-route return value documentation

8e326d36dd16 (qga/linux: Add new api 'guest-network-get-route') > Signed-off-by: Markus Armbruster > Reviewed-by: Daniel P. Berrangé Reviewed-by: John Snow > --- > qga/qapi-schema.json | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/qga/qapi-schema.json

Re: [PATCH] qapi: Add more cross-references

; --- a/qapi/sockets.json > +++ b/qapi/sockets.json > @@ -143,7 +143,7 @@ > # > # @str: decimal is for file descriptor number, otherwise it's a file > # descriptor name. Named file descriptors are permitted in > -# monitor commands, in combination with the 'getfd' command. > +# monitor commands, in combination with the `getfd` command. > # Decimal file descriptors are permitted at startup or other > # contexts where no monitor context is active. Presumably another indent miss. > # > -- > 2.49.0 Reviewed-by: John Snow

Re: [PATCH 0/2] docs, python: bump sphinx preferred version

On Wed, Jul 16, 2025, 11:04 AM Markus Armbruster wrote: > Okay to include this in my next QAPI PR? > That would be very convenient, thank you! (And thanks to Akihiko Odaki for spotting and fixing the issue, even if it took me a while to sort through our policy.) >

Re: [PATCH] python: fix editable installs for modern pip/setuptools

On Tue, Jul 15, 2025, 6:27 PM John Snow wrote: > The way editable installs work has changed at some point since Fedora 40 > was released. Generally, we should be opting to use pyproject.toml > installs (PEP517/518) - but those are not fully supported until v61 of > setuptools, and C

[PATCH] python: fix editable installs for modern pip/setuptools

8.2.3 pkgsrc_current 3.12.11 25.1.1 80.9.0 8.2.3 Signed-off-by: John Snow --- python/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/Makefile b/python/Makefile index 764b79ccb23..32aedce4137 100644 --- a/python/Makefile +++ b/python/Makefile @

Re: [PATCH 0/2] docs, python: bump sphinx preferred version

fwiw, I think this is important enough / harmless enough to sneak into the rc releases, if possible. On Tue, Jul 15, 2025 at 5:28 PM John Snow wrote: > > CI: https://gitlab.com/jsnow/qemu/-/pipelines/1928836481 > > Unlike the previous series, this series only adjusts the *preferr

[PATCH 2/2] MAINTAINERS: Add docs/requirements.txt

From: Akihiko Odaki Add docs/requirements.txt to "Sphinx documentation configuration and build machinery". Signed-off-by: Akihiko Odaki Signed-off-by: John Snow --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e88ed2c0a97..809cd1aa

[PATCH 0/2] docs, python: bump sphinx preferred version

CI: https://gitlab.com/jsnow/qemu/-/pipelines/1928836481 Unlike the previous series, this series only adjusts the *preferred* sphinx version to be higher, leaving the accepted version at 3.4.3, the version that CentOS Stream 9 still ships with. Unfortunately, this means we can't cut out the compa

[PATCH 1/2] docs: Bump sphinx to 6.2.1

ed if they are present and functional. The version used for building docs on readthedocs is pinned to the recommended version, 6.2.1.) Signed-off-by: Akihiko Odaki Tested-by: Markus Armbruster Reviewed-by: John Snow Signed-off-by: John Snow --- docs/requirements.txt | 4 ++-- pythondeps.toml

Re: [PATCH V4 2/3] python: use qom-list-get

On Fri, Jul 11, 2025, 10:47 AM Markus Armbruster wrote: > Steve Sistare writes: > > > Use qom-list-get to speed up the qom-tree command. > > > > Signed-off-by: Steve Sistare > > Quick test... Differences in output before and after match expectations > (see appended diff). > > New version: > >

Re: [PATCH 20/22] vfio-user/pci.c: use QOM casts where appropriate

ead(VFIOPCIDevice *vdev, > VFIOUserDMARW *msg) > > static void vfio_user_dma_write(VFIOPCIDevice *vdev, VFIOUserDMARW *msg) > { > -PCIDevice *pdev = &vdev->pdev; > +PCIDevice *pdev = PCI_DEVICE(vdev); > VFIOUserProxy *proxy = vdev->vbasedev.proxy; > MemTxResult r; > Reviewed-by: John Levon

Re: [PATCH 09/22] vfio/container.c: use QOM casts where appropriate

uot; not vfio/container.c regards john

Re: [PATCH 13/22] vfio-user/pci.c: rename VFIOUserPCIDevice device field to parent_obj

_USER_PCI) > > struct VFIOUserPCIDevice { > -VFIOPCIDevice device; > +VFIOPCIDevice parent_obj; > > SocketAddress *socket; > bool send_queued; /* all sends are queued */ Reviewed-by: John Levon

Re: [PATCH 10/22] vfio-user/container.h: rename VFIOUserContainer bcontainer field to parent_obj

ntainer sub-class for vfio-user. */ > struct VFIOUserContainer { > -VFIOContainerBase bcontainer; > +VFIOContainerBase parent_obj; > > VFIOUserProxy *proxy; > }; Reviewed-by: John Levon

Re: [PATCH 12/22] vfio-user/pci.c: use QOM casts where appropriate

r *name, > VFIOUserPCIDevice *udev = VFIO_USER_PCI(obj); > bool success; > > -if (udev->device.vbasedev.proxy) { > +if (VFIO_PCI_BASE(udev)->vbasedev.proxy) { > error_setg(errp, "Proxy is connected"); > return; > } Reviewed-by: John Levon

Re: [PATCH 11/22] vfio-user/pci.c: update VFIOUserPCIDevice declaration

ruct VFIOUserPCIDevice { > VFIOPCIDevice device; > + > SocketAddress *socket; > bool send_queued; /* all sends are queued */ > uint32_t wait_time; /* timeout for message replies */ Reviewed-by: John Levon

Re: [PATCH 08/22] vfio-user/container.h: update VFIOUserContainer declaration

se bcontainer; > + > VFIOUserProxy *proxy; > -} VFIOUserContainer; > +}; > > OBJECT_DECLARE_SIMPLE_TYPE(VFIOUserContainer, VFIO_IOMMU_USER); > Reviewed-by: John Levon

[PATCH v3 1/4] hw/vfio-user: add Cédric Le Goater as a maintainer

Signed-off-by: John Levon --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e88ed2c0a9..30e9b71e6e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4287,6 +4287,7 @@ F: tests/functional/test_multiprocess.py VFIO-USER: M: John Levon M: Thanos

[PATCH v3 4/4] hw/vfio-user: fix use of uninitialized variable

e same way to resolve this. Resolves: Coverity CID 1611805 Fixes: 18e899e6 ("vfio-user: implement VFIO_USER_DMA_MAP/UNMAP") Reported-by: Cédric Le Goater Signed-off-by: John Levon Reviewed-by: Cédric Le Goater --- hw/vfio-user/container.c | 6 +- 1 file changed, 1 insertion(+), 5 del

[PATCH v3 0/4] vfio-user fixes

Some small Coverity and related fixes for the recently merged vfio-user series. thanks john John Levon (4): hw/vfio-user: add Cédric Le Goater as a maintainer hw/vfio: fix region fd initialization hw/vfio-user: wait for proxy close correctly hw/vfio-user: fix use of uninitialized

[PATCH v3 3/4] hw/vfio-user: wait for proxy close correctly

ity. Signed-off-by: John Levon Reviewed-by: Mark Cave-Ayland Reviewed-by: Cédric Le Goater --- hw/vfio-user/proxy.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/vfio-user/proxy.c b/hw/vfio-user/proxy.c index c418954440..2275d3fe39 100644 --- a/hw/vfio-u

[PATCH v3 2/4] hw/vfio: fix region fd initialization

We were not initializing the region fd array to -1, so we would accidentally try to close(0) on cleanup for any region that is not referenced. Fixes: 95cdb024 ("vfio: add region info cache") Signed-off-by: John Levon Reviewed-by: Mark Cave-Ayland Reviewed-by: Cédric Le Goater --

Re: [PATCH v2 3/4] hw/vfio-user: wait for proxy close correctly

On Tue, Jul 15, 2025 at 10:01:59AM +0100, Mark Cave-Ayland wrote: > On 15/07/2025 06:52, John Levon wrote: > > > Coverity reported: > > > > CID 1611806: Concurrent data access violations (BAD_CHECK_OF_WAIT_COND) > > > > A wait is performed without a loop

[PATCH v2 4/4] hw/vfio-user: fix use of uninitialized variable

e same way to resolve this. Resolves: Coverity CID 1611805 Fixes: 18e899e6 ("vfio-user: implement VFIO_USER_DMA_MAP/UNMAP") Reported-by: Cédric Le Goater Signed-off-by: John Levon --- hw/vfio-user/container.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/vfi

[PATCH v2 3/4] hw/vfio-user: wait for proxy close correctly

xes: 0b3d881a ("vfio-user: implement message receive infrastructure") Signed-off-by: John Levon --- hw/vfio-user/proxy.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/vfio-user/proxy.c b/hw/vfio-user/proxy.c index c418954440..2275d3fe39 100644 --- a

[PATCH v2 2/4] hw/vfio: fix region fd initialization

We were not initializing the region fd array to -1, so we would accidentally try to close(0) on cleanup for any region that is not referenced. Fixes: 95cdb024 ("vfio: add region info cache") Signed-off-by: John Levon --- hw/vfio/device.c | 6 +- 1 file changed, 5 insertions(+),

[PATCH v2 1/4] hw/vfio-user: add Cédric Le Goater as a maintainer

Signed-off-by: John Levon --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e88ed2c0a9..30e9b71e6e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4287,6 +4287,7 @@ F: tests/functional/test_multiprocess.py VFIO-USER: M: John Levon M: Thanos

[PATCH v2 0/4] vfio-user fixes

Some small Coverity and related fixes for the recently merged vfio-user series. thanks john John Levon (4): hw/vfio-user: add Cédric Le Goater as a maintainer hw/vfio: fix region fd initialization hw/vfio-user: wait for proxy close correctly hw/vfio-user: fix use of uninitialized

Re: [PATCH v2 00/18] QAPI: add cross-references to qapi docs

On Fri, Jul 11, 2025, 5:04 AM Markus Armbruster wrote: > John Snow writes: > > > Based-on: 20250711051045.51110-1-js...@redhat.com > > [PATCH v6 0/4] qapi: add auto-generated return docs > > > > v2: > > - Applied a few new transformations I had missed. &

Re: [PATCH v2 08/18] qapi: add cross-references to migration.json

On Fri, Jul 11, 2025, 4:55 AM Markus Armbruster wrote: > John Snow writes: > > > Signed-off-by: John Snow > > --- > > qapi/migration.json | 68 ++--- > > 1 file changed, 34 insertions(+), 34 deletions(-) > > > &g

[PATCH v2] hw/vfio-user: wait for proxy close correctly

ity. Signed-off-by: John Levon --- hw/vfio-user/proxy.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/vfio-user/proxy.c b/hw/vfio-user/proxy.c index c418954440..2275d3fe39 100644 --- a/hw/vfio-user/proxy.c +++ b/hw/vfio-user/proxy.c @@ -32,7 +32,6 @@ static v

[PATCH v2 16/18] qapi: add cross-references to virtio.json

Signed-off-by: John Snow --- qapi/virtio.json | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qapi/virtio.json b/qapi/virtio.json index d1556dbf24a..3bc8700e943 100644 --- a/qapi/virtio.json +++ b/qapi/virtio.json @@ -135,7 +135,7 @@ # @num-vqs: VirtIODevice

[PATCH v2 12/18] qapi: add cross-references to replay.json

Signed-off-by: John Snow --- qapi/replay.json | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi/replay.json b/qapi/replay.json index 35e0c4a6926..78244a9d0bf 100644 --- a/qapi/replay.json +++ b/qapi/replay.json @@ -47,8 +47,8 @@ # @query-replay: # # Retrieve

[PATCH v2 17/18] qapi: add cross-references to yank.json

Signed-off-by: John Snow Acked-by: Lukas Straub --- qapi/yank.json | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/qapi/yank.json b/qapi/yank.json index 5f26d6c0149..f1b737e87d6 100644 --- a/qapi/yank.json +++ b/qapi/yank.json @@ -9,7 +9,7

[PATCH v2 04/18] qapi: add cross-references to crypto.json

Signed-off-by: John Snow --- qapi/crypto.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/crypto.json b/qapi/crypto.json index 9ec6301e188..57620d95da6 100644 --- a/qapi/crypto.json +++ b/qapi/crypto.json @@ -589,9 +589,9 @@ # # Specific parameters for RSA

[PATCH v2 15/18] qapi: add cross-references to ui.json

Signed-off-by: John Snow --- qapi/ui.json | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 7136c985c38..5bc54403cc2 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -39,7 +39,7 @@ ## # @SetPasswordOptions

[PATCH v2 09/18] qapi: add cross-references to net.json

Signed-off-by: John Snow --- qapi/net.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qapi/net.json b/qapi/net.json index 371ade0dc6a..8631c8dd61c 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -655,7 +655,7 @@ # this to zero disables this function. This

[PATCH v2 11/18] qapi: add cross-references to QOM

Signed-off-by: John Snow --- qapi/qdev.json | 4 ++-- qapi/qom.json | 13 +++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/qapi/qdev.json b/qapi/qdev.json index 5d18fb8e0e0..ff3f06a36d6 100644 --- a/qapi/qdev.json +++ b/qapi/qdev.json @@ -95,10 +95,10 @@ #from

[PATCH v2 03/18] qapi: add cross-references to block layer

Signed-off-by: John Snow --- qapi/block-core.json | 188 - qapi/block-export.json | 36 qapi/block.json| 14 +-- qapi/transaction.json | 12 +-- 4 files changed, 125 insertions(+), 125 deletions(-) diff --git a/qapi/block-core.json

[PATCH v2 18/18] qapi: add cross-references to misc modules

These modules don't have specific maintainers, so they're lumped in together here as miscellaneous. Signed-off-by: John Snow --- qapi/control.json| 2 +- qapi/ebpf.json | 2 +- qapi/introspect.json | 24 qapi/misc-arm.json | 4 ++-- qapi/misc

[PATCH v2 10/18] qapi: add cross-references to pci.json

Signed-off-by: John Snow --- qapi/pci.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/pci.json b/qapi/pci.json index 29549d94551..4aad5f98e2a 100644 --- a/qapi/pci.json +++ b/qapi/pci.json @@ -83,7 +83,7 @@ # # @bus: information about the bus the device resides on

[PATCH v2 06/18] qapi: add cross-references to job.json

Signed-off-by: John Snow --- qapi/job.json | 71 ++- 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/qapi/job.json b/qapi/job.json index c1ddae9c0fe..a6026f6a810 100644 --- a/qapi/job.json +++ b/qapi/job.json @@ -10,26 +10,26

[PATCH v2 13/18] qapi: add cross-references to run-state.json

Signed-off-by: John Snow --- qapi/run-state.json | 46 ++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 759f8730059..bafbbf695b2 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json

[PATCH v2 08/18] qapi: add cross-references to migration.json

Signed-off-by: John Snow --- qapi/migration.json | 68 ++--- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index 59a213aeb6c..eda27c18102 100644 --- a/qapi/migration.json +++ b/qapi/migration.json

[PATCH v2 14/18] qapi: add cross-references to sockets.json

Signed-off-by: John Snow Reviewed-by: Eric Blake --- qapi/sockets.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qapi/sockets.json b/qapi/sockets.json index f9f559dabae..e7f8b42bda3 100644 --- a/qapi/sockets.json +++ b/qapi/sockets.json @@ -209,14 +209,14

[PATCH v2 00/18] QAPI: add cross-references to qapi docs

his QAPI codegen section: https://www.qemu.org/docs/master/devel/qapi-code-gen.html#definition-documentation John Snow (18): qapi: add cross-references to acpi.json qapi: add cross-references to authz.json qapi: add cross-references to block layer qapi: add cross-references t

[PATCH v2 07/18] qapi: add cross-references to Machine core

Signed-off-by: John Snow --- qapi/machine-common.json | 20 +- qapi/machine.json| 82 2 files changed, 51 insertions(+), 51 deletions(-) diff --git a/qapi/machine-common.json b/qapi/machine-common.json index 298e51f373a..a9f56cbbb43

[PATCH v2 05/18] qapi: add cross-references to dump.json

Signed-off-by: John Snow --- qapi/dump.json | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qapi/dump.json b/qapi/dump.json index 3a9b67efb1b..a615e73a64a 100644 --- a/qapi/dump.json +++ b/qapi/dump.json @@ -110,7 +110,7 @@ # # Describe the status of a long

[PATCH v2 02/18] qapi: add cross-references to authz.json

Signed-off-by: John Snow --- qapi/authz.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/authz.json b/qapi/authz.json index 7fc6e3032ea..cbd9399c461 100644 --- a/qapi/authz.json +++ b/qapi/authz.json @@ -75,7 +75,7 @@ # Properties for authz-listfile objects

[PATCH v2 01/18] qapi: add cross-references to acpi.json

Signed-off-by: John Snow --- qapi/acpi.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/acpi.json b/qapi/acpi.json index 2d53b823656..8e48d8874dd 100644 --- a/qapi/acpi.json +++ b/qapi/acpi.json @@ -106,7 +106,7 @@ ## # @query-acpi-ospm-status: # -# Return a list

Re: [PATCH 08/18] qapi: add cross-references to migration.json

On Wed, Jul 2, 2025 at 4:04 AM Markus Armbruster wrote: > > John Snow writes: > > > Signed-off-by: John Snow > > --- > > qapi/migration.json | 62 ++--- > > 1 file changed, 31 insertions(+), 31 deletions(-) > > >

[PATCH v6 2/4] docs, qapi: generate undocumented return sections

m, a "TODO:" hack line is used to separate the intro from the remainder of the documentation block in cases where there are no other sections to separate the intro from e.g. examples and additional detail meant to appear below the key sections of interest. Signed-off-by: John Snow --- do

[PATCH v6 1/4] docs/qapi-domain: add return-nodesc

because Sphinx always expects both a type and a description for the prior form and will format it accordingly. To have a reasonable rendering when the body is missing, we need to use a different info field list entirely. Signed-off-by: John Snow --- docs/devel/qapi-

[PATCH v6 4/4] qapi: rephrase return docs to avoid type name

Well, I tried. Maybe not very hard. Sorry! Signed-off-by: John Snow --- qapi/block-core.json | 6 +++--- qapi/block-export.json | 2 +- qapi/block.json| 2 +- qapi/control.json | 5 ++--- qapi/dump.json | 5 ++--- qapi/introspect.json | 6 +++--- qapi/job.json

[PATCH v6 0/4] qapi: add auto-generated return docs

ferred insertion algorithm v4: rebased on origin/master (2025-06-12) v3: rebased on top of python-qapi-linting (v4) pull request; removed commits that are no longer needed. v2: fix multi-return-sections bug :( John Snow (4): docs/qapi-domain: add return-nodesc docs, qapi: generate undoc

[PATCH v6 3/4] qapi: remove trivial "Returns:" sections

m differentiate the introductory paragraph(s) from the rest of the documentation. Signed-off-by: John Snow --- qapi/audio.json | 2 -- qapi/block-core.json | 8 qapi/char.json | 8 qapi/cryptodev.json | 2 -- qapi/machine.json| 22 -- qapi

[PATCH] hw/vfio: fix region fd initialization

We were not initializing the region fd array to -1, so we would accidentally try to close(0) on cleanup for any region that is not referenced. Fixes: 95cdb024 ("vfio: add region info cache") Signed-off-by: John Levon --- hw/vfio/device.c | 6 +- 1 file changed, 5 insertions(+),

[PATCH] hw/vfio-user: wait for proxy close correctly

Coverity reported: CID 1611806: Concurrent data access violations (BAD_CHECK_OF_WAIT_COND) A wait is performed without a loop. If there is a spurious wakeup, the condition may not be satisfied. Fix this by checking ->state for VFIO_PROXY_CLOSED in a loop. Signed-off-by: John Levon ---

Re: [PULL 08/25] vfio-user: connect vfio proxy to remote server

On Thu, Jul 10, 2025 at 01:33:17PM +0100, Peter Maydell wrote: > On Thu, 26 Jun 2025 at 08:51, Cédric Le Goater wrote: > > > > From: John Levon > > > > Introduce the vfio-user "proxy": this is the client code responsible for > > sending and receiving v

Re: Build platform guarantees, docs, tests, and snakes in the garden

On Wed, Jul 9, 2025, 3:40 PM Paolo Bonzini wrote: > > > Il mer 9 lug 2025, 20:39 John Snow ha scritto: > >> You are right. However, the mkvenv configuration tool we pioneered has >> been largely un-noticed by contributors and appears to "just work" for >>

Re: Build platform guarantees, docs, tests, and snakes in the garden

On Mon, Jul 7, 2025 at 5:11 AM Daniel P. Berrangé wrote: > > On Wed, Jul 02, 2025 at 03:24:09PM -0400, Paolo Bonzini wrote: > > Il mar 24 giu 2025, 02:45 Markus Armbruster ha scritto: > > > > > > ... I think I value this a bit higher than Markus, but not really > > > because of offline builds. R

Re: Python ecosystem versions overview

time, but it's still potentially a quite useful reference and I don't know where else to put it. I know we have a wiki, but I think the wiki is not really a great source of information for our project as *most* pages there are quite rotted. On Tue, Jul 8, 2025 at 4:36 PM John Snow

Re: Python ecosystem versions overview

On Tue, Jul 8, 2025, 7:23 PM Paolo Bonzini wrote: > On 7/8/25 22:36, John Snow wrote: > > centos_stream_9 3.9.23 21.3.1 53.0.0 3.4.3 BaseOS, CRB > > Ok, so the lowest version of Sphinx (3.4.3) is currently used for CentOS > Stream 9. It's supported for roug

Python ecosystem versions overview

Hi, recently there was some discussion and debate over what versions of which things in the Python ecosystem we need to support with regards to our build platform promise. I don't address those issues in this mail at all. O:-) In researching that problem, I created a CLI script to automatically po

[PATCH] hw/vfio-user: fix use of uninitialized variable

e same way to resolve this. Reported-by: Cédric Le Goater Signed-off-by: John Levon --- hw/vfio-user/container.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/vfio-user/container.c b/hw/vfio-user/container.c index d318e6a339..d589dd90f5 100644 --- a/hw/vfio-user/cont

Re: [PATCH v3 4/5] docs/sphinx: remove special parsing for freeform sections

On Fri, Jun 27, 2025, 5:52 AM Markus Armbruster wrote: > John Snow writes: > > > This change removes special parsing for freeform sections and allows > > them to simply be unmodified rST syntax. The existing headings in the > > QAPI schema are adjusted to reflect the n

Re: [PATCH v3 4/5] docs/sphinx: remove special parsing for freeform sections

On Fri, Jun 27, 2025, 5:52 AM Markus Armbruster wrote: > John Snow writes: > > > This change removes special parsing for freeform sections and allows > > them to simply be unmodified rST syntax. The existing headings in the > > QAPI schema are adjusted to reflect the n

Re: [PATCH v3 2/5] docs/sphinx: parse @references in freeform text

On Fri, Jun 27, 2025, 5:54 AM Markus Armbruster wrote: > John Snow writes: > > > Oversight in the new qapidoc transmogrifier: @references in freeform > > documentation blocks were not being transformed to literals. This fixes > > that, and the next patch ensures that

[PATCH v5 3/4] qapi: remove trivial "Returns:" sections

ly touch other "Returns" lines that could be rephrased to omit repeating type information; it only removes lines that appear appropriate to wholly remove. Signed-off-by: John Snow --- qapi/audio.json | 2 -- qapi/block-core.json | 8 qapi/char.json | 8

[PATCH v5 1/4] docs/qapi-domain: add return-nodesc

because Sphinx always expects both a type and a description for the prior form and will format it accordingly. To have a reasonable rendering when the body is missing, we need to use a different info field list entirely. Signed-off-by: John Snow --- docs/devel/qapi-

[PATCH v5 4/4] qapi: rephrase return docs to avoid type name

Well, I tried. Maybe not very hard. Sorry! Signed-off-by: John Snow --- qapi/block-core.json | 6 +++--- qapi/block-export.json | 2 +- qapi/block.json| 2 +- qapi/control.json | 5 ++--- qapi/dump.json | 5 ++--- qapi/introspect.json | 6 +++--- qapi/job.json

[PATCH v5 2/4] docs, qapi: generate undocumented return sections

This patch changes the qapidoc parser to generate stub Return value documentation for any command that has a return value but does not have a "Returns:" doc section. The stubs include just the type name, which will be rendered with a cross-reference link in the HTML output. Signed-of

[PATCH v5 0/4] qapi: add auto-generated return docs

removed commits that are no longer needed. v2: fix multi-return-sections bug :( John Snow (4): docs/qapi-domain: add return-nodesc docs, qapi: generate undocumented return sections qapi: remove trivial "Returns:" sections qapi: rephrase return docs to avoid type name docs/d

Re: Build platform guarantees, docs, tests, and snakes in the garden

On Tue, Jun 24, 2025 at 2:45 AM Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 6/5/25 21:35, John Snow wrote: > >> However, if we take as iron-clad our commitment to the build platform > promise -- *and* guarantee offline/tarball builds as well -- then De

[PATCH v5 06/19] vfio-user: implement VFIO_USER_DEVICE_GET_REGION_INFO

Add support for getting region info for vfio-user. As vfio-user has one fd per region, enable ->use_region_fds. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio-user/device.h | 2 ++ hw/vfio-user/protoco

[PATCH v5 05/19] vfio-user: implement VFIO_USER_DEVICE_GET_INFO

Add support for getting basic device information. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio-user/device.h | 20 ++ hw/vfio-user/protocol.h | 12 + hw/vfio-user/proxy.h | 7

[PATCH v5 18/19] docs: add vfio-user documentation

Add some basic documentation on vfio-user usage. Signed-off-by: John Levon --- docs/system/device-emulation.rst | 1 + docs/system/devices/vfio-user.rst | 26 ++ 2 files changed, 27 insertions(+) create mode 100644 docs/system/devices/vfio-user.rst diff --git a/docs

[PATCH v5 14/19] vfio-user: implement VFIO_USER_DMA_READ/WRITE

Unlike most other messages, this is a server->client message, for when a server wants to do "DMA"; this is slow, so normally the server has memory directly mapped instead. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-b

[PATCH v5 19/19] vfio-user: introduce vfio-user protocol specification

discussed as an RFC in: "RFC: use VFIO over a UNIX domain socket to implement device offloading" Signed-off-by: Thanos Makatos Signed-off-by: John Levon --- MAINTAINERS|3 +- docs/interop/index.rst |1 + docs/interop/vfio-user.

[PATCH v5 12/19] vfio-user: implement VFIO_USER_DEVICE_RESET

Hook this call up to the legacy reset handler for vfio-user-pci. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio-user/device.h | 2 ++ hw/vfio-user/device.c | 18 ++ hw/vfio-user/pci.c| 15

[PATCH v5 09/19] vfio-user: implement VFIO_USER_DEVICE_GET/SET_IRQ*

IRQ setup uses the same semantics as the traditional vfio path, but we need to share the corresponding file descriptors with the server as necessary. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio-user

[PATCH v5 10/19] vfio-user: forward MSI-X PBA BAR accesses to server

For vfio-user, the server holds the pending IRQ state; set up an I/O region for the MSI-X PBA so we can ask the server for this state on a PBA read. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/pci.h

[PATCH v5 11/19] vfio-user: set up container access to the proxy

The user container will shortly need access to the underlying vfio-user proxy; set this up. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio-user/container.h | 2 ++ hw/vfio-user/container.c | 43

[PATCH v5 13/19] vfio-user: implement VFIO_USER_DMA_MAP/UNMAP

From: John Levon When the vfio-user container gets mapping updates, share them with the vfio-user by sending a message; this can include the region fd, allowing the server to directly mmap() the region as needed. For performance, we only wait for the message responses when we're doing w

[PATCH v5 03/19] vfio-user: implement message receive infrastructure

Add the basic implementation for receiving vfio-user messages from the control socket. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- meson.build | 1 + hw/vfio-user/protocol.h | 53 + hw/vfio

[PATCH v5 08/19] vfio-user: set up PCI in vfio_user_pci_realize()

Re-use PCI setup functions from hw/vfio/pci.c to realize the vfio-user PCI device. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio-user/pci.c | 29 + 1 file changed, 29 insertions

[PATCH v5 02/19] vfio-user: connect vfio proxy to remote server

rPCIDevice instance. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio-user/proxy.h | 79 + include/hw/vfio/vfio-device.h | 2 + hw/vfio-user/pci.c| 22 + hw/vfio-us

[PATCH v5 07/19] vfio-user: implement VFIO_USER_REGION_READ/WRITE

Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio-user/protocol.h | 12 ++ hw/vfio-user/device.c | 79 +++ hw/vfio-user/trace-events | 1 + 3 files changed, 92

[PATCH v5 04/19] vfio-user: implement message send infrastructure

Add plumbing for sending vfio-user messages on the control socket. Add initial version negotation on connection. Originally-by: John Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John Levon --- hw/vfio-user/protocol.h | 62 + hw/vfio-user

[PATCH v5 16/19] vfio-user: support posted writes

Support an asynchronous send of a vfio-user socket message (no wait for a reply) when the write is posted. This is only safe when no regions are mappable by the VM. Add an option to explicitly disable this as well. Signed-off-by: John Levon --- hw/vfio-user/proxy.h | 6 ++ hw/vfio-user

[PATCH v5 17/19] vfio-user: add coalesced posted writes

Add new message to send multiple writes to server in a single message. Prevents the outgoing queue from overflowing when a long latency operation is followed by a series of posted writes. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by

[PATCH v5 15/19] vfio-user: add 'x-msg-timeout' option

By default, the vfio-user subsystem will wait 5 seconds for a message reply from the server. Add an option to allow this to be configurable. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio-user/proxy.h | 1

[PATCH v5 00/19] vfio-user client

functional test is still being worked on. A previous version of this series can be found at https://lore.kernel.org/qemu-devel/20250619133154.264786-1-john.le...@nutanix.com/ Changes since last series: - fixed SPDX identifier nits - code review changes for error handling thanks john John Levon (18

[PATCH v5 01/19] vfio-user: add vfio-user class and container

.c for instantiating VFIOUserPCIDevice objects, sharing some common code from hw/vfio/pci.c. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- MAINTAINERS | 8 + hw/vfio-user/container.h

Re: [PATCH] vfio: add license tag to some files

ructure files which are > all similar across the QEMU project. OK thanks, happy to drop this patch then regards john

Re: [PATCH v2 06/12] python: upgrade to python3.9+ syntax

On Tue, Jun 24, 2025 at 3:34 AM Markus Armbruster wrote: > John Snow writes: > > > This patch is fully automated, using pymagic, isort and autoflake. > > > > Create a script named pymagic.sh: > > > > = > > > > pyupgrade -

  1   2   3   4   5   6   7   8   9   10   >