Re: [Qemu-devel] EHCI USB regression in 1.2.0 - ehci_state_fetchqtd() asserting

2012-10-08 Thread Johannes Stezenbach
Hi, On Mon, Oct 08, 2012 at 05:03:24PM +0200, Hans de Goede wrote: > On 10/08/2012 04:49 PM, Johannes Stezenbach wrote: > >On Mon, Oct 08, 2012 at 03:51:08PM +0200, Hans de Goede wrote: > >>the real problem is the > >>"ehci warning: guest updated active QH"

Re: [Qemu-devel] EHCI USB regression in 1.2.0 - ehci_state_fetchqtd() asserting

2012-10-08 Thread Johannes Stezenbach
Hi, On Mon, Oct 08, 2012 at 03:51:08PM +0200, Hans de Goede wrote: > On 10/08/2012 03:01 PM, Johannes Stezenbach wrote: > > > >There will always be a race between the call to USBDEVFS_DISCARDURB > >and the URB completing. IMHO the handling in usb_host_stop_n_free_iso() &g

Re: [Qemu-devel] EHCI USB regression in 1.2.0 - ehci_state_fetchqtd() asserting

2012-10-08 Thread Johannes Stezenbach
Hi Hans, On Mon, Oct 08, 2012 at 01:27:28PM +0200, Hans de Goede wrote: > On 10/02/2012 05:26 PM, Shawn Starr wrote: > > > >Reopening this issue with usb-host stalling now > > > >ehci warning: guest updated active QH > >USBDEVFS_DISCARDURB: Invalid argument > >USBDEVFS_DISCARDURB: Invalid argument

Re: [Qemu-devel] [PATCH 14/14] usb-host: add timeout handler

2012-04-26 Thread Johannes Stezenbach
Hi, On Tue, Apr 24, 2012 at 05:51:31PM +0200, Gerd Hoffmann wrote: > Add a timeout handler. In case bulk transfers take too long to finish > the request will be canceled. The timeout is tunable via property, by > default it is 5 seconds. This patch causes an issue for my firmware download. The

Re: [Qemu-devel] [PATCH 0/3] fix zero-length packets in usb-host

2012-04-26 Thread Johannes Stezenbach
Hi, On Thu, Apr 19, 2012 at 10:02:22PM +0200, Johannes Stezenbach wrote: > On Thu, Apr 19, 2012 at 01:54:33PM +0200, Gerd Hoffmann wrote: > > Largely based on a patch from Johannes Stezenbach. Splitted it up, > > improved patch descriptions and added one related ehci bugfix. &g

Re: [Qemu-devel] [PATCH 0/3] fix zero-length packets in usb-host

2012-04-19 Thread Johannes Stezenbach
Hi, On Thu, Apr 19, 2012 at 01:54:33PM +0200, Gerd Hoffmann wrote: > Largely based on a patch from Johannes Stezenbach. Splitted it up, > improved patch descriptions and added one related ehci bugfix. > > Johannes, does this series fix your firmware update issue? The series look

Re: [Qemu-devel] [PATCH] usb-host: fix handling of zero-length packets

2012-04-17 Thread Johannes Stezenbach
Hi Gerd, On Mon, Apr 02, 2012 at 01:50:35PM +0200, Johannes Stezenbach wrote: > Zero-length packets are valid but currently cause > qemu to crash: did you have a chance to look at this? Thanks, Johannes > Program terminated with signal 11, Segmentation fault. > #0 0

[Qemu-devel] [PATCH] usb-host: fix handling of zero-length packets

2012-04-02 Thread Johannes Stezenbach
c:1393 1393ret = usb_handle_packet(dev, &q->packet); (gdb) p q->sgl $4 = {sg = 0xf9160410, nsg = 0, nalloc = 5, size = 0} Signed-off-by: Johannes Stezenbach --- Note that I didn't do sufficient testing. I have a proprietary firmware update tool which does one large bulk trans

[Qemu-devel] [PATCH] block/raw-posix: Linux compat-ioctl warning workaround

2011-06-29 Thread Johannes Stezenbach
tat() the ensure the ioctls are only used on block devices. Signed-off-by: Johannes Stezenbach --- discussed in http://lkml.kernel.org/r/20110617090424.ga19...@sig21.net I'll also send a Linux kernel patch but this is needed to fix the warning on old kernels. diff --git a/block/raw-posix.c

[Qemu-devel] [PATCH v2] block/raw-posix: Linux compat-ioctl warning workaround

2011-06-29 Thread Johannes Stezenbach
tat() the ensure the ioctls are only used on block devices. Signed-off-by: Johannes Stezenbach --- discussed in http://lkml.kernel.org/r/20110617090424.ga19...@sig21.net I'll also send a Linux kernel patch but this is needed to fix the warning on old kernels. v2: changes according to review com

Re: [Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-26 Thread Johannes Stezenbach
Hi, just a few thoughts from a qemu novice... On Mon, Jan 24, 2011 at 03:00:38PM -0600, Anthony Liguori wrote: > This series introduces a hard dependency on glib. The initial use is portable > threads but I see this as just the beginning. Glib/Gobject offer many nice > things including: > > -

Re: [Qemu-devel] RFC: ehci -> uhci handoff suggestions

2010-05-26 Thread Johannes Stezenbach
On Wed, May 26, 2010 at 08:00:33AM -0600, David S. Ahern wrote: > On 05/26/2010 07:23 AM, Kevin Wolf wrote: > > Am 26.05.2010 15:06, schrieb David S. Ahern: > >> > >> My understanding is that the port routing happens internally to the host > >> controller based on device speed - section 4.2 (pag 64