Re: [PATCH v0] kvm: unsigned datatype in ioctl wrapper

2021-09-01 Thread Johannes S
On Mon, Aug 30, 2021 at 10:15 PM Peter Maydell wrote: > I think I would vote for following the type used by the ioctl() > function as declared in the headers for both Linux and the BSDs, > and using 'unsigned long'. > (We should change KVMState::irq_set_ioctl too, to match.) I would agree to 'uns

Re: [PATCH v0] kvm: unsigned datatype in ioctl wrapper

2021-08-30 Thread Johannes S
On Sun, Aug 29, 2021 at 11:10 PM Peter Maydell wrote: > It would be more helpful to readers to state the reason directly > in the commit message, rather than requiring them to go and look > up a comment in some other file. Thanks for the tip, that makes sense. I will follow it next time. > > Of