Re: [Qemu-devel] [PATCH] tcg: Fix tci build

2017-09-11 Thread Jincheng Miao
Good to know, and thanks for your review and remind. Regards, Jincheng Miao On Tue, Sep 12, 2017 at 1:29 AM, Alistair Francis wrote: > On Mon, Sep 11, 2017 at 5:17 PM, wrote: >> From: Jincheng Miao >> >> The previous commit 659ef5cbb8 enable LDST_LABELS in tci target, &g

[Qemu-devel] [PATCH] tcg: Fix tci build

2017-09-11 Thread jincheng . miao
From: Jincheng Miao The previous commit 659ef5cbb8 enable LDST_LABELS in tci target, but which causes tci build error like: tcg/tcg.c:116:13: error: ‘tcg_out_ldst_finalize’ used but never defined [-Werror] static bool tcg_out_ldst_finalize(TCGContext *s); ^ cc1: all warnings being

[Qemu-devel] [PATCH] linux-user: Fix syscall instruction usermode emulation on X86_64

2014-08-07 Thread Jincheng Miao
it is tragic. User mode syscall insn emulation is not used MSR, so the action should be same to INT 0x80. INT 0x80 will update EIP in do_interrupt(), ditto for syscall() for consistency. Signed-off-by: Jincheng Miao --- linux-user/main.c|1 - target-i386/seg_helper.c |4 ++-- 2 fi

Re: [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep

2014-07-25 Thread Jincheng Miao
On 07/25/2014 03:45 PM, Peter Maydell wrote: On 25 July 2014 08:41, Richard Henderson wrote: On 07/24/2014 09:37 PM, Peter Maydell wrote: Huh? We already don't emit goto_tb if single-stepping, surely? (Well, I guess some of the backends might well be broken, but in that case they probably don

[Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep

2014-07-24 Thread Jincheng Miao
ked is executed siliently. Therefore, this patch adds singlestep check before tb_add_jump(). Signed-off-by: Jincheng Miao --- cpu-exec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 38e5f02..64b7289 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @

[Qemu-devel] [PATCH] usb: initialize libusb_device to avoid crash

2014-06-19 Thread Jincheng Miao
=0x7fbbbd3c5670) at hw/usb/host-libusb.c:912 #5 0x7fbbb6cc123b in usb_device_init (dev=0x7fbbbd3c5670) at hw/usb/bus.c:106 ... So initialize libusb_device at the begin time. Signed-off-by: Jincheng Miao --- hw/usb/host-libusb.c |4 ++-- 1 files changed, 2 insertions(+), 2