Re: git format.from (was: 9p: Fix file ID collisions)

2019-09-24 Thread Jeff King
On Tue, Sep 24, 2019 at 11:03:38AM +0200, Christian Schoenebeck wrote: > > Yes, the resulting mail would be correct, in the sense that it could be > > applied just fine by git-am. But I think it would be uglier. IOW, I > > consider the presence of the in-body From to be a clue that something > > i

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-23 Thread Jeff King
On Mon, Sep 23, 2019 at 01:19:18PM +0200, Christian Schoenebeck wrote: > > if (cmit_fmt_is_mail(pp->fmt)) { > > - if (pp->from_ident && ident_cmp(pp->from_ident, &ident)) { > > + if (pp->always_use_in_body_from || > > + (pp->from_ident && ident_cmp(pp->from_id

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-09 Thread Jeff King
On Mon, Sep 09, 2019 at 09:05:45AM -0500, Eric Blake wrote: > > But as you can already read from the manual, the overall behaviour of git > > regarding a separate "From:" line in the email body was intended solely for > > the use case sender != author. So in practice (at least in my git version)

Re: [Qemu-devel] [PATCH] send-email: ask confirmation if given encoding name is very short

2015-02-18 Thread Jeff King
On Mon, Feb 16, 2015 at 02:34:14PM -0800, Junio C Hamano wrote: > Sometimes people respond "y" (or "yes") when asked > this question: > > Which 8bit encoding should I declare [UTF-8]? > > We already have a mechanism to avoid accepting a mistyped e-mail > address (we ask to confirm when the g

Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support

2015-02-06 Thread Jeff King
On Thu, Feb 05, 2015 at 12:17:15PM -0800, Junio C Hamano wrote: > > Would "length() > 1" be enough[1]? Or are people really typing "yes" and > > not just "y"? > > > > I cannot imagine a charset name that is smaller than two characters. It > > may be that there are none smaller than 4, and we could

Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support

2015-02-05 Thread Jeff King
On Thu, Feb 05, 2015 at 11:29:07AM -0800, Junio C Hamano wrote: > Eric Blake writes: > > > On 02/05/2015 04:49 AM, Stefan Hajnoczi wrote: > >> On Wed, Jan 14, 2015 at 03:27:23PM +0800, Zhu Guihua wrote: > >>> This series is based on the previous patchset from Chen Fan: > >>> https://lists.nongnu