On Mon, Sep 2, 2019 at 5:25 AM Stefan Hajnoczi wrote:
>
> On Thu, Aug 29, 2019 at 06:13:34PM +0200, Andrea Bolognani wrote:
> > On Thu, 2019-08-29 at 16:48 +0100, Stefan Hajnoczi wrote:
> > > Hi Jeff,
> > > Philippe noticed that the git HTTPS clone URL
> > > https://git.qemu.org/git/libslirp.git r
Changes from v1:
- cc'ed Peter (meant to for v1, forgot)
- added John's 'jobs' branch to his git url
- kept myself as maintainer for vhdx
- moved sheepdog to 'Odd Fixes'
I'm not going to be involved with day-to-day qemu development, so
this ne
rsonal email address as a maintainer, as I can
answer questions or send the occassional bug fix. Leaving it as
'Supported', instead of 'Odd Fixes', because I think the rest of the
block layer maintainers and developers will upkeep it as well, if
needed.
Signed-off-by: Jeff Cody
--
I'll not be involved with day-to-day qemu development, and John
Snow is a block jobs wizard. Have him take over block job
maintainership duties.
Signed-off-by: Jeff Cody
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
On Tue, Sep 25, 2018 at 03:49:36PM +0800, Fam Zheng wrote:
> On Tue, 09/25 09:37, Markus Armbruster wrote:
> > Do we want to have a dedicated VHDX driver submaintainer again? Fam,
> > you're maintaining VMDK, could you cover VHDX as well?
>
> I don't know a lot VHDX internals. Considering my capa
On Tue, Sep 25, 2018 at 12:09:15AM -0400, Jeff Cody wrote:
> I'll not be involved with day-to-day qemu development, and John
> Snow is a block jobs wizard. Have him take over block job
> maintainership duties.
>
> Signed-off-by: Jeff Cody
> ---
> MAINTAINERS | 4
I'll not be involved in day-to-day qemu development. Remove
myself as maintainer from the remainder of the network block drivers
(and vhdx), and revert them to the general block layer maintainership.
Signed-off-by: Jeff Cody
---
MAINTAINERS | 14 --
1 file changed, 14 dele
I'll not be involved with day-to-day qemu development, and John
Snow is a block jobs wizard. Have him take over block job
maintainership duties.
Signed-off-by: Jeff Cody
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
I'm not going to be involved with day-to-day qemu development, so
this necessitates some changes.
Jeff Cody (2):
MAINTAINERS: Replace myself with John Snow for block jobs
MAINTAINERS: Remove myself as block maintainer
MAINTAINERS | 18 ++
1 file changed, 2 insertions(+
On Wed, Sep 12, 2018 at 09:18:49AM -0400, Jeff Cody wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
&
eprecation warning has been added, although care should be taken
when actually deprecating since the impact is not limited to
commandline or qapi usage, but also opening existing images.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
Message-id:
15b332e5432ad069441f7275a46080f465d789a0.1536704
Signed-off-by: Jeff Cody
Message-id:
647f5b5ab7efd8bf567a504c832b1d2d6f719b23.1536704901.git.jc...@redhat.com
Signed-off-by: Jeff Cody
---
qemu-deprecated.texi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index a43fcf4835
file: SSL: no alternative
certificate subject name matches target host name '8.8.8.8'
Could not open backing image to determine size.
Further information about the two settings is available here:
https://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYPEER.html
https://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYH
.
The failure behavior prior to the patch series that has this test, is
qemu-img complaining about mandatory options (e.g. 'pool') not being
provided.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
Message-id:
f830580e339b974a83ed4870d11adcdc17f49a47.1536704901.git.jc...@redhat.com
rl patches
----
Jeff Cody (4):
block/rbd: pull out qemu_rbd_convert_options
block/rbd: Attempt to parse legacy filenames
block/rbd: add iotest for rbd legacy keyvalue filename parsing
block/rbd: add deprecation documentation for filename keyvalue pairs
R
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
Message-id:
5b49a980f2cde6610ab1df41bb0277d00b5db893.1536704901.git.jc...@redhat.com
Signed-off-by: Jeff Cody
---
block/rbd.c
On Sat, Sep 22, 2018 at 08:18:26AM +0200, Markus Armbruster wrote:
> Jeff Cody writes:
>
> > When we converted rbd to get rid of the older key/value-centric
> > encoding format, we broke compatibility with image files with backing
> > file strings encoded in the old forma
On Fri, Sep 14, 2018 at 10:56:22AM +0100, Richard W.M. Jones wrote:
> The sslverify setting is supposed to turn off all TLS certificate
> checks in libcurl. However because of the way we use it, it only
> turns off peer certificate authenticity checks
> (CURLOPT_SSL_VERIFYPEER). This patch makes
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
Message-id:
5b49a980f2cde6610ab1df41bb0277d00b5db893.1536704901.git.jc...@redhat.com
Signed-off-by: Jeff Cody
---
block/rbd.c
.
The failure behavior prior to the patch series that has this test, is
qemu-img complaining about mandatory options (e.g. 'pool') not being
provided.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
Message-id:
f830580e339b974a83ed4870d11adcdc17f49a47.1536704901.git.jc...@redhat.com
Signed-off-by: Jeff Cody
Message-id:
647f5b5ab7efd8bf567a504c832b1d2d6f719b23.1536704901.git.jc...@redhat.com
Signed-off-by: Jeff Cody
---
qemu-deprecated.texi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 1b9c007f12
eprecation warning has been added, although care should be taken
when actually deprecating since the impact is not limited to
commandline or qapi usage, but also opening existing images.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
Message-id:
15b332e5432ad069441f7275a46080f465d789a0.1536704
es for RBD
----
Jeff Cody (4):
block/rbd: pull out qemu_rbd_convert_options
block/rbd: Attempt to parse legacy filenames
block/rbd: add iotest for rbd legacy keyvalue filename parsing
block/rbd: add deprecation documentation for filename keyvalue pairs
b
On Tue, Sep 11, 2018 at 06:32:29PM -0400, Jeff Cody wrote:
> Changes from v3:
>
>
> Patch 4: Typo fixed [Eric]
> Added examples [Eric]
>
> Changes from v2:
> =
>
> Patch 4: New, document deprecation. [Eric]
> Patch 3,2:
On Wed, Sep 12, 2018 at 08:42:15AM -0400, Jeff Cody wrote:
> On Wed, Sep 12, 2018 at 12:38:56PM +0200, Kevin Wolf wrote:
> > Am 11.09.2018 um 20:37 hat Jeff Cody geschrieben:
> > > On Tue, Sep 11, 2018 at 02:22:31PM -0400, John Snow wrote:
> > > > Once we load
On Wed, Sep 12, 2018 at 12:38:56PM +0200, Kevin Wolf wrote:
> Am 11.09.2018 um 20:37 hat Jeff Cody geschrieben:
> > On Tue, Sep 11, 2018 at 02:22:31PM -0400, John Snow wrote:
> > > Once we load the image, will the header get rewritten into a compliant
> > > format?
>
Signed-off-by: Jeff Cody
---
qemu-deprecated.texi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 1b9c007f12..8d285b281e 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -190,6 +190,21 @@ used instead.
In
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
---
block/rbd.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a
eprecation warning has been added, although care should be taken
when actually deprecating since the impact is not limited to
commandline or qapi usage, but also opening existing images.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
block/
}':
Parameter 'pool' is missing
unable to get monitor info from DNS SRV with service name: ceph-mon
no monitors specified to connect to.
qemu-img: Could not open
'json:{'file.driver':'rbd','file.pool':'rbd','file.image':&#
.
The failure behavior prior to the patch series that has this test, is
qemu-img complaining about mandatory options (e.g. 'pool') not being
provided.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/231 | 62 ++
tests/qe
On Tue, Sep 11, 2018 at 04:56:36PM -0500, Eric Blake wrote:
> [MAINTAINERS says libvir-list should have been cc'd; not sure why that
> didn't happen]
>
Thanks
> On 9/11/18 4:34 PM, Jeff Cody wrote:
> >Signed-off-by: Jeff Cody
>
> In the sub
eprecation warning has been added, although care should be taken
when actually deprecating since the impact is not limited to
commandline or qapi usage, but also opening existing images.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
block/
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
---
block/rbd.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a
V with service name: ceph-mon
no monitors specified to connect to.
qemu-img: Could not open
'json:{'file.driver':'rbd','file.pool':'rbd','file.image':'bogus','file.conf':'BOGUS_CONF'}':
error connecting: No such
.
The failure behavior prior to the patch series that has this test, is
qemu-img complaining about mandatory options (e.g. 'pool') not being
provided.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/231 | 62 ++
tests/qe
Signed-off-by: Jeff Cody
---
qemu-deprecated.texi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 1b9c007f12..4df8ac442d 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -190,6 +190,13 @@ used instead.
In order to
On Tue, Sep 11, 2018 at 04:05:45PM -0500, Eric Blake wrote:
> On 9/11/18 3:43 PM, Jeff Cody wrote:
> >When we converted rbd to get rid of the older key/value-centric
> >encoding format, we broke compatibility with image files with backing
> >file strings encoded in the ol
#x27;rbd','file.pool':'rbd','file.image':'bogus','file.conf':'BOGUS_CONF'}':
error connecting: No such file or directory
Failures: 231
Failed 1 of 1 tests
Jeff Cody (3):
block/rbd: pull out qemu_rbd_convert_options
b
.
The failure behavior prior to the patch series that has this test, is
qemu-img complaining about mandatory options (e.g. 'pool') not being
provided.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/231 | 62 ++
tests/qemu-iotests/23
eprecation warning has been added, although care should be taken
when actually deprecating since the impact is not limited to
commandline or qapi usage, but also opening existing images.
Signed-off-by: Jeff Cody
---
block/rbd.c | 53 +++--
1 file c
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
---
block/rbd.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a
On Tue, Sep 11, 2018 at 02:22:31PM -0400, John Snow wrote:
>
>
> On 09/11/2018 01:15 AM, Jeff Cody wrote:
> > When we converted rbd to get rid of the older key/value-centric
> > encoding format, we broke compatibility with image files with backing
> > file string
On Tue, Sep 11, 2018 at 01:03:44PM -0500, Eric Blake wrote:
> On 9/11/18 12:15 AM, Jeff Cody wrote:
> >When we converted rbd to get rid of the older key/value-centric
> >encoding format, we broke compatibility with image files with backing
> >file strings encoded in the ol
On Tue, Sep 11, 2018 at 01:15:49AM -0400, Jeff Cody wrote:
> When we converted rbd to get rid of the older key/value-centric
> encoding format, we broke compatibility with image files with backing
> file strings encoded in the old format.
>
> This leaves a bit of an ugly conundr
This series enables filename parsing on open, on the old key/value pair.
Recent changes to new option formats for rbd broke some images. See
Patch 2 for more details.
Jeff Cody (2):
block/rbd: pull out qemu_rbd_convert_options
block/rbd: Attempt to parse legacy filenames
block/rbd.c | 66
me options supplied the new way, and some the old way, we may not
catch all the old options if they are not required options (since it
won't cause the initial failure).
Signed-off-by: Jeff Cody
---
block/rbd.c | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
dif
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Signed-off-by: Jeff Cody
---
block/rbd.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index ca8e5bbace
On Thu, Sep 06, 2018 at 09:02:22AM -0400, John Snow wrote:
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> blockdev.c | 14 ++
> qapi/block-core.json | 30 --
> 2 files changed, 42 insertio
On Thu, Sep 06, 2018 at 09:02:24AM -0400, John Snow wrote:
> Fix documentation to match the other jobs amended for 3.1.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> qapi/block-core.json | 18 ++
> 1 file changed
On Thu, Sep 06, 2018 at 09:02:23AM -0400, John Snow wrote:
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> blockdev.c | 9 +
> hmp.c| 5 +++--
> qapi/block-core.json | 16 +++-
> 3 files c
d need to be audited at that time.
>
> Signed-off-by: John Snow
Reviewed-by: Jeff Cody
> ---
> blockdev.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 0cf8febe6c..d4b42403df 100644
> --- a/blo
On Thu, Sep 06, 2018 at 09:02:21AM -0400, John Snow wrote:
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> blockdev.c | 8
> qapi/block-core.json | 16 +++-
> 2 files changed, 23 insertions(+), 1 deletion(-)
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> tests/test-blockjob.c | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/tests/test-blockjob.c b/tests/test-blockjob.c
> index 8e8b68041
_bh_schedule_oneshot.
>
> Move these three functions down into job.c to eliminate a
> forward reference.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> include/qemu/job.h | 11
> job.c | 77
> +
On Thu, Sep 06, 2018 at 09:02:19AM -0400, John Snow wrote:
> The exit callback in this test actually only performs cleanup.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> tests/test-blockjob-txn.c | 4 ++--
> 1 file changed, 2 inser
On Thu, Sep 06, 2018 at 09:02:17AM -0400, John Snow wrote:
> These tests don't actually test blockjobs anymore, they test
> generic Job lifetimes. Change the types accordingly.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
>
On Thu, Sep 06, 2018 at 09:02:16AM -0400, John Snow wrote:
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> block/stream.c | 23 +++
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/block/stre
== 0);
Not something to hold the series up, but in case a v6 is called for due to
other changes: I think it may be worth a comment in mirror_exit_common()
that if abort is true, and we don't return success, QEMU will hit an assert.
Mainly to prevent someone from includin
On Thu, Sep 06, 2018 at 09:02:14AM -0400, John Snow wrote:
> In cases where we abort the block/mirror job, there's no point in
> installing the new backing chain before we finish aborting.
>
> Signed-off-by: John Snow
Reviewed-by: Jeff Cody
> ---
> block/mirror.c | 2
gt; complete -> abort -> clean
>
> During refactor, a potential problem with bdrv_drop_intermediate
> was identified, The patched behavior is no worse than the pre-patch
> behavior, so leave a FIXME for now to be fixed in a future patch.
>
> Signed-off-by: John S
On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote:
> Use the component callbacks; prepare, abort, and clean.
>
> NB: prepare is only called when the job has not yet failed;
> and abort can be called after prepare.
>
> complete -> prepare -> abort -> clean
> complete -> abort -> clean
>
>
speed, granularity, buf_size, backing_mode,
> on_source_error, on_target_error, unmap, NULL, NULL,
> &mirror_job_driver, is_none_mode, base, false,
This is another one of those comments that do not pertain directly to this
patch, so it
On Fri, Aug 31, 2018 at 06:28:55PM -0400, John Snow wrote:
> Add support for taking and passing forward job creaton flags.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
(with the misspelling that Eric pointed out fixed):
Reviewed-by: Jeff Cody
> ---
> block/strea
On Fri, Aug 31, 2018 at 06:28:53PM -0400, John Snow wrote:
> Add support for taking and passing forward job creation flags.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> block/commit.c| 5 +++--
> blockdev
ext in which we call .exit, this is safe to
> defer the possible flushing of any nodes to the job_finalize_single
> cleanup stage.
>
> Signed-off-by: John Snow
Reviewed-by: Jeff Cody
> ---
> block/mirror.c | 29 +++--
> 1 file changed, 11 insertions(+
hd() to fail. */
> block_job_remove_all_bdrv(bjob);
>
> -job_completed(job, ret);
> -g_free(data);
> -
Not having to allocate, track, and free this cumbersome return value for
each of these job specific completions now is pretty nice.
Reviewed-by: Jeff Cody
> /*
rom outside
> of the aio_context, which should allow for job cleanup code to run with
> only one lock, which makes cleanup callbacks less tricky to write.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> include/qemu/job.h | 11 +++
ob_completed
> function.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> block/backup.c| 7 ---
> block/commit.c| 7 ---
> block/create.c| 8 +---
> block/mirror.c
Signed-off-by: Jeff Cody
Reviewed-by: John Snow
Message-id:
df317f617fbe5affcf699cb8560e7b0c2e028a64.1534868459.git.jc...@redhat.com
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/229 | 95 ++
tests/qemu-iotests/229.out | 23 +
tests/qemu
is set to true.
Unfortunately, right before calling this function, it has explicitly
been set to false.
The fix is pretty simple: set job->user_paused to false only after the
job user_resume() function has been called.
Reviewed-by: John Snow
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
ob patches
----
Jeff Cody (2):
block: for jobs, do not clear user_paused until after the resume
block: iotest to catch abort on forced blockjob cancel
job.c | 2 +-
tests/qemu-iotests/229 | 95 ++
tests/qemu-iotests/22
On Tue, Aug 21, 2018 at 12:26:18PM -0400, Jeff Cody wrote:
> v3 changes:
> Rebased to master
> Patch 2: Wait for pause after mirror instead of error, to gobble the
> right message (Thanks John)
> Patch 2: Replace a hard-coded 'qcow2' with '$
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/229 | 95 ++
tests/qemu-iotests/229.out | 23 +
tests/qemu-iotests/group | 1 +
3 files changed, 119 insertions(+)
create mode 100755 tests/qemu-iotests/229
create mode 100644 tests/qemu-iotests
quot;type": "mirror"}}
-*** done
+QEMU_PROG: blockjob.c:460: block_job_iostatus_reset: Assertion
`job->job.user_paused && job->job.pause_count > 0' failed.
+Wrong response matching Assertion on handle 0
Failures: 229
Failed 1 of 1 tests
git-backport-diff,
is set to true.
Unfortunately, right before calling this function, it has explicitly
been set to false.
The fix is pretty simple: set job->user_paused to false only after the
job user_resume() function has been called.
Reviewed-by: John Snow
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
--
On Mon, Aug 20, 2018 at 05:26:23PM -0400, John Snow wrote:
>
>
> On 08/16/2018 02:46 PM, Jeff Cody wrote:
> > Signed-off-by: Jeff Cody
> > ---
> > tests/qemu-iotests/229 | 95 ++
> > tests/qemu-iotests/229.out | 23 ++
is set to true.
Unfortunately, right before calling this function, it has explicitly
been set to false.
The fix is pretty simple: set job->user_paused to false only after the
job user_resume() function has been called.
Reviewed-by: John Snow
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
--
2097152, "offset":
1048576, "speed": 0, "type": "mirror"}}
-*** done
+QEMU_PROG: blockjob.c:460: block_job_iostatus_reset: Assertion
`job->job.user_paused && job->job.pause_count > 0' failed.
+Wrong response matching Assertion on hand
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/229 | 95 ++
tests/qemu-iotests/229.out | 23 +
tests/qemu-iotests/group | 1 +
3 files changed, 119 insertions(+)
create mode 100755 tests/qemu-iotests/229
create mode 100644 tests/qemu-iotests
On Wed, Aug 15, 2018 at 05:23:43PM -0400, John Snow wrote:
>
>
> On 08/15/2018 11:59 AM, Jeff Cody wrote:
> > The function job_cancel_async() will always cause an assert for blockjob
> > user resume. We set job->user_paused to false, and then call
> > job->drive
On Wed, Aug 15, 2018 at 04:25:16PM -0500, Eric Blake wrote:
> On 08/15/2018 10:59 AM, Jeff Cody wrote:
> >The function job_cancel_async() will always cause an assert for blockjob
> >user resume. We set job->user_paused to false, and then call
> >job->driver->
is set to true.
Unfortunately, right before calling this function, it has explicitly
been set to false.
The fix is pretty simple: set job->user_paused to false only after the
job user_resume() function has been called.
Signed-off-by: Jeff Cody
---
job.c | 2 +-
1 file changed, 1 insertion(+)
On Wed, Aug 15, 2018 at 10:12:12AM +0200, Markus Armbruster wrote:
> Max Reitz writes:
>
> > On 2018-07-28 06:32, Jeff Cody wrote:
> >> On Wed, Jul 25, 2018 at 05:01:44PM +0100, Daniel P. Berrangé wrote:
> >>> On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake
On Mon, Aug 13, 2018 at 04:19:52AM +0200, Max Reitz wrote:
> Signed-off-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> block/mirror.c | 54 +-
> 1 file changed, 36 insertions(+), 18 deletions(-)
>
> diff --git a/block/mirror.
On Mon, Aug 13, 2018 at 04:19:50AM +0200, Max Reitz wrote:
> Currently, we never test whether we can read from the source while
> mirroring (that means, whether we can read from the mirror BDS). Add
> such a test to 156 because it fits well.
>
> Signed-off-by: Max Reitz
Reviewe
; This patch makes it and all of its callers coroutine_fns.
>
It'd be nice if someday coroutine_fn was actually functional during
compile. We can dream :)
> Signed-off-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> block/mirror.c | 30 --
>
_co_entry(void *opaque)
> assert(job && job->driver && job->driver->start);
> job_pause_point(job);
> job->driver->start(job);
One nit-picky observation here, that is unrelated to this patch: reading
through, it may not be so o
On Tue, Aug 07, 2018 at 12:33:34AM -0400, John Snow wrote:
> Change the manual deferment to stream_complete into the implicit
> callback to job_exit.
>
> Signed-off-by: John Snow
Reviewed-by: Jeff Cody
> ---
> block/stream.c | 23 ---
> 1 file changed
On Tue, Aug 07, 2018 at 12:33:33AM -0400, John Snow wrote:
> Change the manual deferment to mirror_exit into the implicit
> callback to job_exit and the mirror_exit callback.
>
> Signed-off-by: John Snow
Reviewed-by: Jeff Cody
> ---
> block/mirror.c | 27 +++
filter driver from the backing chain. Do this as the final step so
> that
> * the 'consistent read' permission can be granted. */
> @@ -132,12 +124,12 @@ static void commit_complete(Job *job, void *opaque)
>
> bdrv_unref(commit_top_bs);
>
On Tue, Jul 31, 2018 at 11:18:02AM +0200, Niels de Vos wrote:
> On Mon, Jul 30, 2018 at 03:27:29PM -0400, Jeff Cody wrote:
> > On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote:
> > > On 07/28/2018 02:50 AM, Niels de Vos wrote:
> > > >>
> > >
On Sat, Jul 28, 2018 at 09:50:05AM +0200, Niels de Vos wrote:
> On Sat, Jul 28, 2018 at 12:18:39AM -0400, Jeff Cody wrote:
> > On Fri, Jul 27, 2018 at 08:24:05AM -0500, Eric Blake wrote:
> > > On 07/27/2018 03:19 AM, Niels de Vos wrote:
> > > >From: Prasanna Kum
On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote:
> On 07/28/2018 02:50 AM, Niels de Vos wrote:
> >>
> >>Part of me wishes that libgfapi had just created a new function
> >>'glfs_ftruncate2', so that existing users don't need to handle the api
> >>change. But I guess in the grand scheme,
On Wed, Jul 25, 2018 at 05:01:44PM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:
> > On 07/25/2018 10:10 AM, Markus Armbruster wrote:
> > > qemu_rbd_parse_filename() builds a keypairs QList, converts it to JSON,
> > > and
> > > stores the resulting
On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:
> On 07/25/2018 10:10 AM, Markus Armbruster wrote:
> >qemu_rbd_parse_filename() builds a keypairs QList, converts it to JSON, and
> >stores the resulting QString in a QDict.
> >
> >qemu_rbd_co_create_opts() and qemu_rbd_open() get the QStr
On Fri, Jul 27, 2018 at 08:24:05AM -0500, Eric Blake wrote:
> On 07/27/2018 03:19 AM, Niels de Vos wrote:
> >From: Prasanna Kumar Kalever
> >
> >New versions of Glusters libgfapi.so have an updated glfs_ftruncate()
> >function that returns additional 'struct stat' structures to enable
> >advanced
f,
> size_t size,
> /* Validates the checksum of the buffer, with an in-place CRC.
> *
> * Zero is substituted during crc calculation for the original crc field,
> - * and the crc field is restored afterwards. But the buffer will be modifed
> + * and the crc field is restored afterwards. But the buffer will be modified
Oops, that one was mine.
> * during the calculation, so this may not be not suitable for multi-threaded
> * use.
> *
> --
> 2.11.0
>
Reviewed-by: Jeff Cody
om a local check if one request fails because of, for example, the
offset is beyond EOF, but another may well be accepted by the protocol
layer. This will be implemented separately.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
Message-id: 20180703023758.14422-4-f...@redhat.com
Signed-of
ULL src.
Signed-off-by: Fam Zheng
Message-id: 20180703023758.14422-2-f...@redhat.com
Reviewed-by: Jeff Cody
Signed-off-by: Jeff Cody
---
block/io.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/block/io.c b/block/io.c
index 7035b78
1 - 100 of 2395 matches
Mail list logo
