Re: [PATCH RFC v3 12/13] net: implement tunnel probing

2025-07-21 Thread Jason Wang
On Fri, Jul 18, 2025 at 4:54 PM Paolo Abeni wrote: > > Tap devices support GSO over UDP tunnel offload. Probe for such > feature in a similar manner to other offloads. > > GSO over UDP tunnel needs to be enabled in addition to a "plain" > offload (TSO or USO). > > No need to check separately for t

Re: [PATCH RFC v3 07/13] vhost: add support for negotiating extended features

2025-07-21 Thread Jason Wang
On Fri, Jul 18, 2025 at 4:53 PM Paolo Abeni wrote: > > Similar to virtio infra, vhost core maintains the features status > in the full extended format and allows the devices to implement > extended version of the getter/setter. > > Note that 'protocol_features' are not extended: they are only > us

Re: [PATCH RFC v3 06/13] virtio-pci: implement support for extended features

2025-07-21 Thread Jason Wang
On Fri, Jul 18, 2025 at 4:53 PM Paolo Abeni wrote: > > Extend the features configuration space to 128 bits, and allow the > common read/write operation to access all of it. > > On migration, save the 128 bit version of the features only if the > upper bits are non zero. Relay reset to clear all th

[PULL 01/12] net/tap: drop too small packets

2025-07-20 Thread Jason Wang
f !s->using_vnet_hdr, it doesn't make sense. Tested-by: Lei Yang Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Jason Wang --- net/tap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/tap.c b/net/tap.c index 23536c09b4..2a85936019 100644 --- a/net/tap.c +

[PULL 10/12] net/passt: Check return value of g_remove() in net_passt_cleanup() (CID 1612369)

2025-07-20 Thread Jason Wang
From: Laurent Vivier If g_remove() fails, use warn_report() to log an error. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Signed-off-by: Jason Wang --- net/passt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/passt.c b/net/passt.c index ef59d0682b

[PULL 07/12] net/passt: Remove unused "err" from passt_vhost_user_event() (CID 1612375)

2025-07-20 Thread Jason Wang
ent Vivier Reviewed-by: Peter Maydell Signed-off-by: Jason Wang --- net/passt.c | 5 - 1 file changed, 5 deletions(-) diff --git a/net/passt.c b/net/passt.c index 6f616ba3c2..9cd5b3e6f2 100644 --- a/net/passt.c +++ b/net/passt.c @@ -397,7 +397,6 @@ err: static void passt_vhost_user_event(vo

[PULL 06/12] hw/net/npcm_gmac.c: Drop 'buf' local variable

2025-07-20 Thread Jason Wang
s in passing a place where we set buf = tx_send_buffer but never used that value because we always updated buf to something else later before using it. Coverity: CID 1534027 Signed-off-by: Peter Maydell Signed-off-by: Jason Wang --- hw/net/npcm_gmac.c | 12 1 file changed, 4 in

[PULL 08/12] net/vhost-user: Remove unused "err" from net_vhost_user_event() (CID 1612372)

2025-07-20 Thread Jason Wang
ent Vivier Reviewed-by: Peter Maydell Signed-off-by: Jason Wang --- net/vhost-user.c | 5 - 1 file changed, 5 deletions(-) diff --git a/net/vhost-user.c b/net/vhost-user.c index 1c3b8b36f3..cec83e925f 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -329,7 +329,6 @@ static void net_vhost_

[PULL 09/12] net/passt: Remove dead code in passt_vhost_user_start error path (CID 1612371)

2025-07-20 Thread Jason Wang
es the cleanup block dead code, as reported by Coverity (CID 1612371). Refactor the error handling to occur inline, removing the goto and the unreachable cleanup block. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Signed-off-by: Jason Wang --- net/passt.c | 10 ++ 1 fi

[PULL 11/12] net/passt: Initialize "error" variable in net_passt_send() (CID 1612368)

2025-07-20 Thread Jason Wang
From: Laurent Vivier This was flagged by Coverity as a memory illegal access. Initialize the pointer to NULL at declaration. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Signed-off-by: Jason Wang --- net/passt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL 12/12] net/vhost-user: Remove unused "err" from chr_closed_bh() (CID 1612365)

2025-07-20 Thread Jason Wang
eviewed-by: Peter Maydell Signed-off-by: Jason Wang --- net/vhost-user.c | 4 1 file changed, 4 deletions(-) diff --git a/net/vhost-user.c b/net/vhost-user.c index cec83e925f..8b96157145 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -298,7 +298,6 @@ static void chr_closed_bh(vo

[PULL 04/12] hw/net/npcm_gmac.c: Unify length and prev_buf_size variables

2025-07-20 Thread Jason Wang
64K when sending it; this commit preserves that behaviour by using a local variable when doing the packet send. Signed-off-by: Peter Maydell Signed-off-by: Jason Wang --- hw/net/npcm_gmac.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/net/npcm_gmac.c b/hw/net

[PULL 03/12] hw/net/npcm_gmac.c: Send the right data for second packet in a row

2025-07-20 Thread Jason Wang
the beginning of the buffer. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Maydell Signed-off-by: Jason Wang --- hw/net/npcm_gmac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c index a434112580..921327dd8c 100644 --- a/hw/net/npcm_gmac.c +++

[PULL 02/12] tap: fix net_init_tap() return code

2025-07-20 Thread Jason Wang
ing fails and returns false, ret=0 is returned, and net_client_init1 will use a broken interface. Fix it to be future proof. Signed-off-by: Steve Sistare Signed-off-by: Jason Wang --- net/tap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/tap.c b/net/tap.c in

[PULL 05/12] hw/net/npcm_gmac.c: Correct test for when to reallocate packet buffer

2025-07-20 Thread Jason Wang
is always 8 bytes, and the condition will almost always be true, so we will reallocate the buffer more often than we need to. Correct the condition to test against tx_buffer_size, which is where we track how big the allocated buffer is. Signed-off-by: Peter Maydell Signed-off-by: Jason

[PULL 00/12] Net patches

2025-07-20 Thread Jason Wang
The following changes since commit e82989544e38062beeeaad88c175afbeed0400f8: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2025-07-18 14:10:02 -0400) are available in the Git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fe

Re: [RFC PATCH v3 14/15] Read and validate host SMMUv3 feature bits

2025-07-16 Thread Jason Gunthorpe
ything at VM startup time. Jason

Re: [RFC PATCH v3 14/15] Read and validate host SMMUv3 feature bits

2025-07-16 Thread Jason Gunthorpe
On Wed, Jul 16, 2025 at 10:35:25AM -0700, Nicolin Chen wrote: > On Wed, Jul 16, 2025 at 08:51:23AM -0300, Jason Gunthorpe wrote: > > On Tue, Jul 15, 2025 at 07:57:57PM -0700, Nicolin Chen wrote: > > > > +val = FIELD_EX32(s_accel->info.idr[5], IDR5, GRAN4K); > > &

Re: [RFC PATCH v3 14/15] Read and validate host SMMUv3 feature bits

2025-07-16 Thread Jason Gunthorpe
hese fields to > the HW values, The qemu model should be fully independent of the underlying HW, it should not override from HW. It should check if the underlying supports the model and fail if it doesn't. Jason

Re: [PATCH] net/tap: drop too small packets

2025-07-15 Thread Jason Wang
On Tue, Jul 15, 2025 at 10:59 PM Vladimir Sementsov-Ogievskiy wrote: > > On 14.07.25 05:12, Jason Wang wrote: > > On Wed, Jul 9, 2025 at 10:43 PM Vladimir Sementsov-Ogievskiy > > wrote: > >> > >> On 07.07.25 06:49, Jason Wang wrote: > >>>

Re: [PULL 00/13] Net patches

2025-07-15 Thread Jason Wang
Hi Stefan: On Wed, Jul 16, 2025 at 3:55 AM Stefan Hajnoczi wrote: > > Applied, thanks. > > Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any > user-visible changes. I sent a V2 of the PULL: https://mail.gnu.org/archive/html/qemu-devel/2025-07/msg03794.html That inclu

[PULL V2 09/16] net: Add save_acked_features callback to vhost_net

2025-07-14 Thread Jason Wang
the vhost-user implementation. This cleanup allows for the complete removal of the net/vhost-user.h header file. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/vhost_net-stub.c | 1 - hw/net/vhost_net.c| 10 +- include/hw/virtio/vhost.h | 2 ++ include/net

[PULL V2 11/16] net: Add is_vhost_user flag to vhost_net struct

2025-07-14 Thread Jason Wang
nc->info->type' with the new flag. It improves readability and encapsulates the backend type information directly within the vhost_net instance. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/vhost_net.c| 3 ++- hw/net/virtio-net.c | 8 ++--

[PULL V2 06/16] net: Add get_vhost_net callback to NetClientInfo

2025-07-14 Thread Jason Wang
ff-by: Jason Wang --- hw/net/vhost_net.c | 31 --- include/net/net.h| 2 ++ include/net/tap.h| 3 --- include/net/vhost-user.h | 1 - include/net/vhost-vdpa.h | 2 -- net/tap-win32.c | 5 - net/tap.c

[PULL V2 10/16] net: Allow network backends to advertise max TX queue size

2025-07-14 Thread Jason Wang
-by: Jason Wang --- hw/net/vhost_net.c| 1 + hw/net/virtio-net.c | 24 include/hw/virtio/vhost.h | 1 + include/net/vhost_net.h | 1 + net/tap.c | 1 + net/vhost-user.c | 1 + net/vhost-vdpa.c | 1 + 7 files changed

[PULL V2 14/16] net/af-xdp: Remove XDP program cleanup logic

2025-07-14 Thread Jason Wang
is always skipped since the non-zero test for s->xdp_flags in af_xdp_cleanup() fails. Fixes: cb039ef3d9e3 ("net: add initial support for AF_XDP network backend") Suggested-by: Ilya Maximets Signed-off-by: Daniel Borkmann Reviewed-by: Ilya Maximets Cc: Ilya Maximets Cc: Jason

[PULL V2 15/16] net/af-xdp: Fix up cleanup path upon failure in queue creation

2025-07-14 Thread Jason Wang
into the above format, the af_xdp_cleanup() handler is called as expected. Note the error_propagate() handles a NULL err internally. Fixes: cb039ef3d9e3 ("net: add initial support for AF_XDP network backend") Reviewed-by: Ilya Maximets Signed-off-by: Daniel Borkmann Cc: Ilya Maximets

[PULL V2 03/16] net: Refactor stream logic for reuse in '-net passt'

2025-07-14 Thread Jason Wang
ers within the NetStreamData struct. This allows callers to provide their own specific implementations while reusing the common connection and data transfer logic. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- net/meson.build | 3 +- net/stream.c

[PULL V2 04/16] net: Define net_client_set_link()

2025-07-14 Thread Jason Wang
client search and then calls the new function. The vhost-user implementation is updated to use net_client_set_link() directly, thereby eliminating the unnecessary client lookup. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- include/net/net.h | 1 + net/net.c | 32

[PULL V2 08/16] net: Add get_acked_features callback to VhostNetOptions

2025-07-14 Thread Jason Wang
type check and the direct dependency. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/vhost_net.c | 6 ++ include/net/vhost-user.h | 2 -- include/net/vhost_net.h | 3 +++ net/tap.c| 1 + net/vhost-user.c | 4 +++- net/vhost-vdpa.c | 1

[PULL V2 05/16] vhost_net: Rename vhost_set_vring_enable() for clarity

2025-07-14 Thread Jason Wang
found in cryptodev-vhost.c, it has been renamed to vhost_net_set_vring_enable(). This clarifies that the function belongs to the vhost_net module. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/vhost_net-stub.c | 2 +- hw/net/vhost_net.c | 4 ++-- hw/net/virtio-net.c

[PULL V2 16/16] net/af-xdp: Support pinned map path for AF_XDP sockets

2025-07-14 Thread Jason Wang
27;t make any assumptions and neither go down the path of probing all possible options in which way the user installed the XDP program. Reviewed-by: Ilya Maximets Signed-off-by: Daniel Borkmann Cc: Ilya Maximets Cc: Jason Wang Cc: Anton Protopopov Signed-off-by: Jason Wang --- net/af-xdp.c

[PULL V2 13/16] net/passt: Implement vhost-user backend support

2025-07-14 Thread Jason Wang
ction. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- docs/system/devices/net.rst | 12 +- net/passt.c | 346 qapi/net.json | 3 + qemu-options.hx | 10 +- 4 files changed, 369 insertions(+), 2 deletions(-)

[PULL V2 12/16] net: Add passt network backend

2025-07-14 Thread Jason Wang
QEMU exits. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- docs/system/devices/net.rst | 40 +++- hmp-commands.hx | 3 + meson.build | 6 + meson_options.txt | 2 + net/clients.h | 4 + net/hub.c

[PULL V2 00/16] Net patches

2025-07-14 Thread Jason Wang
The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336: Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into staging (2025-07-13 01:46:04 -0400) are available in the Git repository at: https://github.com/jasowang/qemu.git net-pull-request for you to fe

[PULL V2 07/16] net: Consolidate vhost feature bits into vhost_net structure

2025-07-14 Thread Jason Wang
backends (like TAP, vhost-user, and vhost-vdpa). This patch moves the definition of vhost feature bits directly into the vhost_net structure for each relevant network client. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/vhost_net.c| 90

[PULL V2 01/16] net: fix buffer overflow in af_xdp_umem_create()

2025-07-14 Thread Jason Wang
ewed-by: Ilya Maximets Signed-off-by: Anastasia Belova Signed-off-by: Jason Wang --- net/af-xdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/af-xdp.c b/net/af-xdp.c index 01c5fb914e..d022534d76 100644 --- a/net/af-xdp.c +++ b/net/af-xdp.c @@ -323,7 +323,7

[PULL V2 02/16] virtio-net: Add queues for RSS during migration

2025-07-14 Thread Jason Wang
one queue pair when realizing") Tested-by: Lei Yang Cc: qemu-sta...@nongnu.org Signed-off-by: Akihiko Odaki Signed-off-by: Jason Wang --- hw/net/virtio-net.c| 11 --- hw/virtio/virtio.c | 14 +++--- include/hw/virtio/virtio.h | 10 -- 3 files chang

Re: [PULL 00/13] Net patches

2025-07-14 Thread Jason Wang
On Mon, Jul 14, 2025 at 1:34 PM Jason Wang wrote: > > The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336: > > Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into > staging (2025-07-13 01:46:04 -0400) > > are ava

Re: [PATCH] net/vdpa: fix potential fd leak in net_init_vhost_vdpa()

2025-07-14 Thread Jason Wang
dev, const > char *name, > > queue_pairs = vhost_vdpa_get_max_queue_pairs(vdpa_device_fd, features, > &has_cvq, errp); > -if (queue_pairs < 0) { > -qemu_close(vdpa_device_fd); > -return queue_pairs; > +if (queue_pairs <= 0)

[PULL 10/13] net: Allow network backends to advertise max TX queue size

2025-07-13 Thread Jason Wang
-by: Jason Wang --- hw/net/vhost_net.c| 1 + hw/net/virtio-net.c | 24 include/hw/virtio/vhost.h | 1 + include/net/vhost_net.h | 1 + net/tap.c | 1 + net/vhost-user.c | 1 + net/vhost-vdpa.c | 1 + 7 files changed

[PULL 07/13] net: Consolidate vhost feature bits into vhost_net structure

2025-07-13 Thread Jason Wang
backends (like TAP, vhost-user, and vhost-vdpa). This patch moves the definition of vhost feature bits directly into the vhost_net structure for each relevant network client. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/vhost_net.c| 90

[PULL 08/13] net: Add get_acked_features callback to VhostNetOptions

2025-07-13 Thread Jason Wang
type check and the direct dependency. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/vhost_net.c | 6 ++ include/net/vhost-user.h | 2 -- include/net/vhost_net.h | 3 +++ net/tap.c| 1 + net/vhost-user.c | 4 +++- net/vhost-vdpa.c | 1

[PULL 03/13] net: Refactor stream logic for reuse in '-net passt'

2025-07-13 Thread Jason Wang
ers within the NetStreamData struct. This allows callers to provide their own specific implementations while reusing the common connection and data transfer logic. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- net/meson.build | 3 +- net/stream.c

[PULL 12/13] net: Add passt network backend

2025-07-13 Thread Jason Wang
QEMU exits. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- docs/system/devices/net.rst | 40 +++- hmp-commands.hx | 3 + meson.build | 6 + meson_options.txt | 2 + net/clients.h | 4 + net/hub.c

[PULL 11/13] net: Add is_vhost_user flag to vhost_net struct

2025-07-13 Thread Jason Wang
nc->info->type' with the new flag. It improves readability and encapsulates the backend type information directly within the vhost_net instance. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/vhost_net.c| 3 ++- hw/net/virtio-net.c | 8 ++--

[PULL 00/13] Net patches

2025-07-13 Thread Jason Wang
The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336: Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into staging (2025-07-13 01:46:04 -0400) are available in the Git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you

[PULL 09/13] net: Add save_acked_features callback to vhost_net

2025-07-13 Thread Jason Wang
the vhost-user implementation. This cleanup allows for the complete removal of the net/vhost-user.h header file. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/vhost_net-stub.c | 1 - hw/net/vhost_net.c| 10 +- include/hw/virtio/vhost.h | 2 ++ include/net

[PULL 06/13] net: Add get_vhost_net callback to NetClientInfo

2025-07-13 Thread Jason Wang
ff-by: Jason Wang --- hw/net/vhost_net.c | 31 --- include/net/net.h| 2 ++ include/net/tap.h| 3 --- include/net/vhost-user.h | 1 - include/net/vhost-vdpa.h | 2 -- net/tap-win32.c | 5 - net/tap.c

[PULL 13/13] net/passt: Implement vhost-user backend support

2025-07-13 Thread Jason Wang
ction. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- docs/system/devices/net.rst | 12 +- net/passt.c | 346 qapi/net.json | 3 + qemu-options.hx | 10 +- 4 files changed, 369 insertions(+), 2 deletions(-)

[PULL 01/13] net: fix buffer overflow in af_xdp_umem_create()

2025-07-13 Thread Jason Wang
ewed-by: Ilya Maximets Signed-off-by: Anastasia Belova Signed-off-by: Jason Wang --- net/af-xdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/af-xdp.c b/net/af-xdp.c index 01c5fb914e..d022534d76 100644 --- a/net/af-xdp.c +++ b/net/af-xdp.c @@ -323,7 +323,7

[PULL 04/13] net: Define net_client_set_link()

2025-07-13 Thread Jason Wang
client search and then calls the new function. The vhost-user implementation is updated to use net_client_set_link() directly, thereby eliminating the unnecessary client lookup. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- include/net/net.h | 1 + net/net.c | 32

[PULL 02/13] virtio-net: Add queues for RSS during migration

2025-07-13 Thread Jason Wang
one queue pair when realizing") Tested-by: Lei Yang Cc: qemu-sta...@nongnu.org Signed-off-by: Akihiko Odaki Signed-off-by: Jason Wang --- hw/net/virtio-net.c| 11 --- hw/virtio/virtio.c | 14 +++--- include/hw/virtio/virtio.h | 10 -- 3 files chang

[PULL 05/13] vhost_net: Rename vhost_set_vring_enable() for clarity

2025-07-13 Thread Jason Wang
found in cryptodev-vhost.c, it has been renamed to vhost_net_set_vring_enable(). This clarifies that the function belongs to the vhost_net module. Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/vhost_net-stub.c | 2 +- hw/net/vhost_net.c | 4 ++-- hw/net/virtio-net.c

Re: [PATCH] net/tap: drop too small packets

2025-07-13 Thread Jason Wang
On Wed, Jul 9, 2025 at 10:43 PM Vladimir Sementsov-Ogievskiy wrote: > > On 07.07.25 06:49, Jason Wang wrote: > > On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin > > wrote: > >> > >> On 7/3/25 1:55 PM, Vladimir Sementsov-Ogievskiy wrote: > >> > >

Re: [PATCH] net/tap: drop too small packets

2025-07-06 Thread Jason Wang
On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin wrote: > > On 7/3/25 1:55 PM, Vladimir Sementsov-Ogievskiy wrote: > > > Theoretically tap_read_packet() may return size less than > > s->host_vnet_hdr_len, and next, we'll work with negative size > > (in case of !s->using_vnet_hdr). Let's avoid it. >

Re: [PATCH v2 09/10] net: Add passt network backend

2025-06-30 Thread Jason Wang
On Wed, Jun 18, 2025 at 11:58 PM Laurent Vivier wrote: > > This commit introduces support for passt as a new network backend. > passt is an unprivileged, user-mode networking solution that provides > connectivity for virtual machines by launching an external helper process. > > The implementation

Re: [PATCH v2 05/10] net: Consolidate vhost feature bits into NetClientInfo

2025-06-30 Thread Jason Wang
On Wed, Jun 18, 2025 at 11:57 PM Laurent Vivier wrote: > > Previously, the vhost_net_get_feature_bits() function in > hw/net/vhost_net.c used a large switch statement to determine > the appropriate feature bits based on the NetClientDriver type. > > This created unnecessary coupling between the ge

Re: [PATCH v2 03/10] net: Introduce helper to identify vhost-user clients

2025-06-30 Thread Jason Wang
On Wed, Jun 18, 2025 at 11:57 PM Laurent Vivier wrote: > > Currently, several parts of the codebase check if a network client is a > vhost-user backend by directly comparing its type against the > NET_CLIENT_DRIVER_VHOST_USER enum. This creates a tight coupling > between virtio/vhost-net drivers a

Re: [PATCH 0/8] net: Add passt netdev backend

2025-06-23 Thread Jason Wang
On Mon, Jun 23, 2025 at 4:10 PM Laurent Vivier wrote: > > On 23/06/2025 10:03, Jason Wang wrote: > > On Wed, Jun 18, 2025 at 4:39 PM Laurent Vivier wrote: > >> > >> This series introduces support for passt as a new network backend for > >> QEMU. > >

Re: [PATCH] MAINTAINERS: add reviewers for some s390 areas

2025-06-23 Thread Jason J. Herne
On 6/23/25 12:00 PM, Matthew Rosato wrote: To improve review coverage, assign additional people as reviewers for multiple s390 sections. Signed-off-by: Matthew Rosato Acked-by: Jason J. Herne

Re: [PATCH 0/8] net: Add passt netdev backend

2025-06-23 Thread Jason Wang
On Wed, Jun 18, 2025 at 4:39 PM Laurent Vivier wrote: > > This series introduces support for passt as a new network backend for > QEMU. > > passt is a modern, unprivileged, user-mode networking solution that > provides guest connectivity by launching an external helper process. This > series adds

Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-06-18 Thread Jason Gunthorpe
...@intel.com/T/#m4c8fa70742001d4c22b3c297e240a2151d2c617f My feeling is that it is undesirable to have the shadowing code in the VMM at all, as it increases the attack surface/complexity/etc. There should be a way to fully inhibit legacy mode, and if that means old kernels don't work that's just how it is. Jason

Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-06-17 Thread Jason Gunthorpe
he same issues, BTW, arguably even worse as I didn't notice any way to specify if the v1 page table is supported :\ Jason

Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-06-17 Thread Jason Gunthorpe
e legacy mode or a given version of SMMU > only supports either legacy mode or newer mode? The SMMUv3 spec started out with definitions for S1 and S2 as well as capability bits for them at day 0. So it never had this backward compatible problem where we want to remove something that was a mandatory part of the specification. Jason

Re: [PATCH] vdpa: Allow VDPA to work on big-endian machine

2025-06-15 Thread Jason Wang
re putting it into virtio queue. > > Signed-off-by: Konstantin Shkolnyy > --- Acked-by: Jason Wang Thanks

Re: [PATCH v3 0/4] VFIO and IOMMU prerequisite stuff for IOMMU nesting support

2025-06-04 Thread Jason Gunthorpe
messages when DKIM is turned on in some configurations. Jason

Re: [PATCH v3 0/4] VFIO and IOMMU prerequisite stuff for IOMMU nesting support

2025-06-04 Thread Jason Gunthorpe
wed-by: Eric Auger (✓ DKIM/redhat.com) + Reviewed-by: Donald Dutile (✓ DKIM/redhat.com) [PATCH v2 5/6] hw/arm/virt: Add support for smmuv3 device [PATCH v2 6/6] hw/arm/smmuv3: Enable smmuv3 device creation + Reviewed-by: Nicolin Chen (✓ DKIM/nvidia.com) Jason

Re: [PATCH v2] virtio-net: Add queues for RSS during migration

2025-06-02 Thread Jason Wang
On Fri, May 30, 2025 at 1:19 PM Akihiko Odaki wrote: > > virtio_net_pre_load_queues() inspects vdev->guest_features to tell if > VIRTIO_NET_F_RSS or VIRTIO_NET_F_MQ is enabled to infer the required > number of queues. This works for VIRTIO_NET_F_MQ but it doesn't for > VIRTIO_NET_F_RSS because onl

Re: [PATCH] net: fix buffer overflow in af_xdp_umem_create()

2025-06-02 Thread Jason Wang
On Mon, Jun 2, 2025 at 4:57 PM Anastasia Belova wrote: > > s->pool has n_descs elements so maximum i should be > n_descs - 1. Fix the upper bound. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: cb039ef3d9 ("net: add initial support for AF_XDP network backend") > S

Re: [PATCH] virtio-net: Add queues for RSS during migration

2025-05-25 Thread Jason Wang
On Thu, May 22, 2025 at 12:39 PM Akihiko Odaki wrote: > > On 2025/05/22 10:50, 'Jason Wang' via devel wrote: > > On Wed, May 21, 2025 at 11:51 AM Akihiko Odaki > > wrote: > >> > >> On 2025/05/21 9:51, Jason Wang wrote: > >>> On

Re: [PATCH] virtio-net: Add queues for RSS during migration

2025-05-21 Thread Jason Wang
On Wed, May 21, 2025 at 11:51 AM Akihiko Odaki wrote: > > On 2025/05/21 9:51, Jason Wang wrote: > > On Fri, May 16, 2025 at 11:29 AM Akihiko Odaki > > wrote: > >> > >> On 2025/05/16 10:44, Jason Wang wrote: > >>> On Wed, May 14, 2025 at 2:58 PM Ak

Re: [PATCH] virtio-net: Add queues for RSS during migration

2025-05-20 Thread Jason Wang
On Fri, May 16, 2025 at 11:29 AM Akihiko Odaki wrote: > > On 2025/05/16 10:44, Jason Wang wrote: > > On Wed, May 14, 2025 at 2:58 PM Akihiko Odaki > > wrote: > >> > >> On 2025/05/14 14:05, 'Jason Wang' via devel wrote: > >>> O

Re: [PATCH v4 6/7] vdpa: move iova_tree allocation to net_vhost_vdpa_init

2025-05-15 Thread Jason Wang
gned-off-by: Jonah Palmer > --- Acked-by: Jason Wang Thanks

Re: [PATCH v4 3/7] vdpa: set backend capabilities at vhost_vdpa_init

2025-05-15 Thread Jason Wang
y in > batches, using VHOST_BACKEND_F_IOTLB_BATCH. > > Signed-off-by: Eugenio Pérez > Signed-off-by: Jonah Palmer > --- Acked-by: Jason Wang Thanks

Re: [PATCH v4 5/7] vdpa: reorder listener assignment

2025-05-15 Thread Jason Wang
t; Do the right thing and only set it in the first vdpa device. > > Signed-off-by: Eugenio Pérez > Signed-off-by: Jonah Palmer Acked-by: Jason Wang Thanks

Re: [PATCH v4 4/7] vdpa: add listener_registered

2025-05-15 Thread Jason Wang
On Thu, May 8, 2025 at 2:47 AM Jonah Palmer wrote: > > From: Eugenio Pérez > > Check if the listener has been registered or not, so it needs to be > registered again at start. > > Signed-off-by: Eugenio Pérez > Signed-off-by: Jonah Palmer > --- Acked-by: Jason Wang Thanks

Re: [PATCH v4 2/7] vdpa: reorder vhost_vdpa_set_backend_cap

2025-05-15 Thread Jason Wang
On Thu, May 8, 2025 at 2:48 AM Jonah Palmer wrote: > > From: Eugenio Pérez > > It will be used directly by vhost_vdpa_init. > > Signed-off-by: Eugenio Pérez > Signed-off-by: Jonah Palmer > --- Acked-by: Jason Wang Thanks

Re: [PATCH v4 1/7] vdpa: check for iova tree initialized at net_client_start

2025-05-15 Thread Jason Wang
ent_stop clear it if the device is > stopped. If the guest starts the device again, the iova tree is > recreated by vhost_vdpa_net_data_start_first or vhost_vdpa_net_cvq_start > if needed, so old behavior is kept. > > Signed-off-by: Eugenio Pérez > Signed-off-by: Jonah Palmer A

Re: [PATCH v4 2/7] vdpa: reorder vhost_vdpa_set_backend_cap

2025-05-15 Thread Jason Wang
On Thu, May 8, 2025 at 2:48 AM Jonah Palmer wrote: > > From: Eugenio Pérez > > It will be used directly by vhost_vdpa_init. > > Signed-off-by: Eugenio Pérez > Signed-off-by: Jonah Palmer > --- Acked-by: Jason Wang Thanks

Re: [PATCH v4 0/7] Move memory listener register to vhost_vdpa_init

2025-05-15 Thread Jason Wang
On Thu, May 8, 2025 at 2:47 AM Jonah Palmer wrote: > > Current memory operations like pinning may take a lot of time at the > destination. Currently they are done after the source of the migration is > stopped, and before the workload is resumed at the destination. This is a > period where neigh

Re: [PATCH v4 0/7] Move memory listener register to vhost_vdpa_init

2025-05-15 Thread Jason Wang
? I don't think it changed a lot but > > just to be as updated as possible. > Jonah is off this week and will be back until next Tuesday, but I recall > he indeed did some downtime test with VM with 128GB memory before taking > off, which shows obvious improvement from around 10 seconds to 5.8 > seconds after applying this series. Since this is related to update on > the cover letter, would it be okay for you and Jason to ack now and then > proceed to Michael for upcoming merge? I will go through the series. Thanks

Re: [PATCH v4 0/7] Move memory listener register to vhost_vdpa_init

2025-05-15 Thread Jason Wang
On Thu, May 8, 2025 at 2:47 AM Jonah Palmer wrote: > > Current memory operations like pinning may take a lot of time at the > destination. Currently they are done after the source of the migration is > stopped, and before the workload is resumed at the destination. This is a > period where neigh

Re: [PATCH] virtio-net: Add queues for RSS during migration

2025-05-15 Thread Jason Wang
On Wed, May 14, 2025 at 2:58 PM Akihiko Odaki wrote: > > On 2025/05/14 14:05, 'Jason Wang' via devel wrote: > > On Sat, May 10, 2025 at 3:24 PM Akihiko Odaki > > wrote: > >> > >> virtio_net_pre_load_queues() inspects vdev->guest_features to te

Re: [PATCH] virtio-net: Add queues for RSS during migration

2025-05-13 Thread Jason Wang
On Sat, May 10, 2025 at 3:24 PM Akihiko Odaki wrote: > > virtio_net_pre_load_queues() inspects vdev->guest_features to tell if > VIRTIO_NET_F_RSS or VIRTIO_NET_F_MQ is enabled to infer the required > number of queues. This works for VIRTIO_NET_F_MQ but it doesn't for > VIRTIO_NET_F_RSS because onl

Re: [PATCH] virtio-net: Copy all for dhclient workaround

2025-05-13 Thread Jason Wang
On Mon, May 12, 2025 at 6:11 PM Michael Tokarev wrote: > > On 05.04.2025 11:04, Akihiko Odaki wrote: > > The goal of commit 7987d2be5a8b ("virtio-net: Copy received header to > > buffer") was to remove the need to patch the (const) input buffer with a > > recomputed UDP checksum by copying headers

Re: [PATCH 1/3] include/hw/pci: Attach BDF to Memory Attributes

2025-04-24 Thread Jason Chien
:28寫道: > On Sun, Mar 02, 2025 at 05:12:07PM +0800, Jason Chien wrote: > > This commit adds the BDF to the memory attributes for DMA operations. > > > > Signed-off-by: Jason Chien > > --- > > include/hw/pci/pci_device.h | 10 -- > > 1 file changed, 8 insert

Re: [PATCH v7 4/4] virtio_net: Add third acceptable configuration for MAC setup.

2025-04-20 Thread Jason Wang
On Thu, Apr 17, 2025 at 6:26 PM Cindy Lu wrote: > > For VDPA devices, Allow configurations where both the hardware MAC address > and QEMU command line MAC address are zero. > In this case, QEMU will automatically generate a random MAC address and > assign it to the hardware, and the VM will use th

Re: [PATCH v7 3/4] virtio_net: Add second acceptable configuration for MAC setup

2025-04-20 Thread Jason Wang
On Thu, Apr 17, 2025 at 6:25 PM Cindy Lu wrote: > > For VDPA devices, Allow configurations where the hardware MAC address > is non-zero while the MAC address in the QEMU command line is zero. > In this case, QEMU will use the hardware MAC address from the device. > > Signed-off-by: Cindy Lu > ---

Re: [PATCH v7 2/4] virtio_net: Add the check for vdpa's mac address

2025-04-20 Thread Jason Wang
On Thu, Apr 17, 2025 at 6:25 PM Cindy Lu wrote: > > When using a VDPA device, it is important to ensure that the MAC > address is correctly set. The MAC address in the hardware should > match the MAC address from the QEMU command line. This is a recommended > configuration and will allow the syste

Re: [PATCH v7 1/4] vhost_vdpa : Add a new parameter to enable check mac address

2025-04-20 Thread Jason Wang
On Mon, Apr 21, 2025 at 11:14 AM Jason Wang wrote: > > On Thu, Apr 17, 2025 at 6:25 PM Cindy Lu wrote: > > > > When using a VDPA device, it's important to ensure that the MAC > > address is correctly set. > > This patch adds a new QEMU command line

Re: [PATCH v7 1/4] vhost_vdpa : Add a new parameter to enable check mac address

2025-04-20 Thread Jason Wang
On Thu, Apr 17, 2025 at 6:25 PM Cindy Lu wrote: > > When using a VDPA device, it's important to ensure that the MAC > address is correctly set. > This patch adds a new QEMU command line parameter to enable MAC > address verification, which is enabled by default. > > Usage example: > > -netde

Re: [PATCH] virtio: Call set_features during reset

2025-04-15 Thread Jason Wang
On Thu, Apr 10, 2025 at 3:42 PM Akihiko Odaki wrote: > > virtio-net expects set_features() will be called when the feature set > used by the guest changes to update the number of virtqueues. Call it > during reset as reset clears all features and the queues added for > VIRTIO_NET_F_MQ or VIRTIO_NE

Re: [PATCH 1/3] include/hw/pci: Attach BDF to Memory Attributes

2025-04-14 Thread Jason Chien
Ping. Jason Chien 於 2025年3月20日 週四 上午12:40寫道: > Ping > > Jason Chien 於 2025年3月13日 週四 上午12:59寫道: > >> Ping. >> >> Michael/Marcel, would you mind taking a look? Thanks! >> >> >> Jason >> >> Daniel Henrique Barboza 於 2025年3月7日 週五 >

Re: [PATCH v6 4/4] virtio_net: Add third acceptable configuration for MAC setup.

2025-04-07 Thread Jason Wang
On Tue, Apr 8, 2025 at 2:14 PM Cindy Lu wrote: > > For VDPA devices, Allow configurations where both the hardware MAC address > and QEMU command line MAC address are zero. > Let's explain why this can work. Thanks

Re: [PATCH v6 3/4] virtio_net: Add second acceptable configuration for MAC setup

2025-04-07 Thread Jason Wang
On Tue, Apr 8, 2025 at 2:13 PM Cindy Lu wrote: > > For VDPA devices, Allow configurations where the hardware MAC address > is non-zero while the MAC address in the QEMU command line is zero. > > Signed-off-by: Cindy Lu > --- > hw/net/virtio-net.c | 14 ++ > 1 file changed, 14 inserti

Re: [PATCH v6 2/4] virtio_net: Add the check for vdpa's mac address

2025-04-07 Thread Jason Wang
On Tue, Apr 8, 2025 at 2:13 PM Cindy Lu wrote: > > When using a VDPA device, it is important to ensure that the MAC > address is correctly set. The MAC address in the hardware should > match the MAC address from the QEMU command line. This is a recommended > configuration and will allow the system

Re: [PATCH v6 1/4] vhost_vdpa : Add a new parameter to enable check mac address

2025-04-07 Thread Jason Wang
On Tue, Apr 8, 2025 at 2:13 PM Cindy Lu wrote: > > When using a VDPA device, it's important to ensure that the MAC > address is correctly set. > Add a new parameter in qemu cmdline to enable this check, default value > is false > > The usage is: > > -netdev > type=vhost-vdpa,vhostdev=/dev/vh

Re: [PATCH] Revert "virtio-net: Copy received header to buffer"

2025-04-06 Thread Jason Wang
g > Signed-off-by: Antoine Damhet > --- Acked-by: Jason Wang Thanks

Re: [PATCH] virtio-net: Copy all for dhclient workaround

2025-04-06 Thread Jason Wang
On Sat, Apr 5, 2025 at 4:04 PM Akihiko Odaki wrote: > > The goal of commit 7987d2be5a8b ("virtio-net: Copy received header to > buffer") was to remove the need to patch the (const) input buffer with a > recomputed UDP checksum by copying headers to a RW region and inject the > checksum there. The

  1   2   3   4   5   6   7   8   9   10   >