Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-13 Thread Jacob Abrams
On 9/11/24 03:28, Peter Maydell wrote: > On Wed, 11 Sept 2024 at 07:27, Jacob Abrams wrote: >> On 9/10/24 02:34, Peter Maydell wrote: >>> If we make the .impl and .valid changes, then the result is >>> that we permit 16 bit writes to come through to the read >&g

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-10 Thread Jacob Abrams
On 9/10/24 02:34, Peter Maydell wrote: > On Mon, 9 Sept 2024 at 18:40, Philippe Mathieu-Daudé > wrote: >> >> Hi, >> >> (Cc'ing Arnaud & Inès who are listed as maintainers) >> >> On 6/9/24 18:12, Peter Maydell wrote: >>> On Mon

[PATCH] hw/char/stm32l4x5_usart.c: Enable USART ACK bit response

2024-09-10 Thread Jacob Abrams
read and write") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2540 Signed-off-by: Jacob Abrams --- hw/char/stm32l4x5_usart.c | 16 + tests/qtest/stm32l4x5_usart-test.c | 36 +- 2 files changed, 51 insertions(+), 1 deletion(-) diff

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-09 Thread Jacob Abrams
On 9/9/24 10:40, Philippe Mathieu-Daudé wrote: > Hi, > > (Cc'ing Arnaud & Inès who are listed as maintainers) > > On 6/9/24 18:12, Peter Maydell wrote: >> On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: >>> >>> These changes allow th

[PATCH v2] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-07 Thread Jacob Abrams
should restore ISR to default value. Fixes: 87b77e6e01ca ("hw/char/stm32l4x5_usart: Enable serial read and write") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2540 Signed-off-by: Jacob Abrams --- Changes since version 1: - Add qtest_quit to end of new test hw/char/stm32l4

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-07 Thread Jacob Abrams
On 9/6/24 09:12, Peter Maydell wrote: > On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: >> >> These changes allow the official STM32L4xx HAL UART driver to function >> properly with the b-l475e-iot01a machine. >> >> Modifying USART_CR1 TE bit should alter USA

[PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-02 Thread Jacob Abrams
should restore ISR to default value. Fixes: 87b77e6e01ca ("hw/char/stm32l4x5_usart: Enable serial read and write") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2540 Signed-off-by: Jacob Abrams --- hw/char/stm32l4x5_usart.c | 29 +++--- tests/qtest/stm32