Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc/fpu_helper: Fix efscmp* instructions handling

2016-05-27 Thread Imran, Talha
On 05/27/2016 06:37 AM, David Gibson wrote: > On Thu, May 19, 2016 at 05:11:35PM +0500, Talha Imran wrote: >> With specification at hand from the reference manual from Freescale >> http://cache.nxp.com/files/32bit/doc/ref_manual/SPEPEM.pdf , I have found a >> fix >> to efscmp* instructions handli

Re: [Qemu-devel] [PATCH] Fix QEMU PPC e500v1 efscmp* instructions

2016-05-18 Thread Imran, Talha
With more information at hand with the reference manual from Freescale http://cache.nxp.com/files/32bit/doc/ref_manual/SPEPEM.pdf , I was able to revisit my patch and figure out what is actually going on. Before applying any patch, efscmp* instructions in QEMU set crD values as (0b0100 << 2) = 0b1

Re: [Qemu-devel] [PATCH] Fix QEMU PPC e500v1 efscmp* instructions

2016-05-16 Thread Imran, Talha
support efscmp* instructions. Hence, I believe setting CR = 6 instead of CR = 4 is the most straightforward solution. Comments and suggestions are welcome. From: Imran, Talha Sent: Friday, May 13, 2016 9:26 PM To: qemu-triv...@nongnu.org Subject: [PATCH] Fix QEMU

[Qemu-devel] [PATCH] Fix QEMU PPC e500v1 efscmp* instructions

2016-05-10 Thread Imran, Talha
Hi Everyone, Please find attached a patch which fixes handling in QEMU PPC e500v1 for efscmp* instructions. This was the cause of over 400 FAILs for this CPU while running GCC testsuite, which have been fixed. Value for Condition Registers (CR) being set in QEMU was different from the value obser