In some of our environment, sometimes test did not pass due to multithreading
behavior.
I think this fix will check correct behavior. Could you review this patch?
Hiroki Narukawa (1):
test-thread-pool: Fix occasional test fail
tests/unit/test-thread-pool.c | 6 +-
1 file changed, 5
data.n is set to 4, long_cb() finishes immediately, bdrv_aio_cancel()
is called after that, the job is done and
> g_assert_cmpint(data[i].ret, ==, -ECANCELED);
at the case data[i].n == 4 fails.
This patch makes this rare situation to pass correctly.
Signed-off-by: Hiroki Narukawa
---
tests
adds 64 by default, but now coroutine is not only for block
> devices,
>
> and is not too much burdon comparing with new default.
>
> pool size of 128 * vCPUs.
>
> Signed-off-by: Hiroki Narukawa
> ---
> hw/block/virtio-blk.c| 5 +
> include/qemu/coroutin
implement this.
Changes from v3:
No code changed. Changed commit message so that first line indicates to
correct commit ID.
Changes from v2:
Decrease coroutine pool size on device remove
Changes from v1:
Use qatomic_read properly
Hiroki Narukawa (1):
util: adjust coroutine pool size to virtio block
is not too much burdon comparing with new default.
pool size of 128 * vCPUs.
Signed-off-by: Hiroki Narukawa
---
hw/block/virtio-blk.c| 5 +
include/qemu/coroutine.h | 10 ++
util/qemu-coroutine.c| 20
3 files changed, 31 insertions(+), 4 deletions
coroutine pool size on device remove
Changes from v1:
Use qatomic_read properly
Hiroki Narukawa (1):
util: adjust coroutine pool size to virtio block queue
hw/block/virtio-blk.c| 5 +
include/qemu/coroutine.h | 10 ++
util/qemu-coroutine.c| 20
3 files
> > /* Config size before the discard support (hide associated config
> > fields) */ #define VIRTIO_BLK_CFG_SIZE offsetof(struct
> > virtio_blk_config, \ @@ -1222,6 +1223,8 @@ static void
> virtio_blk_device_realize(DeviceState *dev, Error **errp)
> > for (i = 0; i < conf->num_queues; i++) {
is not too much burdon comparing with new default.
pool size of 128 * vCPUs.
Signed-off-by: Hiroki Narukawa
---
hw/block/virtio-blk.c| 5 +
include/qemu/coroutine.h | 10 ++
util/qemu-coroutine.c| 20
3 files changed, 31 insertions(+), 4 deletions
implied to adjust coroutine pool size adaptively,
> so I
> tried to implement this.
>
> Could you review this patch?
>
>
> Hiroki Narukawa (1):
> util: adjust coroutine pool size to virtio block queue
>
> hw/block/virtio-blk.c| 3 +++
> include/qemu/coro
> On Thu, Jan 06, 2022 at 05:20:57PM +0900, Hiroki Narukawa wrote:
>
> Phil, thanks for notifying me.
>
> > Coroutine pool size was 64 from long ago, and the basis was organized in
> > the commit message in c740ad92.
> >
> > At that time, virtio-b
patch?
Hiroki Narukawa (1):
util: adjust coroutine pool size to virtio block queue
hw/block/virtio-blk.c| 3 +++
include/qemu/coroutine.h | 5 +
util/qemu-coroutine.c| 15 +++
3 files changed, 19 insertions(+), 4 deletions(-)
--
2.17.1
is not too much burdon comparing with new default.
pool size of 128 * vCPUs.
Signed-off-by: Hiroki Narukawa
---
hw/block/virtio-blk.c| 3 +++
include/qemu/coroutine.h | 5 +
util/qemu-coroutine.c| 15 +++
3 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/hw
is not too much burdon comparing with new default.
pool size of 128 * vCPUs.
Signed-off-by: Hiroki Narukawa
---
hw/block/virtio-blk.c| 3 +++
include/qemu/coroutine.h | 5 +
util/qemu-coroutine.c| 15 +++
3 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/hw
We encountered random disk IO performance drop since qemu-5.0.0, and this patch
fixes it.
Commit message in c740ad92 implied to adjust coroutine pool size adaptively, so
I tried to implement this.
Could you review this patch?
Hiroki Narukawa (1):
util: adjust coroutine pool size to virtio
14 matches
Mail list logo
