Re: [PATCH net v3] virtio_net: Do not send RSS key if it is not supported

2024-04-03 Thread Heng Qi
completely V3: * Got some good feedback from and Xuan Zhuo and Heng Qi, and reworked the rejection path. --- drivers/net/virtio_net.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index

Re: [PATCH net v3] virtio_net: Do not send RSS key if it is not supported

2024-03-31 Thread Heng Qi
ger.kernel.org Cc: qemu-devel@nongnu.org Signed-off-by: Breno Leitao --- Changelog: V2: * Moved from creating a valid packet, by rejecting the request completely V3: * Got some good feedback from and Xuan Zhuo and Heng Qi, and reworked the rejection path. --- drivers/net/vi

Re: [PATCH net v2 2/2] virtio_net: Do not send RSS key if it is not supported

2024-03-26 Thread Heng Qi
rst, this seems to work better. Or squash them into one patch. Apart from these and Xuan's comments. For series:         Reviewed-by: Heng Qi Regards, Heng if (rxfh->hfunc != ETH_RSS_HASH_NO_CHANGE && rxfh->hfunc != ETH_RSS_HASH_TOP) return -EOPNOTSUPP;

Re: [PATCH] virtio_net: Do not send RSS key if it is not supported

2024-03-25 Thread Heng Qi
   rss_max_indirection_table_length)); +   } + +   if (vi->has_rss || vi->has_rss_hash_report) {     vi->rss_key_size =     virtio_cread8(vdev, offsetof(struct virtio_net_config, rss_max_key_size)); Regards, Heng @Heng Qi Could you help us? Thanks.