Re: [Qemu-devel] [RFC 0/3] qemu-char: Add poll timeouts for character backends

2014-10-24 Thread Heinz Graalfs
On 24/10/14 11:15, Paolo Bonzini wrote: > On 10/24/2014 10:13 AM, Heinz Graalfs wrote: >> On s390 one can observe system hang situations wrt console input when >> using 'dataplane=on'. >> >> dataplane processing causes an inactive main thread and an act

[Qemu-devel] [RFC 1/3] char: Trigger timeouts on poll() when frontend is unready

2014-10-24 Thread Heinz Graalfs
; to ask the frontend if it is ready. Scheduling a timeout callback on poll() ends when the frontend returns a non negative value on 'can_read'. Frontends still returning zero on 'can_read' or without such callback are not affected. Signed-off-by: Heinz Graalfs --- qemu-char.c

[Qemu-devel] [RFC 2/3] s390x: Fix hanging SCLP line mode console

2014-10-24 Thread Heinz Graalfs
Exploit the new can_read timeout infrastructure in order to avoid hangs when no further activity happens on the main thread. Signed-off-by: Heinz Graalfs --- hw/char/sclpconsole-lm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/sclpconsole-lm.c b/hw/char

[Qemu-devel] [RFC 3/3] s390x: Avoid hanging SCLP ASCII console

2014-10-24 Thread Heinz Graalfs
Exploit the new can_read timeout infrastructure in order to avoid hangs when no further activity happens on the main thread. Signed-off-by: Heinz Graalfs --- hw/char/sclpconsole.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/char/sclpconsole.c b/hw/char

[Qemu-devel] [RFC 0/3] qemu-char: Add poll timeouts for character backends

2014-10-24 Thread Heinz Graalfs
now returns -EAGAIN on 'can_read' to avoid a potential hang. Heinz Graalfs (3): char: Trigger timeouts on poll() when frontend is unready s390x: Fix hanging SCLP line mode console s390x: Avoid hanging SCLP ASCII console hw/char/sclpconsole-lm.c | 4 ++-- hw/char/sclpc

Re: [Qemu-devel] drive_del vs. device_del: what should come first?

2014-04-25 Thread Heinz Graalfs
On 23/04/14 15:01, Stefan Hajnoczi wrote: On Fri, Apr 11, 2014 at 02:47:20PM +0200, Heinz Graalfs wrote: Hello Markus, I finally managed to reproduce the problem, at least once ... The scenario was: dd if=/dev/vdx1 of=partitionone followed by a virsh detach... (with the device_del() under

Re: [Qemu-devel] drive_del vs. device_del: what should come first?

2014-04-11 Thread Heinz Graalfs
... see below the complete core_backtrace ... On 02/04/14 19:40, Markus Armbruster wrote: Heinz Graalfs writes: On 01/04/14 17:48, Markus Armbruster wrote: Heinz Graalfs writes: Hi Kevin, doing a virsh detach-device ... ends up in the following QEMU monitor commands: 1. device_

Re: [Qemu-devel] drive_del vs. device_del: what should come first?

2014-04-03 Thread Heinz Graalfs
On 02/04/14 19:40, Markus Armbruster wrote: Heinz Graalfs writes: On 01/04/14 17:48, Markus Armbruster wrote: Heinz Graalfs writes: Hi Kevin, doing a virsh detach-device ... ends up in the following QEMU monitor commands: 1. device_del ... 2. drive_del ... qmp_device_del

Re: [Qemu-devel] drive_del vs. device_del: what should come first?

2014-04-02 Thread Heinz Graalfs
On 01/04/14 17:48, Markus Armbruster wrote: Heinz Graalfs writes: Hi Kevin, doing a virsh detach-device ... ends up in the following QEMU monitor commands: 1. device_del ... 2. drive_del ... qmp_device_del() performs the device unplug path. In case of a block device do_drive_del

[Qemu-devel] drive_del vs. device_del: what should come first?

2014-04-01 Thread Heinz Graalfs
Hi Kevin, doing a virsh detach-device ... ends up in the following QEMU monitor commands: 1. device_del ... 2. drive_del ... qmp_device_del() performs the device unplug path. In case of a block device do_drive_del() tries to prevent further IO against the host device. However, bdrv_fi

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-12-11 Thread Heinz Graalfs
On Tue, 2012-12-11 at 11:30 +0100, Kevin Wolf wrote: > Am 11.12.2012 10:58, schrieb Heinz Graalfs: > > Hi Kevin, > > > > I'm using the bdrv_pread() function during boot partition detection ... > > > > In detail: > > bdrv_pread() is called to read 3

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-12-11 Thread Heinz Graalfs
for a O_DIRECT opened file, and produces the error. Heinz On Mon, 2012-12-10 at 09:55 +0100, Kevin Wolf wrote: > Am 07.12.2012 21:26, schrieb Heinz Graalfs: > > Hello Kevin, > > > > I'm resending my answer as of Nov 23rd. > > > > Is this still on your queue

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-12-07 Thread Heinz Graalfs
Hello Kevin, I'm resending my answer as of Nov 23rd. Is this still on your queue? Heinz On Wed, 2012-11-21 at 10:15 +0100, Kevin Wolf wrote: > Am 21.11.2012 09:58, schrieb Christian Borntraeger: > > From: Heinz Graalfs > > > > While testing IPL code (bootin

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-11-23 Thread Heinz Graalfs
On Wed, 2012-11-21 at 10:15 +0100, Kevin Wolf wrote: > Am 21.11.2012 09:58, schrieb Christian Borntraeger: > > From: Heinz Graalfs > > > > While testing IPL code (booting) for s390x we faced some problems > > with cache=none on dasds (4k block size) on bdrv_preads with

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-11-21 Thread Heinz Graalfs
On Wed, 2012-11-21 at 11:00 +0100, Christian Borntraeger wrote: > On 21/11/12 10:15, Kevin Wolf wrote: > > Am 21.11.2012 09:58, schrieb Christian Borntraeger: > >> From: Heinz Graalfs > >> > >> While testing IPL code (booting) for s390x we faced some proble

[Qemu-devel] [PATCH] virtio-ccw: Add secondary indicators.

2012-09-11 Thread Heinz Graalfs
From: Cornelia Huck Add a ccw to specify the location of indicators for configuration changes and notice how they are to be used. Signed-off-by: Cornelia Huck --- virtio-spec.lyx | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/virtio-spec.lyx b

[Qemu-devel] [PATCH] virtio spec amendment for virtio-ccw

2012-09-11 Thread Heinz Graalfs
Rusty, here is Conny's virtio spec amendment. Cornelia Huck (1): virtio-ccw: Add secondary indicators. virtio-spec.lyx | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) -- 1.7.11.5

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-08-20 Thread Heinz Graalfs
Alex, some more answers for a couple of leftovers. Heinz On Mon, 2012-07-30 at 15:24 +0200, Alexander Graf wrote: > On 24.07.2012, at 09:37, Christian Borntraeger wrote: > > > From: Heinz Graalfs > > > > Several SCLP features are considered to be events. Those event

Re: [Qemu-devel] [PATCH 3/7] s390: sclp base support

2012-08-20 Thread Heinz Graalfs
Hi Alex, there was one leftover ... On Mon, 2012-07-30 at 14:38 +0200, Alexander Graf wrote: > On 24.07.2012, at 09:37, Christian Borntraeger wrote: > > > From: Heinz Graalfs > > > > This adds a more generic infrastructure for handling Service-Call > > reque

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-08-20 Thread Heinz Graalfs
On Tue, 2012-07-31 at 14:59 +0200, Andreas Färber wrote: > Am 24.07.2012 09:37, schrieb Christian Borntraeger: > > From: Heinz Graalfs > > > > Several SCLP features are considered to be events. Those events don't > > provide SCLP commands on their own, instea

Re: [Qemu-devel] [PATCH 7/8] s390: Add SCLP vt220 console support

2012-06-13 Thread Heinz Graalfs
On Tue, 2012-06-12 at 13:52 +0200, Alexander Graf wrote: > On 06/06/2012 02:05 PM, Jens Freimann wrote: > > From: Heinz Graalfs > > > > Adds console support (in vt220 mode). > > In order to run qemu exploiting the SCLP's console functionality in vt220 > >

Re: [Qemu-devel] [PATCH 6/8] s390: sclp event facility and signal quiesce support via system_powerdown

2012-06-13 Thread Heinz Graalfs
Alex, thanks for the comments, On Tue, 2012-06-12 at 13:38 +0200, Alexander Graf wrote: > On 06/06/2012 02:05 PM, Jens Freimann wrote: > > From: Heinz Graalfs > > > > This patch implements a subset of the sclp event facility as well > > as the signal quiesce event