On 7/15/25 14:55, Mark Cave-Ayland wrote:
Use QOM casts to convert between VFIOContainer and VFIOContainerBase instead
of accessing bcontainer directly.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Harsh Prateek Bora
---
hw/vfio/spapr.c | 16 ++--
1 file changed, 6
On 7/15/25 14:55, Mark Cave-Ayland wrote:
Use a QOM cast to convert to VFIOContainer instead of accessing bcontainer
directly.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Harsh Prateek Bora
---
hw/ppc/spapr_pci_vfio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
/hw/acpi/pcihp.h| 2 +-
include/hw/misc/ivshmem-flat.h | 2 +-
tests/qtest/vmgenid-test.c | 2 +-
8 files changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Harsh Prateek Bora
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 9ba90806f2..732d613ac0 100644
--- a/hw/acpi
This logic was kept here to support pseries-2.12 and older machine type
to enable them to calculate supported page size. Since the support for
such older machine types is already removed, this becomes dead code and
hence removed.
Signed-off-by: Harsh Prateek Bora
---
hw/ppc/spapr_caps.c | 13
uint8_t buf_in[TPM_SPAPR_BUFSIZE];
-uint8_t buf_out[TPM_SPAPR_BUFSIZE];
+QEMU_UNINITIALIZED uint8_t buf_in[TPM_SPAPR_BUFSIZE];
+QEMU_UNINITIALIZED uint8_t buf_out[TPM_SPAPR_BUFSIZE];
Reviewed-by: Harsh Prateek Bora
ssize_t ret;
trace_spapr_tpm_execute(data_in, da
c.c
@@ -789,7 +789,7 @@ static bool occ_opal_process_command(PnvOCC *occ,
static bool occ_model_tick(PnvOCC *occ)
{
-struct occ_dynamic_data dynamic_data;
+QEMU_UNINITIALIZED struct occ_dynamic_data dynamic_data;
Reviewed-by: Harsh Prateek Bora
if (!occ_read_dynamic_data(occ,
pseries-3.0 had been deprecated and due for removal now as per policy.
Also remove legacy irq support which existed for pre pseries-3.1 machines.
Suggested-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw/ppc/spapr.h | 1 -
include/hw/ppc/spapr_irq.h | 1 -
hw/ppc
pseries-3.1 had been deprecated and due for removal now as per policy.
Also remove backward compatibility flags and related code introduced for
pre pseries-4.0 machines.
Suggested-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw/ppc/spapr.h | 3 --
hw/ppc/spapr.c
pseries-3.0, 3.1 and 4.0 had been deprecated and due for removal now.
Also removing pre-4.1 backward compatibility hacks that aren't needed
anymore.
Harsh Prateek Bora (3):
ppc/spapr: remove deprecated machine pseries-3.0
ppc/spapr: remove deprecated machine pseries-3.1
ppc/spapr: r
pseries-4.0 had been deprecated and due for removal now as per policy.
Also remove pre-4.1 migration hacks which were introduced for backward
compatibility.
Suggested-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw/ppc/spapr.h | 1 -
hw/ppc/spapr.c | 27
leads to bits being set to 0 in absence of maxmem param.
Fix this by initializing the respective bits as per total mem size in
such case.
Reported-by: Gaurav Batra
Tested-by: David Christensen
Signed-off-by: Harsh Prateek Bora
---
hw/ppc/spapr.c | 11 +++
1 file changed, 7 insertions
Hi Cedric,
On 4/29/25 18:59, Cédric Le Goater wrote:
Hello Harsh,
On 10/11/24 07:57, Cédric Le Goater wrote:
On 10/7/24 17:38, Harsh Prateek Bora wrote:
As per Qemu's deprecation policy [1], and the mailing list discussion
that happened on [2], pseries-3.0 is more than 6 years old
-off-by: Thomas Huth
Reviewed-by: Harsh Prateek Bora
---
tests/functional/test_ppc64_pseries.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/functional/test_ppc64_pseries.py
b/tests/functional/test_ppc64_pseries.py
index fdc404ed033..67057934e8d 100755
--- a/tests/functional/t
On 3/23/25 23:10, Aditya Gupta wrote:
Add skeleton for handle "ibm,configure-kernel-dump" rtas call in QEMU.
Verify basic details mandated by the PAPR, such as number of
inputs/output, and add handling for the three fadump commands:
regiser/unregister/invalidate.
Currently fadump register wi
On 2/17/25 12:49, Aditya Gupta wrote:
When MPIPL is used, OPAL/Linux registers memory regions to be preserved
on a Memory-Preserving boot ('crashkernel boot').
The regions are added to two tables: MDST and MDDT (source and
destination tables)
The MDST contains the start address of the region
0 CPU")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Harsh Prateek Bora
---
v2: addressed review comments from Philippe, Daniel
---
hw/ppc/spapr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index c15340a58d..825afba4f4 100644
--- a/hw/ppc/spapr.c
+++ b/hw/p
On 3/13/25 15:02, Daniel P. Berrangé wrote:
On Wed, Mar 12, 2025 at 11:28:04AM +0530, Harsh Prateek Bora wrote:
When POWER10 CPU was made as default, we missed keeping POWER9 as
default for older pseries releases (pre-10.0) at that time.
This caused breakge in default cpu evaluation for
On 3/12/25 15:50, Harsh Prateek Bora wrote:
On 3/12/25 15:39, Philippe Mathieu-Daudé wrote:
On 12/3/25 06:58, Harsh Prateek Bora wrote:
When POWER10 CPU was made as default, we missed keeping POWER9 as
default for older pseries releases (pre-10.0) at that time.
This caused breakge in
On 3/12/25 15:39, Philippe Mathieu-Daudé wrote:
On 12/3/25 06:58, Harsh Prateek Bora wrote:
When POWER10 CPU was made as default, we missed keeping POWER9 as
default for older pseries releases (pre-10.0) at that time.
This caused breakge in default cpu evaluation for older pseries
machines
0 CPU")
Signed-off-by: Harsh Prateek Bora
---
hw/ppc/spapr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index c15340a58d..b31a91e2e2 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -4748,6 +4748,7 @@ static void spapr_machine_9_2_class_options(Ma
ept 'struct SpaprMachineState *' [ Nic ]
* Updated code in 'spapr_nested.c' to pass around 'struct
SpaprMachineState *' which eventually needs to be sent to the 'struct
guest_state_element_type.location' callback.
Loooks fine to me.
Reviewed-by: Harsh Prateek Bo
On 2/17/25 12:49, Aditya Gupta wrote:
Add offsets for the processor state captured during MPIPL dump.
This is incomplete. And might be implemented in future if the effort to
implement MPIPL is resumed again.
Please use RFC prefix in next iteration of patch series until the
patches are requ
On 2/17/25 12:49, Aditya Gupta wrote:
Earlier since the SBE_CMD_STASH_MPIPL_CONFIG command was not handled, so
skiboot used to not get any response from SBE:
[ 106.350742821,3] SBE: Message timeout [chip id = 0], cmd = d7, subcmd =
7
[ 106.352067746,3] SBE: Failed to send stash M
On 2/17/25 12:49, Aditya Gupta wrote:
Linux expect a "ibm,opal/dump" node to know whether MPIPL (aka fadump)
is supported on the hardware.
Export the "ibm,opal/dump" node in QEMU's device tree for Linux to know
that PowerNV supports MPIPL.
With the commit, kernel boots thinking fadump is sup
On 2/17/25 12:49, Aditya Gupta wrote:
Add the MDST, MDDT, MDRT tables offsets and structures as per current
skiboot upstream:
commit bc7b85db1e7e ("opal-ci: Remove centos7")
These structures will be later populated when preserving memory regions
for MPIPL
Signed-off-by: Aditya Gupta
-
On 2/17/25 12:49, Aditya Gupta wrote:
SBE's implementation of S0 seems to be basically "stop all clocks" and
then "host reset"
Nearest equivalent to the stop clocks seems to be 'pause_all_vcpus' in
QEMU,
Then reset the host, which is 'SHUTDOWN_CAUSE_GUEST_RESET' in QEMU.
Implement the S0 in
On 2/17/25 12:49, Aditya Gupta wrote:
During MPIPL (aka fadump), OPAL triggers the S0 SBE interrupt to trigger
MPIPL.
Currently QEMU treats it as "Unimplemented", handle the interrupts by
just logging that the interrupt happened.
Signed-off-by: Aditya Gupta
---
hw/ppc/pnv_sbe.c | 13 +
On 2/27/25 08:58, Nicholas Piggin wrote:
On Mon Feb 17, 2025 at 5:17 PM AEST, Aditya Gupta wrote:
Platform (ie. QEMU) is expected to pass few device tree properties for
details for fadump:
* "ibm,configure-kernel-dump": RTAS call for fadump
* "ibm,configure-kernel-dump-sizes": Space re
On 2/17/25 12:47, Aditya Gupta wrote:
Kernel expects CPU states/register states in the format mentioned in
"Register Save Area" in PAPR.
The platform (in our case, QEMU) saves each CPU register in the form of
an array of "register entries", the start and end of this array is
signified by "CPU
On 2/17/25 12:47, Aditya Gupta wrote:
While the first kernel boots, it registers memory regions for fadump
such as:
* CPU state data (has to be populated by the platform)
* HPTE state data (has to be populated by the platform)
* Real Mode Regions (platform should copy it to req
On 2/17/25 12:47, Aditya Gupta wrote:
According to PAPR:
R1–7.3.30–3. When the platform receives an ibm,os-term RTAS call, or
on a system reset without an ibm,nmi-interlock RTAS call, if the
platform has a dump structure registered through the
ibm,configure-kernel-dump cal
On 2/17/25 12:47, Aditya Gupta wrote:
Implement the handler for "ibm,configure-kernel-dump" rtas call in QEMU.
Currently the handler just does basic checks and handles
register/unregister/invalidate requests from kernel.
Fadump will be enabled in a later patch.
Let's use FADump or fadump f
On 2/6/25 18:44, Cédric Le Goater wrote:
For pseries machines, commit 567b5b309abe ("vfio/pci: Relax DMA map
errors for MMIO regions") introduced 2 error reports to notify the
user of MMIO mapping errors. Consolidate both code paths under one.
Cc: Harsh Prateek Bora
Cc: Shivapra
4)
-#define H_GUEST_GETSET_STATE_FLAG_GUEST_WIDE 0x8000
-#define GUEST_STATE_REQUEST_GUEST_WIDE 0x1
-#define GUEST_STATE_REQUEST_SET 0x2
+#define H_GUEST_GET_STATE_FLAGS_MASK 0xC000ULL
+#define H_GUEST_SET_STATE_FLAGS_MASK 0x8000ULL
+#define H_GUEST_SET_STATE_FL
On 1/27/25 15:56, Philippe Mathieu-Daudé wrote:
In order to move TCG specific code dependent on powerpc_excp()
in the next commit, expose its prototype in "internal.h".
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Harsh Prateek Bora
---
target/ppc/internal.h| 1
On 1/27/25 15:56, Philippe Mathieu-Daudé wrote:
Move helper_attn(), helper_scv() and helper_pminsn() to
tcg-excp_helper.c.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Harsh Prateek Bora
---
target/ppc/excp_helper.c | 45
target/ppc/tcg
On 1/27/25 15:56, Philippe Mathieu-Daudé wrote:
Fix style in do_rfi() before moving the code around.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Harsh Prateek Bora
---
target/ppc/excp_helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/ppc
{
diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c
index dc5601a4577..5ad39cacc92 100644
--- a/target/ppc/tcg-excp_helper.c
+++ b/target/ppc/tcg-excp_helper.c
@@ -66,6 +66,149 @@ void raise_exception(CPUPPCState *env, uint32_t exception)
raise_exception_err_ra(env, exc
On 1/27/25 15:56, Philippe Mathieu-Daudé wrote:
Make is_prefix_insn_excp() prototype but have it guarded by
a tcg_enabled() check. Inline part of it in powerpc_excp_books().
Extract POWERPC_EXCP_HV_EMU handling code to ppc_tcg_hv_emu(),
also exposing its prototype in "internal.h".
Signed-off
On 1/27/25 15:56, Philippe Mathieu-Daudé wrote:
Move exception helpers to tcg-excp_helper.c so they are
only built when TCG is selected.
Signed-off-by: Philippe Mathieu-Daudé
---
target/ppc/excp_helper.c | 34
target/ppc/tcg-excp_helper.c | 38
On 1/27/25 15:56, Philippe Mathieu-Daudé wrote:
Expose powerpc_checkstop() prototype, and move it to
tcg-excp_helper.c, only built when TCG is available.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Harsh Prateek Bora
---
target/ppc/internal.h| 4 +++-
target/ppc
ion_err_ra calls passing
error_code as 0, I hope removing this is fine as still unused.
Reviewed-by: Harsh Prateek Bora
---
target/ppc/cpu.h | 2 --
target/ppc/excp_helper.c | 6 --
2 files changed, 8 deletions(-)
diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
index 0
On 1/28/25 12:13, Harsh Prateek Bora wrote:
On 1/27/25 15:56, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
target/ppc/excp_helper.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
On 1/27/25 15:56, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
target/ppc/excp_helper.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index 8956466db1d..b08cd53688c 100644
--- a/targe
the function declaration introduced in
internal.h in patch 3.
Otherwise,
Reviewed-by: Harsh Prateek Bora
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index b05eb7f5aec..8956466db1d 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -136,27 +136,6
,
.debug_check_breakpoint = ppc_cpu_debug_check_breakpoint,
.debug_check_watchpoint = ppc_cpu_debug_check_watchpoint,
};
#endif /* CONFIG_TCG */
Thanks for capturing this in commit log.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Harsh Prateek Bora
---
target/ppc
Reviewed-by: Harsh Prateek Bora
---
target/ppc/internal.h| 2 ++
target/ppc/excp_helper.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/ppc/internal.h b/target/ppc/internal.h
index 20fb2ec593c..46db6adfcf6 100644
--- a/target/ppc/internal.h
+++ b/target/ppc
On 1/27/25 15:56, Philippe Mathieu-Daudé wrote:
Restrict the tb_flush() call to TCG. Assert we are using KVM or TCG.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Harsh Prateek Bora
---
hw/ppc/spapr_hcall.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a
Hi Philippe,
On 1/27/25 15:56, Philippe Mathieu-Daudé wrote:
TODO: Add PPC folks why :)
While this appear be TCG specific, may I know what caused you to bring
this change? Usually we have blanks stubs for hcalls in KVM mode which
are only TCG specific. That helps in avoiding building TCG spe
Hi Vaibhav,
On 1/15/25 12:37, Vaibhav Jain wrote:
Add support for reporting Hostwide state counters for nested KVM pseries
guests running with 'cap-nested-hv' with Qemu-TCG acting as
I hope you meant cap-nested-papr for APIv2 (cap-nested-hv is APIv1).
L0-hypervisor. sPAPR supports reporting
+ Shivaprasad (had posted patches for DAWR1/DAWRX1 earlier)
https://lore.kernel.org/qemu-devel/170679876639.188422.11634974895844092362.st...@ltc-boston1.aus.stglabs.ibm.com/
On 1/8/25 02:21, dan tan wrote:
From: dan tan
*** BLURB HERE ***
Version 3 summary:
RWMR (Region Weighted Mode Re
hw/ppc/spapr: Convert DIRTY_HPTE() macro as hpte_set_dirty() method
> hw/ppc/epapr: Do not swap ePAPR magic value
>
For spapr:
Reviewed-by: Harsh Prateek Bora
> hw/ppc/sam460ex.c | 2 +-
> hw/ppc/spapr.c| 63 +--
> hw/ppc/vi
Typo corrected below.
On 12/20/24 15:27, Harsh Prateek Bora wrote:
Hi Shiva,
On 2/1/24 20:16, Shivaprasad G Bhat wrote:
As per the PAPR, bit 0 of byte 64 in pa-features property
indicates availability of 2nd DAWR registers. i.e. If this bit is set,
2nd
DAWR is present, otherwise not. Use
On 12/20/24 14:59, BALATON Zoltan wrote:
On Fri, 20 Dec 2024, Harsh Prateek Bora wrote:
Hi Nick,
On 12/19/24 09:10, Nicholas Piggin wrote:
The dispatch count is a field in guest memory that the hypervisor
increments when preempting and dispatching the guest. This was not
being done
CE_SET_DAWR0 ?
+ppc_store_dawr1(env, value1);
+ppc_store_dawrx1(env, value2);
and then do an else g_assert_not_reached() ?
With suggested changes after addressing other review comments from
Nick/David:
Reviewed-by: Harsh Prateek Bora
+}
return H_SUCCESS;
}
@@ -911,8 +917
Hi Nick,
On 12/19/24 09:10, Nicholas Piggin wrote:
The dispatch count is a field in guest memory that the hypervisor
increments when preempting and dispatching the guest. This was not
being done deterministically with respect to icount, because tcg
exec exit is not deterministic (e.g., an async
Reviewed-by: Harsh Prateek Bora
---
include/hw/ppc/spapr.h | 1 +
hw/ppc/spapr.c | 3 +++
hw/ppc/spapr_cpu_core.c | 2 ++
3 files changed, 6 insertions(+)
diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index af4aa1cb0fb..db44893689b 100644
--- a/include/hw/ppc
t;msr & ((target_ulong)1 << MSR_DR)) {
-if (!wt) {
-return false;
-}
-} else {
-if (wt) {
- return false;
-}
-}
+} else {
+
On 12/18/24 23:51, Philippe Mathieu-Daudé wrote:
Convert CLEAN_HPTE() macro as hpte_set_clean() method.
Since sPAPR is in big endian configuration at reset,
use the big endian LD/ST API to access the HPTEs.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ppc/spapr.c | 15 ++-
1 f
Hi Philippe,
Similar issue here as with patch 2 ..
On 12/18/24 23:51, Philippe Mathieu-Daudé wrote:
Convert HPTE_DIRTY() macro as hpte_is_dirty() method.
Since sPAPR is in big endian configuration at reset,
use the big endian LD/ST API to access the HPTEs.
Signed-off-by: Philippe Mathieu-Daudé
Hi Philippe,
On 12/18/24 23:51, Philippe Mathieu-Daudé wrote:
Convert HPTE() macro as hpte_get() method.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ppc/spapr.c | 38 ++
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/
On 12/16/24 09:20, Richard Henderson wrote:
Signed-off-by: Richard Henderson
Reviewed-by: Harsh Prateek Bora
---
target/ppc/cpu_init.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
index 1253dbf622..5e95790def 100644
--- a
On 12/14/24 00:36, Richard Henderson wrote:
Signed-off-by: Richard Henderson
Reviewed-by: Harsh Prateek Bora
---
target/ppc/cpu_init.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
index 1253dbf622..5e95790def 100644
--- a
pegasos2: Fix IRQ routing from pci.0
> >
> > Glenn Miles (1):
> >target/ppc: Fix THREAD_SIBLING_FOREACH for multi-socket
> >
> > Harsh Prateek Bora (1):
> >ppc/spapr: fix drc index mismatch for partially enabled vcpus
> >
I think at least this ^^^
the issue by using correct drc index for explicitly
enabled vcpus during init.
Reported-by: Anushree Mathur
Tested-by: Anushree Mathur
Signed-off-by: Harsh Prateek Bora
---
hw/ppc/spapr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.
he GSB elements lookup table.")
Suggested-by: Harsh Prateek Bora
Signed-off-by: Amit Machhiwal
Reviewed-by: Harsh Prateek Bora
---
Changes since v1:
- Addressed Harsh's comments on v1
- Updated the patch description to more precise details of the issue
- v1:
ht
Hi Amit,
On 10/18/24 10:47, Harsh Prateek Bora wrote:
Hi Amit,
On 10/17/24 16:30, Amit Machhiwal wrote:
The DPDES support for doorbell emulation and handling for KVM on PAPR
guests was added in Linux via [1]. Subsequently, a new GSB element for
DPDES was added in Linux; the same has been
With that:
Reviewed-by: Harsh Prateek Bora
KVM: unknown exit, hardware reason ffea
NIP 0100 LR CTR XER
CPU#0
MSR 3000 HID0 HF 6c002000 iidx 3 didx 3
TB DECR
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as
deprecated with reasons mentioned in its commit log.
Removing pseries-2.2 specific code with this patch for now.
Suggested-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as
deprecated with reasons mentioned in its commit log.
Removing pseries-2.8 specific code with this patch for now.
Suggested-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
hw/ppc/spapr.c
Le Goater
Signed-off-by: Harsh Prateek Bora
---
docs/about/deprecated.rst | 8
include/hw/ppc/spapr_cpu_core.h | 1 -
target/ppc/cpu.h| 4
hw/ppc/spapr.c | 25 -
hw/ppc/spapr_cpu_core.c | 12
: Cédric Le Goater
Acked-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw/pci-host/spapr.h | 4 --
target/ppc/cpu.h| 5 ---
hw/ppc/spapr.c | 75 -
hw/ppc/spapr_pci.c | 57
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as
deprecated with reasons mentioned in its commit log.
Removing pseries-2.6 specific code with this patch for now.
Suggested-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
hw/ppc/spapr.c
Commit 0cac0f1b964 marked pseries-2.12 machines as deprecated
with reasons mentioned in its commit log.
Removing pseries-2.12-sxxm specific code with this patch.
Suggested-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
hw/ppc/spapr.c | 14 --
1 file changed, 14
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as
deprecated with reasons mentioned in its commit log.
Removing pseries-2.11 specific code with this patch.
Suggested-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
hw/ppc/spapr.c | 15
Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw/ppc/spapr.h | 1 -
hw/ppc/spapr.c | 38 --
2 files changed, 4 insertions(+), 35 deletions(-)
diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as
deprecated with reasons mentioned in its commit log.
Removing pseries-2.10 specific code with this patch for now.
Suggested-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
hw/ppc
: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw/ppc/spapr.h | 1 -
hw/ppc/spapr.c | 25 +
2 files changed, 1 insertion(+), 25 deletions(-)
diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index 1821ef96c7..6e9e62386c 100644
--- a
Reviewed-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw/ppc/spapr.h | 1 -
target/ppc/cpu.h | 1 -
hw/intc/xics.c | 16 ---
hw/ppc/spapr.c | 104 -
migration/savevm.c | 19
target/ppc
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as
deprecated with reasons mentioned in its commit log.
Removing pseries-2.1 specific code with this patch for now.
Suggested-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw
bm.com>
Harsh Prateek Bora (13):
ppc/spapr: remove deprecated machine pseries-2.1
ppc/spapr: remove deprecated machine pseries-2.2
ppc/spapr: remove deprecated machine pseries-2.3
ppc/spapr: remove deprecated machine pseries-2.4
ppc/spapr: remove deprecated machine pseries-2.5
machines until pseries-2.3.
Suggested-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw/boards.h | 3 ---
include/hw/pci-host/spapr.h | 1 -
hw/core/machine.c | 13 -
hw/ppc/spapr.c | 15
The second if-condition can be true only if the first one above is true.
Enclose the latter into the former to avoid un-necessary check if first
condition fails.
Reviewed-by: BALATON Zoltan
Reviewed-by: Nicholas Piggin
Signed-off-by: Harsh Prateek Bora
---
target/ppc/helper_regs.c | 6
ppc_excp_apply_ail has multiple if-checks for ail which is un-necessary.
Combine them as appropriate.
Reviewed-by: Nicholas Piggin
Signed-off-by: Harsh Prateek Bora
---
target/ppc/excp_helper.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/target/ppc
Most of the p8 exception handling accesses env->pending_interrupts and
env->spr[SPR_LPCR] at multiple places. Passing it directly as local
variables simplifies the code and avoids multiple indirect accesses.
Reviewed-by: Nicholas Piggin
Signed-off-by: Harsh Prateek Bora
---
targ
Currently, p9 exception handling has multiple if-condition checks where
it does an indirect access to pending_interrupts and LPCR via env.
Pass the values during entry to avoid multiple indirect accesses.
Reviewed-by: Nicholas Piggin
Signed-off-by: Harsh Prateek Bora
---
target/ppc
Cache env->spr[SPR_POWER_MMCR0] in a local variable as used in multiple
conditions to avoid multiple indirect accesses.
Reviewed-by: Nicholas Piggin
Signed-off-by: Harsh Prateek Bora
---
target/ppc/helper_regs.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --gi
As previously done for arch specific handlers, simplify var usage in
ppc_next_unmasked_interrupt by caching the env->pending_interrupts and
env->spr[SPR_LPCR] in local vars and using it later at multiple places.
Reviewed-by: Nicholas Piggin
Signed-off-by: Harsh Prateek Bora
---
targ
tended improvements to other Power arch p7, p8 (Nick)
other minor improvements
v2: addressed review comments from BALATON Zoltan
v1: Initial patch
Harsh Prateek Bora (9):
target/ppc: use locally stored msr and avoid indirect access
target/ppc: optimize hreg_compute_pmu_hflags_value
target/ppc: op
hreg_compute_hflags_value already stores msr locally to be used in most
of the logic in the routine however some instances are still using
env->msr which is unnecessary. Use locally stored value as available.
Reviewed-by: Nicholas Piggin
Reviewed-by: BALATON Zoltan
Signed-off-by: Harsh Prat
Like p8 and p9, simplifying p7 exception handling rotuines to avoid
un-necessary multiple indirect accesses to env->pending_interrupts and
env->spr[SPR_LPCR].
Reviewed-by: Nicholas Piggin
Signed-off-by: Harsh Prateek Bora
---
target/ppc/excp_helper.
Historically, the registration of sprs have been inherited alongwith
every new Power arch support being added leading to a lot of code
duplication. It's time to do necessary cleanups now to avoid further
duplication with newer arch support being added.
Signed-off-by: Harsh Prateek Bora
Rev
Hi Philippe,
On 10/8/24 01:53, Philippe Mathieu-Daudé wrote:
Hi Harsh,
On 7/10/24 12:38, Harsh Prateek Bora wrote:
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as
deprecated with reasons mentioned in its commit log.
Removing pseries-2.1 specific code with this patch for now
rnel.org/qemu-devel/1d7c210e-d7a6-4233-b555-c99a41f3c...@kaod.org/
While at it, also remove related legacy irq hacks which are now obsolete.
Suggested-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw/ppc/spapr.h | 1 -
include/hw/ppc/spapr_irq.h | 1 -
hw/ppc
Reviewed-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw/ppc/spapr.h | 1 -
target/ppc/cpu.h | 1 -
hw/intc/xics.c | 16 ---
hw/ppc/spapr.c | 104 -
migration/savevm.c | 19
target/ppc
: Harsh Prateek Bora
---
include/hw/ppc/spapr.h | 1 -
hw/ppc/spapr.c | 25 +
2 files changed, 1 insertion(+), 25 deletions(-)
diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index 1821ef96c7..6e9e62386c 100644
--- a/include/hw/ppc/spapr.h
+++ b
machines until pseries-2.3.
Suggested-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
include/hw/pci-host/spapr.h | 1 -
hw/ppc/spapr.c | 15 ---
hw/ppc/spapr_pci.c | 35 ---
3 files changed, 51 deletions(-)
diff
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as
deprecated with reasons mentioned in its commit log.
Removing pseries-2.8 specific code with this patch for now.
Suggested-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
hw/ppc/spapr.c
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as
deprecated with reasons mentioned in its commit log.
Removing pseries-2.2 specific code with this patch for now.
Suggested-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Harsh Prateek Bora
---
hw/ppc/spapr.c
ments from Cedric on v2 patchset
Removed some more pre-2.10 migration hacks in patch 9/14
Removed pseries-2.12 and pseries-3.10 also as due for removal.
v2: <20241001092910.1030913-1-hars...@linux.ibm.com>
v1: <20240917060300.943496-1-hars...@linux.ibm.com>
Harsh Prateek Bora
1 - 100 of 605 matches
Mail list logo
