[PATCH v3 3/3] hw/char/stm32f2xx_usart: Add more definitions for CR1 register

2023-10-30 Thread Hans-Erik Floryd
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Acked-by: Alistair Francis Signed-off-by: Hans-Erik Floryd --- include/hw/char/stm32f2xx_usart.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/include/hw/char/stm32f2xx_usart.h b/include/hw

[PATCH v3 2/3] hw/char/stm32f2xx_usart: Update IRQ when DR is written

2023-10-30 Thread Hans-Erik Floryd
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Hans-Erik Floryd --- hw/char/stm32f2xx_usart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/stm32f2xx_usart.c b/hw/char/stm32f2xx_usart.c index 519d3461a3

[PATCH v3 0/3] stm32f2xx_usart: implement TX interrupts

2023-10-30 Thread Hans-Erik Floryd
Generate interrupt if either of the TXE, TC or RXNE bits are active and the corresponding interrupt enable bit is set. v3: - Drop patch "hw/char/stm32f2xx_usart: Update IRQ when SR is read" as it is not required Hans-Erik Floryd (3): hw/char/stm32f2xx_usart: Extract common IRQ u

[PATCH v3 1/3] hw/char/stm32f2xx_usart: Extract common IRQ update code to update_irq()

2023-10-30 Thread Hans-Erik Floryd
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Hans-Erik Floryd --- hw/char/stm32f2xx_usart.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/hw/char/stm32f2xx_usart.c b/hw

Re: [PATCH v2 2/4] hw/char/stm32f2xx_usart: Update IRQ when SR is read

2023-10-23 Thread Hans-Erik Floryd
On Mon, 23 Oct 2023 at 03:37, Alistair Francis wrote: > > On Sat, Oct 21, 2023 at 4:12 AM Philippe Mathieu-Daudé > wrote: > > > > From: Hans-Erik Floryd > > > > Signed-off-by: Hans-Erik Floryd > > [PMD: Split from bigger patch] > > Signed-off-by

Re: [PATCH 1/1] stm32f2xx_usart: implement TX interrupts

2023-10-20 Thread Hans-Erik Floryd
Hi Phil, On Fri, 20 Oct 2023 at 14:42, Philippe Mathieu-Daudé wrote: > > Hi Hans-Erik, > > On 20/10/23 13:14, Hans-Erik Floryd wrote: > > Generate interrupt if either of the TXE, TC or RXNE bits are active > > and the corresponding interrupt enable bit is set. > >

[PATCH 1/1] stm32f2xx_usart: implement TX interrupts

2023-10-20 Thread Hans-Erik Floryd
Generate interrupt if either of the TXE, TC or RXNE bits are active and the corresponding interrupt enable bit is set. Signed-off-by: Hans-Erik Floryd --- hw/char/stm32f2xx_usart.c | 29 + include/hw/char/stm32f2xx_usart.h | 10 ++ 2 files changed, 23

Re: [Qemu-devel] [PATCH v3] sdhci: add i.MX SD Stable Clock bit

2018-08-17 Thread Hans-Erik Floryd
Den fre 17 aug 2018 19:51Peter Maydell skrev > (Your indentation was off-by-one -- we use 4-space indent -- but I fixed > that.) -- PMM > Thanks! I think i fixed that in a new patch so please ignore v3. /Hans-Erik Floryd >

[Qemu-devel] [PATCH v3] sdhci: add i.MX SD Stable Clock bit

2018-08-17 Thread Hans-Erik Floryd
Add the ESDHC PRSSTAT_SDSTB bit, using the value of SDHC_CLOCK_INT_STABLE. Freescale recommends checking this bit when changing clock frequency. Signed-off-by: Hans-Erik Floryd --- hw/sd/sdhci-internal.h | 2 ++ hw/sd/sdhci.c | 8 2 files changed, 10 insertions(+) diff --git

[Qemu-devel] [PATCH v2] sdhci: add i.MX SD Stable Clock bit

2018-08-17 Thread Hans-Erik Floryd
Add the ESDHC PRSSTAT_SDSTB bit, using the value of SDHC_CLOCK_INT_STABLE. Freescale recommends checking this bit when changing clock frequency. Signed-off-by: Hans-Erik Floryd --- hw/sd/sdhci-internal.h | 2 ++ hw/sd/sdhci.c | 8 2 files changed, 10 insertions(+) diff --git

[Qemu-devel] [PATCH] sdhci: add i.MX SD Stable Clock bit

2018-08-16 Thread Hans-Erik Floryd
Add the ESDHC PRSSTAT_SDSTB bit, using the value of SDHC_CLOCK_INT_STABLE. Freescale recommends checking this bit when changing clock frequency. Signed-off-by: Hans-Erik Floryd --- hw/sd/sdhci-internal.h | 2 ++ hw/sd/sdhci.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a

[Qemu-devel] [PATCH] imx_serial: Generate interrupt on receive data ready if enabled

2018-08-15 Thread Hans-Erik Floryd
Generate an interrupt if USR2_RDR and UCR4_DREN are both set. Signed-off-by: Hans-Erik Floryd --- hw/char/imx_serial.c | 3 ++- include/hw/char/imx_serial.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c index 0747db9