On Fri, Sep 26, 2014 at 01:29:41PM -0400, Luiz Capitulino wrote:
> On Fri, 26 Sep 2014 13:25:45 -0400
> Luiz Capitulino wrote:
>
> > On Thu, 18 Sep 2014 15:53:21 +0800
> > Zhu Guihua wrote:
> >
> > > Add peripheral_device_del_completion() to let peripheral device del
> > > completion
> > > be
On Wed, Sep 03, 2014 at 05:44:17PM +0100, Stefan Hajnoczi wrote:
> Hi,
> QEMU offers both NBD client and server functionality. The NBD protocol
> runs unencrypted, which is a problem when the client and server
> communicate over an untrusted network.
>
> The particular use case that prompted this
Signed-off-by: Hani Benhabiles
---
monitor.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index 5bc70a6..7465775 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4520,16 +4520,15 @@ void netdev_del_completion(ReadLineState *rs, int
nb_args
On Sun, Jun 29, 2014 at 12:45:27PM +0100, Peter Maydell wrote:
> On 27 June 2014 15:11, Paolo Bonzini wrote:
> > The following changes since commit d4cba13bdf251baeedb36b87c1e9f6766773e380:
> >
> > tcg/ppc: Fix failure in tcg_out_mem_long (2014-06-27 13:23:41 +0100)
> >
> > are available in the
Due to an incomplete initialization, adding a usb-bt-dongle device through HMP
or QMP will cause a segmentation fault.
Signed-off-by: Hani Benhabiles
Suggested-by: Paolo Bonzini
---
Compared to v1:
* Remove duplicate code from usb_bt_init() and inline usb_create_simple() call.
* usb_bt_initfn
On Mon, Jun 16, 2014 at 11:00:42AM +0200, Paolo Bonzini wrote:
> Il 15/06/2014 23:37, Hani Benhabiles ha scritto:
> >>>diff --git a/hw/usb/dev-bluetooth.c b/hw/usb/dev-bluetooth.c
> >>>index a9661d2..6d02343 100644
> >>>--- a/hw/usb/dev-bluetooth.c
> >
On Wed, Jun 11, 2014 at 08:58:08PM +0200, Paolo Bonzini wrote:
> Il 11/06/2014 19:25, Hani Benhabiles ha scritto:
> >Due to an incomplete initialization, adding a usb-bt-dongle device through
> >HMP
> >or QMP will cause a segmentation fault.
> >
> &
On Sun, Jun 15, 2014 at 03:57:46PM +0200, Paolo Bonzini wrote:
> Il 15/06/2014 12:03, Hani Benhabiles ha scritto:
> >Also, use it instead of using hard-coded values.
> >
> >Signed-off-by: Hani Benhabiles
> >---
> >Should have been part of the last monitor c
Also, use it instead of using hard-coded values.
Signed-off-by: Hani Benhabiles
---
Should have been part of the last monitor completion series, but better late
then never. :)
hw/watchdog/watchdog.c| 35 +++
include/sysemu/watchdog.h | 6 ++
monitor.c
Due to an incomplete initialization, adding a usb-bt-dongle device through HMP
or QMP will cause a segmentation fault.
Signed-off-by: Hani Benhabiles
---
Not sure about the exact policy of qemu-stable. CC'ing it as this bug results in
a segfault.
hw/usb/dev-bluetooth.c | 6 ++
1
On Mon, Jun 09, 2014 at 04:32:32PM -0400, Luiz Capitulino wrote:
> On Sun, 1 Jun 2014 12:53:35 +0100
> Hani Benhabiles wrote:
>
> > Signed-off-by: Hani Benhabiles
> > ---
> > util/readline.c | 9 +
> > 1 file changed, 9 insertions(+)
> >
When this flag is set, the server tells the client that it can send another
option if the server received a request with an option that it doesn't
understand instead of directly closing the connection.
Also add link to the most up-to-date documentation.
Signed-off-by: Hani Benha
Compared to v2:
* 1/2: Handle options in loop. Handle NBD_OPT_ABORT. Add link to documentation.
Improve commit message.
* 2/2: Fix return value in NBD_OPT_LIST case. Rename nbd_send_list() function to
nbd_handle_list().
* Remove patch 3/3 from v2. Applied separately by Paolo.
Hani Benhabiles
Signed-off-by: Hani Benhabiles
---
include/block/nbd.h | 2 ++
nbd.c | 61 +
2 files changed, 63 insertions(+)
diff --git a/include/block/nbd.h b/include/block/nbd.h
index 561b70c..fd7e057 100644
--- a/include/block/nbd.h
+++ b
On Thu, Jun 05, 2014 at 03:55:40AM +0200, Paolo Bonzini wrote:
> Il 05/06/2014 00:33, Hani Benhabiles ha scritto:
> >> IIUC, what this does is ensure that the other side gets a FIN before it
> >> gets
> >> a RST. Is this correct?
> >
> >Yes. Wi
On Tue, Jun 03, 2014 at 01:36:35PM +0200, Paolo Bonzini wrote:
> Il 31/05/2014 23:39, Hani Benhabiles ha scritto:
> >This is added by handling the NBD_OPT_LIST and NBD_OPT_ABORT options.
> >
> >NBD_REP_ERR_UNSUP is also sent for unknown NBD option values.
> >
> &
On Tue, Jun 03, 2014 at 01:33:41PM +0200, Paolo Bonzini wrote:
> Il 31/05/2014 23:39, Hani Benhabiles ha scritto:
> >This forces finishing data sending to client before closing the socket like
> >in
> >exports listing or replying with NBD_REP_ERR_UNSUP cases.
> >
> &
On Mon, Jun 02, 2014 at 02:32:06PM +0200, Stefan Hajnoczi wrote:
> On Sat, May 31, 2014 at 10:39:40PM +0100, Hani Benhabiles wrote:
> > Signed-off-by: Hani Benhabiles
> > ---
> > include/block/nbd.h | 6 ++
> > nbd.c | 12 +++-
> > 2 f
On Mon, Jun 02, 2014 at 02:20:36PM +0200, Stefan Hajnoczi wrote:
> On Sun, Jun 01, 2014 at 12:53:35PM +0100, Hani Benhabiles wrote:
> > Signed-off-by: Hani Benhabiles
> > ---
> > util/readline.c | 9 +
> > 1 file changed, 9 insertions(+)
>
> Please only
Signed-off-by: Hani Benhabiles
---
util/readline.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/util/readline.c b/util/readline.c
index 8baec55..08d07e3 100644
--- a/util/readline.c
+++ b/util/readline.c
@@ -345,6 +345,12 @@ static void readline_completion(ReadLineState *rs
This is added by handling the NBD_OPT_LIST and NBD_OPT_ABORT options.
NBD_REP_ERR_UNSUP is also sent for unknown NBD option values.
Signed-off-by: Hani Benhabiles
---
include/block/nbd.h | 5 ++
nbd.c | 197 +---
2 files changed
This forces finishing data sending to client before closing the socket like in
exports listing or replying with NBD_REP_ERR_UNSUP cases.
Signed-off-by: Hani Benhabiles
---
blockdev-nbd.c | 1 +
qemu-nbd.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/blockdev-nbd.c b/blockdev-nbd.c
Compared to v1:
* 2/3: Handle options in a loop. Handle NBD_OPT_ABORT and send NBD_REP_ERR_UNSUP
accordingly.
* 3/3: New patch.
Hani Benhabiles (3):
nbd: Handle fixed new-style clients.
nbd: Add exports listing support.
nbd: Shutdown socket before closing.
blockdev-nbd.c | 1
Signed-off-by: Hani Benhabiles
---
include/block/nbd.h | 6 ++
nbd.c | 12 +++-
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/include/block/nbd.h b/include/block/nbd.h
index 79502a0..95d52ab 100644
--- a/include/block/nbd.h
+++ b/include/block/nbd.h
On Tue, May 27, 2014 at 04:46:46PM +0200, Paolo Bonzini wrote:
> Il 25/05/2014 11:50, Hani Benhabiles ha scritto:
> >@@ -236,9 +236,10 @@ static int nbd_receive_options(NBDClient *client)
> > LOG("read failed");
> > goto fail;
> >
Export chr_is_ringbuf() function. Also remove left-over function prototypes
while at it.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 2 ++
hmp.h | 2 ++
include/sysemu/char.h | 3 +--
monitor.c | 39 +++
qemu
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 2 ++
monitor.c | 14 ++
3 files changed, 17 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index dcec5ef..45e1763 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1359,6 +1359,7
Relies on readline unique completion strings patch to make the added vlan/hub
completion values unique, instead of using something like a hash table.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 2 ++
monitor.c | 38
Also fix the parameters documentation.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 3 ++-
hmp.h | 1 +
monitor.c | 16
3 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 919af6e..aab9cf5 100644
--- a
Signed-off-by: Hani Benhabiles
---
include/net/net.h | 1 +
net/net.c | 34 --
2 files changed, 21 insertions(+), 14 deletions(-)
diff --git a/include/net/net.h b/include/net/net.h
index 8166345..8b189da 100644
--- a/include/net/net.h
+++ b/include/net
A set of patches adding completion support for various hmp commands. Following
other series that were merged earlier.
Compared to v1:
* patch 04/08: New.
* patch 05/08: Use exported list of host network devices.
Hani Benhabiles (8):
monitor: Add ringbuf_write and ringbuf_read argument
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 2 ++
monitor.c | 21 +
3 files changed, 24 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 45e1763..919af6e 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -975,6
There is no need to clutter the user's choices with repeating the same value
multiple times.
Signed-off-by: Hani Benhabiles
---
util/readline.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/util/readline.c b/util/readline.c
index 8baec55..7214e84 100644
--- a/util/readline.c
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 2 ++
hmp.h | 2 ++
monitor.c | 48
3 files changed, 52 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index f99da0e..5f1a677 100644
--- a/hmp-commands.hx
+++ b
On Fri, May 23, 2014 at 02:05:03PM +0200, Stefan Hajnoczi wrote:
> On Tue, May 20, 2014 at 12:03:17AM +0100, Hani Benhabiles wrote:
> > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > index 919af6e..6aaec1b 100644
> > --- a/hmp-commands.hx
> > +++ b/hmp-commands
Before the patches:
$ nbd-client -l localhost
Negotiation: ..
E: Server does not support listing exports
After the patches:
$ nbd-client -l localhost
Negotiation: ..
ide0-hd0
ide1-cd0
Hani Benhabiles (2):
nbd: Handle fixed new-style clients.
nbd: Handle NBD_OPT_LIST option.
include/block
Signed-off-by: Hani Benhabiles
---
include/block/nbd.h | 4 +++
nbd.c | 97 +++--
2 files changed, 99 insertions(+), 2 deletions(-)
diff --git a/include/block/nbd.h b/include/block/nbd.h
index 95d52ab..23e9a84 100644
--- a/include
Signed-off-by: Hani Benhabiles
---
include/block/nbd.h | 6 ++
nbd.c | 12 +++-
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/include/block/nbd.h b/include/block/nbd.h
index 79502a0..95d52ab 100644
--- a/include/block/nbd.h
+++ b/include/block/nbd.h
Relies on readline unique completion strings patch to make the added vlan/hub
completion values unique, instead of using something like a hash table.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 2 ++
monitor.c | 38
A set of patches adding completion support for various hmp commands. Following
other series that were merged earlier.
Hani Benhabiles (7):
monitor: Add ringbuf_write and ringbuf_read argument completion.
monitor: Add watchdog_action argument completion.
monitor: Add migrate_set_capability
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 2 ++
monitor.c | 14 ++
3 files changed, 17 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index dcec5ef..45e1763 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1359,6 +1359,7
Export chr_is_ringbuf() function. Also remove left-over function prototypes
while at it.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 2 ++
hmp.h | 2 ++
include/sysemu/char.h | 3 +--
monitor.c | 39 +++
qemu
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 2 ++
hmp.h | 2 ++
monitor.c | 48
3 files changed, 52 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 935f744..d68a00b 100644
--- a/hmp-commands.hx
+++ b
On Tue, May 20, 2014 at 12:01:01AM +0100, Hani Benhabiles wrote:
> A set of patches adding completion support for various hmp commands. Following
> other series that were merged earlier.
>
Resent the complete series. Please ignore this incomplete one.
Sorry for the flood.
> Hani B
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 2 ++
monitor.c | 21 +
3 files changed, 24 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 45e1763..919af6e 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -975,6
Also fix the parameters documentation.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 3 ++-
hmp.h | 1 +
monitor.c | 14 ++
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 919af6e..6aaec1b 100644
--- a
There is no need to clutter the user's choices with repeating the same value
multiple times.
Signed-off-by: Hani Benhabiles
---
util/readline.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/util/readline.c b/util/readline.c
index 8baec55..7214e84 100644
--- a/util/readline.c
A set of patches adding completion support for various hmp commands. Following
other series that were merged earlier.
Hani Benhabiles (7):
monitor: Add ringbuf_write and ringbuf_read argument completion.
monitor: Add watchdog_action argument completion.
monitor: Add migrate_set_capability
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 2 ++
monitor.c | 21 +
3 files changed, 24 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 45e1763..919af6e 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -975,6
Export chr_is_ringbuf() function. Also remove left-over function prototypes
while at it.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 2 ++
hmp.h | 2 ++
include/sysemu/char.h | 3 +--
monitor.c | 39 +++
qemu
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 2 ++
monitor.c | 14 ++
3 files changed, 17 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index dcec5ef..45e1763 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1359,6 +1359,7
On Mon, May 19, 2014 at 01:05:12PM +0200, Paolo Bonzini wrote:
> Il 18/05/2014 12:50, Hani Benhabiles ha scritto:
> >These values aren't used in this case.
> >
> >Currently, the from field in the request sent by the nbd kernel module
> >leading
> >to
51104, Len: 0, Size: 20971520,
Offset: 0
nbd.c:nbd_trip():L1032: requested operation past EOF--bad client?
nbd.c:nbd_receive_request():L638: read failed
Signed-off-by: Hani Benhabiles
---
nbd.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/nbd.c b/nbd.c
index e5084b6..dc
write-protected, mounting read-only
mount: /dev/nbd0: can't read superblock
After the patch:
(qemu) nbd_server_add ide0-hd0
(qemu) nbd_server_add floppy0
Device 'floppy0' has no medium
Signed-off-by: Hani Benhabiles
---
blockdev-nbd.c | 4
1 file changed, 4 insertions(+)
diff --
On Thu, May 15, 2014 at 04:10:11PM -0400, Luiz Capitulino wrote:
> On Thu, 15 May 2014 20:42:03 +0100
> Hani Benhabiles wrote:
>
> > On Wed, May 07, 2014 at 11:41:26PM +0100, Hani Benhabiles wrote:
> > > Compared to v1:
> > > * Dropped patch 02/07 for help compl
On Wed, May 07, 2014 at 11:41:26PM +0100, Hani Benhabiles wrote:
> Compared to v1:
> * Dropped patch 02/07 for help completion conversion.
> * Nothing else changed. 04,05 and 06 are R-b by Stefan.
>
> Hani Benhabiles (6):
> monitor: Convert sendkey to use command_completion
Otherwise, the nbd client may hang waiting for the server response.
Signed-off-by: Hani Benhabiles
---
Quick method to trigger such behaviour:
(qemu) nbd_server_start localhost:10809
(qemu) nbd_server_add sd0
$ nbd-client localhost 10809 -name /dev/nbd0
Negotiation: ..
(Client will hang
Signed-off-by: Hani Benhabiles
---
nbd.c | 2 +-
qemu-nbd.c| 2 +-
qemu-nbd.texi | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/nbd.c b/nbd.c
index e5084b6..e0d032c 100644
--- a/nbd.c
+++ b/nbd.c
@@ -306,7 +306,7 @@ static int nbd_send_negotiate(NBDClient
On Thu, May 08, 2014 at 04:21:17PM +0200, Andreas Färber wrote:
> Re-implemented based on qmp_qom_set() to facilitate argument parsing.
>
> Signed-off-by: Andreas Färber
> ---
> hmp-commands.hx | 13 +
> hmp.c | 18 ++
> hmp.h | 1 +
> 3 files cha
On Thu, May 08, 2014 at 04:21:16PM +0200, Andreas Färber wrote:
> Reimplement it based on qmp_qom_get() to avoid converting QObjects back
> to strings.
>
> Inspired-by: Paolo Bonzini
> Signed-off-by: Andreas Färber
> ---
> hmp-commands.hx | 13 +
> hmp.c | 22 +
On Thu, May 08, 2014 at 04:21:15PM +0200, Andreas Färber wrote:
> Implement it as a wrapper for QMP qom-list, but mimic the behavior of
> scripts/qmp/qom-list in making the path argument optional and listing
> the root if absent, to hint users what kind of path to pass.
>
> Signed-off-by: Andreas
quot;%*s/%s (%s)\n", indent, "", name,
> + object_get_typename(obj));
> +g_free(name);
> +object_child_foreach(obj, print_qom_composition_child, &s);
> +}
> +
> +void do_info_qom_composition(Monitor *mon, const QDict *dict)
> +{
> +print_qom_composition(mon, qdev_get_machine(), 0);
> +}
> +
> int do_device_add(Monitor *mon, const QDict *qdict, QObject **ret_data)
> {
> Error *local_err = NULL;
Reviewed-by: Hani Benhabiles
On Wed, May 07, 2014 at 05:39:36PM +0200, Andreas Färber wrote:
> Hi Hani,
>
> Am 27.04.2014 12:29, schrieb Hani Benhabiles:
> > Signed-off-by: Hani Benhabiles
> > ---
> >
> > Not sure whether the qobject stringifying functions could fit or be of some
> &g
On Wed, May 07, 2014 at 01:01:12PM +0200, Paolo Bonzini wrote:
> Il 05/05/2014 20:33, Luiz Capitulino ha scritto:
> >>+data = object_property_get_qobject(obj, info->name, NULL);
> >>+if (!data) {
> >>+list = list->next;
> >>+continue;
>
> You
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 26 ++
3 files changed, 28 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index a7f9b2f..2e462c0 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
Also update the command's documentation.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 3 ++-
hmp.h | 1 +
monitor.c | 15 +++
3 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 3e7b29c..a7f9b2f 1
Compared to v1:
* Dropped patch 02/07 for help completion conversion.
* Nothing else changed. 04,05 and 06 are R-b by Stefan.
Hani Benhabiles (6):
monitor: Convert sendkey to use command_completion.
monitor: Add chardev-remove command completion.
monitor: Add chardev-add backend argument
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 23 +++
3 files changed, 25 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index b4b23c8..ba88e2a 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1639,6
Make it possible to query all net clients without specifying an ID when calling
qemu_find_net_clients_except().
This also adds the add_completion_option() function which is to be used for
other commands completions as well.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 23 +++
3 files changed, 25 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index ba88e2a..93fa534 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1623,6
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 32 +++-
3 files changed, 25 insertions(+), 9 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 8971f1b..b4b23c8 100644
--- a/hmp-commands.hx
+++ b
On Mon, May 05, 2014 at 03:51:37PM -0400, Luiz Capitulino wrote:
> On Sun, 27 Apr 2014 17:00:03 +0100
> Hani Benhabiles wrote:
>
> > Signed-off-by: Hani Benhabiles
> > ---
> > hmp-commands.hx | 1 +
> > hmp.h | 1 +
> > monitor.c | 2
On Tue, May 06, 2014 at 07:28:35PM +0100, Peter Maydell wrote:
> On 6 May 2014 19:16, Mike Day wrote:
> > This updates scripts/checkpatch.pl to version 0.32. Also,
> > forward-ported the QEMU checks for no tabs and correct capitalization
> > of "QEMU." Finally, make --no-tree the default option si
Signed-off-by: Hani Benhabiles
---
util/readline.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/util/readline.c b/util/readline.c
index 8441be4..8d2a0d3 100644
--- a/util/readline.c
+++ b/util/readline.c
@@ -272,6 +272,11 @@ void readline_set_completion_index(ReadLineState *rs, int
On Mon, Apr 28, 2014 at 02:55:03AM +, Gonglei (Arei) wrote:
> Hi,
>
> > Il 26/04/2014 10:56, Gonglei (Arei) ha scritto:
> > > Public bug reported:
> > >
> > > I want to repeated hot-plug/unplug the virtio-net in the latest qemu
> > upstream
> > > (commit 839a5547574e57cce62f49bfc50fe1f04b00589
Signed-off-by: Hani Benhabiles
Suggested-by: Andreas Färber
---
qmp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/qmp.c b/qmp.c
index 74107be..0d49abf 100644
--- a/qmp.c
+++ b/qmp.c
@@ -199,7 +199,10 @@ ObjectPropertyInfoList *qmp_qom_list(const char *path,
Error
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 23 +++
3 files changed, 25 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index ba13997..8c93e61 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1632,6
Make it possible to query all net clients without specifying an ID when calling
qemu_find_net_clients_except().
This also adds the add_completion_option() function which is to be used for
other commands completions as well.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h
hardcoding them.
* Left patches 10-17 for a separate series to make review process faster.
* wrt. to Luiz' question about set_link patch: It prints both backend and
frontend values because both are accepted by set_link command.
Hani Benhabiles (7):
monitor: Convert sendkey t
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 24 +---
3 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index b3f45d6..ba13997 100644
--- a/hmp-commands.hx
+++ b/hmp
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 26 ++
3 files changed, 28 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 73fbe54..f10f52f 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
Also update the command's documentation.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 3 ++-
hmp.h | 1 +
monitor.c | 15 +++
3 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 353161f..73fbe54 1
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 32 +++-
3 files changed, 25 insertions(+), 9 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 4c4d261..b3f45d6 100644
--- a/hmp-commands.hx
+++ b
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 23 +++
3 files changed, 25 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 8c93e61..648400a 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1616,6
Signed-off-by: Hani Benhabiles
---
Not sure whether the qobject stringifying functions could fit or be of some use
elsewhere. Thus, I kept them as static near the only place where they are used
at the moment.
hmp-commands.hx | 2 +
hmp.c | 143
On Fri, Apr 25, 2014 at 05:51:33PM +0200, Andreas Färber wrote:
> Am 25.04.2014 17:40, schrieb Luiz Capitulino:
> > On Tue, 22 Apr 2014 22:44:03 +0100
> > Hani Benhabiles wrote:
> >
> >> Signed-off-by: Hani Benhabiles
> >> ---
> >> qmp.c
On Fri, Apr 25, 2014 at 09:48:33AM -0400, Luiz Capitulino wrote:
> On Sun, 13 Apr 2014 16:25:04 +0100
> Hani Benhabiles wrote:
>
> > This patch series adds a new callback to mon_cmd_t which will make adding
> > completion support for more commands cleaner.
> >
Signed-off-by: Hani Benhabiles
---
qmp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qmp.c b/qmp.c
index 87a28f7..44a6e17 100644
--- a/qmp.c
+++ b/qmp.c
@@ -194,11 +194,10 @@ void qmp_system_wakeup(Error **errp)
ObjectPropertyInfoList *qmp_qom_list(const char *path
Also fix device_add completion including non-hotpluggable devices.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 2 ++
hmp.h | 2 ++
monitor.c | 38 --
3 files changed, 28 insertions(+), 14 deletions(-)
diff --git a/hmp-commands.hx b
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index f3fc514..6bf4797 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -176,7 +176,7 @@ ETEXI
{
.name = "driv
This patch series adds a new callback to mon_cmd_t which will make adding
completion support for more commands cleaner.
It moves some existing commands completions to using the new callback and also
fixes the completion for device_add and drive_del commands.
Hani Benhabiles (3):
monitor: Fix
Convert object_add and object_del commands to use the new callback.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 2 ++
hmp.h | 3 +++
monitor.c | 19 +--
3 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
On Fri, Apr 11, 2014 at 01:50:57PM -0400, Luiz Capitulino wrote:
> On Sun, 30 Mar 2014 11:58:22 +0100
> Hani Benhabiles wrote:
>
> > This patch series adds a new callback to mon_cmd_t which will make adding
> > completion support for more commands cleaner.
> >
>
Also convert nearby monitor_printf() call to error_report().
Signed-off-by: Hani Benhabiles
---
net/net.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index e3ef1e4..d319f49 100644
--- a/net/net.c
+++ b/net/net.c
@@ -952,10 +952,12 @@ void
On Mon, Mar 31, 2014 at 02:45:49PM +0200, Markus Armbruster wrote:
> Gerd Hoffmann writes:
>
> >> +if (!(s->handler->mask & (INPUT_EVENT_MASK_REL |
> >> + INPUT_EVENT_MASK_ABS))) {
> >> +monitor_printf(mon, "Input device '%s' is not a mouse",
>
() with error_report() and
adjust error message.
Signed-off-by: Hani Benhabiles
---
ui/input.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/ui/input.c b/ui/input.c
index 2761911..6e6a924 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -342,15 +342,21 @@ void
Otherwise, the index of an input device like a usb-kbd is silently accepted.
(qemu) info mice
Mouse #2: QEMU PS/2 Mouse
* Mouse #3: QEMU HID Mouse
(qemu) mouse_set 1
(qemu) info mice
Mouse #2: QEMU PS/2 Mouse
* Mouse #3: QEMU HID Mouse
Signed-off-by: Hani Benhabiles
---
ui/input.c | 15
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 2 ++
hmp.h | 2 ++
monitor.c | 34 +-
3 files changed, 25 insertions(+), 13 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 1b382b6..4c4d261 100644
--- a/hmp-commands.hx
Convert object_add and object_del commands to use the new callback.
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 2 ++
hmp.h | 3 +++
monitor.c | 19 +--
3 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
Signed-off-by: Hani Benhabiles
---
hmp-commands.hx | 1 +
hmp.h | 2 ++
monitor.c | 21 +
3 files changed, 24 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 669a845..8c674ba 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -975,6
1 - 100 of 148 matches
Mail list logo
